Commit Graph

122631 Commits

Author SHA1 Message Date
Manish Goregaokar
50026aed24
Rollup merge of - kraai:remove-blank-line, r=jonas-schievink
Remove blank line
2020-06-26 13:57:46 -07:00
Manish Goregaokar
7926c64642
Rollup merge of - nbdd0121:comment, r=nikomatsakis
Remove irrelevant comment

Iterator is no longer a lang item since 216e72f8d9.
2020-06-26 13:57:44 -07:00
Manish Goregaokar
83f6d0a93f
Rollup merge of - oli-obk:const_prop_cleanup, r=wesleywiser
Document some invariants correctly/more

r? @wesleywiser
2020-06-26 13:57:43 -07:00
Manish Goregaokar
bc10bb02f5
Rollup merge of - poliorcetics:super-keyword, r=shepmaster
Document the super keyword

Partial fix of .

Quite short, just a small example and a link to the reference.

@rustbot modify labels: T-doc,C-enhancement
2020-06-26 13:57:41 -07:00
Manish Goregaokar
8d9c00d7f1
Rollup merge of - poliorcetics:self-upper-keyword, r=Mark-Simulacrum
Document the Self keyword

Partial fix of .

Document the `Self` keyword.

This contains simple examples of the places where `Self` can be used.
2020-06-26 13:57:39 -07:00
Manish Goregaokar
c18e919a79
Rollup merge of - ajpaverd:bootstrap-windows-73689, r=Mark-Simulacrum
Bootstrap: detect Windows based on sys.platform

Closes .
2020-06-26 13:57:37 -07:00
Manish Goregaokar
dfbba65786
Rollup merge of - ssomers:btree_iter_min_max, r=Mark-Simulacrum
Shortcuts for min/max on double-ended BTreeMap/BTreeSet iterators

Closes : a performance tweak that might benefit some. Optimizes `min` and `max ` on all btree double-ended iterators that do not drop, i.e. the iterators created by:

- `BTreeMap::iter`
- `BTreeMap::iter_mut`
- `BTreeMap::keys` and `BTreeSet::iter`
- `BTreeMap::range` and `BTreeSet::range`
- `BTreeMap::range_mut`

Also in these (currently) single-ended iterators, but obviously for `min` only:
- `BTreeSet::difference`
- `BTreeSet::intersection`
- `BTreeSet::symmetric_difference`
- `BTreeSet::union`

Did not do this in iterators created by `into_iter` to preserve drop order, as outlined in .

Did not do this in iterators created by `drain_filter`, possibly to preserve drop order, possibly to preserve predicate invocation, mostly to not have to think about it too hard (I guess maybe it wouldn't be a change for `min`, which is the only shortcut possible in this single-ended iterator).
2020-06-26 13:57:35 -07:00
Manish Goregaokar
92af945256
Rollup merge of - RalfJung:doc-missing-links, r=shepmaster
add missing doc links

The doc comments contain ``[`size_of_val`]`` but the link target was missing.
2020-06-26 13:57:33 -07:00
Manish Goregaokar
23b0776a59
Rollup merge of - pickfire:liballoc-specfromelem-i8, r=cuviper
Add liballoc impl SpecFromElem for i8

Speedup vec![1_i8; N] for non-zero element.

Before
test do_bench_from_elem_i8        ... bench:         130 ns/iter (+/- 7) = 61 MB/s
test do_bench_from_elem_u8        ... bench:         121 ns/iter (+/- 4) = 66 MB/s
After
test do_bench_from_elem_i8        ... bench:         123 ns/iter (+/- 7) = 65 MB/s
test do_bench_from_elem_u8        ... bench:         121 ns/iter (+/- 5) = 66 MB/s

No speed difference if element is already zero.

```rust
#[bench]
fn do_bench_from_elem_i8(b: &mut Bencher) {
    b.bytes = 8 as u64;
    b.iter(|| {
        let dst = ve::vec![10_i8; 100];
        assert_eq!(dst.len(), 100);
        assert!(dst.iter().all(|x| *x == 10));
    })
}
```

As suggested by @cuviper
https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/SpecForElem.20for.20other.20integers

r? @cuviper
CC @joshtriplett

Edit: Wow, I just realized both reviewers are Josh.
2020-06-26 13:57:31 -07:00
Manish Goregaokar
f13d09abe1
Rollup merge of - estebank:dedup-preds, r=nikomatsakis
Perform obligation deduplication to avoid buggy `ExistentialMismatch`

Address .
2020-06-26 13:57:29 -07:00
Manish Goregaokar
38cbf158b8
Rollup merge of - AdrianCX:master, r=nikomatsakis
Fortanix SGX target libunwind build process changes

Ticket: https://github.com/fortanix/rust-sgx/issues/174
LLVM related changes (merged): https://github.com/rust-lang/llvm-project/pull/57

Description: libunwind changes needed to run code in sgx environment via rust-sgx.

Target that uses this in rust: x86_64-fortanix-unknown-sgx.

Without this change, rust std for this toolchain is forced to use a precompiled library loaded via environment variable.

With this change we act the same as musl target.
2020-06-26 13:57:26 -07:00
Manish Goregaokar
8adc781a1f
Rollup merge of - jyn514:rustdoc, r=Manishearth
Warn if linking to a private item

Closes https://github.com/rust-lang/rust/issues/72769

r? @GuillaumeGomez
2020-06-26 13:57:24 -07:00
Aaron Hill
fa6a61c689
Explain move errors that occur due to method calls involving self
This is a re-attempt of  (which was reverted in )
Instead of using `ExpnKind::Desugaring` to represent operators, this PR
checks the lang item directly.
2020-06-26 16:28:09 -04:00
Aaron Hill
36ac08e264
Make fn_arg_names return Ident instead of symbol
Also, implement this query for the local crate, not just foreign crates.
2020-06-26 15:46:22 -04:00
Dylan MacKenzie
234019758b Add peek test for projections 2020-06-26 11:31:48 -07:00
Dylan MacKenzie
558c8a8c3c Handle stores to projections correctly in liveness analysis
Previously, we were too conservative and `x.field = 4` was treated as a
"use" of `x`.
2020-06-26 11:30:28 -07:00
Vadim Petrochenkov
7b2064f4f9 rustc_lexer: Simplify shebang parsing once more 2020-06-26 19:52:19 +03:00
David Wood
3678e5c97e
errors: use -Z terminal-width in JSON emitter
This commit makes the JSON emitter use `-Z terminal-width` in the
"rendered" field of the JSON output.

Signed-off-by: David Wood <david@davidtw.co>
2020-06-26 16:01:51 +01:00
Eric Huss
6bcbc426c9 Update mdbook. 2020-06-26 07:47:19 -07:00
Eric Huss
6654c5852f Remove mdbook-linkcheck. 2020-06-26 07:45:28 -07:00
bors
7750c3d46b Auto merge of - oli-obk:const_binop_overflow, r=estebank
Show the values and computation that would overflow a const evaluation or propagation

Fixes 

In contrast to the example in the issue it doesn't use individual spans for each operand. The effort required to implement that is quite high compared to the little (if at all) benefit it would bring to diagnostics.

cc @shepmaster

The way this is implemented it is also fairly easy to do the same for overflow panics at runtime, but that should be done in a separate PR since it may have runtime performance implications.
2020-06-26 14:08:46 +00:00
KRAAI, MATTHEW [VISUS]
cb152eae2f Remove blank line 2020-06-26 06:22:35 -07:00
Joshua Nelson
67423821aa Fix debug messages 2020-06-26 08:24:45 -04:00
Joshua Nelson
20552c811a Generate docs for links to private items when passed --document-private
- Pass around document_private a lot more
- Add tests
  + Add tests for intra-doc links to private items
  + Add ignored tests for warnings in reference links
2020-06-26 07:23:39 -04:00
Joshua Nelson
6f8bec9399 Warn if linking to a private item 2020-06-26 07:14:02 -04:00
David Wood
a6417b9c38
improper_ctypes: fix remaining Reveal:All
This commit replaces the remaining uses of `ParamEnv::reveal_all` with
`LateContext`'s `param_env` (normally `Reveal::UserFacing`).

Signed-off-by: David Wood <david@davidtw.co>
2020-06-26 11:21:31 +01:00
bors
9672b5e95c Auto merge of - Manishearth:rollup-aehswb2, r=Manishearth
Rollup of 13 pull requests

Successful merges:

 -  (Omit DW_AT_linkage_name when it is the same as DW_AT_name)
 -  (Don't move cursor in search box when using arrows to navigate results)
 -  (proc_macro: Stop flattening groups with dummy spans)
 -  (Support configurable deny-warnings for all in-tree crates.)
 -  (Cleanup MinGW LLVM linkage workaround)
 -  (Fix handling of reserved registers for ARM inline asm)
 -  (Record span of `const` kw in GenericParamKind)
 -  (Make AssocOp Copy)
 -  (Update Chalk to 0.14)
 -  (Fix links in `SliceIndex` documentation)
 -  (emitter: column width defaults to 140)
 -  (disable collectionbenches for android)
 -  (Add code block to code in documentation of `List::rebase_onto`)

Failed merges:

r? @ghost
2020-06-26 10:11:43 +00:00
Oliver Scherer
819cde5dab Show the values and computation that would overflow a const evaluation or propagation 2020-06-26 10:08:52 +02:00
Stein Somers
42062a5802 Shortcuts for min/max on ordinary BTreeMap/BTreeSet iterators 2020-06-26 10:05:21 +02:00
Manish Goregaokar
a7eee3cca0
Rollup merge of - jyn514:doc-fix, r=Manishearth
Add code block to code in documentation of `List::rebase_onto`

Closes https://github.com/rust-lang/rust/issues/73676

@bors rollup=always
2020-06-26 00:39:19 -07:00
Manish Goregaokar
91a638d794
Rollup merge of - nellshamrell:disable-collectionsbenches-android, r=sfackler
disable collectionbenches for android

Fixes 

Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
2020-06-26 00:39:17 -07:00
Manish Goregaokar
97ccd97068
Rollup merge of - davidtwco:issue-72509-emitter-column-width, r=estebank
emitter: column width defaults to 140

Fixes .

This PR modifies the column width computation in the emitter when `termize::dimensions` returns `None` so that it uses the default value of 140 (which is used in UI testing currently) instead of `usize::MAX` which just ends up causing overflows in later computations.

I also tried changing the computations which used `column_width` with their saturating equivalent, but the output appeared the same - so I decided to go with this approach because I feel like it's less likely to accidentally re-introduce an ICE like this in future (e.g. adding a non-saturating operation on `column_width` in future).

I haven't added a test because I couldn't come up with a MCVE. I stumbled upon this running rustc-perf with the `piston-image` benchmark (running in tmux; it only happened with stage two builds only; and only when running through Cargo, not rustc directly with the same flags). In addition, given the nature of the issue, I don't know that we *could* write a UI test for this. Open to suggestions here though.

r? @estebank
2020-06-26 00:39:15 -07:00
Manish Goregaokar
6061752853
Rollup merge of - LeSeulArtichaut:patch-3, r=kennytm
Fix links in `SliceIndex` documentation

See [this doc](https://doc.rust-lang.org/nightly/std/slice/trait.SliceIndex.html#tymethod.get_unchecked) whose links aren't active because of this missing newline.
2020-06-26 00:39:14 -07:00
Manish Goregaokar
1755e3b05c
Rollup merge of - jackh726:chalk-0.14, r=nikomatsakis
Update Chalk to 0.14

Not a ton here. Notable changes:
- Update to `0.14.0`
  - New dependency on `tracing`, in `librustc_traits` only
  - `FnAbi` from Chalk is `rustc_target::spec::abi::Abi`
  - `Dynamic` actually lowers region
  - Actually lower closures, with some tests. This doesn't 100% work, but can't confirm that's *only* because of closure lowering.
- Use `FxIndexSet` instead of `FxHashSet` in `chalk_fulfill`, which seems to have fixed the non-deterministic test error ordering. Guess we'll see on CI
- Actually implement `opaque_ty_data`, though I don't think this is sufficient for tests for them (I haven't added any)
- Uncomment some of the chalk tests that now work

r? @nikomatsakis
2020-06-26 00:39:12 -07:00
Manish Goregaokar
3d7521d31d
Rollup merge of - flip1995:assoc_op_copy_clone, r=Manishearth
Make AssocOp Copy

Found that this enum is not `Copy` while reviewing this Clippy PR: https://github.com/rust-lang/rust-clippy/pull/5727#discussion_r443761621

There shouldn't be a reason why this should not be `Copy`.
2020-06-26 00:39:10 -07:00
Manish Goregaokar
7f6dfb451a
Rollup merge of - ayazhafiz:i/const-span, r=ecstatic-morse
Record span of `const` kw in GenericParamKind

Context: this is needed for a fix of https://github.com/rust-lang/rustfmt/issues/4263,
which currently records the span of a const generic param incorrectly
because the location of the `const` kw is not known.

I am not sure how to add tests for this; any guidance in how to do so
would be appreciated 🙂
2020-06-26 00:39:08 -07:00
Manish Goregaokar
81d2d3cf35
Rollup merge of - Amanieu:thumb-fp, r=nagisa
Fix handling of reserved registers for ARM inline asm

`r6` is now disallowed as an operand since LLVM sometimes uses it as a base pointer.

The check against using the frame pointer as an operand now takes the platform into account and will block either `r7` or `r11` as appropriate.

Fixes 

cc @cbiffle
2020-06-26 00:39:06 -07:00
Manish Goregaokar
25671fa0fc
Rollup merge of - mati865:cleanup-mingw-llvm-linkage, r=matthewjasper
Cleanup MinGW LLVM linkage workaround

LLVM correctly passes `uuid` for a long time, GCC unwinding library (either static or dynamic) comes from [windows_gnu_base](06e47688bf/src/librustc_target/spec/windows_gnu_base.rs).
2020-06-26 00:39:04 -07:00
Manish Goregaokar
10d655bb47
Rollup merge of - ehuss:tool-warnings, r=Mark-Simulacrum
Support configurable deny-warnings for all in-tree crates.

This removes the hard-coded `deny(warnings)` on all in-tree tools, and allows it to be configured from the config.  This is just a personal preference, as I find `deny(warnings)` frustrating during development or doing small tests.

This also fixes some regressions in terms of warning handling.  Warnings used to be dependent on `SourceType`, but in  it was changed to be based on `Mode`. This means tools like rustdoc no longer used the same settings as the rest of the tree. It also made `SourceType` useless since the only thing it was used for was warnings. I think it would be better for everything in the tree to use the same settings.

Fixes 
2020-06-26 00:39:01 -07:00
Manish Goregaokar
2aee60897f
Rollup merge of - petrochenkov:flatgroup, r=Aaron1011
proc_macro: Stop flattening groups with dummy spans

Reduce the scope of the hack described in https://github.com/rust-lang/rust/issues/72545#issuecomment-640276791.

We still pass AST fragments to attribute and derive macros as single nonterminal tokens rather than as tokens streams, but now use a precise flag instead of the span-based heuristic that could do lead to incorrect behavior in unrelated cases.

https://github.com/rust-lang/rust/pull/73345 attempts to fully resolve this issue, but there are some compatibility issues to be addressed.
2020-06-26 00:39:00 -07:00
Manish Goregaokar
a25fbb9710
Rollup merge of - integer32llc:prevent-default-arrows, r=kinnison
Don't move cursor in search box when using arrows to navigate results

## What happens

- Go to https://doc.rust-lang.org/stable/std/index.html
- Press 's' to focus the search box
- Type a query like 'test'
- Press the down arrow one or more times to change which search result is highlighted
- Press the up arrow once to go up one search result
- Notice the cursor in the search box is now at the beginning of your query, such that if you now typed 'a' the search box would contain 'atest', when it would be expected that the cursor would have remained where it was and if you typed 'a' at this point it would result in 'testa'
- Press the down arrow once to go down one search result
- Now notice the cursor is at the end of your query again

## What I expected

I expected that changing which search result was highlighted using the up and down arrows would have no effect on where the cursor was in the search box.

## The fix

This PR prevents the default action of the up and down arrows when the custom keydown events are happening during a search.
2020-06-26 00:38:58 -07:00
Manish Goregaokar
14dc103a85
Rollup merge of - tmiasko:linkage-name, r=eddyb
Omit DW_AT_linkage_name when it is the same as DW_AT_name

The DWARF standard suggests that it might be useful to include
`DW_AT_linkage_name` when it is *distinct* from the identifier name.

Fixes .
Fixes .
2020-06-26 00:38:56 -07:00
bors
14e65d5e95 Auto merge of - eddyb:lint-on-demand-typeck-tables, r=Manishearth
rustc_lint: only query `typeck_tables_of` when a lint needs it.

This was prompted by @jyn514 running into a situation where `rustdoc` wants to run the `unused_doc` lint without triggering type-checking (as an alternative to the "everybody loops" approach - type-checking may error/ICE because of the `rustdoc` feature of allowing multi-platform docs where the actual bodies of functions may refer to APIs for different platforms).

There was also this comment in the source:
```rust
// FIXME: Make this lazy to avoid running the TypeckTables query?
```

The main effect of this is for lint authors, who now need to use `cx.tables()` to get `&TypeckTables`, as opposed to having them always available in `cx.tables`.

r? @oli-obk or @Manishearth
2020-06-26 06:11:01 +00:00
Eric Huss
75983e137e Support configurable deny-warnings for all in-tree crates. 2020-06-25 21:17:21 -07:00
Joshua Nelson
d279b3c260 Add code block to code in documentation of List::rebase_onto 2020-06-25 22:28:03 -04:00
bors
e093b65250 Auto merge of - Manishearth:rollup-80jnynm, r=Manishearth
Rollup of 14 pull requests

Successful merges:

 -  (Add a fast path for `std:🧵:panicking`.)
 -  (Self contained linking option)
 -  (Implement mixed script confusable lint.)
 -  (Add unstable `core::mem::variant_count` intrinsic)
 -  (Emit line info for generator variants)
 -  (Provide suggestions for some moved value errors)
 -  (make commented examples use valid syntax, and be more consistent )
 -  (Create 0766 error code)
 -  (Document the mod keyword)
 -  (Document the mut keyword)
 -  (Document the return keyword)
 -  (Fix ptr doc warnings.)
 -  (Tweak binop errors)
 -  (Clean up E0701 explanation)

Failed merges:

 -  (Explain move errors that occur due to method calls involving `self` (take two))

r? @ghost
2020-06-26 02:16:07 +00:00
Josh Stone
49f6166ef7 Prepare for LLVM 11 2020-06-25 18:52:41 -07:00
Manish Goregaokar
8c5d794b52
Rollup merge of - GuillaumeGomez:cleanup-e0701, r=Dylan-DPC
Clean up E0701 explanation

r? @Dylan-DPC
2020-06-25 18:00:25 -07:00
Manish Goregaokar
7fb7765cda
Rollup merge of - estebank:op-trait-bound-suggestion, r=davidtwco
Tweak binop errors

* Suggest potentially missing binop trait bound (fix )
* Use structured suggestion for dereference in binop
2020-06-25 18:00:23 -07:00
Manish Goregaokar
91f8766cea
Rollup merge of - ehuss:fix-ptr-docs, r=oli-obk
Fix ptr doc warnings.

 added some stray backtick lines which cause warnings when the docs are built.
2020-06-25 18:00:22 -07:00