Commit Graph

106373 Commits

Author SHA1 Message Date
varkor
f4f96e2943 Normalise diagnostics with respect to "the X is declared/defined here" 2020-01-24 16:24:49 +00:00
varkor
50dd8eaeb9 Print constants in type_name for const generics 2020-01-24 16:23:32 +00:00
Oliver Scherer
9a2d5e87d6 Render const pointers in MIR more compactly 2020-01-24 16:20:58 +01:00
bors
73f76b74ef Auto merge of #68414 - michaelwoerister:share-drop-glue, r=alexcrichton
Also share drop-glue when compiling with -Zshare-generics (i.e. at opt-level=0)

This PR adds drop-glue to the set of monomorphizations that can be shared across crates via `-Zshare-generics`.

This version of the PR might have detrimental effects on performance as it makes lots of stuff dependent on a single query results (`upstream_monomorphizations_for(def_id_of_drop_in_place)`). That should be fixable but let's do a perf run first.

Potentially fixes issue https://github.com/rust-lang/rust/issues/64140. (cc @alexcrichton)
The changes here are related to @matthewjasper's https://github.com/rust-lang/rust/pull/67332 but should be mostly orthogonal.

r? @ghost
2020-01-24 14:00:56 +00:00
Guillaume Gomez
768f6f9340 Clean up error codes E0223 and E0225 explanations 2020-01-24 12:56:32 +01:00
bors
dee12bb2b7 Auto merge of #68506 - tmandry:rollup-kz9d33v, r=tmandry
Rollup of 7 pull requests

Successful merges:

 - #68424 (Suggest borrowing `Vec<NonCopy>` in for loop)
 - #68438 (Account for non-types in substs for opaque type error messages)
 - #68469 (Avoid overflow in `std::iter::Skip::count`)
 - #68473 (Enable ASan on Fuchsia)
 - #68479 (Implement `unused_parens` for block return values)
 - #68483 (Add my (@flip1995) name to .mailmap)
 - #68500 (Clear out std, not std tools)

Failed merges:

r? @ghost
2020-01-24 08:32:10 +00:00
Tyler Mandry
7f8a61d96c
Rollup merge of #68500 - Mark-Simulacrum:fix-bootstrap-clearing, r=alexcrichton
Clear out std, not std tools

This was a typo that slipped in, and meant that we were still not properly
clearing out std.

This is basically #67760 but actually correct...
2020-01-24 00:31:02 -08:00
Tyler Mandry
a7e2ac41ed
Rollup merge of #68483 - flip1995:mailmap, r=Dylan-DPC
Add my (@flip1995) name to .mailmap
2020-01-24 00:31:00 -08:00
Tyler Mandry
1662888126
Rollup merge of #68479 - Tyg13:unused_parens_return, r=Centril
Implement `unused_parens` for block return values

Fixes #68386

r? @Centril
2020-01-24 00:30:59 -08:00
Tyler Mandry
94aa655a3c
Rollup merge of #68473 - nopsledder:rust_sanitizer_fuchsia, r=alexcrichton
Enable ASan on Fuchsia

This change adds the x86_64-fuchsia and aarch64-fuchsia LLVM targets to
those allowed to invoke -Zsanitizer. Currently, the only overlap between
compiler_rt sanitizers supported by both rustc and Fuchsia is ASan.
2020-01-24 00:30:58 -08:00
Tyler Mandry
e7752aefdc
Rollup merge of #68469 - ollie27:skip_count, r=sfackler
Avoid overflow in `std::iter::Skip::count`

The call to `count` on the inner iterator can overflow even if `Skip` itself would return less that `usize::max_value()` items.

Fixes #68139
2020-01-24 00:30:56 -08:00
Tyler Mandry
143059deaf
Rollup merge of #68438 - Aaron1011:fix/tait-non-defining, r=estebank
Account for non-types in substs for opaque type error messages

Fixes #68368

Previously, I assumed that the substs contained only types, which caused
the computed index number to be wrong.
2020-01-24 00:30:55 -08:00
Tyler Mandry
eb769ed6b0
Rollup merge of #68424 - estebank:suggest-borrow-for-non-copy-vec, r=davidtwco
Suggest borrowing `Vec<NonCopy>` in for loop

Partially address #64167.
2020-01-24 00:30:53 -08:00
Mark Rousskov
1cbb5d8490 Clear out std, not std tools
This was a typo that slipped in, and meant that we were still not properly
clearing out std.
2020-01-23 20:29:42 -05:00
Esteban Küber
55dce720b2 Account for ty::Error when suggesting impl Trait or Box<dyn Trait> 2020-01-23 17:04:09 -08:00
Tomasz Miąsko
2fd6c4a18a Remove unused ignore-license directives
The tidy check was removed in rust-lang/rust#53617
2020-01-24 00:00:00 +00:00
bors
62f227b3f8 Auto merge of #68012 - alexcrichton:update-some-deps, r=Mark-Simulacrum
Update some of Cargo's dependencies

This is primarily updating the `curl` dependency, but also went ahead
and applied a few updates for other packages that Cargo depends on.
2020-01-23 23:44:51 +00:00
Alex Crichton
aabf4e9253 Update some of Cargo's dependencies
This is primarily updating the `curl` dependency, but also went ahead
and applied a few updates for other packages that Cargo depends on.
2020-01-23 15:17:55 -08:00
Matthew Jasper
f30a8186f7 Make pointers to statics internal 2020-01-23 21:38:15 +00:00
Matthew Maurer
72aaa3a414 rustc: Allow cdylibs to link against dylibs
Previously, rustc mandated that cdylibs could only link against rlibs as
dependencies (not dylibs).
This commit disables that restriction and tests that it works in a
simple case.
2020-01-23 13:10:04 -08:00
Linus Färnstrand
61fecfb82f Add test accessing the module level int/float consts 2020-01-23 20:55:07 +01:00
Linus Färnstrand
002c7897a6 Unlock assoc_int_consts in documentation examples using it 2020-01-23 20:55:06 +01:00
Linus Färnstrand
4d9e90d2a5 Unlock assoc_int_consts in core+std 2020-01-23 20:55:06 +01:00
Linus Färnstrand
9fcbaa4158 Fix broken show-const-contents test 2020-01-23 20:55:06 +01:00
Linus Färnstrand
6ce16cfa42 Remove no longer valid test 2020-01-23 20:55:06 +01:00
Linus Färnstrand
9d257579fc Fix some float operations to work together with the assoc consts 2020-01-23 20:55:06 +01:00
Linus Färnstrand
22dcfa1d8d Add relevant associated constants to the float types 2020-01-23 20:55:06 +01:00
Linus Färnstrand
b5ff8064a4 Add MIN/MAX associated constants to the integer types 2020-01-23 20:55:06 +01:00
Esteban Küber
6eaf59dfc8 use diagnostic_item and modify wording 2020-01-23 11:51:56 -08:00
bors
41f41b2354 Auto merge of #68391 - tmiasko:compiletest-debuginfo, r=alexcrichton
compiletest: Simplify multi-debugger support

Previous implementation used a single mode type to store various pieces
of otherwise loosely related information:

* Whether debuginfo mode is in use or not.
* Which debuggers should run in general.
* Which debuggers are enabled for particular test case.

The new implementation introduces a separation between those aspects.
There is a single debuginfo mode parametrized by a debugger type.
The debugger detection is performed first and a separate configuration
is created for each detected debugger. The test cases are gathered
independently for each debugger which makes it trivial to implement
support for `ignore` / `only` conditions.

Functional changes:

* A single `debuginfo` entry point (rather than `debuginfo-cdb`, `debuginfo-gdb+lldb`, etc.).
* Debugger name is included in the test name.
* Test outputs are placed in per-debugger directory.
* Fixed spurious hash mismatch. Previously, the config mode would change
  from `DebugInfoGdbLldb` (when collecting tests) to `DebugInfoGdb` or
  `DebugInfoLldb` (when running them) which would affect hash computation.
* PYTHONPATH is additionally included in gdb hash.
* lldb-python and lldb-python-dir are additionally included in lldb hash.
2020-01-23 19:39:07 +00:00
Michael Woerister
197cc1e43a Add projection query for upstream drop-glue instances.
This reduces the amount of invalidated data when new types are
add to upstream crates.
2020-01-23 16:56:59 +01:00
Tuomas Lappeteläinen
ad1cdecaeb add a test for #60976
The test fails on 1.36.0 but passes on master.
2020-01-23 15:37:39 +02:00
flip1995
06064b99fd
Add my (@flip1995) name to .mailmap 2020-01-23 13:43:23 +01:00
Guillaume Gomez
0f5ed4d2cd Clean up E0207 explanation 2020-01-23 13:37:05 +01:00
Guillaume Gomez
3850d96379 clean up error codes explanation 2020-01-23 13:29:15 +01:00
Michael Woerister
2ceb92bc53 Make drop-glue take advantage of -Zshare-generics. 2020-01-23 13:15:15 +01:00
Michael Woerister
190f0c0b0b Always just use symbol name for sorting exported symbols. 2020-01-23 13:15:15 +01:00
Michael Woerister
0c366cdeaf Make ExportedSymbols type more local because it's not supposed to be
used outside of the LLVM backend.
2020-01-23 13:15:15 +01:00
Michael Woerister
29951edbdf Clarify some methods around instance instantiation via comments and clearer names. 2020-01-23 13:15:14 +01:00
Tomasz Miąsko
5c384ab00c compiletest: Do not run debuginfo tests with gdb on msvc targets 2020-01-23 11:41:55 +01:00
bors
e0bbe7915e Auto merge of #68435 - tmandry:llvmup-2-the-return-of-phibitcast-transform-fixes, r=alexcrichton
Update LLVM

Fixes #67855 (rust-lang/llvm-project#31)
Fixes #66036 (rust-lang/llvm-project#32)

r? @nikic @alexcrichton
2020-01-23 07:26:56 +00:00
Tyler Lanphear
6f7e89ffe3 unused-parens: implement for block return values 2020-01-23 00:42:35 -05:00
bors
462fc37fa8 Auto merge of #68298 - Mark-Simulacrum:binary-depdep-fix, r=petrochenkov
Avoid declaring a fake dependency edge

When we're producing an rlib, we do not need anything more than an rmeta file
for each of our dependencies (this is indeed utilized by Cargo for pipelining).
Previously, we were still storing the paths of possible rlib/dylib crates, which
meant that they could still plausibly be accessed. With -Zbinary-dep-depinfo,
that meant that Cargo thought that rustc was using both the rlib and an (earlier
emitted) rmeta, and so needed a recompile, as the rlib may have finished writing
*after* compilation started (for more detail, see issue 68149).

This commit changes metadata loading to not store the filepaths of dylib/rlib if
we're going to end up creating an rlib only.

Fixes #68149.
2020-01-23 03:48:07 +00:00
bors
e23dd6687f Auto merge of #68474 - tmandry:rollup-6gmbet6, r=tmandry
Rollup of 10 pull requests

Successful merges:

 - #67195 ([experiment] Add `-Z no-link` flag)
 - #68253 (add bare metal ARM Cortex-A targets to rustc)
 - #68361 (Unbreak linking with lld 9 on FreeBSD 13.0-CURRENT i386)
 - #68388 (Make `TooGeneric` error in WF checking a proper error)
 - #68409 (Micro-optimize OutputFilenames)
 - #68410 (Export weak symbols used by MemorySanitizer)
 - #68425 (Fix try-op diagnostic in E0277 for methods)
 - #68440 (bootstrap: update clippy subcmd decription)
 - #68441 (pprust: use as_deref)
 - #68462 (librustc_mir: don't allocate vectors where slices will do.)

Failed merges:

r? @ghost
2020-01-23 00:04:33 +00:00
Tyler Mandry
bfac73c0a6
Rollup merge of #68462 - matthiaskrgr:novec, r=varkor
librustc_mir: don't allocate vectors where slices will do.
2020-01-22 16:02:24 -08:00
Tyler Mandry
14e6259c29
Rollup merge of #68441 - Centril:pprust-as_deref, r=Mark-Simulacrum
pprust: use as_deref

Some drive-by cleanup.
2020-01-22 16:02:20 -08:00
Tyler Mandry
ac3e183c42
Rollup merge of #68440 - matthiaskrgr:xpyclippy, r=Mark-Simulacrum
bootstrap: update clippy subcmd decription

Clarify where the clippy used in `./x.py clippy` is coming from.
It uses whatever clippy binary was installed via rustup, cargo-install
or otherwise and does NOT use the binary generated by `./x.py build src/tools/clippy`.
2020-01-22 16:02:19 -08:00
Tyler Mandry
1077adae12
Rollup merge of #68425 - phi-gamma:try-method, r=varkor
Fix try-op diagnostic in E0277 for methods

For methods the try-op diagnostic displays the empty string where
it has more descriptive strings like “a function” otherwise:

    error[E0277]: the `?` operator can only be used in  that returns `Result` or `Option` (or another type that implements `std::ops::Try`)
                                                      ^^
       | |             ^^ cannot use the `?` operator in  that returns `()`
                                                        ^^

I’m seeing this on nightly (rustc 1.42.0-nightly (b5a3341f1
2020-01-20)) and [on the playpen](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=0e7ce7792c2aceb8056941710d539124).

The changeset add strings for impl methods and trait provided
methods and test cases for the option type.
2020-01-22 16:02:17 -08:00
Tyler Mandry
97ac259148
Rollup merge of #68410 - tmiasko:msan-lto, r=varkor
Export weak symbols used by MemorySanitizer

Export weak symbols defined by MemorySanitizer instrumentation, which are used
to implement `-Zsanitizer-memory-track-origins` and `-Zsanitizer-recover=memory`.
Previously, when using fat LTO, they would internalized and eliminated.

Fixes #68367.
2020-01-22 16:02:16 -08:00
Tyler Mandry
f9b0561031
Rollup merge of #68409 - sinkuu:temp_path, r=Mark-Simulacrum
Micro-optimize OutputFilenames

For example, its methods consume 6% of time during debug-compiling a `warp` example:
![Screenshot (debug-compiling a `warp` example)](https://user-images.githubusercontent.com/7091080/72780288-d74f1580-3c61-11ea-953b-34e59ca682f9.png)

This PR optimize them a bit by using `PathBuf::set_extension` instead of `Path::with_extension`, to avoid cloning `PathBuf` excessively.
2020-01-22 16:02:14 -08:00