bors
a62bab2076
Auto merge of #6000 - ebroto:sync-from-rust, r=ebroto
...
Sync from rust
r? @ghost
changelog: none
2020-09-02 07:56:44 +00:00
Eduardo Broto
a5754a1fad
Run cargo dev fmt
2020-09-02 08:57:00 +02:00
Eduardo Broto
da86067775
Merge remote-tracking branch 'upstream/master' into sync-from-rust
2020-09-02 08:53:29 +02:00
bors
48248af630
Auto merge of #5999 - rail-rain:fix_fp_transmute_ptr_to_ptr_in_consts, r=ebroto
...
Fix a fp in `transmute_ptr_to_ptr`
fixes #5959
changelog: Fix a false positive in `transmute_ptr_to_ptr` that the lint fires when `transmute` is used to cast a reference in const contexts although dereferencing raw pointers in consts is unstable.
2020-09-01 22:28:55 +00:00
Ricky
337729137b
Ran cargo dev update_lints
2020-09-01 17:05:40 -04:00
Ricky
202a80c927
Added tests for map_err, ignored map_err lint on drop_ref tests
2020-09-01 16:59:37 -04:00
Ricky
e49a29933b
Working map_err_ignore lint
2020-09-01 16:26:59 -04:00
bors
67e18c2d5c
Auto merge of #5993 - taiki-e:default_trait_access, r=phansch
...
default_trait_access: Fix wrong suggestion
https://github.com/rust-lang/rust-clippy/issues/5975#issuecomment-683751131
> I think the underlying problem is clippy suggests code with complete parameters, not clippy triggers this lint even for complex types. AFAIK, If code compiles with `Default::default`, it doesn't need to specify any parameters, as type inference is working. (So, in this case, `default_trait_access` should suggest `RefCell::default`.)
Fixes #5975 Fixes #5990
changelog: `default_trait_access`: fixed wrong suggestion
2020-09-01 15:05:16 +00:00
Takayuki Nakata
aa7ffa5257
Fix FP in same_item_push
...
Don't emit a lint when the pushed item doesn't have Clone trait
2020-09-01 22:39:09 +09:00
Koxiaet
b30422114e
Allow GraphQL in doc without backticks
2020-09-01 14:05:19 +01:00
Taiki Endo
2e4b4cebbb
useless_attribute: Permit wildcard_imports and enum_glob_use
2020-09-01 12:09:32 +09:00
rail
afeb917fca
Fix a fp in transmute_ptr_to_ptr
...
Avoid firing the lint when `transmute` in const contexts
as dereferencing raw pointers in consts is unstable. cc #5959
2020-09-01 11:51:32 +12:00
Vali Schneider
f9fcbbea03
fixed bug
2020-08-31 13:32:05 -07:00
bors
066f105d67
Auto merge of #5992 - giraffate:fix_wrong_seggestion_in_collapsible_if, r=yaahc
...
Fix the wrong suggestion when using macro in `collapsible_if`
Fix #5962
changelog: Fix the wrong suggestion when using macro in `collapsible_if`
2020-08-31 19:41:13 +00:00
bors
8334a58c2f
Auto merge of #5909 - khuey:async_yields_async, r=yaahc
...
Add a lint for an async block/closure that yields a type that is itself awaitable.
This catches bugs of the form
tokio::spawn(async move {
let f = some_async_thing();
f // Oh no I forgot to await f so that work will never complete.
});
See the two XXXkhuey comments and the unfixed `_l` structure for things that need more thought.
*Please keep the line below*
changelog: none
2020-08-31 19:20:30 +00:00
Taiki Endo
8b0aa6a00b
default_trait_access: Fix wrong suggestion
2020-09-01 00:31:53 +09:00
Takayuki Nakata
001f9e45f2
Fix the wrong suggestion when using macro in collapsible_if
2020-09-01 00:05:53 +09:00
Hirochika Matsumoto
451ef78803
Use match_def_path
instead of match_qpath
2020-08-31 22:40:47 +09:00
bors
001c1c51d2
Auto merge of #5984 - ebroto:5693_const_assoc_fn, r=flip1995
...
or_fn_call: ignore nullary associated const fns
The fix in #5889 was missing associated functions.
changelog: Ignore also `const fn` methods in [`or_fun_call`]
Fixes #5693
2020-08-31 10:43:58 +00:00
Aaron Hill
fdc48fb90c
Fix clippy
2020-08-30 19:17:17 -04:00
bors
ab64d47c03
Auto merge of #5988 - camelid:patch-2, r=ebroto
...
Syntax-highlight `single_char_push_str` lint
It wasn't being syntax highlighted in the online lint index:
![image](https://user-images.githubusercontent.com/37223377/91666682-8fc02000-eab3-11ea-95fa-6671472712c8.png )
changelog: none
2020-08-30 20:21:00 +00:00
Camelid
17b2ba5ded
Syntax-highlight single_char_push_str
lint
2020-08-30 11:29:17 -07:00
Dylan MacKenzie
1c5b0fbe53
Update dataflow analyses to use new interface
2020-08-30 11:15:25 -07:00
Vali Schneider
73a3288282
uncommented fn
2020-08-29 16:22:15 -07:00
Vali Schneider
a424a2c167
changed check_impl_item to check_fn and added a few more test cases
2020-08-29 16:17:53 -07:00
Kyle Huey
04912ca115
Formatting changes requested by ThibsG.
2020-08-29 15:33:54 -07:00
Kyle Huey
c1d2b9376a
Add a test for an async function.
2020-08-29 15:33:54 -07:00
Kyle Huey
4972989b61
Add a lint for an async block/closure that yields a type that is itself awaitable.
...
This catches bugs of the form
tokio::spawn(async move {
let f = some_async_thing();
f // Oh no I forgot to await f so that work will never complete.
});
2020-08-29 15:33:54 -07:00
Hirochika Matsumoto
5b7590f841
Downgrade applicability of create_dir
2020-08-29 14:20:01 +09:00
Eduardo Broto
7a66e6502d
or_fn_call: ignore nullary associated const fns
2020-08-29 01:20:49 +02:00
flip1995
282c59820b
Merge commit '3d0b0e66afdfaa519d8855b338b35b4605775945' into clippyup
2020-08-28 18:43:25 +02:00
bors
c88c614941
Auto merge of #5970 - ebroto:changelog_beta_1_47, r=flip1995
...
Update changelog to beta 1.47
[Rendered](https://github.com/ebroto/rust-clippy/blob/changelog_beta_1_47/CHANGELOG.md )
changelog: none
2020-08-28 13:08:29 +00:00
bors
3d0b0e66af
Auto merge of #5774 - ThibsG:FixNewRetNoSelf, r=ebroto
...
Fix FP in `new_ret_no_self`: trigger in trait def instead of impl block
Lint in trait def instead of impl block.
Fixes : #5435
changelog: none
2020-08-28 11:54:07 +00:00
Hirochika Matsumoto
eebd248365
Fix errors
2020-08-28 19:56:19 +09:00
Hirochika Matsumoto
34e302e67c
Fix clippy error
2020-08-28 19:35:04 +09:00
Hirochika Matsumoto
607905d126
Add STD_FS_CREATE_DIR into paths
2020-08-28 18:53:15 +09:00
Hirochika Matsumoto
5574182b4d
Add a new lint to prevent create_dir
from being used
2020-08-28 18:45:28 +09:00
Thibaud
73b1ee1a61
Update clippy_lints/src/methods/mod.rs
...
Co-authored-by: Eduardo Broto <ebroto@tutanota.com>
2020-08-28 09:33:05 +02:00
Thibaud
ffaadae8e4
Update clippy_lints/src/utils/mod.rs
...
Co-authored-by: Eduardo Broto <ebroto@tutanota.com>
2020-08-28 09:31:29 +02:00
Thibaud
e8be047c5b
Update clippy_lints/src/utils/mod.rs
...
Co-authored-by: Eduardo Broto <ebroto@tutanota.com>
2020-08-28 09:31:12 +02:00
Vali Schneider
b006522393
added lint for todo and removed option
2020-08-27 16:55:23 -07:00
Vali Schneider
b2d8ca9a76
ran cargo dev update lints
2020-08-27 16:30:49 -07:00
bors
07c5e9edb5
Auto merge of #5971 - giraffate:fix_fp_in_to_string_in_display, r=ebroto
...
Fix FP in `to_string_in_display`
Don't emit a lint when `.to_string()` on anything that is not `self`
Fix #5967
changelog: Fix FP in `to_string_in_display` when calling `.to_string()` on anything that is not `self`
2020-08-27 23:26:52 +00:00
Vali Schneider
8462cce960
edited documentation
2020-08-27 16:22:37 -07:00
Vali Schneider
ceab1a9167
removed unnecessary comment
2020-08-27 16:19:24 -07:00
Vali Schneider
459969f88f
added restriction lint that prohibits the usage of unimplemented, unreachable or panic in a function of type result or option
2020-08-27 16:18:05 -07:00
Tim Nielens
f3ccbef2af
unit-arg - pr comments
2020-08-27 19:36:28 +02:00
ThibsG
504612622f
Merge logic of looking for Self
type
2020-08-27 18:31:31 +02:00
ThibsG
3cb75c2e5c
Remove expansion restriction + fix doc and tests naming
2020-08-27 18:25:38 +02:00
ThibsG
2a3ee5fa85
Fix FP in new_ret_no_self
: trigger in trait def instead of impl block
2020-08-27 18:25:38 +02:00