360: Improve comments and code in ra_vfs r=DJMcNab a=DJMcNab
Some random code/comment improvements I saw whilst trying to understand `ra_vfs`.
Let's see if this works:
bors r+
Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com>
Attempting to format a document when rustfmt isn't installed will result
in an error being returned to the frontend. An alternative
implementation would be returning zero replacements.
359: Add more docs in ty.rs r=matklad a=flodiebold
Also get rid of the indirection through query_definitions for the type-related
queries.
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
356: Fix a bug in char literal validation discovered through fuzzing r=matklad a=DJMcNab
We also add a Cargo.lock to the fuzzing directory, as that isn't gitignored automatically, so I imagine it should be committed.
Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com>
355: Type variables / unification r=matklad a=flodiebold
This will really become necessary when we implement generics, but even now, it allows us to reason 'backwards' to infer types of expressions that we didn't understand for some reason.
This uses [ena](https://crates.io/crates/ena) to keep track of type variables.
Also turn `Ty::Tuple` from a `Vec` into an `Arc<[Ty]>` to keep `Ty` easily cloneable. Though to be honest I'm not sure how often we actually share data here, with all the make_muts and modifying...
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
This will really become necessary when we implement generics, but even now, it
allows us to reason 'backwards' to infer types of expressions that we didn't
understand for some reason.
We use ena, the union-find implementation extracted from rustc, to keep track of
type variables.
TODO: Check this on CI. Maybe we should change the prettier script
in `editors/code`, or move it to somewhere else
(`tests/format` maybe)
Editing the script in editors/code would be easiest as
that means we don't have to double install some shared `node_modules`
353: update README with Rust 1.31 r=matklad a=yerke
Update README with Rust 1.31, since Rust 2018 edition is already on stable
Co-authored-by: Yerkebulan Tulibergenov <yerkebulan@gmail.com>
350: Super simple macro support r=matklad a=matklad
Super simple support for macros, mostly for figuring out how to fit them into the current architecture. Expansion is hard-coded and string based (mid-term, we should try to copy-paste macro-by-example expander from rustc).
Ideally, we should handle
* highlighting inside the macro (done)
* extend selection inside the macro
* completion inside the macro
* indexing structs, produced by the macro
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
349: Bump serde from 1.0.82 to 1.0.83 r=matklad a=dependabot[bot]
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.82 to 1.0.83.
<details>
<summary>Release notes</summary>
*Sourced from [serde's releases](https://github.com/serde-rs/serde/releases).*
> ## v1.0.83
> - Support a `rename_all` specification that applies only to the Serialize impl or only to the Deserialize impl ([#1447](https://github-redirect.dependabot.com/serde-rs/serde/issues/1447), thanks [**vincascm**](https://github.com/vincascm))
>
> ```rust
> #[derive(Serialize, Deserialize)]
> #[serde(rename_all(
> serialize = "camelCase",
> deserialize = "SCREAMING_SNAKE_CASE",
> ))]
> struct S { /* ... */ }
> ```
>
> - Allow serializing struct name inside of structs with named fields ([#1448](https://github-redirect.dependabot.com/serde-rs/serde/issues/1448), thanks [**motu42**](https://github.com/motu42))
>
> ```rust
> #[derive(Serialize)]
> #[serde(tag = "type")]
> struct S { /* ... */ } // serializes as {"type":"S",...}
> ```
</details>
<details>
<summary>Commits</summary>
- [`b1b9702`](b1b9702daf) Release 1.0.83
- [`32728d2`](32728d2f1d) Format with rustfmt 2018-12-10
- [`807a097`](807a097387) Fix spelling in ui test name
- [`794ee15`](794ee15386) Merge pull request [#1448](https://github-redirect.dependabot.com/serde-rs/serde/issues/1448) from motu42/master
- [`2359417`](2359417804) Added ui tests, Limited serde(tag = "...") to structs with named field
- [`7950f3c`](7950f3cdc5) Format with rustfmt 2018-12-10
- [`b87f8f3`](b87f8f35ee) Merge pull request 1447 from vincascm/master
- [`9e53405`](9e53405f43) Fix for rustc 1.15.0
- [`c6c1d8f`](c6c1d8fa86) Work around deprecation of str::trim_left_matches
- [`8aa5c2b`](8aa5c2b45d) Removed deprected ui/enum-representation/internally-tagged-struct test
- Additional commits viewable in [compare view](https://github.com/serde-rs/serde/compare/v1.0.82...v1.0.83)
</details>
<br />
[](https://dependabot.com/compatibility-score.html?dependency-name=serde&package-manager=cargo&previous-version=1.0.82&new-version=1.0.83)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme
Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)
Finally, you can contact us by mentioning @dependabot.
</details>
Co-authored-by: dependabot[bot] <support@dependabot.com>
