Jason Newcomb
c0fa6a92f0
literal_representation: Delay macro check.
2024-07-07 18:06:27 -04:00
Jason Newcomb
15f640a7cb
let_with_type_underscore:
...
* Delay macro check.
* Use `is_from_proc_macro
2024-07-07 18:06:17 -04:00
Jason Newcomb
5332def0fd
let_underscore: Delay macro check.
2024-07-07 18:06:00 -04:00
Jason Newcomb
fed75b3895
let_if_seq: use array_windows.
2024-07-07 18:05:51 -04:00
Jason Newcomb
ff4e62d3ec
len_zero: Check HIR tree first
2024-07-07 18:05:41 -04:00
Alex Macleod
eac1aab1ff
Reduce the size of lintcheck JSON output
2024-07-07 21:05:51 +00:00
Jason Newcomb
5ae33c7699
legacy_numeric_constants: Check HIR tree first.
2024-07-07 16:52:59 -04:00
Jason Newcomb
03036c11b3
large_include_file: Check HIR tree first.
2024-07-07 16:52:33 -04:00
Jason Newcomb
c3dd028d3e
large_futures: Delay macro check
2024-07-07 16:52:13 -04:00
Jason Newcomb
430c02cbd0
large_enum_variant: Delay macro check
2024-07-07 16:51:58 -04:00
Jason Newcomb
3092c8a5fd
large_const_arrays: Check HIR tree first.
2024-07-07 16:51:33 -04:00
Jason Newcomb
6b10b4360c
iter_without_into_iter: Delay macro check
2024-07-07 16:51:20 -04:00
Jason Newcomb
fa1a690b23
iter_not_returning_iterator:
...
* Check HIR tree first.
* Check name by symbol.
2024-07-07 16:43:07 -04:00
Jason Newcomb
ca5c2813eb
items_after_statements: Do less work in the default case.
2024-07-07 16:41:36 -04:00
Jason Newcomb
aef0710054
instant_subtraction: Reduce redundant work.
2024-07-07 16:37:51 -04:00
Jason Newcomb
dc8403f0f5
inline_fn_without_body: inline into a single function
2024-07-07 16:37:31 -04:00
Jason Newcomb
8e2ddc800b
inherent_to_string: Check HIR tree before checking for macros.
2024-07-07 16:35:05 -04:00
Jason Newcomb
f493d71a38
infinite_iter: Only lock the symbol table once.
2024-07-07 16:27:27 -04:00
Jason Newcomb
c73aceb043
indexing_slicing: Check HIR tree first.
2024-07-07 16:26:57 -04:00
Jason Newcomb
06f83b4e26
index_refutable_slice: Check HIR tree first.
2024-07-07 16:26:42 -04:00
Jason Newcomb
b58b491d16
inconsistent_struct_constructor: Check HIR tree first.
2024-07-07 16:26:04 -04:00
Jason Newcomb
3869e93408
ignored_unit_patterns: Reorder checks.
2024-07-07 16:24:45 -04:00
Jason Newcomb
517e1ac225
if_then_some_else_none: Check HIR tree before other checks.
2024-07-07 16:23:50 -04:00
Jason Newcomb
b26b820f3f
Refactor if_not_else:
...
* Check HIR tree first.
* Merge lint calls.
2024-07-07 16:23:18 -04:00
Jason Newcomb
776a5238b7
if_let_mutex: Use for_each_expr.
2024-07-07 16:16:59 -04:00
Jason Newcomb
c32af26be0
Refactor future_not_send
2024-07-07 16:16:36 -04:00
Jason Newcomb
d409b5c700
extra_unused_type_parameters:
...
* Inline `is_empty_exported_or_macro`.
* Check if there are any generic parameters before walking the signature.
2024-07-07 16:13:38 -04:00
Jason Newcomb
f178316ae2
Refactor excessive_bools:
...
* Check HIR tree before checking for macros.
* Check item count before checking for bools.
2024-07-07 16:11:11 -04:00
Jason Newcomb
1b0230cf25
Refactor endian_bytes:
...
* Merge code paths.
* Check HIR tree before checking for macros.
2024-07-07 16:10:19 -04:00
bors
a4132817fb
Auto merge of #13052 - xFrednet:00000-lintcheck-warn-all, r=Alexendoo
...
Lintcheck: Add `--warn-all` and make it the CI default
This PR adds a new `--warn-all` flag to lintcheck. This is intended for our CI, as it currently doesn't detect changes of `nursery` and `restriction` lints.
I only made it the default for the CI, as `restriction` lints tend to generate A LOT of lint triggers. Looking at you [`clippy::implicit_return`](https://rust-lang.github.io/rust-clippy/master/index.html#/clippy::implicit_return )
That's it. Should hopefully be easy to review.
Also, a bit thanks again to `@Alexendoo` for adding this to our CI ❤️
---
r? `@Alexendoo`
changelog: none
2024-07-07 18:30:39 +00:00
xFrednet
93e74a4187
Lintcheck: Update lintcheck documentation
2024-07-07 18:42:09 +02:00
Maybe Waffle
791ff40337
Add support for mir::TerminatorKind::TailCall in clippy
2024-07-07 17:11:05 +02:00
bors
09c07ed63f
Auto merge of #13048 - Jarcho:disallowed_methods, r=blyxyas
...
Refactor `disallowed_methods` and narrow span
Using the span of the call site just produces noisy diagnostics for long calls. Especially multi-line calls.
changelog: none
2024-07-07 14:28:44 +00:00
Jason Newcomb
d2ff2b9850
Move panicking_overflow_checks into correctness and clean up docs.
2024-07-07 10:24:46 -04:00
Jason Newcomb
23d96f65e4
Rename overflow_check_conditional to panicking_overflow_checks.
2024-07-07 10:24:42 -04:00
Jason Newcomb
aa371c37c2
Rewrite overflow_check_conditional
2024-07-07 10:22:29 -04:00
Lzu Tao
c46c1f6da6
Fix 13018: self should be T
...
with `Option::unwrap_or(self, T) -> T`.
2024-07-07 20:41:55 +07:00
bors
f2c74e220b
Auto merge of #12966 - Rudxain:patch-1, r=dswij
...
Clarify that `modulo_one` only applies to ints
changelog: [`modulo_one`]: (docs) Clarify that it only applies to integers
This might be nitpicky, but it's more technically correct.
It also helps if a user skims through the docs, because they may believe it also applies to `{float}`s. This doc edit minimizes that possibility
2024-07-07 10:21:47 +00:00
John Arundel
5a9e5e4acf
resolve code review comments
2024-07-07 10:49:26 +01:00
John Arundel
f7050b0c78
resolve code review comments
2024-07-07 10:44:27 +01:00
Michael Goulet
7ce4a49911
iter_identity is a better name
2024-07-07 00:12:35 -04:00
Lzu Tao
e864519fbc
Add test for manual_unwrap_or in issue 13018
2024-07-07 03:34:38 +00:00
Jason Newcomb
0a25df87ef
Refactor double_parens:
...
* Merge control flow before emission
* Check the AST before the macro check
2024-07-06 22:13:45 -04:00
Jason Newcomb
65b9fae565
Refactor checked_conversions:
...
* Check HIR tree before checking macros, msrv and constness
* Remove redundant HIR tree matching
2024-07-06 21:47:57 -04:00
lukas
e0f32e09de
Mark format! with must_use hint
2024-07-06 14:24:20 +02:00
bors
0c9016aa1e
Auto merge of #13055 - Jarcho:auto_derive, r=Alexendoo
...
Only check for `automatically_derived` on impl blocks
This brings us in line with how rustc checks for the attribute. Also note that `unused_attributes` will trigger if it's placed anywhere else.
See:
9a21ac8e7e/compiler/rustc_passes/src/dead.rs (L400-L403)9a21ac8e7e/compiler/rustc_passes/src/liveness.rs (L143-L148)
2024-07-06 12:01:28 +00:00
Jason Newcomb
d8fb164a7c
Rename any_parent_is_automatically_derived to in_automatically_derived. Only check for the attribute on an impl block.
2024-07-06 00:24:48 -04:00
y21
ecbb2d7ba9
remove internal compiler_lint_functions lint
2024-07-06 00:51:58 +02:00
bors
3ed690f07a
Auto merge of #12974 - alex-semenyuk:rename_thread_local_initializer_can_be_made_const, r=Alexendoo
...
Rename thread_local_initializer_can_be_made_const to missing_const_for_thread_local
Close #12934
As discussed at #12934 name `thread_local_initializer_can_be_made_const` sounds against convention for other lints which describe the issue/wrong code but not suggestion and it is quite long. The new name take example from existing lint `missing_const_for_fn`
changelog: `thread_local_initializer_can_be_made_const` : Rename to [`missing_const_for_thread_local`]
2024-07-05 17:50:06 +00:00
xFrednet
25bb612538
Lintcheck: Add --warn-all and make it the CI default
2024-07-05 16:42:20 +02:00
