kjeremy
f633f69e36
Do not call reserve since extend will handle it.
...
`Take` implements `TrustedLen` so we are guaranteed that only one
reserve call will be made.
2020-03-30 17:09:21 -04:00
kjeremy
c39725212c
Use more functional programming in ArenaMap::insert
...
I find this more readable and it flattens out the body a little.
2020-03-30 16:15:28 -04:00
bors[bot]
6f0d8db529
Merge #3775
...
3775: Fix typo r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-03-30 16:51:56 +00:00
Aleksey Kladov
beab6f34ce
Fix typo
2020-03-30 18:51:30 +02:00
kjeremy
d4c317320d
Simplify SemanticTokensBuilder build method
...
This matches the next stable vscode api
2020-03-30 12:07:27 -04:00
Kirill Bulatov
4c897d8d2d
Fix the endless progress bar issue
2020-03-30 14:38:01 +03:00
Kirill Bulatov
8e78371222
Rebase fixes
2020-03-30 13:39:14 +03:00
Kirill Bulatov
2a19459ee9
Avoid failing on incorrect settings response
2020-03-30 13:39:14 +03:00
Kirill Bulatov
fbef0127ba
Small style fix
2020-03-30 13:39:14 +03:00
Kirill Bulatov
b892a48740
Code review fixes
...
Co-Authored-By: Veetaha <veetaha2@gmail.com>
2020-03-30 13:39:14 +03:00
Kirill Bulatov
590af37bff
Small style fix
...
Co-Authored-By: Veetaha <veetaha2@gmail.com>
2020-03-30 13:39:14 +03:00
Kirill Bulatov
392eb74b5f
Remove an obsolete fixme
2020-03-30 13:39:14 +03:00
Kirill Bulatov
bbe59c7197
Reload watcher configuration
2020-03-30 13:39:14 +03:00
Kirill Bulatov
8a23bec2cd
Style fixes
2020-03-30 13:39:14 +03:00
Kirill Bulatov
332799d914
Reload only the properties that do not affect vfs
2020-03-30 13:39:14 +03:00
Kirill Bulatov
2feaef91bd
Read new config on the server side
2020-03-30 13:39:14 +03:00
Kirill Bulatov
019f269a0a
Process configuration response draft
2020-03-30 13:39:14 +03:00
Kirill Bulatov
8c4aab0c80
Client side draft
2020-03-30 13:39:14 +03:00
Aleksey Kladov
0cfa9eb445
Use IntoIter
2020-03-30 12:28:22 +02:00
bors[bot]
d2ea3f25b5
Merge #3761
...
3761: Append new match arms rather than replacing all of them r=matklad a=mattyhall
This means we now retain comments when filling in match arms. This fixes #3687 . This is my first contribution so apologies if it needs a rethink! I think in particular the way I find the position to append to and remove_if_only_whitespace are a little hairy.
Co-authored-by: Matthew Hall <matthew@quickbeam.me.uk>
2020-03-30 10:19:02 +00:00
bors[bot]
3901198e87
Merge #3763
...
3763: Simplify r=matklad a=Veetaha
Co-authored-by: veetaha <veetaha2@gmail.com>
2020-03-30 09:57:40 +00:00
Aleksey Kladov
4c9272583c
Pull options outwards
2020-03-30 11:46:04 +02:00
Aleksey Kladov
12297ab675
Fix race in the tests
2020-03-30 11:33:01 +02:00
Aleksey Kladov
f7df0b56a7
Use automatic thread joining for cargo-watch
2020-03-30 11:33:01 +02:00
Edwin Cheng
36812b9d7b
Fix review comments
2020-03-30 02:39:03 +08:00
Matthew Hall
ddb9cc47d1
Tidy up insertion position logic
2020-03-29 12:45:15 +01:00
Matthew Hall
b8b271d984
Remove unneeded variables
2020-03-29 12:32:01 +01:00
Edwin Cheng
dc0076de12
Move roots_to_scan to LoopState
2020-03-29 06:33:16 +08:00
veetaha
3d73345cdb
Simplify
2020-03-28 23:48:37 +02:00
Matthew Hall
77bb9a56f1
Remove "TODO" in comment in test
2020-03-28 21:24:26 +00:00
Matthew Hall
ecc2615ba2
Append new match arms rather than replacing all of them
...
This means we now retain comments when filling in match arms.
2020-03-28 20:58:46 +00:00
Aleksey Kladov
311cbbdad5
Remove some unwraps
2020-03-28 12:27:54 +01:00
Aleksey Kladov
6596e7cddf
Nice string formatting
2020-03-28 12:27:54 +01:00
Aleksey Kladov
b764c38436
Start stdx
...
This crate will hold everything to small to be worth publishing
2020-03-28 11:01:25 +01:00
Piotr Szpetkowski
f016d8b900
Fix merge-imports assist for wildcard imports
2020-03-27 17:28:25 +01:00
Aleksey Kladov
dc311b10f3
Fix assist description
2020-03-27 13:23:19 +01:00
bors[bot]
a4901fdcfd
Merge #3742
...
3742: Replace if with if-let r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-03-27 11:21:57 +00:00
Aleksey Kladov
91e482b46d
Replace if with if-let
2020-03-27 12:15:46 +01:00
bors[bot]
f9cf86475c
Merge #3741
...
3741: More general ctor for ifs r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-03-27 10:38:31 +00:00
Aleksey Kladov
cbb53cf55c
More general ctor for ifs
2020-03-27 11:38:00 +01:00
bors[bot]
31528620a8
Merge #3740
...
3740: Simplify r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-03-27 10:27:01 +00:00
Aleksey Kladov
d953df319b
Simplify
2020-03-27 11:25:11 +01:00
bors[bot]
b1594f1080
Merge #3727
...
3727: Introduce ra_proc_macro r=matklad a=edwin0cheng
This PR implemented:
1. Reading dylib path of proc-macro crate from cargo check , similar to how `OUTDIR` is obtained.
2. Added a new crate `ra_proc_macro` and implement the foot-work for reading result from external proc-macro expander.
3. Added a struct `ProcMacroClient` , which will be responsible to the client side communication to the External process.
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2020-03-26 17:09:32 +00:00
Edwin Cheng
db162df264
Remove deps on tt_mbe
2020-03-27 00:46:40 +08:00
bors[bot]
20c110e57f
Merge #3732
...
3732: Assist: replace unwrap with match r=matklad a=unrealhoang
attempt on #3669
Co-authored-by: Unreal Hoang <unrealhoang@gmail.com>
2020-03-26 15:38:03 +00:00
Aleksey Kladov
db34abeb85
Get rid of ItemOrMacro
2020-03-26 16:10:01 +01:00
Unreal Hoang
d9df0f43ac
Assist: replace unwrap with match
2020-03-27 00:08:12 +09:00
Aleksey Kladov
b7aaefb5a4
Minor incremental tests cleanup
2020-03-26 15:44:31 +01:00
Edwin Cheng
72e68d0caf
Refactoring a bit
2020-03-26 10:49:23 +08:00
Edwin Cheng
d0b6ed4441
Add ProcMacroClient
2020-03-26 03:29:45 +08:00