Yuki Kodama
fd83f469e9
Trim at presentation layer
2020-05-26 01:06:25 +09:00
Yuki Kodama
41d0f7f24e
Fix test to consider multiple underscores
2020-05-26 01:06:25 +09:00
Yuki Kodama
408d04764c
Use built-in method
2020-05-26 01:06:25 +09:00
Yuki Kodama
378bfc3c8f
Separate assertions
2020-05-26 01:06:25 +09:00
Yuki Kodama
4d13691ad1
Reflect test case
2020-05-26 01:06:25 +09:00
Yuki Kodama
6c676909dd
Strip leading underscore
2020-05-26 01:06:25 +09:00
bors[bot]
30f058dfea
Merge #4602 #4603
...
4602: Add boolean literal semantic token type to package.json r=matklad a=lnicola
Closes #4583 .
CC @GrayJack
4603: Add self keyword semantic token type r=matklad a=lnicola
Not sure if this is warranted a new token type or just a modifier.
---
CC #4583 , @GrayJack
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-05-25 14:08:21 +00:00
Aleksey Kladov
0ebb25b29b
Document parentModule
experimental LSP request
2020-05-25 15:59:49 +02:00
Aleksey Kladov
a30bdd9795
Cleanup lsp extensions on the client side
2020-05-25 14:56:26 +02:00
Aleksey Kladov
76e170c3d0
Less rust-analyzer specific onEnter
2020-05-25 14:28:47 +02:00
Laurențiu Nicola
c2358365ad
Add self keyword semantic token type
2020-05-25 12:08:58 +03:00
bors[bot]
fbb8b884a2
Merge #4593
...
4593: Document some rust-analyzer specific protocol extensions r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-24 15:05:20 +00:00
Aleksey Kladov
5276bfff81
Fix formatting
2020-05-24 17:04:17 +02:00
Aleksey Kladov
dec4ba8023
Document some rust-analyzer specific protocol extensions
2020-05-24 17:01:40 +02:00
Aleksey Kladov
9342273616
Document matchingBrace LSP request
2020-05-24 16:53:18 +02:00
Benjamin Coenen
0e814a3b5f
fix textedit range returned for completion when left token is a keyword #4545
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-24 16:47:35 +02:00
Matthew Jasper
1895888aec
Handle more cases in highlight_name_by_syntax
2020-05-24 15:12:17 +01:00
Matthew Jasper
e2d36cb692
Highlight true
and false
as literals
2020-05-24 15:12:17 +01:00
Aleksey Kladov
d1ff0145a9
Fix tests
2020-05-24 15:47:05 +02:00
Aleksey Kladov
130318b823
Merge pull request #4548 from bnjjj/fix_4464
...
add support of feature flag for runnables
2020-05-24 15:34:35 +02:00
Aleksey Kladov
f26b7928e0
Merge pull request #4495 from vsrs/fixture_meta
...
Test fixtures parsing improvements
2020-05-24 15:32:52 +02:00
Aleksey Kladov
ce7144a93d
Merge pull request #4474 from georgewfraser/color_attrs
...
Color attribute functions
2020-05-24 15:32:31 +02:00
Mikhail Rakhmanov
08aa8e1de7
Further refactoring under review comments
2020-05-24 14:53:12 +02:00
Benjamin Coenen
27ed376bc4
add support of feature flag for runnables #4464
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-24 13:34:34 +02:00
Julian Wollersberger
ff9d553fe3
Some FIXMEs were outdated:
...
* Done at line 243: "Add validation of `crate` keyword not appearing in the middle of the symbol path"
* Already happened: "Remove validation of unterminated literals (it is already implemented in `tokenize()`)"
* Happens in `unescape()`: "Add validation of character literal containing only a single char"
* Missing: "raw string literals and raw byte string literals"
2020-05-24 13:17:16 +02:00
Julian Wollersberger
cd4ffc1945
Update to rustc_lexer version 660.
...
Change `unescape_*()` to `unescape_literal()`.
2020-05-24 13:12:16 +02:00
Benjamin Coenen
48d7c61e26
add support of feature flag for runnables #4464
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-23 20:59:18 +02:00
bors[bot]
4cc2ff6e39
Merge #4555 #4575
...
4555: VSCode: added patchelf after download for NixOS support r=matklad a=cab404
This adds Nix support, and fixes #4542
4575: Use Chalk's built-in representations for fn items and pointers r=matklad a=flodiebold
The `TypeName::FnDef` was just added; the function pointer variant has existed for a while, I just forgot about it because it's special (because fn pointers can be higher-ranked over lifetimes).
We *could* also make `FnPtr` a separate `Ty` variant instead of a `TypeCtor` variant, which would make the conversion code a bit less special-casey, but it doesn't seem worth doing right now.
Co-authored-by: Vladimir Serov <me@cab404.ru>
Co-authored-by: Cabia Rangris <me@cab404.ru>
Co-authored-by: Florian Diebold <florian.diebold@freiheit.com>
2020-05-23 11:32:26 +00:00
bors[bot]
ca5e4596a0
Merge #4578
...
4578: Remove unnecessary clone that prevented clippy from moving on r=matklad a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
2020-05-23 11:24:28 +00:00
bors[bot]
88c292b1c2
Merge #4559
...
4559: Module name on hover shows another newline after it r=matklad a=Arthamys
This changes the display of hover information to add a newline between the module path of the item and the signature of the item, as suggested in #3813
**Before**

**After**

Co-authored-by: Galilée 'Bill' Enguehard <galilee.enguehard@gmail.com>
2020-05-23 11:09:24 +00:00
Mikhail Rakhmanov
e2974ba8f7
Remove unnecessary set_file and change variable positions for better readability
2020-05-23 11:57:12 +02:00
Mikhail Rakhmanov
3a244e02b5
Remove unwraps where possible
2020-05-23 11:53:02 +02:00
Galilée 'Bill' Enguehard
6197a960df
Fix resolve_proc_macro heavy test
2020-05-23 08:59:51 +02:00
Jess Balint
4967b811dd
tweak syntax
2020-05-22 19:09:37 -05:00
Mikhail Rakhmanov
6ee1c60c9c
Further review fixes
2020-05-23 01:41:08 +02:00
Mikhail Rakhmanov
4984520ef5
Use default instead of new in AssistDirector
2020-05-23 01:27:11 +02:00
Mikhail Rakhmanov
fce10200a0
Better naming and fix some review comments
2020-05-23 01:23:40 +02:00
kjeremy
7a46a99490
And a few drive-bys
2020-05-22 17:26:31 -04:00
kjeremy
d8af45472e
Remove unnecessary clone that prevented clippy from moving on
2020-05-22 17:13:14 -04:00
Mikhail Rakhmanov
ef1aaeb595
More formatting
2020-05-22 22:59:17 +02:00
Mikhail Rakhmanov
97ffe3c6e8
Refactor AssistDirector
2020-05-22 22:47:25 +02:00
Mikhail Rakhmanov
04a35784df
Formatting and remove unused imports
2020-05-22 22:43:52 +02:00
Mikhail Rakhmanov
5cd4eb6dd6
Add preliminary implementation of extract struct from enum variant
2020-05-22 22:28:30 +02:00
Florian Diebold
194dd9eb0d
Use Chalk's Ty::Function for function pointer types
...
Function pointers can be 'higher-ranked' over lifetimes, which is why they're
not an application type in Chalk, but since we don't model lifetimes it doesn't
matter for us yet.
2020-05-22 21:05:28 +02:00
Florian Diebold
bfbc210bc1
Use Chalk's built-in representation of function item types
2020-05-22 21:05:13 +02:00
Galilée 'Bill' Enguehard
d688215f25
Update tests to accept new hover formatting
2020-05-22 20:11:24 +02:00
Galilée 'Bill' Enguehard
910ac5a213
Fix formatting error when no modpath is present
2020-05-22 20:10:37 +02:00
Florian Diebold
ea265aad64
Provide missing Chalk debug methods
2020-05-22 19:52:06 +02:00
Florian Diebold
27fe68ad5c
Use TypeCtorId as AdtId directly, and rename the type alias StructId -> AdtId
2020-05-22 19:52:06 +02:00
Florian Diebold
1d0e27254d
Split up chalk module a bit
2020-05-22 19:52:06 +02:00