fixes both goto_definition and goto_type_definition.
before, when running goto between some non-trivia token and an
identifier, goto would be attempted for the non-trivia token.
but this does not make sense for e.g. L_PAREN or COLONCOLON only for
IDENTs. now only IDENTs will be searched for in goto actions.
2544: Map first and last tokens in original_range r=matklad a=edwin0cheng
This PR try to fix the first part of the `original_range` : Try to map the first token and last token of a `SyntaxNode` , If success, return the union range of mapped tokens.
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2527: Enable tsc builtin lint options for vscode/extension r=matklad a=saneyuki
* These options are not enabled by `--strict` option and these options make a code more solid.
* https://www.typescriptlang.org/docs/handbook/compiler-options.html
* For `noUnusedParameters` , we need to tweak tslint option to allow `_bar` style.
Co-authored-by: Tetsuharu OHZEKI <tetsuharu.ohzeki@gmail.com>
2525: Use ES2018 for vscode extension r=matklad a=saneyuki
Today's latest vscode v1.40 (Node.jsv12.4/V8 v7.6) supports ES2018
features natively.
We don't have to transform codes to ES6.
Co-authored-by: Tetsuharu OHZEKI <tetsuharu.ohzeki@gmail.com>
2526: Support LSP 3.15 r=matklad a=kjeremy
This merely upgrades our protocol support. It does not add any of the new features.
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
2523: Fixed#2250 r=matklad a=gab-umich
Bugfix Debriefing:
1. Tuple in type annotation expands correctly;
2. Expansion will prefer the following delimiter when possible. This involves modification of previous test cases to match current behaviour.
3. New regression tests added to verify the consistency between tuple expansion in type annotation and tuple expansion in rvalue. Both should behave exactly the same.
Co-authored-by: Gabriel Luo <luogm@umich.edu>
Tuple in type annotation expands correctly;
Expansion will prefer the following delimiter when possible.
New regression tests added to verify the consistency between tuple expansion in type annotation and tuple expansion in rvalue.
