Commit Graph

8545 Commits

Author SHA1 Message Date
Georg Brandl
e9a41e2374 new lint: lint when iterating over any Iterator::next() result (fixes #182) 2015-08-17 07:28:40 +02:00
llogiq
759b45a46d made is_negative(..) public (+doctest), fixed identity_op and precedence 2015-08-16 23:09:56 +02:00
llogiq
c4b07ead17 Merge pull request #179 from nweston/step-by-zero
New lint: Range::step_by(0) (fixes #95)
2015-08-16 20:12:52 +02:00
Nathan Weston
23a38c4170 New lint: Range::step_by(0) (fixes #95)
Uses type information so it can detect non-literal ranges as well
(Range or RangeFrom -- the other range types don't have step_by).
2015-08-16 12:58:54 -04:00
llogiq
e1438e7010 copied over cmp_owned fix from master 2015-08-16 16:13:44 +02:00
llogiq
4244f2479f dogfooding, part 2 2015-08-16 16:09:00 +02:00
llogiq
fe0de07b28 dogfooded 2015-08-16 16:05:51 +02:00
llogiq
03c7d7074d With working test now 2015-08-16 15:56:09 +02:00
Manish Goregaokar
164907ece2 restrict toplevel_ref_arg to only functions (fixes #170) 2015-08-16 17:24:03 +05:30
Manish Goregaokar
7a870ad46b Merge pull request #180 from birkenfeld/small_changes
Small changes
2015-08-16 13:12:56 +05:30
Georg Brandl
64954283c1 add some imports to guard against crate moves 2015-08-16 09:03:06 +02:00
Georg Brandl
47b605304d all: organize imports
* remove unused imports
* separate external and internal imports
* consistent import of rustc::lint
* move #[allow(unused_imports)] to local impl
2015-08-16 08:55:34 +02:00
Georg Brandl
997f345046 all: remove unneeded as_str() calls for ast::Name
Name has PartialEq and Display impls that do what we want.
2015-08-16 08:38:47 +02:00
Manish Goregaokar
f494f14aa6 Merge pull request #177 from birkenfeld/if_let_mini_fix
misc: fix check for unit body in "match -> if let" lint (fixes #172)
2015-08-15 14:12:34 +05:30
llogiq
8b9d27a625 Merge pull request #178 from birkenfeld/dogfood_shebang
util: make dogfood executable and give it a shebang
2015-08-15 10:25:01 +02:00
Georg Brandl
c64e373c9e util: make dogfood executable and give it a shebang 2015-08-15 09:59:23 +02:00
Georg Brandl
542bf8d50e misc: fix check for unit body in "match -> if let" lint (fixes #172) 2015-08-15 09:56:15 +02:00
Manish Goregaokar
767fa915ce Merge pull request #176 from birkenfeld/static_lt_fix
lifetimes: fix case with one unnamed and one static ref (fixes #171)
2015-08-15 13:08:20 +05:30
Georg Brandl
b299433de3 lifetimes: fix case with one unnamed and one static ref (fixes #171) 2015-08-15 09:36:07 +02:00
llogiq
b1920cb21c Merge pull request #174 from birkenfeld/small_fixes
methods: allow Option.unwrap by default
2015-08-15 08:27:33 +02:00
Georg Brandl
137a9f3def methods: allow Option.unwrap by default 2015-08-15 07:23:04 +02:00
llogiq
f23af0cfd5 changed const to consts to avoid keyword, added test, fixed a lot of bugs 2015-08-14 17:14:54 +02:00
Manish Goregaokar
84f9108808 Merge pull request #166 from Manishearth/contrib
add a few words on dogfood + update_lints
2015-08-14 18:42:33 +05:30
llogiq
3aa37e4997 Merge pull request #168 from Manishearth/eta-reduction
fixed false positives (at the cost of some false negatives)
2015-08-14 15:02:47 +02:00
llogiq
b6ac44d5b2 Removed #![allow(redundant_closure)] on eq_op 2015-08-14 15:00:04 +02:00
llogiq
99d769c858 Merge branch 'eta-reduction' of https://github.com/Manishearth/rust-clippy into eta-reduction 2015-08-14 14:37:30 +02:00
llogiq
5d99ebec72 fixed false positives (at the cost of some false negatives) 2015-08-14 14:37:12 +02:00
llogiq
811d89a01b removed String::from_str(..) to fix build with 1.4.0-nightly/2015-08-14 2015-08-14 14:33:59 +02:00
llogiq
1118f97691 Merge pull request #169 from Manishearth/rustup
removed String::from_str(..) to fix build with 1.4.0-nightly/2015-08-14
2015-08-14 14:29:22 +02:00
llogiq
ffda91a8c7 removed String::from_str(..) to fix build with 1.4.0-nightly/2015-08-14 2015-08-14 14:26:57 +02:00
llogiq
49f6eb88d3 fixed false positives (at the cost of some false negatives) 2015-08-14 14:21:05 +02:00
llogiq
6f8d47b411 add a few words on dogfood + update_lints 2015-08-14 11:30:39 +02:00
Manish Goregaokar
1afc5b6235 Merge pull request #141 from Manishearth/multilinetrim
Add trim_multiline utility (fixes #139)
2015-08-13 23:21:41 +05:30
Manish Goregaokar
763ae1f3ae Fix dogfood 2015-08-13 23:20:00 +05:30
Manish Goregaokar
5ce8e7ba85 trim_multiline: ignore empty lines 2015-08-13 23:18:34 +05:30
llogiq
dece5a6cb5 added empty line test 2015-08-13 23:18:34 +05:30
llogiq
f4b5d21533 added a few unit tests to trim_multiline 2015-08-13 23:18:34 +05:30
Manish Goregaokar
fbbb44d93b Handle tabs 2015-08-13 23:18:34 +05:30
Manish Goregaokar
83487c060f Add trim_multiline utility (fixes #139) 2015-08-13 23:18:33 +05:30
Manish Goregaokar
847070e19d Merge pull request #151 from birkenfeld/needless_bool_msg
spelling fix, rework needless_bool with snippet (fixes #150)
2015-08-13 23:17:18 +05:30
Manish Goregaokar
27cb45e55d Merge pull request #160 from Manishearth/dogfood
Start dogfooding clippy
2015-08-13 21:54:05 +05:30
Manish Goregaokar
3cf5c36296 Address review comments, move to travis 2015-08-13 21:45:50 +05:30
Manish Goregaokar
485960a00c Add dogfood script 2015-08-13 21:45:42 +05:30
Georg Brandl
49e51fe65a lifetimes: try to fix w.r.t. lifetimes from parent scopes (fixes #162) 2015-08-13 21:45:42 +05:30
Manish Goregaokar
09db7f3fee fix 2015-08-13 21:45:42 +05:30
Manish Goregaokar
c2bdc85715 oh the irony 2015-08-13 21:45:41 +05:30
Manish Goregaokar
5eab397e7c Some fixes from dogfooding clippy 2015-08-13 21:45:41 +05:30
Manish Goregaokar
0d8447e0f8 Merge pull request #158 from birkenfeld/iter_methods
new lint: looping over x.iter() or x.iter_mut() (fixes #157)
2015-08-13 20:21:35 +05:30
Georg Brandl
9578403638 new lint: looping over x.iter() or x.iter_mut() (fixes #157) 2015-08-13 16:31:16 +02:00
Manish Goregaokar
b456e5fbd2 Don't run cargo build (fixes #156) 2015-08-13 19:30:33 +05:30