bors
e91ba8af85
Auto merge of #3848 - felix91gr:null_transmute, r=flip1995
...
Transmuting known null ptr to ref
Working on implementing #628
2019-04-08 07:20:25 +00:00
bors
42e1cf3763
Auto merge of #3901 - rail-rain:issue_1670, r=flip1995
...
Fix `explicit_counter_loop` suggestion
#1670
This code seems to me to work, but I have two question.
* Because range expression desugared in hir, `Sugg::hir` doesn't add parenthesis to range expression. Which function is better to check range do you think, `check_for_loop_explicit_counter` or `hir_from_snippet`?
* Do you think we need to distinguish between range expression and struct expression that creates `std::ops::Range*`?
2019-04-08 06:28:15 +00:00
bors
e226f17d52
Auto merge of #3885 - mikerite:clippy_dev_toolchain, r=phansch
...
Add rust-toolchain for clippy_dev
AFAIK, `clippy_dev` is supposed to be built on stable. (This is why it's not a `[bin]` inside the root `Cargo.toml`.) This adds a `rust-toolchain` file for easy switching.
2019-04-08 05:58:34 +00:00
Philipp Hansch
547c5c0667
cargo fmt
2019-04-08 07:56:54 +02:00
bors
0849f73595
Auto merge of #3928 - rust-lang:tmpadd, r=Manishearth
...
Re-add tmp feature to compiletest
Got accidentally removed in the rustup
2019-04-07 21:36:51 +00:00
Manish Goregaokar
c7b78234da
Re-add tmp feature to compiletest
...
Got accidentally removed in the rustup
2019-04-07 14:36:03 -07:00
bors
cffb416d89
Auto merge of #3927 - rust-lang:rustup, r=Manishearth
...
Revert compiletest hacks, use latest compiletest
The libtest changes have been reverted, see https://github.com/rust-lang/rust/pull/59766 , https://github.com/laumann/compiletest-rs/pull/174
2019-04-07 20:41:39 +00:00
Manish Goregaokar
4c7c39acbc
Remove libtest from deps
2019-04-07 12:39:43 -07:00
Manish Goregaokar
ee69237274
Re-allow clippy::identity_conversion in compiletest
2019-04-07 12:07:20 -07:00
Manish Goregaokar
a8ce9d655a
Use latest compiletest-rs
2019-04-07 12:02:22 -07:00
Manish Goregaokar
ba8712c5fd
Revert tests/compile-test.rs to 61aa5c957c
2019-04-07 12:01:39 -07:00
Philipp Hansch
60c1bb0546
Fix ICE in suspicious_else_formatting
2019-04-07 11:11:06 +02:00
Matthias Krüger
0e455b0466
Merge pull request #3918 from matthiaskrgr/typos
...
NFC: fix typos
2019-04-07 10:29:51 +02:00
Oliver Scherer
b996fd52ff
Merge pull request #3922 from rust-lang/run-pass
...
Add missing `// run-pass` annotations to ICE tests
2019-04-06 18:33:52 +02:00
Andy Russell
0d50d44ea6
use a multispan for MANY_SINGLE_CHAR_NAMES
2019-04-05 10:07:39 -04:00
Philipp Hansch
b545f1c3bb
Add missing // run-pass
annotations to ICE tests
...
compiletest UI tests do not fail when encountering panics and ICEs
unless the `// run-pass` flag is used.
(This was forgotten in https://github.com/rust-lang/rust-clippy/pull/3743 )
2019-04-05 07:22:36 +02:00
Michael Wright
63cd54ba11
Remove clippy_dev as dev-dependency
2019-04-05 06:00:27 +02:00
Michael Wright
a9d002c8a5
Merge branch 'master' into clippy_dev_toolchain
2019-04-05 05:59:46 +02:00
Matthias Krüger
920e47ceb5
NFC: fix typos
2019-04-04 11:15:30 +02:00
Philipp Krones
17e04ac751
Merge pull request #3916 from matthiaskrgr/rustup
...
rustup https://github.com/rust-lang/rust/pull/59657
2019-04-03 11:43:26 +02:00
Matthias Krüger
c81e43b92c
rustup https://github.com/rust-lang/rust/pull/59657
...
commit: 4122d2221e
2019-04-03 10:48:54 +02:00
Félix Fischer
069957a8ad
Add TransmutingNull Lint
...
* Late Lint pass, catches:
* One liner: 0 -> null -> transmute
* One liner: std:null() -> transmute
* Const (which resolves to null) -> transmute
* UI Test case for Lint
* Updated test for issue 3849, because now the lint that code generated is in Clippy.
* Expanded `const.rs` miri-based Constant Folding code, to cover
raw pointers
2019-04-02 11:39:43 -03:00
Philipp Krones
25a11568fc
Merge pull request #3905 from rust-lang/compiletest
...
Hacky rustup
2019-04-01 22:15:42 +02:00
flip1995
41927796bf
Run rustfmt
2019-04-01 20:37:05 +02:00
flip1995
55f67fc7f4
Set level of identity_conversion FP to warn
2019-04-01 20:37:05 +02:00
Philipp Hansch
b253c564d5
Rustup to https://github.com/rust-lang/rust/pull/58805
2019-04-01 20:37:05 +02:00
Matthias Krüger
414c34c300
rustup 41316f0449
2019-04-01 20:37:05 +02:00
Félix Fischer
491f72442e
Updated source to match with recent rustc master
toolchain changes
2019-04-01 20:37:05 +02:00
flip1995
bbb7963735
Fix dogfood error of question_mark lint fix
2019-04-01 20:37:05 +02:00
flip1995
6f01ecfefd
Fix question_mark lint+test
2019-04-01 20:37:05 +02:00
rail
2b82c71b55
use span_lint_and_sugg
in explicit_counter_loop
2019-03-28 08:51:57 +09:00
Félix Fischer
3cff06a0eb
Fix some test failures
2019-03-26 13:57:03 -03:00
Oliver Scherer
d020565ed2
Hacky rustup
2019-03-26 10:55:03 +01:00
Manish Goregaokar
61aa5c957c
Merge pull request #3902 from matthiaskrgr/rustup
...
rustup https://github.com/rust-lang/rust/pull/59096/
2019-03-23 16:53:01 -07:00
Matthias Krüger
b5d82524b4
run cargo fmt
2019-03-23 23:39:58 +01:00
Matthias Krüger
e17dd4efa9
rustup https://github.com/rust-lang/rust/pull/59096/
2019-03-23 23:37:38 +01:00
rail
9698e41994
Change explicit_counter_loop's message to add parentheses if necessary
2019-03-23 15:36:48 +09:00
rail
bd6c2df066
Change explicit_counter_loop's message to reflect original variable name
2019-03-23 15:30:17 +09:00
bors
c7d4445086
Auto merge of #3888 - phansch:extract_mistyped_literal_suffix_tests_and_rustfix, r=flip1995
...
Add rustfix tests for mistyped_literal_suffix lint
This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.
cc #3603 , #2038
Based on #3887
2019-03-19 06:26:01 +00:00
bors
dc825a36f2
Auto merge of #3894 - markcatley:adding_lint_documentation_fixes, r=phansch
...
Add implementation for the EarlyLintPass trait into the Adding Lints …
…documentation.
To follow along with the adding lint documentation you need to implement this trait in order to register the lint pass.
2019-03-19 06:05:41 +00:00
Philipp Hansch
0452704978
cargo fmt
2019-03-19 06:57:41 +01:00
Philipp Hansch
f1d0858a8f
Add rustfix tests for mistyped_literal_suffix lint
...
This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.
cc #3603 , #2038
Based on #3887
2019-03-19 06:55:42 +01:00
Philipp Hansch
4e51c980bc
Move some unreadable_literal
ui tests to correct file
...
The moved tests were part of `tests/ui/literals.rs` before. Now they are
placed in `tests/ui/unreadable_literal.rs`, which now also runs
`rustfix` on these 4 extra let statements.
2019-03-19 06:55:42 +01:00
Mark Catley
5c8c487851
Add implementation for the EarlyLintPass trait into the Adding Lints documentation.
...
To follow along with the adding lint documentation you need to implement this trait in order to register the lint pass.
2019-03-19 13:39:19 +13:00
bors
92612c9de1
Auto merge of #3893 - mati865:rustup, r=oli-obk
...
Rustup
Supersedes https://github.com/rust-lang/rust-clippy/pull/3889
Addresses some review comments from previous PR and rustups to https://github.com/rust-lang/rust/pull/58899
2019-03-18 16:21:56 +00:00
Mateusz Mikuła
6cb0605600
Cargo fmt
2019-03-18 13:39:11 +01:00
Mateusz Mikuła
664391c5f8
Drop range_contains feature
2019-03-18 12:54:10 +01:00
Mateusz Mikuła
8feb2c6b2f
Fix rustfmt::skip detection
2019-03-18 12:54:10 +01:00
Mateusz Mikuła
fb7699d9e5
Rework clippy detection in attribute lint
2019-03-18 12:54:10 +01:00
Mateusz Mikuła
0ea5e38a9e
name -> check_name
2019-03-18 12:54:10 +01:00