Dylan DPC
a65ca91b84
Rollup merge of #103919 - nnethercote:unescaping-cleanups, r=matklad
...
Unescaping cleanups
Some code improvements, and some error message improvements.
Best reviewed one commit at a time.
r? ````@matklad````
2022-11-09 19:21:22 +05:30
bors
392784ad17
Auto merge of #13584 - jonas-schievink:fix-signature-panic, r=jonas-schievink
...
fix: fix panic when computing signature of generic `FnOnce` callable
Fixes https://github.com/rust-lang/rust-analyzer/issues/13579
2022-11-08 17:27:13 +00:00
Jonas Schievink
9be0615bde
Don't canonicalize self type when querying FnOnce signature
2022-11-08 18:05:07 +01:00
bors
977a029c1e
Auto merge of #13582 - lnicola:nest-cargo-toml, r=lnicola
...
feat: Nest Cargo.lock under Cargo.toml in Code
Closes #13580
2022-11-08 08:44:43 +00:00
Laurențiu Nicola
4403dde711
Nest Cargo.lock under Cargo.toml in Code
2022-11-08 09:57:05 +02:00
bors
236c1167cc
Auto merge of #13581 - Veykril:unit-struct-compl, r=Veykril
...
fix: Fix item completions not working properly after unit structs and outline modules
Fixes https://github.com/rust-lang/rust-analyzer/issues/13578
2022-11-08 07:38:13 +00:00
Lukas Wirth
90e2db8126
fix: Fix item completions not working properly after unit structs and outline modules
2022-11-08 08:37:45 +01:00
bors
b8b1951ee8
Auto merge of #13573 - Veykril:invalid-file-range, r=Veykril
...
internal: error instead of panic on invalid file range
Fixes the panic in https://github.com/rust-lang/rust-analyzer/issues/13170
2022-11-07 16:45:26 +00:00
Lukas Wirth
1cb6ab89ee
internal: error instead of panic on invalid file range
2022-11-07 17:45:12 +01:00
bors
0aa0da9dda
Auto merge of #13572 - Veykril:cancellable, r=Veykril
...
internal: Use Cancellable in favor of Result for clarity
2022-11-07 16:22:33 +00:00
Lukas Wirth
fa70b0a86e
internal: Use Cancellable in favor of Result for clarity
2022-11-07 17:21:37 +01:00
bors
a27e4dad37
Auto merge of #13571 - Veykril:unique-references, r=Veykril
...
minor: Deduplicate reference search results
Fixes https://github.com/rust-lang/rust-analyzer/issues/13407
2022-11-07 15:49:54 +00:00
Lukas Wirth
6a06f6f724
Deduplicate reference search results
2022-11-07 16:48:50 +01:00
bors
d1c9775171
Auto merge of #13568 - noritada:fix/len-of-byte-string-with-escaped-newlines, r=Veykril
...
Fix the length displayed for byte string literals with escaped newlines
This is a fix for the problem I reported earlier: "the length of byte strings containing escaped newlines is displayed two bytes longer when the first escaped character is a newline".
I would appreciate it if you could review the fix.
Many thanks.
Closes #13567
2022-11-07 15:04:40 +00:00
bors
8a633fe986
Auto merge of #13570 - Veykril:dedup-crates-for, r=Veykril
...
minor: Remove code duplication
2022-11-07 14:52:05 +00:00
Lukas Wirth
b169e1e5de
Remove code duplication
2022-11-07 15:49:26 +01:00
Noritada Kobayashi
2340d7059e
Add test code for unescaping byte strings
2022-11-07 23:39:02 +09:00
bors
b0e56ef5e8
Auto merge of #13545 - Veykril:adjustment-hints, r=Veykril
...
Generalize reborrow hints as adjustment hints
Like reborrow hints, these are still mainly useful for teaching/learning
2022-11-07 14:38:59 +00:00
bors
3a839ea22e
Auto merge of #13569 - Veykril:rust-version, r=Veykril
...
Bump Cargo rust-version fields to latest stable
We already depend on `let ... else` now anyways
Closes https://github.com/rust-lang/rust-analyzer/issues/13562
2022-11-07 14:21:31 +00:00
Noritada Kobayashi
bdf8547013
Clarify the intent
...
Thanks to Lukas Wirth for a suggestion.
2022-11-07 22:51:29 +09:00
Lukas Wirth
ffd7bf8bf9
Bump Cargo rust-version fields to latest stable
2022-11-07 12:59:51 +01:00
Lukas Wirth
ee2dd934ca
Don't trigger adjustment hints in all inlay hint tests
2022-11-07 12:49:52 +01:00
bors
c0310c1e03
Auto merge of #13565 - Veykril:sysroot, r=Veykril
...
Update sysroot crates
2022-11-07 11:40:44 +00:00
Noritada Kobayashi
180b4cedec
Fix the length displayed for byte string literals with escaped newlines
...
The length of byte strings containing escaped newlines is displayed two
bytes longer when the first escaped character is a newline.
This is due to a small bug in handling the first escaped newline in
string literals.
Closes #13567
2022-11-07 20:07:16 +09:00
bors
d3d3806565
Auto merge of #12991 - TiddoLangerak:extract-method-from-trait-into-impl-root, r=Veykril
...
Feat: extracted method from trait impl is placed in existing impl
**Before**
https://user-images.githubusercontent.com/1759192/183872883-3b0eafd2-d1dc-440e-9e66-38e3372f8b64.mp4
**After**
https://user-images.githubusercontent.com/1759192/183875769-87f34c7d-52f0-4dfc-9766-f591ee738ebb.mp4
Previously, when triggering a method extraction from within an impl trait block, then this would always create a new impl block for
the struct, even if there already is one. Now, if there is already an existing trait-less impl block, then it'll put the extracted method in there.
**Caveats**:
- It currently requires the target impl block to be non-empty. This limitation is because the current architecture takes a `node_to_insert_after` as reference for where to insert the extracted function. An empty impl block doesn't have such a reference node, since it's empty. It seems that supporting this requires a much larger and more complex change.
- This is my first contribution in rust, so apologies for any beginner mistakes.
2022-11-07 11:07:12 +00:00
Lukas Wirth
8ad4a1d118
Update sysroot crates
2022-11-07 12:01:12 +01:00
Lukas Wirth
f24fbc2027
rustfmt
2022-11-07 11:58:57 +01:00
bors
364820a296
Auto merge of #13566 - lnicola:therefor, r=lnicola
...
minor: Fix typos
2022-11-07 10:54:38 +00:00
Laurențiu Nicola
cff7ab1308
Fix typos
2022-11-07 12:54:12 +02:00
bors
f54c313914
Auto merge of #13547 - Veykril:line-index, r=Veykril
...
internal: Optimize `apply_document_changes` a bit
cc https://github.com/rust-lang/rust-analyzer/issues/13538
2022-11-07 10:33:13 +00:00
bors
7742077419
Auto merge of #13552 - Veykril:flycheck-process-group, r=Veykril
...
internal: Use a process group for flycheck
Should fix https://github.com/rust-lang/rust-analyzer/issues/13348
2022-11-07 10:19:32 +00:00
bors
d03c1c87d4
Auto merge of #13556 - pd4d10:patch-1, r=lnicola
...
docs: fix adoc links
Correct #13536 with adoc link syntax
2022-11-05 17:57:31 +00:00
Rongjian Zhang
935eb3f634
docs: fix adoc links
2022-11-06 01:33:57 +08:00
Lukas Wirth
1dcc25a70a
internal: Use a process group for flycheck
2022-11-05 16:28:04 +01:00
bors
e47460b208
Auto merge of #13550 - Veykril:issue-template, r=lnicola
...
minor: Update github issue templates
2022-11-05 13:20:26 +00:00
bors
c06bbfb380
Auto merge of #13536 - pd4d10:patch-1, r=Veykril
...
docs: add crates section to the manual
closes #13533
Added a section to the user manual, to make it easier for users to find the correct crate.
2022-11-05 12:59:05 +00:00
bors
25b1d6f3f9
Auto merge of #13435 - DropDemBits:assists-format-args-capture-pt3, r=Veykril
...
Migrate assists to format args captures, part 3
Continuation of https://github.com/rust-lang/rust-analyzer/pull/13379
Migrates:
- `inline_call`
- `inline_local_variable`
- `introduce_named_lifetime`
- `merge_match_arms`
- `move_from_mod_rs`
- `move_guard`
- `move_module_to_file`
- `move_to_mod_rs`
- `number_representation`
- `qualify_method_call`
- `qualify_path`
- `raw_string`
- `remove_dbg`
- `replace_derive_with_manual_impl`
- `replace_or_with_or_else`
- `replace_turbofish_with_explicit_type`
- `unwrap_tuple`
- `wrap_return_type_in_result`
2022-11-05 12:41:23 +00:00
Lukas Wirth
ef4616822b
minor: Update github issue templates
2022-11-05 13:29:44 +01:00
bors
afe8f6b922
Auto merge of #13379 - DropDemBits:ide-assists-format-args-capture, r=Veykril
...
internal: Migrate `ide_assists::utils` and `ide_assists::handlers` to use format arg captures (part 1)
This not only serves as making future migration to mutable syntax trees easier, it also finds out what needs to be migrated in the first place.
~~Aside from the first commit, subsequent commits are structured to only deal with one file/handler at a time.~~
This is the first of 3 PRs, migrating:
Utils:
- `gen_trait_fn_body`
- `render_snippet`
- `ReferenceConversion`
- `convert_type`
- `getter`
Handlers:
- `add_explicit_type`
- `add_return_type`
- `add_turbo_fish`
- `apply_demorgan`
- `auto_import`
- `convert_comment_block`
- `convert_integer_literal`
- `convert_into_to_from`
- `convert_iter_for_each_to_for`
- `convert_let_else_to_match`
- `convert_tuple_struct_to_named_struct`
- `convert_two_arm_bool_match_to_matches_macro`
- `destructure_tuple_binding`
- `extract_function`
- `extract_module`
- `extract_struct_from_enum_variant`
- `extract_type_alias`
- `extract_variable`
- `fix_visibility`
2022-11-05 12:29:06 +00:00
bors
2c37e7d4af
Auto merge of #13549 - Veykril:search-fix, r=Veykril
...
fix: Fix reference searching only accounting substrings instead of whole identifiers
Fixes https://github.com/rust-lang/rust-analyzer/issues/13498
2022-11-05 12:16:18 +00:00
Lukas Wirth
17619de711
fix: Fix reference searching only accounting substrings instead of whole identifiers
2022-11-05 13:00:02 +01:00
Ryo Yoshida
41b0c54c07
Fix tt::Punct's spacing calculation
2022-11-05 19:42:09 +09:00
Ryo Yoshida
b87a23b91b
Rename convertor -> converter
2022-11-05 19:41:08 +09:00
bors
df3877037e
Auto merge of #13454 - justinmmott:master, r=flodiebold
...
Fixed local shadowing the caller's argument issue
fix https://github.com/rust-lang/rust-analyzer/issues/12536
2022-11-05 10:05:52 +00:00
Lukas Wirth
28afe57068
Add tests for LineEndings::normalize
2022-11-05 11:00:17 +01:00
Lukas Wirth
e468a1af35
internal: Optimize apply_document_changes a bit
2022-11-05 10:59:46 +01:00
Nicholas Nethercote
7d2a1ee4fc
Remove unescape_byte_literal.
...
It's easy to just use `unescape_literal` + `byte_from_char`.
2022-11-05 13:56:36 +11:00
bors
66900a7e05
Auto merge of #13541 - Veykril:dbg-cmd, r=Veykril
...
Clarify what commands are debug commands in VSCode
Renders as
2022-11-04 23:30:48 +00:00
Lukas Wirth
26b5621018
Mark the Memory Usage command as debug command
2022-11-05 00:30:21 +01:00
Lukas Wirth
d841ad116a
Fix up adjustment hints configurations
2022-11-04 22:59:07 +01:00
