ShuiRuTian
727a7827fd
fix windows test.
2021-01-13 22:56:31 +08:00
Lukas Wirth
3d6480bc31
Render Fn* trait objects and impl types as rust does
2021-01-13 13:29:47 +01:00
bors[bot]
f84f5cb0ea
Merge #7262
...
7262: Don't show internal server error on rename r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-01-13 12:09:26 +00:00
Aleksey Kladov
f0e802f490
Don't show internal server error on rename
...
Doesn't quite work due to https://github.com/microsoft/vscode-languageserver-node/issues/730
Note that this intentionally removes `impl std::Error for RenameError`
-- we nether want to blindly bubble the rename error.
2021-01-13 15:07:30 +03:00
bors[bot]
e41b363027
Merge #7251
...
7251: Group references by FileId r=matklad a=Veykril
Fixes #4901
This doesn't address https://github.com/rust-analyzer/rust-analyzer/pull/7032/files#diff-a7e1e771e911237bb893e1b0f5e0f2c2a856b54ca06f95ef0818a922f1a8b5ebR266
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-01-13 10:38:30 +00:00
ShuiRuTian
76e6589016
unwrap.
2021-01-13 12:10:45 +08:00
Arnaud
4b71c8332d
Document vfs private items
2021-01-12 18:01:47 +01:00
Arnaud
311ec70d03
Document vfs public items
2021-01-12 18:01:36 +01:00
ShuiRuTian
6a15876fc4
skip slow tests.
2021-01-13 00:58:28 +08:00
ShuiRuTian
5f8fa66b77
use path rather than hard code.
2021-01-13 00:53:17 +08:00
ShuiRuTian
e1c9c9b604
fix and add tests.
2021-01-13 00:30:49 +08:00
Lukas Wirth
e9e3ab549d
Move FamousDefs fixture out into its own file
2021-01-12 17:26:08 +01:00
Lukas Wirth
aff9102afb
Rename FileReferences -> UsageSearchResult
2021-01-12 15:56:24 +01:00
Lukas Wirth
2c1777a2e2
Ensure uniqueness of file ids in reference search via hashmap
2021-01-12 15:51:02 +01:00
Lukas Wirth
fbdb32adfc
Group references by FileId
2021-01-12 01:03:04 +01:00
bors[bot]
52fa926f00
Merge #7250
...
7250: Improve analysis stats legibility r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-01-11 19:18:34 +00:00
Aleksey Kladov
9fd4e5c66c
Improve analysis stats legibility
2021-01-11 22:17:30 +03:00
bors[bot]
5a0b8a2714
Merge #7249
...
7249: Add build benchmark xtask command r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-01-11 18:40:23 +00:00
Aleksey Kladov
c62f1c762f
Add build benchmark xtask command
2021-01-11 21:39:16 +03:00
ShuiRuTian
cf3042f881
format
2021-01-12 00:21:43 +08:00
ShuiRuTian
d877390882
fix as suggestion.
2021-01-12 00:21:03 +08:00
Song Gao
1b004dcf88
Update crates/rust-analyzer/src/handlers.rs
...
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
2021-01-12 00:16:12 +08:00
Song Gao
497e9da433
Update crates/rust-analyzer/src/handlers.rs
...
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
2021-01-12 00:15:56 +08:00
bors[bot]
3aa153b46c
Merge #7247
...
7247: cargo update r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
2021-01-11 14:08:00 +00:00
kjeremy
d229f0a1b2
cargo update
2021-01-11 09:06:30 -05:00
bors[bot]
8ad325a806
Merge #7051 #7219 #7245 #7246
...
7051: Check dbg! macro in tidy_test r=matklad a=edwin0cheng
Same as `check_todo` but for dbg! macro
r? @matklad
7219: Refactor rename name checking r=matklad a=Veykril
Improves the user facing error messages a bit and prevents renaming to `_` when the name is referenced as this would change source to not compile anymore since `_` is only a pattern, not a proper identifier.
7245: Encourage gifs r=matklad a=matklad
bors r+
🤖
7246: Unfreeze cargo_metadata r=matklad a=kjeremy
It now pulls in a newer version of semver-parser.
This does add a dependency on `cargo-platform` in the interest of correctness.
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: kjeremy <kjeremy@gmail.com>
2021-01-11 13:37:28 +00:00
Aleksey Kladov
2d0464a6f3
Encourage gifs
2021-01-11 16:29:29 +03:00
kjeremy
1da68e87af
Unfreeze cargo_metadata
...
It now pulls in a newer version of semver-parser.
2021-01-11 08:27:16 -05:00
bors[bot]
b84c49b9af
Merge #7244
...
7244: Goto for inner doc links works for module inner doc comments r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-01-11 13:25:51 +00:00
Aleksey Kladov
8adf5cc0e3
Goto for inner doc links works for module inner doc comments
2021-01-11 16:24:50 +03:00
bors[bot]
8c33ffecc1
Merge #7235
...
7235: Postfix completions like ifl now works with references r=Veykril a=Maan2003
Closes #7230
Co-authored-by: Manmeet <manmeetmann2003@gmail.com>
Co-authored-by: Manmeet Maan <manmeetmann2003@gmail.com>
2021-01-11 11:27:54 +00:00
ShuiRuTian
f7cb9e9fbe
move logic from client to server.
2021-01-11 14:45:35 +08:00
Manmeet Maan
f05c14594a
Fix formatting
2021-01-11 11:47:38 +05:30
Manmeet Maan
430dc5cd24
Apply Suggestions from code review
2021-01-11 11:32:55 +05:30
Lukas Wirth
f7af0b4b96
Add some more marks to rename tests
2021-01-11 00:28:21 +01:00
Lukas Wirth
2347944aae
Use local error macros in references/rename
2021-01-10 21:59:44 +01:00
bors[bot]
60c501fa19
Merge #7241
...
7241: Honor client's dynamic registration caps r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-01-10 19:41:06 +00:00
Aleksey Kladov
bb453edebe
Honor client's dynamic registration caps
...
cc https://github.com/rust-analyzer/rust-analyzer/pull/5516#issuecomment-757520828
2021-01-10 22:38:35 +03:00
bors[bot]
607b9ea160
Merge #7218
...
7218: Fix typos r=Veykril a=regexident
Apart from the very last commit on this PR (which fixes a public type's name) all changes are non-breaking.
Co-authored-by: Vincent Esche <regexident@gmail.com>
2021-01-10 18:16:29 +00:00
bors[bot]
3e32e39da7
Merge #7240
...
7240: Make default memory stats less verbose r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-01-10 17:59:06 +00:00
Aleksey Kladov
a0957723fe
Make default memory stats less verbose
2021-01-10 20:58:02 +03:00
Vincent Esche
d462119744
Updated tests via cargo xtask codegen
2021-01-10 18:36:27 +01:00
bors[bot]
b3ae7974af
Merge #7239
...
7239: Replace SyntaxKind usage with T! macro where applicable r=lnicola a=Veykril
https://github.com/rust-analyzer/rust-analyzer/blob/master/docs/dev/style.md#token-names
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-01-10 16:31:32 +00:00
Lukas Wirth
e618d12903
Replace SyntaxKind usage with T! macro where applicable
2021-01-10 17:14:01 +01:00
bors[bot]
13b205ec0b
Merge #7238
...
7238: Fix typo, parentheses is plural r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-01-10 16:04:06 +00:00
Laurențiu Nicola
10e7fd25fe
Fix typo, parentheses is plural
2021-01-10 17:56:53 +02:00
bors[bot]
e1430d822e
Merge #7237
...
7237: Use T! for bool keywords r=matklad a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-01-10 15:53:39 +00:00
Laurențiu Nicola
a7db8abab7
Use T! for bool keywords
2021-01-10 17:47:12 +02:00
bors[bot]
035fed5f9f
Merge #7236
...
7236: Fix progress token is already registered crash r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-01-10 15:09:21 +00:00
Aleksey Kladov
2ed258ba42
Fix progress token is already registered crash
...
After we started reporting progress when running cargo check during
loading, it is possible to crash the client with two identical progress
tokens.
This points to a deeper issue: we might be running several cargo checks
concurrently, which doesn't make sense.
This commit linearizes all workspace fetches, making sure no updates are
lost.
As an additional touch, it also normalizes progress & result reporting,
to make sure they stand in sync.
2021-01-10 18:02:02 +03:00