mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
171,229 Commits 2 Branches 0 Tags 1.4 GiB
dbdbdb6874
Commit Graph

745 Commits

Author SHA1 Message Date
David Wood
dbdbdb6874 lint: port no-mangle diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
a13b70ea83 lint: port unused doc comment diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
e151d66343 lint: port deprecated attr diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
18a48c1d6c lint: port anonymous parameter diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
284ec37810 lint: port missing debug impl diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
28655bc955 lint: port missing copy impl diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
82bd2c23e5 lint: port missing documentation diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
7dffd14b96 lint: port unsafe diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
4c63a2145c lint: port non-shorthand pattern diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
d433c9a446 lint: port box pointers diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
588977b350 lint: port while true diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
4f7b10f484 lint: port unused allocation diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
e24833869f lint: port unused import braces diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
fc4f8d9bc2 lint: port unused delimiter diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
2829f519a0 lint: port path statement diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:22 +01:00
David Wood
1999a4c421 lint: port unused diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
0602729c71 lint: port atomic ordering diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
14c3016583 lint: port variant size difference diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
e5f2e0e16c lint: port improper ctypes diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
7a9bef4d83 lint: port overflowing literals diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
7ef610c003 lint: port drop trait/glue diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
8e836566f0 lint: port redundant semicolons diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
37588d6d4e lint: port pass-by-value diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
855f23773b lint: port no-op method call diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
096a69dd19 lint: port non-standard style diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
7ee4aa7003 lint: port non-fmt-panic diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
48e4bf115f lint: port non-ascii-idents diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
c29e05e745 lint: port CString ptr diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
4f35c7993b lint: port translation migration diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
674ac60d5a lint: port non-existant doc keyword diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
1c3a3e0711 lint: port impl LintPass by hand diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
0996a7ab5c lint: port ty diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
8139542598 lint: port query instability diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
e88916cc92 lint: port default hash types diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
fd57269e8c lint: port hidden unicode codepoints diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
a0624eb6c9 lint: port expectation diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
2a69640eb2 lint: port enum intrinsics diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:21 +01:00
David Wood
0f4c4c5e18 lint: port array-into-iter diagnostics 
Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:59:19 +01:00
David Wood
7d2eba6311 middle: translation in LintDiagnosticBuilder 
Accept `DiagnosticMessage` in `LintDiagnosticBuilder::build` so that
lints can be built with translatable diagnostic messages.

Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-30 08:58:41 +01:00
Dylan DPC
400f435c2d
Rollup merge of #98420 - davidtwco:translation-lint-fixes-and-more-migration, r=compiler-errors 
translation: lint fix + more migration

- Unfortunately, the diagnostic lints are very broken and trigger much more often than they should. This PR corrects the conditional which checks if the function call being made is to a diagnostic function so that it returns in every intended case.
- The `rustc_lint_diagnostics` attribute is used by the diagnostic translation/struct migration lints to identify calls where non-translatable diagnostics or diagnostics outwith impls are being created. Any function used in creating a diagnostic should be annotated with this attribute so this PR adds the attribute to many more functions.
- Port the diagnostics from the `rustc_privacy` crate and enable the lints for that crate.

r? ``@compiler-errors``
 2022-06-28 15:30:04 +05:30
David Wood
871c879bff lint: fix condition in diagnostic lints 
Unfortunately, the diagnostic lints are very broken and trigger much
more often than they should. Correct the conditional which checks if the
function call being made is to a diagnostic function so that it returns
in every intended case.

Signed-off-by: David Wood <david.wood@huawei.com>
 2022-06-27 08:32:06 +01:00
Matthias Krüger
3694e40ffa
Rollup merge of #97389 - m-ou-se:memory-ordering-diagnostics, r=estebank 
Improve memory ordering diagnostics

Before:

![image](https://user-images.githubusercontent.com/783247/170234545-891cac30-eaa2-4186-847b-35cd51e00f2b.png)

After:

![image](https://user-images.githubusercontent.com/783247/170239684-645f186f-5a02-4eb9-8651-2e5fe9591352.png)

---

Before this change, the compiler suggests the failure ordering is too strong and suggests choosing a weaker ordering. After this change, it instead suggests the success ordering is not strong enough, and suggests chosing a stronger one. This is more likely to be correct.

Also, before this change, the compiler suggested downgrading an invalid AcqRel failure ordering to Relaxed, without mentioning Acquire as an option.
 2022-06-27 08:06:45 +02:00
Mara Bos
f107923cc0 Slightly tweak invalid atomic ordering lint messages. 
Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
 2022-06-22 20:09:23 +02:00
Camille GILLOT
47b8d26eff Use ensure for UnusedBrokenConst. 2022-06-19 09:44:32 +02:00
Camille GILLOT
dae1d97468 Make some lints incremental. 2022-06-19 00:00:36 +02:00
bors
cdcc53b7dc Auto merge of #98153 - nnethercote:fix-MissingDoc-quadratic-behaviour, r=cjgillot 
Fix `MissingDoc` quadratic behaviour

Best reviewed one commit at a time.

r? `@cjgillot`
 2022-06-18 09:57:00 +00:00
Matthias Krüger
95be954af4
Rollup merge of #97757 - xFrednet:rfc-2383-expect-with-force-warn, r=wesleywiser,flip1995 
Support lint expectations for `--force-warn` lints (RFC 2383)

Rustc has a `--force-warn` flag, which overrides lint level attributes and forces the diagnostics to always be warn. This means, that for lint expectations, the diagnostic can't be suppressed as usual. This also means that the expectation would not be fulfilled, even if a lint had been triggered in the expected scope.

This PR now also tracks the expectation ID in the `ForceWarn` level. I've also made some minor adjustments, to possibly catch more bugs and make the whole implementation more robust.

This will probably conflict with https://github.com/rust-lang/rust/pull/97718. That PR should ideally be reviewed and merged first. The conflict itself will be trivial to fix.

---

r? `@wesleywiser`

cc: `@flip1995` since you've helped with the initial review and also discussed this topic with me. 🙃

Follow-up of: https://github.com/rust-lang/rust/pull/87835

Issue: https://github.com/rust-lang/rust/issues/85549

Yeah, and that's it.
 2022-06-16 09:10:20 +02:00
xFrednet
8527a3d369
Support lint expectations for --force-warn lints (RFC 2383) 2022-06-16 08:16:43 +02:00
Nicholas Nethercote
be45f10a9c Inline and remove {enter,exit}_attrs functions. 
They each have a single call site.
 2022-06-16 09:52:04 +10:00
Nicholas Nethercote
c9e97251ad Remove unused hir_id arg from visit_attribute. 2022-06-16 09:52:04 +10:00