flip1995
767cc7cd89
Merge remote-tracking branch 'upstream/master' into rustup
2021-05-06 11:32:03 +02:00
bors
796a6f00e1
Auto merge of #7177 - giraffate:add_a_missing_lint_to_msrv_config_doc, r=flip1995
...
Add a missing lint to MSRV config doc
A follow-up of https://github.com/rust-lang/rust-clippy/pull/6859 .
changelog: Add a missing lint to MSRV config doc
2021-05-06 08:43:36 +00:00
bors
7191675ab1
Auto merge of #7166 - TaKO8Ki:refactor_misc_early_module, r=llogiq
...
Refactor: arrange lints in misc_early module
This PR arranges misc_early lints so that they can be accessed more easily.
Basically, I refactored them following the instruction described in #6680 .
cc: `@Y-Nak,` `@flip1995,` `@magurotuna`
changelog: Move lints in misc_early module into their own modules.
2021-05-06 07:46:52 +00:00
Takayuki Nakata
b8046fab23
Add a missing lint to MSRV config doc
2021-05-06 14:04:50 +09:00
bors
9dd87051c7
Auto merge of #7175 - camsteffen:filter-map-none, r=Manishearth
...
Fix unnecessary_filter_map false positive
changelog: Fix an [`unnecessary_filter_map`] false positive
Fixes #6804
2021-05-05 22:57:05 +00:00
Cameron Steffen
d66d37303c
Fix unnecessary_filter_map false positive
2021-05-05 16:44:00 -05:00
bors
93fe3562d0
Auto merge of #7174 - camsteffen:eval-order-async, r=flip1995
...
Fix eval_order_dependence async false positive
changelog: Fix [`eval_order_dependence`] false positive in async code
Fixes #6925
2021-05-05 21:18:05 +00:00
Cameron Steffen
7a7b8bd3e8
Fix eval_order_dependence async false positive
2021-05-05 15:08:44 -05:00
Cameron Steffen
2b38399920
Improve eval_order_dependence output
2021-05-05 15:03:14 -05:00
bors
182a1853c3
Auto merge of #7170 - flip1995:revert_drop_order, r=llogiq
...
Fix stack overflow issue in `redundant_pattern_matching`
Fixes #7169
~~cc `@Jarcho` Since tomorrow is release day and we need to get this also fixed in beta, I'll just revert the PR instead of looking into the root issue. Your changes are good, so if you have an idea what could cause this stack overflow and know how to fix it, please open a PR that reverts this revert with a fix.~~
r? `@llogiq`
changelog: none (fixes stack overflow, but this was introduced in this release cycle)
2021-05-05 17:33:46 +00:00
xFrednet
e0eb29c936
Applying PR suggestions (mostly typos)
...
Co-authored-by: flip1995 <hello@philkrones.com>
Co-authored-by: phansch <dev@phansch.net>
2021-05-05 18:58:57 +02:00
xFrednet
62cafe2c02
Applying PR suggestions
2021-05-05 18:38:26 +02:00
xFrednet
c1fa1102d4
ENABLE_METADATA_COLLECTION env-value to disable default metadata collection
2021-05-05 18:38:26 +02:00
xFrednet
4fc960301b
Metadata collection: Rounding up the implementation
2021-05-05 18:38:26 +02:00
xFrednet
35844d0a48
Metadata collection: Resolve lint from locals
2021-05-05 18:35:33 +02:00
xFrednet
2ce5e368d8
Metadata collection: Refining the implementation
2021-05-05 18:35:33 +02:00
xFrednet
6658db1044
Metadata collection: processing emission closures (417/455)
2021-05-05 18:35:33 +02:00
xFrednet
5830fa7c60
Metadata Collection: Collecting direct emission applicabilities (324/455)
2021-05-05 18:35:33 +02:00
xFrednet
ee8a99a114
Metadata collection: Collecting Applicability assign values
2021-05-05 18:35:33 +02:00
xFrednet
a39912cfbb
Metadata collection: Some refactoring for readability
2021-05-05 18:35:33 +02:00
xFrednet
ee130d066d
Metadata collection: Tracking Applicability mut borrows
2021-05-05 18:35:33 +02:00
xFrednet
8dca1b8f61
Metadata collection: Collecting Applicability assign values
2021-05-05 18:35:33 +02:00
xFrednet
68d702f88d
Metadata collection lint: Start Applicability value tracking
2021-05-05 18:35:33 +02:00
xFrednet
060e0e9f93
Metadata collection lint: Basic applicability collection
2021-05-05 18:35:33 +02:00
xFrednet
637751ff62
Metadata collection lint: Basic lint collection
...
WIP-2021-02-01
WIP-2021-02-01
WIP-2021-02-13
2021-05-05 18:34:24 +02:00
bors
0baf6bf226
Auto merge of #7163 - mgacek8:issue7110_needless_collect_with_type_annotations, r=flip1995
...
needless_collect: Lint cases with type annotations for indirect usage and recognize `BinaryHeap`
fixes #7110
changelog: needless_collect: Lint cases with type annotations for indirect usage and recognize `BinaryHeap`.
2021-05-05 15:43:02 +00:00
Cameron Steffen
344f04bea6
Fix stack overflow in redundant_pattern_matching
2021-05-05 16:12:39 +02:00
Mateusz Gacek
f79a2a3990
needless_collect: use node_type_opt
instead of node_type
...
It may prevent future ICEs.
2021-05-05 04:52:03 -07:00
Cameron Steffen
83329ec705
Fix unused_unit macro false positive
2021-05-04 17:20:33 -05:00
Takayuki
3fbb060379
replace lit_snip type with &str
2021-05-05 06:53:04 +09:00
Takayuki
2dfb246d8e
refactor unseparated_literal_suffix
2021-05-05 06:39:38 +09:00
Takayuki
b1567f4466
move zero_prefixed_literal to its own module
2021-05-05 06:18:58 +09:00
Mateusz Gacek
1835d8a238
needless_collect: Add BinaryHeap
for indirect usage lint
2021-05-04 12:38:30 -07:00
Mateusz Gacek
b1faaaeb0c
needless_collect: Lint cases with type annotations
2021-05-04 12:38:30 -07:00
Takayuki
0773d8afdb
move mixed_case_hex_literals to its own module
2021-05-05 02:21:26 +09:00
Takayuki
f012e0e3de
move unseparated_literal_suffix to its own module
2021-05-05 02:10:24 +09:00
Takayuki
829fde5e1f
move unneeded_field_pattern to its own module
2021-05-05 01:44:38 +09:00
Takayuki
c0a106e252
move unneeded_wildcard_pattern to its own module
2021-05-04 19:50:48 +09:00
Takayuki
52cfde0586
move redundant_pattern to its own module
2021-05-04 17:28:32 +09:00
Takayuki
55af0cee15
move double_neg to its own module
2021-05-04 17:20:22 +09:00
Takayuki
64eb18e675
move builtin_type_shadow to its own module
2021-05-04 17:04:10 +09:00
Takayuki
91a8611b44
move misc_early to misc_early/mod.rs
2021-05-04 16:38:34 +09:00
bors
5e3160ca0b
Auto merge of #7156 - hellow554:single_char_strip, r=flip1995
...
[single_char_pattern] add strip_prefix and strip_suffix
Title says it all. Adjusted ui tests.
I added the second commit in case you don't like that I moved that table into `single_char_pattern.rs` directly. I don't see any reason why it shouldn't be in that file. It isn't used anywhere else.
*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: add strip_prefix and strip_suffix to single_char_pattern lint
2021-05-03 14:44:44 +00:00
Marcel Hellwig
19e7448c7f
move PATTERN_METHODS table directly into file
...
also removed rustfmt::skip
2021-05-03 16:25:05 +02:00
Marcel Hellwig
c080899848
add strip_{prefix,suffix} to PATTERN_METHODS
...
this will warn, if a single_char_pattern is used in one of the above
methods
2021-05-03 16:18:41 +02:00
Cameron Steffen
499813026f
Fix config parsing
2021-05-02 17:50:22 -05:00
Cameron Steffen
857d9f15da
Fix error punctuation
2021-05-02 16:56:46 -05:00
Cameron Steffen
1e22e564e4
Refactor config deserialization
2021-05-01 17:38:05 -05:00
Cameron Steffen
b9c8e683d6
Disable default_trait_access in macros
2021-05-01 16:16:32 -05:00
bors
a300b0e66c
Auto merge of #7144 - rust-lang:while_immutable_mut_cond, r=flip1995
...
while_immutable_cond: check condition for mutation
This fixes #6689 by also checking the bindings mutated in the condition, whereas it was previously only checked in the loop body.
---
changelog: Fix FP in [`while_immutable_cond`] where mutation in the loop variable wasn't picked up.
2021-04-30 15:08:27 +00:00