Oli Scherer
6fc3850847
update clippy stderr file
2022-03-24 11:27:07 +00:00
Esteban Kuber
90da7cdd41
Do not point at whole file missing fn main
...
Only point at the end of the crate. We could try making it point at the
beginning of the crate, but that is confused with `DUMMY_SP`, causing
the output to be *worse*.
This change will make it so that VSCode will *not* underline the whole
file when `main` is missing, so other errors will be visible.
2022-03-05 02:42:55 +00:00
flip1995
611d039814
Merge commit '57b3c4b90f4346b3990c1be387c3b3ca7b78412c' into clippyup
2022-02-10 18:40:06 +01:00
flip1995
97ab44ca97
Merge commit '0eff589afc83e21a03a168497bbab6b4dfbb4ef6' into clippyup
2021-12-30 15:10:43 +01:00
Jacob Pratt
f8817f63e1
Stabilize destructuring_assignment
2021-12-14 22:38:51 -05:00
flip1995
8fea1d94f3
Merge commit 'a5d597637dcb78dc73f93561ce474f23d4177c35' into clippyup
2021-12-06 12:33:31 +01:00
Aaron Hill
3c8b644d0d
Only check for errors in predicate when skipping impl assembly
...
Prior to PR #91205 , checking for errors in the overall obligation
would check checking the `ParamEnv`, due to an incorrect
`super_visit_with` impl. With this bug fixed, we will now
bail out of impl candidate assembly if the `ParamEnv` contains
any error types.
In practice, this appears to be overly conservative - when an error
occurs early in compilation, we end up giving up early for some
predicates that we could have successfully evaluated without overflow.
By only checking for errors in the predicate itself, we avoid causing
additional spurious 'type annotations needed' errors after a 'real'
error has already occurred.
With this PR, the diagnostic changes caused by PR #91205 are reverted.
2021-11-27 11:33:55 -06:00
bors
6b997b6576
Auto merge of #91205 - Aaron1011:visit_param_env, r=lcnr
...
Visit `param_env` field in Obligation's `TypeFoldable` impl
This oversight appears to have gone unnoticed for a long time
without causing issues, but it should still be fixed.
2021-11-26 09:55:06 +00:00
Aaron Hill
9274ec5691
Visit param_env
field in Obligation's TypeFoldable
impl
...
This oversight appears to have gone unnoticed for a long time
without causing issues, but it should still be fixed.
2021-11-25 15:33:37 -06:00
Esteban Kuber
5fc61a24c4
Fix clippy test
2021-11-25 18:39:32 +00:00
flip1995
e674d0a599
Merge commit 'e18101137866b79045fee0ef996e696e68c920b4' into clippyup
2021-11-04 12:52:36 +00:00
Cameron Steffen
0a23fff82d
Fix clippy with changed macro statement spans
2021-10-15 02:36:58 -05:00
Oli Scherer
049ab82662
Update clippy ui output
2021-10-13 11:06:14 +00:00
flip1995
5cf4984872
Merge commit 'b7f3f7f6082679da2da9a0b3faf1b5adef3afd3b' into clippyup
2021-10-07 11:21:30 +02:00
Cameron Steffen
9c2d52fabe
Add desugaring mark to while loop
2021-10-02 17:41:14 -05:00
lcnr
fd8b150959
feature(const_generics)
-> feature(const_param_types)
2021-08-30 11:00:21 +02:00
Caio
b97d4c062b
Introduce hir::ExprKind::Let - Take 2
2021-08-15 16:18:26 -03:00
Guillaume Gomez
fd5427b686
Rollup merge of #87885 - m-ou-se:edition-guide-links, r=rylev
...
Link to edition guide instead of issues for 2021 lints.
This changes the 2021 lints to not link to github issues, but to the edition guide instead.
Fixes #86996
2021-08-12 13:25:07 +02:00
Mara Bos
8e563b5468
Bless clippy tests.
2021-08-12 10:48:16 +02:00
Esteban Kuber
652b6a771f
update clippy
2021-08-11 14:21:33 +00:00
Esteban Küber
9a6ae783d4
Use multispan suggestions more often
...
* Use more accurate span for `async move` suggestion
* Use more accurate span for deref suggestion
* Use `multipart_suggestion` more often
2021-07-30 09:26:31 -07:00
flip1995
884ef4c287
Merge commit '4c41a222ca5d1325fb4b6709395bd06e766cc042' into clippyup
2021-07-19 11:52:05 +02:00
flip1995
1d084b13a5
Merge commit '54a20a02ecd0e1352a871aa0990bcc8b8b03173e' into clippyup
2021-07-15 10:44:10 +02:00
Ryan Levick
abc9a46868
Fix clippy test
2021-06-25 15:29:14 +02:00
flip1995
6c27482115
Merge commit '3ae8faff4d46ad92f194c2a4b941c3152a701b31' into clippyup
2021-06-03 08:41:37 +02:00
flip1995
97705b7ea6
Merge commit '9e3cd88718cd1912a515d26dbd9c4019fd5a9577' into clippyup
2021-05-20 13:07:57 +02:00
Aaron Hill
4698b366c4
Show macro name in 'this error originates in macro' message
...
When there are multiple macros in use, it can be difficult to tell
which one was responsible for producing an error.
2021-05-12 19:03:06 -04:00
flip1995
d605882023
Merge commit 'b71f3405606d49b9735606b479c3415a0ca9810f' into clippyup
2021-05-06 12:20:44 +02:00
bors
9735470bb4
Auto merge of #83213 - rylev:update-lints-to-errors, r=nikomatsakis
...
Update BARE_TRAIT_OBJECT and ELLIPSIS_INCLUSIVE_RANGE_PATTERNS to errors in Rust 2021
This addresses https://github.com/rust-lang/rust/pull/81244 by updating two lints to errors in the Rust 2021 edition.
r? `@estebank`
2021-05-04 08:09:23 +00:00
Ryan Levick
6ddd3c9e36
Fix clippy error
2021-04-29 18:37:22 +02:00
flip1995
ae72f1adb9
Merge commit '7c7683c8efe447b251d6c5ca6cce51233060f6e8' into clippyup
2021-04-27 16:55:11 +02:00
flip1995
02bf692169
Merge commit '98e2b9f25b6db4b2680a3d388456d9f95cb28344' into clippyup
2021-04-22 11:31:13 +02:00
lcnr
419bf6bbd8
fix suggestion for unsized function parameters
2021-04-19 20:06:19 +02:00
flip1995
f6d1f368db
Merge commit 'b40ea209e7f14c8193ddfc98143967b6a2f4f5c9' into clippyup
2021-04-08 17:50:13 +02:00
flip1995
f2f2a005b4
Merge commit '6ed6f1e6a1a8f414ba7e6d9b8222e7e5a1686e42' into clippyup
2021-03-12 15:30:50 +01:00
flip1995
f64149dd04
Merge commit '928e72dd10749875cbd412f74bfbfd7765dbcd8a' into clippyup
2021-02-25 11:25:22 +01:00
flip1995
ac912be984
Merge commit '95c0459217d1661edfa794c8bb122452b92fb485' into clippyup
2021-01-30 18:06:34 +01:00
bors
39aca5ff9f
Auto merge of #78399 - vn-ki:gsgdt-graphviz, r=oli-obk
...
make MIR graphviz generation use gsgdt
gsgdt [https://crates.io/crates/gsgdt ] is a crate which provides an
interface for stringly typed graphs. It also provides generation of
graphviz dot format from said graph.
This is the first in a series of PRs on moving graphviz code out of rustc into normal crates and then implementating graph diffing on top of these crates.
r? `@oli-obk`
2020-12-15 22:00:02 +00:00
Vishnunarayan K I
4e14c05976
fix clippy test
2020-12-05 20:21:21 +05:30
bors
3be53bc45a
Auto merge of #79329 - camelid:int-lit-suffix-error, r=davidtwco
...
Update error to reflect that integer literals can have float suffixes
For example, `1` is parsed as an integer literal, but it can be turned
into a float with the suffix `f32`. Now the error calls them "numeric
literals" and notes that you can add a float suffix since they can be
either integers or floats.
2020-11-30 01:42:14 +00:00
Camelid
2347eac4cc
Update error to reflect that integer literals can have float suffixes
...
For example, `1` is parsed as an integer literal, but it can be turned
into a float with the suffix `f32`. Now the error calls them "numeric
literals" and notes that you can add a float suffix since they can be
either integers or floats.
2020-11-27 19:08:24 -08:00
flip1995
284c359c61
Fix ICE in utils::implements_trait
...
This only happend when debug_assertions were enabled in rustc
2020-11-23 13:52:27 +01:00
flip1995
d3d2018ead
Merge commit '3e7c6dec244539970b593824334876f8b6ed0b18' into clippyup
2020-11-23 13:51:04 +01:00
bors
0c7a48c5f0
Auto merge of #78809 - vn-ki:fix-issue-76064, r=oli-obk
...
add error_occured field to ConstQualifs,
fix #76064
I wasn't sure what `in_return_place` actually did and not sure why it returns `ConstQualifs` while it's sibling functions return `bool`. So I tried to make as minimal changes to the structure as possible. Please point out whether I have to refactor it or not.
r? `@oli-obk`
cc `@RalfJung`
2020-11-14 18:03:17 +00:00
Vishnunarayan K I
7987f39ad5
update clippy test ouput
2020-11-13 17:11:13 +05:30
Fabian Zaiser
5f310d9b83
Implement destructuring assignment for structs and slices
...
Co-authored-by: varkor <github@varkor.com>
2020-11-11 12:10:52 +00:00
flip1995
34244190d4
Merge commit 'b20d4c155d2fe3a8391f86dcf9a8c49e17188703' into clippyup
2020-11-05 14:29:48 +01:00
Eduardo Broto
50419118b4
Merge commit '645ef505da378b6f810b1567806d1bcc2856395f' into clippyup
2020-10-28 23:36:07 +01:00
Eduardo Broto
cdb555f4fc
Merge commit 'bf1c6f9871f430e284b17aa44059e0d0395e28a6' into clippyup
2020-10-23 22:16:59 +02:00
varkor
fcde7683fe
Fix clippy tests
2020-10-22 13:23:14 +01:00
flip1995
fbf2430f02
Merge commit '2f6439ae6a6803d030cceb3ee14c9150e91b328b' into clippyup
2020-10-09 12:45:29 +02:00
flip1995
d1f9cad102
Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup
2020-09-24 14:49:22 +02:00
flip1995
282c59820b
Merge commit '3d0b0e66afdfaa519d8855b338b35b4605775945' into clippyup
2020-08-28 18:43:25 +02:00
flip1995
027780ca2c
Merge commit '09bd400243ed6f7059fedc0c1623aae3792521d6' into clippyup
2020-08-11 17:50:45 +02:00
Tamir Duberstein
cf91c54cc6
Avoid "whitelist"
...
Other terms are more inclusive and precise.
2020-07-10 07:39:28 -04:00
flip1995
80bcbf521c
Merge commit 'c2c07fa9d095931eb5684a42942a7b573a0c5238' into clippyup
2020-06-23 17:05:22 +02:00
Lzu Tao
8db24840f7
Merge commit 'ff0993c5e9162ddaea78e83d0f0161e68bd4ea73' into clippy
2020-06-09 14:36:01 +00:00
bors
8164832c4b
Auto merge of #68717 - petrochenkov:stabexpat, r=varkor
...
Stabilize fn-like proc macros in expression, pattern and statement positions
I.e. all the positions in which stable `macro_rules` macros are supported.
Depends on https://github.com/rust-lang/rust/pull/68716 ("Stabilize `Span::mixed_site`").
cc https://github.com/rust-lang/rust/issues/54727
cc https://github.com/rust-lang/rust/issues/54727#issuecomment-580647446
Stabilization report: https://github.com/rust-lang/rust/pull/68717#issuecomment-623197503 .
2020-05-19 03:11:32 +00:00
flip1995
f1d3086492
Merge commit 'e214ea82ad0a751563acf67e1cd9279cf302db3a' into clippyup
2020-05-17 17:36:26 +02:00
Vadim Petrochenkov
2d10babb71
Stabilize fn-like proc macros in expression, pattern and statement positions
2020-05-03 19:24:41 +03:00
Matthias Krüger
7221db2dc3
fix crash on issue-69020-assoc-const-arith-overflow.rs
...
Fixes #5497
2020-04-20 23:01:34 +02:00
David Tolnay
5f92faec6d
Downgrade implicit_hasher to pedantic
2020-04-08 08:43:20 -07:00
Linus Färnstrand
b192f2cd15
Use primitive type assoc consts in more tests
2020-04-08 00:43:27 +02:00
bors
557f6848bd
Auto merge of #5296 - sinkuu:fix_ice_trivial_bounds, r=flip1995
...
Fix ICE with trivial_bounds feature
https://github.com/rust-lang/rust/issues/69874#issuecomment-596890446
changelog: Fix ICE with trivial_bounds feature
2020-03-10 12:25:07 +00:00
Yuki Okushi
8d2a3e0a61
Use node_type_opt
over node_type
2020-03-10 18:18:34 +09:00
Shotaro Yamada
a3d9355bef
Fix ICE with trivial_bounds feature
2020-03-10 13:17:35 +09:00
Yuki Okushi
46ee6b1840
Add regression test
2020-03-03 22:22:46 +09:00
Matthias Krüger
1e29b36e4e
add test for #5238
2020-02-28 22:00:20 +01:00
Yuki Okushi
8abe4365f3
Use generator own DefId
2020-02-21 16:24:58 +09:00
Lzu Tao
c6a4beaf56
Rustup https://github.com/rust-lang/rust/pull/67359
2020-02-07 10:40:09 +07:00
Yuki Okushi
c6aeda7bd5
Move use_self_macro
into crashes/auxiliary
2020-01-03 17:03:07 +09:00
Yuki Okushi
20318e00ef
Add attribute
2020-01-02 09:32:55 +09:00
Yuki Okushi
de6fe1071b
Rename test prefix
2019-12-31 20:55:12 +09:00
Yuki Okushi
50a8582980
Move ICE tests to /crashes
2019-12-31 20:55:12 +09:00
Yuki Okushi
12a3d72462
Add regression test for #4968
2019-12-31 20:55:12 +09:00
Michael Wright
cc6e27fa71
Put ice test auxiliary fix in right place
2019-11-08 07:18:12 +02:00
Michael Wright
9c48a2c39a
Merge branch 'master' into fix-4727
2019-11-08 07:15:16 +02:00
Michael Wright
a952708b6c
Fix crash in use-self
lint
...
Fixes #4727
2019-11-06 07:33:56 +02:00
HMPerson1
e3d6069e18
Use correct TypeckTables when hashing bodies
2019-11-04 20:03:03 -05:00
Shotaro Yamada
555f5a49a2
Test fixes
2019-10-03 08:10:29 +09:00
James Wang
189eaa54c6
Ignore impls derived from macros
2019-09-27 20:47:00 -05:00
James Wang
52408f5b7d
Add a new lint for comparison chains
2019-09-24 16:55:05 -05:00
Philipp Hansch
a316179850
Rustup to https://github.com/rust-lang/rust/pull/60965
2019-05-23 20:19:00 +02:00
Oliver Scherer
efac2e5eff
Revert "Turn off two tests broken due to #4108 "
...
This reverts commit 568a3ecfc3
.
2019-05-20 12:31:53 +02:00
Oliver Scherer
568a3ecfc3
Turn off two tests broken due to #4108
2019-05-18 00:57:23 +02:00
bors
2278814c8e
Auto merge of #3931 - phansch:3891, r=flip1995
...
Fix ICE in decimal_literal_representation lint
Handling the integer parsing properly instead of just unwrapping.
Note that the test is not catching the ICE because plain UI tests
[currently hide ICEs][compiletest_issue]. Once that issue is fixed, this
test would fail properly again.
Fixes #3891
[compiletest_issue]: https://github.com/laumann/compiletest-rs/issues/169
2019-04-10 20:57:15 +00:00
Philipp Hansch
0307ff020c
Fix ICE in decimal_literal_representation lint
...
Handling the integer parsing properly instead of just unwrapping.
Note that the test is not catching the ICE because plain UI tests
[currently hide ICEs][compiletest_issue]. Once that issue is fixed, this
test would fail properly again.
[compiletest_issue]: https://github.com/laumann/compiletest-rs/issues/169
2019-04-08 22:16:34 +02:00
Philipp Hansch
3ab8038450
Remove force-host and explain no-prefer-dynamic
2019-04-08 21:23:39 +02:00
Philipp Hansch
60c1bb0546
Fix ICE in suspicious_else_formatting
2019-04-07 11:11:06 +02:00
Philipp Hansch
b545f1c3bb
Add missing // run-pass
annotations to ICE tests
...
compiletest UI tests do not fail when encountering panics and ICEs
unless the `// run-pass` flag is used.
(This was forgotten in https://github.com/rust-lang/rust-clippy/pull/3743 )
2019-04-05 07:22:36 +02:00
flip1995
44c46d2059
Run rustfmt
2019-03-10 22:12:26 +01:00
Alexander Regueiro
d43966a176
Various cosmetic improvements.
2019-03-10 18:06:28 +00:00
Martins Polakovs
391ee7987d
Fix ICE #3747
...
[Martins Polakovs, John Firebaugh]
2019-02-23 21:38:16 +02:00
Philipp Hansch
a586f52a0f
Move run-pass tests to UI tests
...
This should give us more UI coverage for free.
It also removes the `run-pass` suite, so we now only have the `ui` suite.
2019-02-06 08:17:39 +01:00