Oliver Schneider
|
d011dae96d
|
Rustup
|
2018-01-15 12:08:17 +01:00 |
|
Jonathan Goodman
|
40c6f431da
|
add new lint else_if_without_else
|
2018-01-14 22:53:00 -06:00 |
|
Adam Lusch
|
f343cd22f6
|
Adds the missing turbofish
|
2018-01-14 20:19:55 -08:00 |
|
Adam Lusch
|
1615813960
|
Moves clone_on_ref_ptr to be a restriction lint
Also updates the suggestion to include the full type (e.g. `Arc<Foo>::clone(&rc)`)
and adds a case using trait objects to the UI tests.
|
2018-01-14 19:58:09 -08:00 |
|
Phil Ellison
|
ad164939ed
|
Check that we're calling Iterator::fold
|
2018-01-14 20:04:34 +00:00 |
|
Phil Ellison
|
70a5535ffa
|
Address some review comments
|
2018-01-14 18:18:09 +00:00 |
|
Phil Ellison
|
360f2359d5
|
Fix name
|
2018-01-14 15:30:06 +00:00 |
|
Oliver Schneider
|
2f62d803ab
|
Merge pull request #2349 from rust-lang-nursery/no-main-doc
Don't warn about missing docs for main()
|
2018-01-14 13:16:54 +01:00 |
|
Phil Ellison
|
7e833ea5ce
|
Add description
|
2018-01-14 10:07:41 +00:00 |
|
Phil Ellison
|
528be23c07
|
Move get_arg_name into utils
|
2018-01-14 10:05:01 +00:00 |
|
Phil Ellison
|
1feb9fd550
|
Tidy using if_chain and snippet function. Actually check that the initial fold value is false. Remove some unwraps
|
2018-01-14 09:30:08 +00:00 |
|
Phil Ellison
|
f6e56d2559
|
First pass at linting for .any expressed as a .fold
|
2018-01-14 08:27:53 +00:00 |
|
Manish Goregaokar
|
7e63f93d81
|
Don't warn about missing docs for main()
Fixes #2348
|
2018-01-14 11:35:08 +05:30 |
|
Oliver Schneider
|
cc9008b7d4
|
Merge pull request #2347 from kimsnj/extrem_comp
Fix #1159: avoid comparing fixed and target sized types in lint
|
2018-01-13 12:27:36 +01:00 |
|
kimsnj
|
53c0ae0169
|
Fix #1159: avoid comparing fixed and target sized types in lint
|
2018-01-12 18:33:25 +01:00 |
|
HMPerson1
|
8505ee7028
|
Add lint to replace consts with const fns
|
2018-01-11 12:03:46 -05:00 |
|
Oliver Schneider
|
1245de1e46
|
Don't suggest changing explicit Clone impls if they have generics
|
2018-01-11 10:28:42 +01:00 |
|
Oliver Schneider
|
41a710e3f4
|
Version bump
|
2018-01-10 09:50:58 +01:00 |
|
Oliver Schneider
|
75c92aa2d2
|
Fix an ICE in HashMap generalization suggestions
|
2018-01-09 14:57:44 +01:00 |
|
Oliver Schneider
|
4603e60fca
|
Merge pull request #2316 from tspiteri/doc-names
Add "NaNs" and "GitLab" to `doc-valid-idents`
|
2018-01-09 09:10:18 +01:00 |
|
Oliver Schneider
|
64af362ab0
|
Merge pull request #2334 from Rantanen/ast-fix
Implement nightly libsyntax changes to fix the build
|
2018-01-08 10:56:07 +01:00 |
|
Philipp Hansch
|
1a16ac058d
|
Add 'positive' examples for some lints
This allows to see at a quick glance what the improved code could look
like for these lints.
|
2018-01-08 10:20:04 +01:00 |
|
Mikko Rantanen
|
91ecb3b8ed
|
Implement nightly libsyntax changes
|
2018-01-07 05:58:53 +02:00 |
|
Pascal Hertleif
|
82d91c5fcb
|
Add auto-fixable println!() suggestion
Fixes #2319
|
2018-01-04 12:46:26 +01:00 |
|
Trevor Spiteri
|
a5d0569a20
|
Add "NaNs" and "GitLab" to doc-valid-idents
|
2018-01-02 13:51:35 +01:00 |
|
zmt00
|
a7f423b114
|
Fix typos in README, documentation
|
2018-01-01 13:55:40 -08:00 |
|
Michael Wright
|
6737bae9b1
|
Implemented option_option lint
|
2017-12-26 09:24:12 +02:00 |
|
Darren Tsung
|
b9abe028c9
|
Move in_macro check to end of expression since usual case is not inside macro
|
2017-12-22 10:54:52 -08:00 |
|
Darren Tsung
|
1f36aa519e
|
Check that eq_op lint doesn’t mark macro use of functions as errors since macros, fix #2265
|
2017-12-22 10:51:41 -08:00 |
|
Manish Goregaokar
|
bebc192df4
|
Universal impl traits get removed earlier now
https://github.com/rust-lang/rust/pull/46754
|
2017-12-21 20:54:49 -08:00 |
|
Manish Goregaokar
|
7e099903be
|
Update to handle GenericParam
introduced in https://github.com/rust-lang/rust/pull/45930
|
2017-12-21 20:54:49 -08:00 |
|
Wilco Kusee
|
a6ccc6fe3d
|
Also suggest as_mut for match_as_ref
|
2017-12-20 10:39:48 +01:00 |
|
Wilco Kusee
|
919601bc51
|
Lint for matching option as ref
|
2017-12-19 23:51:06 +01:00 |
|
Oliver Schneider
|
cf58e1c672
|
Merge pull request #2269 from letheed/fix-2267
Disable cast_lossless on const/static items
|
2017-12-17 15:09:41 +01:00 |
|
Oliver Schneider
|
8ddcb81a15
|
Rustup and lazy_static version mismatch fix
fixes #2274
|
2017-12-15 10:05:32 +01:00 |
|
letheed
|
2703e74440
|
Disable cast_lossless on const items
|
2017-12-11 16:22:02 +01:00 |
|
Oliver Schneider
|
299ffcab77
|
Try fixing const_with_static_lifetime docs
|
2017-12-07 08:09:46 +01:00 |
|
Seiichi Uchida
|
4121507a48
|
Rustup to rustc 1.24.0-nightly (bb42071f6 2017-12-01)
|
2017-12-02 18:23:32 +09:00 |
|
laurent
|
c3a8946a46
|
Bugfix the bugfix.
|
2017-12-01 19:27:02 +00:00 |
|
laurent
|
904f27a2ea
|
Do raise a same-arms warning when the two arms are separated by an arm with a guard, fix #1996.
|
2017-12-01 19:25:43 +00:00 |
|
HMPerson1
|
e2bc383383
|
Add linting for empty blocks too
|
2017-11-30 19:40:40 -05:00 |
|
HMPerson1
|
5fca6eb89e
|
Fix #2160
|
2017-11-30 15:31:56 -05:00 |
|
Oliver Schneider
|
7d7fef1690
|
Fix #1925
|
2017-11-30 10:55:06 +01:00 |
|
laurent
|
c3ae2ddeb3
|
Fix a bug in search_same + add a test case.
|
2017-11-29 21:42:58 +00:00 |
|
laurent
|
f8dbd32433
|
Add a couple small tests to the match-same-arm lint.
|
2017-11-29 20:42:37 +00:00 |
|
Oliver Schneider
|
273ddafac5
|
Fix #2188
|
2017-11-29 17:20:00 +01:00 |
|
Oliver Schneider
|
d5b73c184b
|
Fix placement of new_without_default suggestion
|
2017-11-29 17:10:53 +01:00 |
|
Oliver Schneider
|
317e97bae7
|
Fix #2196
|
2017-11-29 17:06:27 +01:00 |
|
Oliver Schneider
|
f65a022ace
|
Fix #2245
|
2017-11-29 16:03:05 +01:00 |
|
Oliver Schneider
|
0b0337d258
|
Fix #2247
|
2017-11-29 15:52:57 +01:00 |
|
Lukas Stevens
|
c22455cb9e
|
Check for word beginning in stutter lint
|
2017-11-26 18:36:12 +01:00 |
|
Oliver Schneider
|
af718413db
|
Rustup
|
2017-11-22 10:55:12 +01:00 |
|
Frederick Zhang
|
e91b01348e
|
fix usage of LayoutDetails
|
2017-11-21 16:51:36 +11:00 |
|
Oliver Schneider
|
c5fa86da04
|
Merge pull request #2203 from clippered/float_cmp_const
Fix #1142 float constant comparison lint
|
2017-11-20 09:51:12 +01:00 |
|
laurent
|
ed202b6055
|
Bugfix + add test.
|
2017-11-19 11:29:25 +00:00 |
|
laurent
|
8e9d0c277c
|
Remove the brackets argument.
|
2017-11-19 11:29:25 +00:00 |
|
laurent
|
b74ed09d42
|
Use a struct to store most of the recurse parameters for boolean expr suggestion.
|
2017-11-19 11:29:25 +00:00 |
|
Oliver Schneider
|
acc81cf921
|
Merge pull request #2232 from rust-lang-nursery/fixup-const-static-lifetime
Fixup "const static lifetime" lint for non-path types
|
2017-11-19 09:28:47 +01:00 |
|
Johannes Hofmann
|
3efa07f959
|
Ignore identifier 'OpenStreetMap' for DOC_MARKDOWN lint
|
2017-11-18 19:13:07 +01:00 |
|
Georg Brandl
|
296edda3a9
|
const_static_lifetime: this applies not only to path types
For example, &'static [u8] or &'static (t1, t2).
|
2017-11-18 16:10:29 +01:00 |
|
Oliver Schneider
|
2d005b58c5
|
Merge pull request #2229 from LaurentMazare/master
Simplify the boolean expression suggestion function
|
2017-11-17 09:29:09 +01:00 |
|
laurent
|
87f5b1f043
|
Remove the union type.
|
2017-11-16 21:20:17 +00:00 |
|
laurent
|
e44af6b14d
|
First attempt at simplifying boolean processing.
|
2017-11-16 21:08:08 +00:00 |
|
Christopher Vittal
|
0155ecf6b0
|
Split TyImplTrait into Universal and Existential
This fixes build after the implementation of impl Trait in argument
position lands in rustc
|
2017-11-15 17:52:25 -05:00 |
|
Oliver Schneider
|
f975fb54f8
|
Merge pull request #2216 from LaurentMazare/master
Handle methods with an obvious negation in the non-minimal bool lint
|
2017-11-15 09:08:36 +01:00 |
|
Oliver Schneider
|
c6a4eaeb0d
|
Rustup
|
2017-11-15 08:38:43 +01:00 |
|
laurent
|
25783fa485
|
Raise a lint when suggest has simplified the expression.
|
2017-11-14 21:14:08 +00:00 |
|
Oliver Schneider
|
bdf3887d22
|
Move 'handle_method_call_in_not' code into 'suggest'
|
2017-11-14 17:07:04 +01:00 |
|
Oliver Schneider
|
561d47f338
|
Merge remote-tracking branch 'origin/master' into laurent_master
|
2017-11-14 16:46:56 +01:00 |
|
Oliver Schneider
|
b464432972
|
Merge branch 'master' of github.com:Manishearth/rust-clippy into rust-test
|
2017-11-14 16:31:52 +01:00 |
|
Oliver Schneider
|
127c41f700
|
Apply changes that were required for running in the rustc test suite
|
2017-11-14 14:56:00 +01:00 |
|
laurent
|
14d5013314
|
Use both pair orders.
|
2017-11-10 19:55:15 +00:00 |
|
Oliver Schneider
|
09d988521d
|
Merge pull request #2214 from rust-lang-nursery/nrlfp
Improve `needless_range_loop`
|
2017-11-10 10:11:20 +01:00 |
|
Oliver Schneider
|
299f1270a6
|
Rustup
|
2017-11-10 08:58:54 +01:00 |
|
laurent
|
67aeb2eaeb
|
Only apply when there is a single argument.
|
2017-11-07 21:49:30 +00:00 |
|
laurent
|
82793768b7
|
Handle methods with an immediate negation in the non-minimal boolean lint, fixes #1930.
|
2017-11-07 21:43:24 +00:00 |
|
Oliver Schneider
|
1b323b9f35
|
Don't lint mixed slice indexing and usize indexing in needless_range_loop
|
2017-11-07 15:32:52 +01:00 |
|
Oliver Schneider
|
652df0fb79
|
Differentiate between mutable iteration and immutable iteration in needless_range_loop
|
2017-11-07 14:41:54 +01:00 |
|
Oliver Schneider
|
088555c4ea
|
Merge pull request #2209 from sinkuu/trait_methods
Fix false positive in needless_pass_by_value trait methods
|
2017-11-07 08:26:32 +01:00 |
|
laurent
|
c9681905ba
|
Fix broken tests.
|
2017-11-06 23:26:44 +00:00 |
|
laurent
|
e2b9cf836a
|
Fix merge issues.
|
2017-11-06 23:22:19 +00:00 |
|
sinkuu
|
6fb736bd42
|
Fix false positive in needless_pass_by_value trait methods
|
2017-11-07 06:33:49 +09:00 |
|
sinkuu
|
00081be73d
|
Rustup
|
2017-11-07 06:32:12 +09:00 |
|
Oliver Schneider
|
9cd778ac9a
|
Version bump
|
2017-11-06 12:39:21 +01:00 |
|
Oliver Schneider
|
ed589761e6
|
Merge pull request #2202 from topecongiro/format
Run `cargo fmt`
|
2017-11-06 08:35:52 +01:00 |
|
Oliver Schneider
|
fdeaf8002e
|
Merge pull request #2205 from kraai/2204
Fix compilation errors with rustc 1.23.0-nightly (d762b1d6c 2017-11-04)
|
2017-11-06 08:12:28 +01:00 |
|
Oliver Schneider
|
4018b0a495
|
Merge pull request #2197 from AlexEne/dissalow-underscores-and-numbrers
Warns if variable name is composed only of underscores and digits.
|
2017-11-06 08:11:45 +01:00 |
|
laurent
|
af2c93eeb2
|
Clean the code a bit.
|
2017-11-05 15:45:23 +00:00 |
|
laurent
|
4fb1bb124e
|
Make the dogfood test happy.
|
2017-11-05 15:17:28 +00:00 |
|
laurent
|
42f44d5c78
|
Cosmetic change.
|
2017-11-05 15:04:01 +00:00 |
|
laurent
|
7624736961
|
Bugfix.
|
2017-11-05 14:56:15 +00:00 |
|
laurent
|
bcdf57e220
|
Refactor the never-loop detection, fixes #1991.
|
2017-11-05 14:43:28 +00:00 |
|
Matt Kraai
|
b778659c42
|
Fix compilation errors with rustc 1.23.0-nightly (d762b1d6c 2017-11-04)
Fixes #2204
|
2017-11-05 04:19:11 -08:00 |
|
clippered
|
2787a60fc2
|
Fix #1142 float constant comparison lint
|
2017-11-05 09:37:17 +11:00 |
|
topecongiro
|
a6c71e9c0d
|
Fix lines that exceed max width manually
|
2017-11-05 04:59:21 +09:00 |
|
topecongiro
|
7a06d312fd
|
Cargo fmt
|
2017-11-05 04:55:56 +09:00 |
|
topecongiro
|
65e75c5647
|
Fix excessive indentation in if_chain!
|
2017-11-05 04:51:15 +09:00 |
|
Alexandru Ene
|
f92c91601e
|
Addressed PR comments
|
2017-11-03 20:54:33 +00:00 |
|
sinkuu
|
c102d50ece
|
&Self
|
2017-11-03 17:56:17 +09:00 |
|
sinkuu
|
be7c4b4862
|
Fix test
|
2017-11-03 17:36:38 +09:00 |
|
sinkuu
|
cad33c0306
|
Extend needless_pass_by_value to methods
|
2017-11-03 17:36:38 +09:00 |
|
cgm616
|
76e765aeda
|
Switch to new method of checking access
|
2017-11-02 23:53:48 -05:00 |
|
cgm616
|
ee289c9f88
|
Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy
|
2017-11-02 22:57:07 -05:00 |
|
Alexandru Ene
|
9d01468bc7
|
Warns if variable name is composed only of underscores and digits.
|
2017-11-03 01:01:41 +00:00 |
|
Oliver Schneider
|
47be692723
|
Merge pull request #2194 from martinlindhe/master
fix some typos
|
2017-11-02 10:30:10 +01:00 |
|
Oliver Schneider
|
cabbc781ca
|
Merge pull request #2189 from gendx/pr-1590
Start working on #1590
|
2017-11-02 10:29:30 +01:00 |
|
sinkuu
|
0328d4c6e5
|
Known problems
|
2017-11-01 23:30:07 +09:00 |
|
sinkuu
|
b9f272cdc2
|
Known problems
|
2017-11-01 21:38:59 +09:00 |
|
sinkuu
|
7fa27d9387
|
Lint transmute::<&[u8], &str>
|
2017-11-01 18:05:46 +09:00 |
|
kennytm
|
44d3ea5308
|
Fix lint_without_lint_pass
|
2017-10-31 10:04:02 -07:00 |
|
Martin Lindhe
|
7bce43b66b
|
fix some typos
|
2017-10-31 08:34:27 +01:00 |
|
Manish Goregaokar
|
c526c51923
|
Update clippy for rustc 1.23.0-nightly (f0fe716db 2017-10-30)
|
2017-10-31 00:07:10 -07:00 |
|
G. Endignoux
|
87fd68731d
|
Update UI tests.
|
2017-10-30 14:10:38 +01:00 |
|
G. Endignoux
|
f0a1eff1c4
|
Start working on #1590
|
2017-10-30 13:08:09 +01:00 |
|
Manish Goregaokar
|
a69764d93d
|
Bump to 0.0.167 (rustup to rustc 1.23.0-nightly (90ef3372e 2017-10-29))
|
2017-10-29 20:46:25 -07:00 |
|
Manish Goregaokar
|
f76225e388
|
Handle TyForeign
|
2017-10-29 05:21:25 -04:00 |
|
Manish Goregaokar
|
09143cdaf0
|
Update tests; make it work with generics on context
|
2017-10-29 05:19:24 -04:00 |
|
cgm616
|
85683bf07c
|
Fix mistake in merging
|
2017-10-28 13:23:05 -05:00 |
|
Manish Goregaokar
|
b0616df931
|
Merge branch 'pr-2140'
|
2017-10-28 14:04:25 -04:00 |
|
cgm616
|
d094f98f0b
|
Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy
|
2017-10-28 12:55:16 -05:00 |
|
Oliver Schneider
|
e76eac4b18
|
Fix dogfood
|
2017-10-27 10:51:43 +02:00 |
|
Lukas Stevens
|
0ae2ece91e
|
Check for arrays with size > 32
|
2017-10-25 21:41:31 +02:00 |
|
Alex Burka
|
24a2c14733
|
remove if_let_chain
|
2017-10-23 17:53:30 -04:00 |
|
Alex Burka
|
2153d1e560
|
manual fixups if_let_chain -> if_chain
|
2017-10-23 17:53:30 -04:00 |
|
Alex Burka
|
41840ae3c4
|
mechanically swap if_let_chain -> if_chain
|
2017-10-23 15:18:02 -04:00 |
|
Oliver Schneider
|
2771378620
|
Merge pull request #2136 from ykrivopalov/identity_op_fixing
Identity/erasing operation lints
|
2017-10-23 09:25:08 +02:00 |
|
Oliver Schneider
|
b96639f23a
|
Merge pull request #2143 from HMPerson1/master
Add lint for fallible impls of `From`
|
2017-10-23 09:21:31 +02:00 |
|
Oliver Schneider
|
6d89798119
|
Merge pull request #2163 from HMPerson1/useless_asref
Add lint for useless `as_ref` calls
|
2017-10-23 09:16:44 +02:00 |
|
cgm616
|
29626b883e
|
Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy
|
2017-10-22 10:14:44 -04:00 |
|
cgm616
|
0b0eb8ead6
|
Undo rustfmt changes unrelated to issue
|
2017-10-22 09:59:19 -04:00 |
|
cgm616
|
60c7bd47a5
|
Prevent should_implement_trait on private method
This should close #2159.
|
2017-10-21 07:53:57 -04:00 |
|
sinkuu
|
00d35eea26
|
Fix typo
|
2017-10-21 19:16:13 +09:00 |
|
HMPerson1
|
7206023b1b
|
Change to TryFrom
|
2017-10-20 20:47:51 -04:00 |
|
HMPerson1
|
e5076d06db
|
Add lint for From<String>
|
2017-10-20 20:47:30 -04:00 |
|
HMPerson1
|
ff4a850353
|
Add lint for useless as_ref calls
|
2017-10-20 20:33:19 -04:00 |
|
Oliver Schneider
|
0e489f3221
|
Merge pull request #2146 from MaloJaffre/println_empty_string
Add PRINTLN_EMPTY_STRING lint.
|
2017-10-20 17:39:34 +02:00 |
|
Malo Jaffré
|
22f3ca0e2c
|
Add PRINTLN_EMPTY_STRING lint.
|
2017-10-20 16:45:32 +02:00 |
|
Paul Florence
|
625aae76de
|
Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy
|
2017-10-20 10:18:54 -04:00 |
|
Paul Florence
|
0928168a79
|
Remove "#![feature(plugin)]" in the test".
|
2017-10-20 10:17:41 -04:00 |
|
Paul Florence
|
4bbda68d56
|
Better linting : use of span_lint_and_then.
|
2017-10-20 10:17:41 -04:00 |
|
Paul Florence
|
406931381b
|
Fixed some code in clippy to pass the new, removed formatting changes.
|
2017-10-20 10:17:41 -04:00 |
|
Paul Florence
|
322effe415
|
Implementation of the const_static_lifetime lint.
|
2017-10-20 10:17:41 -04:00 |
|
Oliver Schneider
|
ebdefff88a
|
Something went through the cracks of our CI
|
2017-10-20 16:13:50 +02:00 |
|
Oliver Schneider
|
9293188b65
|
Merge pull request #2156 from cgm616/master
Deprecate should_assert_eq lint
|
2017-10-20 15:24:52 +02:00 |
|
Oliver Schneider
|
281bd790de
|
Merge pull request #2148 from sinkuu/proc_macro
needless_pass_by_value false-positive in annotation
|
2017-10-20 11:12:21 +02:00 |
|
Oliver Schneider
|
327d995bb6
|
Merge pull request #2147 from clippered/fix-manual-memcpy-on-overlapping-slices
Fix #2123 : check that the source and destination are different for m…
|
2017-10-20 09:27:15 +02:00 |
|
Oliver Schneider
|
e2429f023b
|
Version bump
|
2017-10-20 09:24:37 +02:00 |
|
Oliver Schneider
|
35b2669219
|
Check the map for promotable instead for existance of a node (which is always the case)
|
2017-10-20 09:02:32 +02:00 |
|
cgm616
|
4960d9de86
|
Deprecate should_assert_eq lint
This should close #2090.
|
2017-10-19 23:42:04 -05:00 |
|
Manish Goregaokar
|
3e108b7190
|
Fix constant promotion stuff
|
2017-10-19 10:16:03 -07:00 |
|