Nicholas Nethercote
2a2b0b78eb
Rename DiagnosticBuilder as Diag.
...
Much better!
Note that this involves renaming (and updating the value of)
`DIAGNOSTIC_BUILDER` in clippy.
2024-02-28 08:55:35 +11:00
Nicholas Nethercote
a16dbd7339
Prefer DiagnosticBuilder over Diagnostic in diagnostic modifiers.
...
There are lots of functions that modify a diagnostic. This can be via a
`&mut Diagnostic` or a `&mut DiagnosticBuilder`, because the latter type
wraps the former and impls `DerefMut`.
This commit converts all the `&mut Diagnostic` occurrences to `&mut
DiagnosticBuilder`. This is a step towards greatly simplifying
`Diagnostic`. Some of the relevant function are made generic, because
they deal with both errors and warnings. No function bodies are changed,
because all the modifier methods are available on both `Diagnostic` and
`DiagnosticBuilder`.
2024-02-19 20:23:20 +11:00
Philipp Krones
c9a43b18f1
Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync
2023-12-01 18:21:58 +01:00
Philipp Krones
6246f0446a
Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup
2023-11-16 19:13:24 +01:00
Philipp Krones
d6d530fd0b
Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup
2023-07-17 10:22:32 +02:00
Takayuki Maeda
4bcaddeeb2
separate the receiver from arguments in HIR under /clippy
2022-09-05 22:25:57 +09:00
Jason Newcomb
fb41bfa774
Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup
2022-08-31 09:24:45 -04:00
Cameron Steffen
82f613ee3b
Remove a span from hir::ExprKind::MethodCall
2022-01-21 07:48:10 -06:00
Cameron Steffen
eb80da175c
Fix Visitor::NestedFilter in Clippy
2022-01-16 16:02:36 -06:00
flip1995
8fea1d94f3
Merge commit 'a5d597637dcb78dc73f93561ce474f23d4177c35' into clippyup
2021-12-06 12:33:31 +01:00
Cameron Steffen
e165c12932
Make diangostic item names consistent
2021-10-02 19:38:19 -05:00
flip1995
091ed44b50
Merge commit '27afd6ade4bb1123a8bf82001629b69d23d62aff' into clippyup
2021-09-08 16:31:47 +02:00
Cameron Steffen
ae02282ad0
Fix clippy let expressions fallout
2021-08-19 14:17:05 -05:00
Caio
b97d4c062b
Introduce hir::ExprKind::Let - Take 2
2021-08-15 16:18:26 -03:00
flip1995
2b20f49841
Merge commit '0cce3f643bfcbb92d5a1bb71858c9cbaff749d6b' into clippyup
2021-07-29 12:16:06 +02:00
flip1995
ebe52869a3
Merge commit '61eb38aeda6cb54b93b872bf503d70084c4d621c' into clippyup
2021-07-01 18:17:38 +02:00
flip1995
f6d1f368db
Merge commit 'b40ea209e7f14c8193ddfc98143967b6a2f4f5c9' into clippyup
2021-04-08 17:50:13 +02:00
flip1995
9f6b5de7de
Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup
2021-03-25 19:29:11 +01:00
flip1995
488153ff2f
Merge commit '953f024793dab92745fee9cd2c4dee6a60451771' into clippyup
2021-01-15 10:56:44 +01:00
Valentin Lazureanu
5a20489c5c
Rename TypeckTables to TypeckResults.
2020-07-17 08:47:04 +00:00
flip1995
6f25adbd5a
Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup
2020-07-14 14:59:59 +02:00
Eduard-Mihai Burtescu
30c046ede4
Use 'tcx for references to AccessLevels wherever possible.
2020-07-03 00:04:48 +03:00
Eduard-Mihai Burtescu
f5ce0e5fe9
rustc_lint: only query typeck_tables_of when a lint needs it.
2020-06-26 02:56:23 +03:00
Aaron Hill
6b3ee8f600
Update Clippy for MethodCall changes
2020-06-10 17:30:11 -04:00
Philipp Hansch
0480ff861a
More diagnostic items
...
In particular for:
* `VecDeque`
* `String`
* `Mutex`
* `HashMap`
* `HashSet`
cc https://github.com/rust-lang/rust/pull/71414 https://github.com/rust-lang/rust-clippy/issues/5393
2020-04-26 13:44:08 +02:00
Devin R
489dd2e504
factor ifs into function, add differing mutex test
2020-04-20 15:08:44 -04:00
Devin R
d1b1a4c5eb
update span_lint_and_help call to six args
2020-04-20 06:49:59 -04:00
Devin R
a9f1bb43ef
test for mutex eq, add another test case
2020-04-20 06:30:01 -04:00
Devin R
ae820924c4
use if chain
2020-04-20 06:30:01 -04:00
Devin R
4cebe2bf84
cargo dev fmt
2020-04-20 06:30:01 -04:00
Devin R
7242fa5e41
fix map import to rustc_middle
2020-04-20 06:30:01 -04:00
Devin R
1ee04e4f55
fix internal clippy warnings
2020-04-20 06:30:01 -04:00
Devin R
930619b484
change visitor name to OppVisitor
2020-04-20 06:30:01 -04:00
Devin R
c6c77d9a42
use Visitor api to find Mutex::lock calls
2020-04-20 06:30:00 -04:00
Devin R
fca3537fa3
add note about update-all-refs script, revert redundant pat to master
2020-04-20 06:30:00 -04:00
Devin R
51c2325dd7
move closures to seperate fns, remove known problems
2020-04-20 06:30:00 -04:00
Devin R
40bbdffc89
use span_lint_and_help, cargo dev fmt
2020-04-20 06:30:00 -04:00
Devin R
139e2c6227
creating suggestion
2020-04-20 06:30:00 -04:00
Devin R
001a42e632
progress work on suggestion for auto fix
2020-04-20 06:29:59 -04:00
