Commit Graph

6385 Commits

Author SHA1 Message Date
Jerry Hardee
8adbf7f2c1 Fix float_cmp false positive when comparing signum
f1.signum() == f2.signum()
f1.signum() != f2.signum()
should not trigger a warning.
2019-07-15 12:46:58 -05:00
flip1995
1c87df486e
grep only lines, that start with 'changelog: ' 2019-07-15 19:39:59 +02:00
flip1995
61ca901e51
Get PR number from bors commit message 2019-07-15 19:39:59 +02:00
flip1995
cb6cec5695
Authenticate with github_api_token 2019-07-15 19:39:59 +02:00
flip1995
a0f6c9361b
Check PRs for changelog entry in the body 2019-07-15 19:39:58 +02:00
daxpedda
6c067bf50e
false positives fixes of implicit_return
-  Handle returning macro statements properly
-  Handle functions that return never type
-  Handle functions that panic but do not return never type
2019-07-15 16:02:50 +02:00
bors
a73bb33399 Auto merge of #4273 - mikerite:deny-warnings, r=flip1995
Deny warnings in CI

changelog: none
2019-07-15 07:51:29 +00:00
Michael Wright
b523d35d41 Deny warnings in CI 2019-07-15 07:35:02 +02:00
bors
48b50e80b1 Auto merge of #3418 - phansch:add_travis_windows_build, r=me,flip1995
Fix Travis Windows build

Closes #3306
2019-07-15 05:20:34 +00:00
flip1995
ce2a7b0160
Disable dogfood on windows for faster build time on travis 2019-07-14 15:21:50 +02:00
flip1995
625051d3e7
Revert "Remove CARGO_INCREMENTAL=0 from windows build"
This reverts commit 876a7e1f01.

Using incremental build on windows increases the build time on travis by
about 8 minutes.
2019-07-14 15:13:47 +02:00
flip1995
876a7e1f01
Remove CARGO_INCREMENTAL=0 from windows build 2019-07-13 13:26:26 +02:00
flip1995
4817c2c381
Test with different sysroots dependent on the OS 2019-07-13 12:48:43 +02:00
flip1995
c100c70822
Build sys_root in driver with PathBuf instead of String 2019-07-13 12:48:42 +02:00
flip1995
6b8ebcc0c8
Don't re-set the LD_LIBRARY_PATH in base_tests.sh 2019-07-13 12:48:42 +02:00
flip1995
2991f31c17
Add master toolchain binaries to the PATH 2019-07-13 12:48:42 +02:00
Philipp Hansch
ac6e52a91c
Change conditional
Maybe uname == Linux was true on the windows VM?
This could be a way to avoid the secret environment variable issue with
Travis CI.
2019-07-13 12:48:42 +02:00
Philipp Hansch
bd2c76824d
Stop allowing failures in Travis windows build 2019-07-13 12:48:42 +02:00
bors
36fb646394 Auto merge of #4229 - euclio:lint-doc-generation-fix, r=flip1995
don't strip blank lines in lint documentation

changelog: don't strip blank lines in lint documentation

Fixes #4116.

This PR also switches the docs headings to deterministically display in the order that they are declared in the source, with "Configuration" always appearing last. It doesn't seem like there was a defined order before.
2019-07-13 10:05:15 +00:00
bors
3267e054da Auto merge of #4232 - mikerite:dev-fmt-4, r=flip1995
Add dev fmt subcommand

changelog: none
2019-07-13 09:26:16 +00:00
bors
10b915fa7e Auto merge of #4268 - mikerite:fix-4260, r=flip1995
Fix bug in `implicit_hasher` causing crashes

Skip linting if the type is from an external macro. Closes #4260.

changelog: Fix bug in `implicit_hasher` causing crashes
2019-07-13 08:59:12 +00:00
Michael Wright
76d66e6413 Merge branch 'master' into dev-fmt-4 2019-07-13 09:20:54 +02:00
bors
b0290424bb Auto merge of #4269 - lzutao:rustup, r=flip1995
Rustup `macro expansion and resolution`

Rustup https://github.com/rust-lang/rust/pull/62476

changelog: none
2019-07-12 07:26:03 +00:00
Lzu Tao
27c5348793 Rustup macro expansion and resolution 2019-07-12 00:26:36 +07:00
Michael Wright
de7749832c Fix bug in implicit_hasher causing crashes
Skip linting if the type is from an external macro. Closes #4260.
2019-07-11 08:47:05 +02:00
Michael Wright
2c90083f62 Avoid rustfmt bug on Windows 2019-07-11 05:21:44 +00:00
uHOOCCOOHu
a9bec0c8a6
Ignore generated fresh lifetimes in elision check. 2019-07-10 01:57:25 +08:00
bors
032ae96856 Auto merge of #4257 - skade:improve-cast-alignment, r=flip1995
Improve cast_ptr_alignment lint

<!--
Thank you for making Clippy better!

We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.

If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `util/dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo fmt`

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

Delete this line and everything above before opening your PR -->

* print alignment in bytes in the lint message
* ignore ZST left-hand types

Fixes #3797 and #4256
changelog:
* `cast_ptr_alignment`: Print alignment in bytes in the lint message
* `cast_ptr_alignment`: Ignore casting from ZST left-hand types
2019-07-09 15:28:26 +00:00
Florian Gilcher
aa72cac87a
Improve cast_ptr_alignment lint
* print alignment in bytes in the lint message
* ignore ZST left-hand types
2019-07-09 17:02:26 +02:00
bors
f0d217026a Auto merge of #4265 - vks:patch-1, r=flip1995
cast_ptr_alignment: Mention legal use under known problems

Refs #2881.

changelog: Mention know problems for cast_ptr_alignment
2019-07-09 13:15:29 +00:00
Vinzent Steinberg
f831b0979e
cast_ptr_alignment: Mention legal use under known problems
Refs #2881.
2019-07-09 14:48:48 +02:00
bors
5f890d44f5 Auto merge of #4264 - flip1995:appveyor, r=flip1995
Disable AppVeyor builds on the master branch

AppVeyor is already checked on every merge of a PR, rechecking it
immediately after on the master branch is not necessary.

Resolves #4263

changelog: none
2019-07-09 11:40:43 +00:00
flip1995
70cffef3b2
Disable AppVeyor builds on the master branch
AppVeyor is already checked on every merge of a PR, rechecking it
immediately after on the master branch is not necessary.
2019-07-09 13:34:22 +02:00
bors
5c921a9f61 Auto merge of #4233 - thiagoarrais:jens1o-fix-1208, r=phansch,flip1995
Avoid reporting string_lit_as_bytes for long strings

Port of @jens1o code ([b76f939][jens1o_commit])

Fixes #1208

[jens1o_commit]: b76f939ac2

<!--
Thank you for making Clippy better!

We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.

If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `cargo fmt`

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

Delete this line and everything above before opening your PR -->

changelog: bugfix for long strings as bytes
2019-07-09 09:48:33 +00:00
bors
1987bf73a8 Auto merge of #4262 - bara86:master, r=flip1995
Use empty block instead of unit type for needless return

fixes #4238

changelog: Use empty block instead of unit type for needless return
2019-07-09 09:10:07 +00:00
Thiago Arrais
7d1a9447ea Extract semantic constant 2019-07-08 17:51:13 -03:00
Bara
2fb73fe037 Use empty block instead of unit type for needless return 2019-07-08 20:45:51 +02:00
Jens Hausdorf
6d1aaac6c3 Avoid reporting string_lit_as_bytes for long strings
Port of @jens1o code ([b76f939][jens1o_commit])

Fixes #1208

[jens1o_commit]: b76f939ac2

Co-authored-by: Thiago Arrais <thiago.arrais@gmail.com>
2019-07-08 13:13:01 -03:00
Michael Wright
186b5b2ee2 Add rustfmt nightly to appveyor install 2019-07-08 07:20:11 +02:00
Michael Wright
c0c2a8d9c1
Work around rustup fallback error on Windows 2019-07-07 15:11:38 +02:00
flip1995
3977843ab5
Update documentation to the dev fmt command 2019-07-07 15:11:38 +02:00
Michael Wright
0c00391ed0
Remove format checks from CI scripts again. 2019-07-07 15:11:38 +02:00
Michael Wright
503474a647
Remove format checks from CI script 2019-07-07 15:11:37 +02:00
Michael Wright
aeac3da2c1
Improve fmt test failure message 2019-07-07 15:11:37 +02:00
Michael Wright
11707f3443
Fix crash on dev --limit-stderr-length 2019-07-07 15:11:37 +02:00
Michael Wright
4c771c3478
Add dev fmt subcommand 2019-07-07 15:11:33 +02:00
bors
316da7eb41 Auto merge of #4258 - mikerite:fix-breakage-20190706, r=Manishearth
Fix breakage due to rust-lang/rust#61988

changelog: none
2019-07-07 02:25:07 +00:00
Michael Wright
c72be0f65a rustfmt 2019-07-06 19:43:34 +02:00
Michael Wright
adcc02ed8a Address reviews 2019-07-06 19:35:08 +02:00
Michael Wright
0579c3e0aa Fix breakage due to rust-lang/rust#61988 2019-07-06 19:06:49 +02:00