flip1995
c6a577ea11
Merge remote-tracking branch 'upstream/master' into rustup
2020-11-24 17:05:01 +01:00
bors
53ce1dd719
Auto merge of #79228 - flip1995:clippyup, r=oli-obk
...
Update Clippy
Biweekly Clippy update
r? `@Manishearth`
2020-11-24 06:56:02 +00:00
bors
295fe28057
Auto merge of #6313 - giraffate:fix_fp_needless_collect, r=ebroto
...
Fix FP in indirect `needless_collect` when used multiple times
Fix https://github.com/rust-lang/rust-clippy/issues/5991
Fix https://github.com/rust-lang/rust-clippy/issues/6297
changelog: Fix FP in indirect `needless_collect` when used multiple times
2020-11-23 22:26:45 +00:00
bors
d5b40bf469
Auto merge of #78343 - camelid:macros-qualify-panic, r=m-ou-se
...
Qualify `panic!` as `core::panic!` in non-built-in `core` macros
Fixes #78333 .
-----
Otherwise code like this
#![no_implicit_prelude]
fn main() {
::std::todo!();
::std::unimplemented!();
}
will fail to compile, which is unfortunate and presumably unintended.
This changes many invocations of `panic!` in a `macro_rules!` definition
to invocations of `$crate::panic!`, which makes the invocations hygienic.
Note that this does not make the built-in macro `assert!` hygienic.
2020-11-23 22:05:28 +00:00
Eduardo Broto
209ab1885c
Merge remote-tracking branch 'upstream/master' into rustup
2020-11-23 23:02:12 +01:00
Camelid
d708b444e4
Qualify panic! as core::panic! in non-built-in core macros
...
Otherwise code like this
#![no_implicit_prelude]
fn main() {
::std::todo!();
::std::unimplemented!();
}
will fail to compile, which is unfortunate and presumably unintended.
This changes many invocations of `panic!` in a `macro_rules!` definition
to invocations of `$crate::panic!`, which makes the invocations hygienic.
Note that this does not make the built-in macro `assert!` hygienic.
2020-11-23 11:28:25 -08:00
bors
58a2bc45d7
Auto merge of #6369 - camsteffen:cast-cfg, r=Manishearth
...
Disable unnecessary_cast for cfg-dependant types
changelog: Disable unnecessary_cast for cfg-dependant types
Fix #6331
2020-11-23 16:33:13 +00:00
bors
723ac0faf1
Auto merge of #6317 - chansuke:add-external-macro, r=llogiq
...
Add exteranal macros for as_conversions
Added external macros to this PR https://github.com/rust-lang/rust-clippy/pull/4888 .
r? `@llogiq`
changelog: none
2020-11-23 13:26:28 +00:00
flip1995
284c359c61
Fix ICE in utils::implements_trait
...
This only happend when debug_assertions were enabled in rustc
2020-11-23 13:52:27 +01:00
flip1995
d3d2018ead
Merge commit '3e7c6dec244539970b593824334876f8b6ed0b18' into clippyup
2020-11-23 13:51:04 +01:00
Cameron Steffen
a39a93faeb
Disable unnecessary_cast for cfg-dependant types
2020-11-22 19:35:04 -06:00
Lzu Tao
4b698f2069
Drop support for cloudabi targets
2020-11-22 17:11:41 -05:00
oliver
e30bb7661d
update
2020-11-22 00:50:09 -04:00
bors
8325d48d2d
Auto merge of #6351 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
changelog: none
2020-11-20 09:07:56 +00:00
flip1995
dd4e471b3f
Properly deprecate panic_params lint
2020-11-20 09:37:47 +01:00
Mara Bos
78faaef8de
Remove the clippy::panic-params lint.
...
Rustc itself now warns for all cases that triggered this lint.
2020-11-19 18:34:40 +01:00
Takayuki Nakata
6494bd0bac
Revert "Add rustfmt::skip as a work around"
...
This reverts commit 0e803417f9https://github.com/rust-lang/rustfmt/issues/4528 .
2020-11-18 12:36:47 +09:00
bors
44d944586c
Auto merge of #6070 - matsujika:unnecessary_wrap, r=flip1995
...
Add new lint `unnecessary_wrap`
Fixes #5969
changelog: New lint [`unnecessary_wraps`]
2020-11-17 20:28:32 +00:00
Camelid
4e4c4fb8aa
Fix handling of panic calls
...
This should make Clippy more resilient and will unblock #78343 .
This PR is made against rust-lang/rust to avoid the need for a subtree
sync at @flip1995's suggestion in rust-lang/rust-clippy#6310 .
2020-11-17 12:16:15 -08:00
bors
5464cbed2f
Auto merge of #6337 - ThibsG:FixIce6332, r=Manishearth
...
Remove `expect()` calls to avoid ICEs in `deref_addrof` lint
Fixes : #6332
changelog: none
2020-11-17 17:55:46 +00:00
Hirochika Matsumoto
c7445d7f2c
Pluralize lint name
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
1f577c0300
Fix embarrassing grammatical error
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
4e5c02e898
Ignore trait implementations
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
4c8d248190
Update stderr files
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
86331a46e4
Update stderr files
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
30632fb8e6
Allow this lint on lint tests
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
c5447eb3c1
Make lint skip macros
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
12474c62ff
Add support for methods
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
1bdac87128
Improve lint message
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
6b55f3fec9
Add test case
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
cdb72df6f9
Split lint suggestion into two
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
6a62390c86
Optout rustfix test
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
0e9d227c04
Add test cases
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
750c118b34
Add suggestion on type signatures
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
a7ac441760
Add new lint to detect unnecessarily wrapped value
2020-11-18 01:28:37 +09:00
ThibsG
5b8f2b6c93
Remove expect() calls to avoid ICEs in deref_addrof lint
2020-11-16 23:30:11 +01:00
bors
ad4f82997a
Auto merge of #6119 - rsulli55:find_is_some_on_strs, r=flip1995
...
Add a case to `lint_search_is_some` to handle searching strings
Fixes : #6010
This adds a lint which recommends using `contains()` instead of `find()` followed by `is_some()` on strings as suggested in #6010 .
This was added as an additional case to
5af88e3c2d/clippy_lints/src/methods/mod.rs (L3037)
2020-11-16 08:45:10 +00:00
bors
df3bb5881d
Auto merge of #6336 - giraffate:sync-from-rust, r=flip1995
...
Rustup
changelog: none
2020-11-16 08:23:27 +00:00
Takayuki Nakata
0e803417f9
Add rustfmt::skip as a work around
...
because comments are checked and removed by rustfmt for some reason
2020-11-16 12:32:16 +09:00
bors
db0464103e
Auto merge of #6334 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
changelog: none
2020-11-15 13:09:53 +00:00
bors
0c7a48c5f0
Auto merge of #78809 - vn-ki:fix-issue-76064, r=oli-obk
...
add error_occured field to ConstQualifs,
fix #76064
I wasn't sure what `in_return_place` actually did and not sure why it returns `ConstQualifs` while it's sibling functions return `bool`. So I tried to make as minimal changes to the structure as possible. Please point out whether I have to refactor it or not.
r? `@oli-obk`
cc `@RalfJung`
2020-11-14 18:03:17 +00:00
bors
408b615d34
Auto merge of #6320 - giraffate:fix_suggestion_in_manual_range_contains_using_float, r=llogiq
...
Fix suggestion in `manual_range_contains` when using float
Fix #6315
changelog: Fix suggestion in `manual_range_contains` when using float
2020-11-14 08:06:00 +00:00
Vishnunarayan K I
7987f39ad5
update clippy test ouput
2020-11-13 17:11:13 +05:30
bors
cf7b4b0fe6
Auto merge of #6329 - giraffate:sync-from-rust, r=matthiaskrgr
...
Rustup
changelog: none
2020-11-13 10:49:21 +00:00
Takayuki Nakata
8f89108533
Fix FP in indirect needless_collect when used multiple times
2020-11-12 23:29:16 +09:00
Takayuki Nakata
5f64867e1d
Fix suggestion in manual_range_contains when using float
2020-11-11 22:44:48 +09:00
Fabian Zaiser
5f310d9b83
Implement destructuring assignment for structs and slices
...
Co-authored-by: varkor <github@varkor.com>
2020-11-11 12:10:52 +00:00
Ryan Sullivant
5c1c50ee17
Change variable named foo and rerun update-all-references
2020-11-10 23:48:01 -07:00
Ryan Sullivant
fd303132a2
Cleaned up message and suggestion for lint_search_is_some
2020-11-10 23:18:48 -07:00
Ryan Sullivant
ee1b959054
Added period back to lint search_is_some and ran
...
`update-all-references.sh`
2020-11-10 23:18:47 -07:00
