Commit Graph

493 Commits

Author SHA1 Message Date
Caleb Zulawski
c504f01abe Use cast and improve comments 2023-04-25 21:37:04 -04:00
Caleb Zulawski
394a8845c6 Fix {to,from}_array UB when repr(simd) produces padding 2023-04-23 14:52:38 -04:00
Jubilee
ad8afa8c81
lane -> element for core::simd::Simd (rust-lang/portable-simd#338) 2023-04-22 19:07:46 -07:00
Jubilee
4f0d8225fa
Implement dynamic byte-swizzle prototype (rust-lang/portable-simd#334)
This is meant to be an example that is used to test
a Rust intrinsic against, which will replace it.
The interface is fairly direct and doesn't address
more nuanced or interesting permutations one can do,
nevermind on types other than bytes.

The ultimate goal is for direct LLVM support for this.
2023-04-22 18:27:52 -07:00
Jubilee Young
2b32732d0f Do not construct Simd 2023-04-22 18:22:04 -07:00
Jubilee Young
4064678daf Explain why to use Simd early 2023-04-22 17:58:54 -07:00
Jubilee
92259a4a6c Clarify elementwise cmp reduces
Saying "elementwise (non-)equal" may suggest it returns a vector.
The comments should be clear that it instead reduces to a scalar.

Co-authored-by: Jacob Lifshay <programmerjake@gmail.com>
2023-04-22 17:58:54 -07:00
Jubilee Young
71d4c36850 lane -> element for core::simd::Simd
A while ago we began saying T, N instead of T, LANES in reference to Simd.
At some point that leaked in to us checking in code with const N: usize.
After a while, we had a discussion and agreed that "lanes", while common,
is unnecessary jargon for Rust learners who aren't familiar with SIMD, and
is fully interchangeable with terms for arrays like element and index.

But we never acted on that. Let's update the main type's docs, at least.
The example tweaks also enable removing a slated-for-removal nightly fn.
2023-04-22 17:58:51 -07:00
Jubilee
f916add75d
Don't use direct field access in Simd functions (rust-lang/portable-simd#339)
Also see: https://rust-lang.zulipchat.com/#narrow/stream/257879-project-portable-simd/topic/splat.20no.20longer.20compiles.20for.20release.20builds
2023-04-22 17:55:38 -07:00
Markus Everling
f1b86baf84 Use pointer reads for better codegen in debug mode 2023-04-22 23:29:23 +00:00
Markus Everling
52833ccbe8 Add notes to avoid direct field accesses 2023-04-22 23:08:55 +00:00
Markus Everling
afad9c3f64 Don't use direct field access in Simd functions 2023-04-22 21:40:36 +00:00
Jubilee
ceb2611592
Remove formats [T; N] does not impl (rust-lang/portable-simd#337)
Remove these extra formatting traits, as they are
inconsistent with how arrays and slices format,
and it can cause unnecessary code bloat in binaries.
We can revisit this if people ever agree on doing these
formatters for the other slice-y types.

Prefer to dispatch to the `impl `fmt::Debug for [T]`,
to reduce the chances of monomorphizing twice.
Inlining it seems like a good idea for similar reasons?
2023-04-09 21:26:40 -07:00
Caleb Zulawski
90f2af774a Fix lint 2023-03-26 16:11:05 -04:00
Caleb Zulawski
e6bbf49ba9
Merge pull request #336 from bjorn3/faster_tests
Skip building wasm-bindgen-test on non-wasm targets
2023-03-26 09:33:53 -04:00
bjorn3
65b5210bdb Skip building wasm-bindgen-test on non-wasm targets
This reduces compilation time
2023-03-26 12:56:35 +02:00
Caleb Zulawski
8dcb4d5ef7
Merge pull request #331 from rust-lang/to_slice
Add copy_to_slice
2023-03-11 12:02:15 -05:00
Caleb Zulawski
36829ddca7 Check that vectors aren't padded 2023-02-19 15:35:36 -05:00
Caleb Zulawski
0fd7c8e138 Add copy_to_slice 2023-02-19 12:33:40 -05:00
Caleb Zulawski
9bd30e77b3
Merge pull request #327 from howjmay/typo
Fix the typo
2023-01-22 23:22:58 -05:00
Yang Hau
e3ef226f7b Fix the typo 2023-01-23 11:00:35 +07:00
Jubilee
582239ac3b
Merge pull request #128 from miguelraz/dotprodexample
add dot_product example
2022-12-04 12:25:09 -08:00
The Atelier
da3bd6d3a0 Update dot_product example import 2022-12-03 18:41:43 -08:00
Miguel Raz Guzmán Macedo
64247a327d add _scalar names for dot_product examples 2022-12-03 16:12:24 -08:00
Miguel Raz Guzmán Macedo
aeac9ed373 proper mul_add arg order, added tests 2022-12-03 16:12:24 -08:00
Miguel Raz Guzmán Macedo
4ddfd2f3f8 non allocating fold simd
allocating fold with std::ops::Add::add
2022-12-03 16:12:19 -08:00
Miguel Raz Guzmán Macedo
4615805ec2 add remainder dot_product and cleanup
cleanup dot_product and README.md
2022-12-03 16:12:00 -08:00
Miguel Raz Guzmán Macedo
c08a4d1f10 add more basic dot products and comments, README 2022-12-03 16:12:00 -08:00
miguel raz
df3a63906c add dot_product example 2022-12-03 16:12:00 -08:00
Caleb Zulawski
1547dd66f9
Merge pull request #318 from thomcc/simd_from_slice
Avoid a scalar loop in `Simd::from_slice`
2022-11-28 09:17:02 -05:00
Thom Chiovoloni
54b6f6923e
Avoid a scalar loop in Simd::from_slice 2022-11-28 06:03:32 -08:00
Caleb Zulawski
645ab61a16
Merge pull request #317 from rust-lang/fix-exports
Remove reexport of simd::*
2022-11-28 08:37:24 -05:00
Caleb Zulawski
db8b23cea5 Remove reexport of simd::* 2022-11-27 23:44:20 -05:00
Caleb Zulawski
6e30c6eca3
Merge pull request #315 from rust-lang/scatter-gather-ptr
Scatter/gather for pointers
2022-11-19 21:37:58 -05:00
Caleb Zulawski
7e614f0438 Fix typo typo 2022-11-12 22:41:44 -05:00
Caleb Zulawski
c247915eb8
Update crates/core_simd/src/vector.rs
Co-authored-by: Jubilee <46493976+workingjubilee@users.noreply.github.com>
2022-11-12 22:39:54 -05:00
Caleb Zulawski
bef4c41fc0 Add test examples 2022-11-11 21:31:05 -05:00
Caleb Zulawski
35c60ce669
Merge pull request #314 from rust-lang/try-from-slice
impl TryFrom<&[T]> for Simd
2022-11-11 19:48:46 -05:00
Caleb Zulawski
fd53445d05 Add pointer scatter/gather 2022-11-11 19:48:27 -05:00
Caleb Zulawski
9dc690c482 Add TryFrom<&[T]> tests 2022-11-11 18:10:51 -05:00
Caleb Zulawski
7ac1fbbcb1 impl TryFrom<&[T]> for Simd 2022-11-11 17:32:48 -05:00
Caleb Zulawski
ecc28752e8
Merge pull request #313 from rust-lang/pointer-tests
Add missing pointer tests and rename pointer cast fns to match scalars
2022-11-09 22:10:23 -05:00
Caleb Zulawski
572122a95d Add missing pointer tests and rename pointer cast fns to match scalars 2022-11-09 21:28:38 -05:00
Caleb Zulawski
de30820035
Update README.md 2022-10-29 21:39:08 -04:00
Caleb Zulawski
87779aef0b
Merge pull request #287 from rust-lang/feature/pointer-vectors
Vectors of pointers
2022-10-29 17:51:36 -04:00
Caleb Zulawski
469c620bde Account for pointer metadata in pointer bounds 2022-10-29 11:55:01 -04:00
Caleb Zulawski
078cb58e76 Apply suggestions from code review
Co-authored-by: Jacob Lifshay <programmerjake@gmail.com>
2022-10-29 11:55:01 -04:00
Caleb Zulawski
a79718ffa8 Use new intrinsics 2022-10-29 11:55:01 -04:00
Caleb Zulawski
0fcc4069c1 Fix pointer mutability casts and safety lints 2022-10-29 11:55:01 -04:00
Caleb Zulawski
e5db1ecc82 Fix documentation 2022-10-29 11:55:01 -04:00