rainy-me
c1685e56b7
fix: remove lookup and handle mut kw case
2022-04-27 18:54:57 +09:00
Lukas Wirth
4255996965
Re-export FxHashMap
and FxHashSet
from ide_db
2022-04-25 18:51:59 +02:00
Lukas Wirth
8154365b00
minor: Remove either dependency from ide_completion
2022-04-25 18:40:38 +02:00
bors
1d2bd0e379
Auto merge of #12071 - Ma124:fix-tabs-snippet, r=jonas-schievink
...
Change tabs to spacs in macro_rules snippet
This PR changes the `macro_rules!` snippet to use spaces instead of tabs.
The other snippets like [this one][test-snippet] already use spaces.
The snippet was introduced in 5575588
where no reason is provided to use tabs.
[test-snippet]: https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide_completion/src/completions/snippet.rs#L70=
2022-04-25 12:44:49 +00:00
Jonas Schievink
3a83684a16
Reduce priority of flyimport completions
2022-04-25 14:34:54 +02:00
Ma_124
b06c95aeda
Change tabs to spacs in macro_rules snippet
2022-04-24 15:18:31 +02:00
bors
c606229241
Auto merge of #12060 - Veykril:completion-ctx, r=Veykril
...
minor: Simplify
bors r+
2022-04-23 00:29:18 +00:00
Lukas Wirth
ea45e54458
Simplify
2022-04-23 02:21:27 +02:00
rainy-me
8f8f20fda5
fix: lookup
2022-04-22 00:07:42 +09:00
rainy-me
a58f7acc97
fix: improve parameter completion
2022-04-20 17:56:20 +09:00
Lukas Wirth
f8c32df7cd
minor: Document completion context some more
2022-04-18 16:54:13 +02:00
bors
e0d41bc2a1
Auto merge of #12021 - Veykril:completion-ctx, r=Veykril
...
internal: Add a `NameContext` to `CompletionContext`, move out some ImmediateLocation variants
Continues the completion rewrite I started some time ago
(will merge tomorrow after stable since our completion tests still let a lot through)
2022-04-18 14:00:56 +00:00
XFFXFF
fedd0245d1
derive completions take existing derives into count
2022-04-18 21:34:36 +08:00
Lukas Wirth
ff667c7228
internal: Add a NameContext
to CompletionContext
, move out some ImmediateLocation variants
2022-04-17 21:53:58 +02:00
iDawer
d26deb5b9f
Show impl Trait
in argument positon in completion details
...
`hir`: Use `db.callable_item_signature` query more.
2022-04-16 19:18:42 +05:00
iDawer
c53412046f
minor: address nit
2022-04-16 13:54:24 +05:00
iDawer
9d787e1bfe
Add hir::Function::async_ret_type
method
...
Adjust completion detail for `async fn` return types
2022-04-16 13:53:22 +05:00
iDawer
f972adc201
fix: comletion detail shows {unknown}
for impl Trait
in return position
2022-04-16 13:41:10 +05:00
Jonas Schievink
1fd232cd69
Enable ADT keyword completions in block expression
2022-04-14 18:39:27 +02:00
Jonas Schievink
a182156517
Add trailing ;
when completing assoc const/type
2022-04-12 18:28:43 +02:00
Jonas Schievink
3328a0a11b
Fix trait impl completions' lookup_by
text
2022-04-12 17:17:31 +02:00
Jonas Schievink
e66037f139
simplify
2022-04-12 15:34:12 +02:00
Jonas Schievink
63f87ff047
Deprioritize already-imported names
2022-04-11 18:48:27 +02:00
Jonas Schievink
22b13c8bff
Make trait item completions work in a bare impl and score them
2022-04-08 19:56:41 +02:00
Jonas Schievink
99d91bc550
flyimport: omit types when completing where-clause
2022-04-07 20:02:33 +02:00
Jonas Schievink
5d8b4c40eb
Determine function unsafety semantically
2022-04-07 18:33:03 +02:00
bors[bot]
f5c069c9d9
Merge #11894
...
11894: complete pattern args based on type name r=Veykril a=cameron1024
Addresses #11892
Changes function argument completion to cover a case like this:
```rust
struct Foo { bar: i32 }
fn qux(Foo { bar }: Foo) {
println!("{bar}");
}
```
When completing the function call for `qux`, instead of expanding to `qux(_)`, it will now expand to `qux(foo)` (based on the snake-cased version of the name of the ADT)
Non ADTs are unaffected
Co-authored-by: cameron <cameron.studdstreet@gmail.com>
Co-authored-by: cameron1024 <cameron.studdstreet@gmail.com>
2022-04-04 13:06:51 +00:00
cameron1024
37d2a8243f
Update crates/ide_completion/src/render/function.rs
...
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2022-04-04 13:33:14 +01:00
cameron
bb1c3a20b5
fix type error
2022-04-04 14:30:49 +01:00
cameron
2137bdfca3
remove unwarp on adt name
2022-04-04 14:28:15 +01:00
cameron
c735b979ed
complete pattern args based on type name
2022-04-04 13:51:51 +01:00
Aleksey Kladov
a8f460209d
add test for postfix completion relevance
...
Follow up to #11857 , add a test and cov-marks
2022-04-03 12:13:26 +01:00
hkalbasi
003a6b74e4
suggest infered type in auto complete
2022-04-03 11:17:33 +04:30
Lukas Wirth
f610e2c2ed
Simplify completion import insertion
2022-04-02 01:42:21 +02:00
Lukas Wirth
28251e486c
Cleanup relevance scoring
2022-04-02 01:19:33 +02:00
bors[bot]
a9ae0b0855
Merge #11857
...
11857: Lower postfix suggestions in completions list r=Veykril a=avrong
Fixes #11850
Adds a parameter for postfix suggestions in `CompletionRelevance`, and basing on it, decreases relevance score of such items in completion list
Co-authored-by: Aleksei Trifonov <avrong@avrong.me>
2022-04-01 21:42:54 +00:00
Aleksei Trifonov
eda4046a05
Introduce postfix item types
2022-04-01 20:50:27 +03:00
Lukas Wirth
75689f2ad8
internal: Enforce Resolver to always have a module scope
2022-03-31 11:12:08 +02:00
Aleksei Trifonov
41d8369d1c
Fix formatting
2022-03-31 02:59:15 +03:00
Aleksei Trifonov
0d1f4f9b27
Lower postfix suggestions in completions list
2022-03-31 02:27:33 +03:00
Lukas Wirth
ef92453dfe
internal: Refactor FamousDefs builtin crate search
2022-03-30 22:23:54 +02:00
Florian Diebold
9a427839fa
fix: Disable ref_match for qualified paths as well
...
I.e. don't suggest `Foo::&foo()`.
CC #8058 .
2022-03-27 12:50:55 +02:00
Lukas Wirth
9b046d1051
fix: Don't complete Drop::drop for qualified paths
2022-03-26 18:46:49 +01:00
bors[bot]
652233283b
Merge #11791
...
11791: fix: some fixes and improvements to signature help r=jonas-schievink a=jonas-schievink
bors r+
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
2022-03-23 00:36:11 +00:00
bors[bot]
c2ea378920
Merge #11795
...
11795: fix: Correctly suggest auto importing traits from aliases r=Veykril a=unexge
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/11506
Co-authored-by: unexge <unexge@gmail.com>
2022-03-22 21:44:06 +00:00
unexge
4e4c9ea4ac
fix: Correctly suggest auto importing traits from aliases
2022-03-22 22:30:29 +01:00
Lukas Wirth
8e91bb7660
minor: Bump dependencies
2022-03-22 17:42:24 +01:00
Jonas Schievink
b7cc9a7275
Trigger call info when completing generic type
...
Closes #11763
2022-03-22 16:10:17 +01:00
Lukas Wirth
000e681d5f
fix: Fix tuple- and record struct completions not working with existing braces
2022-03-21 22:01:26 +01:00
Lukas Wirth
7370a6b5b8
fix: Fix flyimport showing functions in pattern position
2022-03-21 19:41:39 +01:00