Commit Graph

3715 Commits

Author SHA1 Message Date
Jonathan Goodman
40c6f431da add new lint else_if_without_else 2018-01-14 22:53:00 -06:00
Adam Lusch
f343cd22f6 Adds the missing turbofish 2018-01-14 20:19:55 -08:00
Adam Lusch
30de2e7106 Update UI test expected output 2018-01-14 20:10:36 -08:00
Adam Lusch
1615813960 Moves clone_on_ref_ptr to be a restriction lint
Also updates the suggestion to include the full type (e.g. `Arc<Foo>::clone(&rc)`)
and adds a case using trait objects to the UI tests.
2018-01-14 19:58:09 -08:00
Phil Ellison
ad164939ed Check that we're calling Iterator::fold 2018-01-14 20:04:34 +00:00
Phil Ellison
70a5535ffa Address some review comments 2018-01-14 18:18:09 +00:00
Phil Ellison
360f2359d5 Fix name 2018-01-14 15:30:06 +00:00
Oliver Schneider
2f62d803ab
Merge pull request #2349 from rust-lang-nursery/no-main-doc
Don't warn about missing docs for main()
2018-01-14 13:16:54 +01:00
Phil Ellison
7e833ea5ce Add description 2018-01-14 10:07:41 +00:00
Phil Ellison
528be23c07 Move get_arg_name into utils 2018-01-14 10:05:01 +00:00
Phil Ellison
1feb9fd550 Tidy using if_chain and snippet function. Actually check that the initial fold value is false. Remove some unwraps 2018-01-14 09:30:08 +00:00
Phil Ellison
f6e56d2559 First pass at linting for .any expressed as a .fold 2018-01-14 08:27:53 +00:00
Manish Goregaokar
7e63f93d81 Don't warn about missing docs for main()
Fixes #2348
2018-01-14 11:35:08 +05:30
Oliver Schneider
cc9008b7d4
Merge pull request #2347 from kimsnj/extrem_comp
Fix #1159: avoid comparing fixed and target sized types in lint
2018-01-13 12:27:36 +01:00
kimsnj
53c0ae0169 Fix #1159: avoid comparing fixed and target sized types in lint 2018-01-12 18:33:25 +01:00
Oliver Schneider
b863a00a4e
Merge pull request #2344 from HMPerson1/svar_to_cfn
Add lint to replace `const`s with `const fn`s
2018-01-12 14:59:06 +01:00
Oliver Schneider
7e21663f75
Merge pull request #2296 from DarrenTsung/test_types
Start regression tests for types.rs
2018-01-12 14:55:39 +01:00
Manish Goregaokar
c66eaee77c Nightly only 2018-01-12 16:03:13 +05:30
HMPerson1
8505ee7028 Add lint to replace consts with const fns 2018-01-11 12:03:46 -05:00
Oliver Schneider
1245de1e46
Don't suggest changing explicit Clone impls if they have generics 2018-01-11 10:28:42 +01:00
Oliver Schneider
41a710e3f4
Version bump 2018-01-10 09:50:58 +01:00
Oliver Schneider
75c92aa2d2
Fix an ICE in HashMap generalization suggestions 2018-01-09 14:57:44 +01:00
Oliver Schneider
4603e60fca
Merge pull request #2316 from tspiteri/doc-names
Add "NaNs" and "GitLab" to `doc-valid-idents`
2018-01-09 09:10:18 +01:00
Oliver Schneider
18f3f0dd62
Version bump 2018-01-08 11:43:01 +01:00
Oliver Schneider
25e5b9f78e
Merge pull request #2328 from phansch/master
Split up casting UI tests
2018-01-08 11:06:28 +01:00
Oliver Schneider
64af362ab0
Merge pull request #2334 from Rantanen/ast-fix
Implement nightly libsyntax changes to fix the build
2018-01-08 10:56:07 +01:00
Manish Goregaokar
752c02d35d
Merge pull request #2339 from phansch/add_some_lint_examples
Add 'positive' examples for some lints
2018-01-08 15:09:33 +05:30
Philipp Hansch
1a16ac058d
Add 'positive' examples for some lints
This allows to see at a quick glance what the improved code could look
like for these lints.
2018-01-08 10:20:04 +01:00
Martin Carton
53b77071d0
Merge pull request #2337 from phansch/update_readme
Add link to lints in README configuration section
2018-01-07 14:12:34 +01:00
Philipp Hansch
ab5b7dd7c1
Add link to lints in README configuration section
The wiki has been deprecated.
2018-01-07 12:55:40 +01:00
Mikko Rantanen
91ecb3b8ed
Implement nightly libsyntax changes 2018-01-07 05:58:53 +02:00
Philipp Hansch
fded77d85e
Split up casting UI tests
Part of #2038
2018-01-06 11:22:20 +01:00
Oliver Schneider
5815681b38
Merge pull request #2326 from mikerite/fix_travis_macos
Fix Travis CI build
2018-01-06 10:59:08 +01:00
Michael Wright
1afbe3203c Fix build
Added comment
2018-01-06 08:31:39 +02:00
Michael Wright
80f86633a9 Make style consistent 2018-01-06 08:14:52 +02:00
Michael Wright
5068a1252d Fix build
Adding gpg key import.
2018-01-04 21:17:04 +02:00
Michael Wright
6802232e28 Fix build
Trying the work-around suggested at
https://github.com/travis-ci/travis-ci/issues/6307 to fix the Travis CI
MacOS build.
2018-01-04 20:39:31 +02:00
Manish Goregaokar
29c6093ef0
Merge pull request #2324 from killercup/feature/2319-suggest-empty-println
Add auto-fixable `println!()` suggestion
2018-01-04 12:08:54 +00:00
Pascal Hertleif
82d91c5fcb Add auto-fixable println!() suggestion
Fixes #2319
2018-01-04 12:46:26 +01:00
Trevor Spiteri
a5d0569a20 Add "NaNs" and "GitLab" to doc-valid-idents 2018-01-02 13:51:35 +01:00
llogiq
ca3d6dd51a
Merge pull request #2312 from zmt00/master
Fix typos in README, documentation
2018-01-01 22:51:04 +00:00
zmt00
a7f423b114 Fix typos in README, documentation 2018-01-01 13:55:40 -08:00
Oliver Schneider
1ecce2d803
Merge pull request #2307 from clarcharr/master
Rearrange README.md.
2017-12-27 23:28:04 +01:00
Clar Charr
8abf9647ce Rearrange README.md.
This suggests `cargo clippy` first, which is probably the best method at this point. It also describes how to enable clippy only when testing.
2017-12-27 11:06:40 -05:00
Michael Wright
6737bae9b1 Implemented option_option lint 2017-12-26 09:24:12 +02:00
Darren Tsung
0f4c40b229 Start regression tests for types.rs 2017-12-23 10:15:11 -08:00
Oliver Schneider
f0d0fc69de
Merge pull request #2291 from DarrenTsung/fix_2265
Fix #2265, ignore eq_op lint in macro invocation
2017-12-23 01:06:44 +01:00
Darren Tsung
b9abe028c9 Move in_macro check to end of expression since usual case is not inside macro 2017-12-22 10:54:52 -08:00
Darren Tsung
1f36aa519e Check that eq_op lint doesn’t mark macro use of functions as errors since macros, fix #2265 2017-12-22 10:51:41 -08:00
Darren Tsung
50eb48e42b Create failing test for equal inside macro 2017-12-22 10:37:44 -08:00