Aleksey Kladov
0650f77dd9
internal: remove one more immutable tree
2021-05-14 16:19:27 +03:00
Aleksey Kladov
ad0648dc95
Cleanup imports
2021-05-13 13:44:47 +03:00
Jonas Schievink
b8d40a02a9
Document viewCrateGraph request
2021-05-11 16:45:51 +02:00
Aleksey Kladov
d4a51241ce
internal: explain why sentence-per-line
2021-05-06 17:40:36 +03:00
Aleksey Kladov
3f6980e4e1
simplify macro expansion code
...
Using `Option` arguments such that you always pass `None` or `Some` at
the call site is a code smell.
2021-05-04 22:41:46 +03:00
bors[bot]
576f50637c
Merge #8605
...
8605: internal: Automatically categorize the changelog entries r=matklad a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-04-22 17:35:41 +00:00
Aleksey Kladov
27073f4fc3
feat: make sure nightly regressions don't break users
2021-04-22 11:15:20 +03:00
Laurențiu Nicola
39ce393a9e
Automatically categorize the changelog entries
2021-04-20 19:54:58 +03:00
bors[bot]
15b34667c5
Merge #8588
...
8588: internal: Add guidelines for release notes PR descriptions r=matklad a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-04-19 18:38:34 +00:00
Laurențiu Nicola
bb4952da04
internal: Add guidelines for release notes PR descriptions
2021-04-19 21:30:44 +03:00
Aleksey Kladov
dcb759b727
Remove confusion around serverStatusNotification
2021-04-19 18:12:25 +03:00
Aleksey Kladov
e5d91e8992
Fix spec bug
2021-04-19 17:55:51 +03:00
Aleksey Kladov
453b9cf6f0
Update docs/dev/README.md
...
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
2021-04-19 16:08:50 +03:00
Aleksey Kladov
ad24310d41
internal: document review requesting etiquette
...
* don't feel obliged to quickly review every PR assigned to you
* so that other folks can notify you about interesting PRs without
thinking to much about creating additional work for you
2021-04-19 16:08:49 +03:00
Lukas Wirth
b501b59eda
Update lsp-extensions docs
2021-04-18 12:50:44 +02:00
Jonas Schievink
93128efef8
Fix markdown links
2021-04-15 19:45:07 +02:00
bors[bot]
3af303600a
Merge #8510 #8533
...
8510: Move cursor position when using item movers r=jonas-schievink a=jonas-schievink
This updates the cursor position when moving items around to stay in the same location within the moved node.
I changed the `moveItem` response to `SnippetTextEdit[]`, since that made more sense to me (the file was ignored by the client anyways, since the edits always apply to the current document). It also matches `onEnter`, which seems logical to me, but please let me know if this doesn't make sense.
There's still a bug in the client-side snippet code that will cause the cursor position to be slightly off when moving parameters in the same line (presumably we don't track the column correctly after deleting `$0`). Not really sure how to fix that immediately, but this PR should already be an improvement despite that bug.
8533: Fix typo in style guide r=jonas-schievink a=jonas-schievink
Fixes bold text rendering
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2021-04-15 16:42:36 +00:00
Jonas Schievink
6e575d8c73
Fix typo in style guide
2021-04-15 18:38:52 +02:00
Jonas Schievink
30aae2cefb
Move cursor position when using item movers
2021-04-14 00:03:04 +02:00
Aleksey Kladov
db2a989565
internal: don't use #[should_panic] for tests
2021-04-13 12:21:59 +03:00
Aleksey Kladov
c8f48f50b3
internal: clarify who a rls-2.0 wg
2021-04-12 19:19:16 +03:00
Laurențiu Nicola
7221188b0d
Remove extra bracket in architecture docs
2021-04-08 17:51:19 +03:00
Kirill Bulatov
e785672f15
Adjust fixture docs a bit
2021-04-06 21:42:27 +03:00
Kirill Bulatov
b5f3815aee
Small grammar fixes
2021-04-06 21:42:27 +03:00
Kirill Bulatov
d5bedf8d6d
Update Zulip link and macro privacy statement
2021-04-06 21:42:27 +03:00
Aleksey Kladov
658776d4ed
internal: document broken windows
2021-04-06 20:11:42 +03:00
Aleksey Kladov
8fe20b19d4
More robust status notifications
2021-04-06 15:45:31 +03:00
Aleksey Kladov
a01fd1af19
internal: explain "extract if condition" refactoring
2021-04-05 13:02:47 +03:00
sim
d542a2b463
docs: Fix moveItem method name
2021-04-04 11:49:32 -07:00
Aleksey Kladov
636c3c49d2
internal: document style for helper functions and variables
2021-04-02 14:52:00 +03:00
Aleksey Kladov
27b779d1fd
internal: document Cargo.lock maintenance process
2021-04-02 13:59:36 +03:00
Aleksey Kladov
ff8142d47e
internal: touch up dev readme
2021-03-30 13:30:38 +03:00
Aleksey Kladov
b352b90c86
internal: make --log-file more discoverable
2021-03-29 15:11:31 +03:00
bors[bot]
d4fa6721af
Merge #8054
...
8054: Item movers r=matklad a=ivan770
Closes #6823
https://user-images.githubusercontent.com/14003886/111331579-b4f43480-8679-11eb-9af0-e4dabacc4923.mp4
Implementation issues:
- [ ] Most of items are non-movable, since _movability_ of any item has to be determined manually. Common ones are movable though
- [x] Cursor should move with the item
Co-authored-by: ivan770 <leshenko.ivan770@gmail.com>
2021-03-22 13:08:45 +00:00
Aleksey Kladov
79b4c89b89
Update docs/dev/README.md
...
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
2021-03-22 15:08:04 +03:00
Aleksey Kladov
aab148f943
Document patch policy
2021-03-22 14:59:56 +03:00
ivan770
7d60458495
Item up and down movers
2021-03-18 11:22:27 +02:00
Aleksey Kladov
30dea3a727
Prefer match to if let else
2021-03-16 10:51:05 +03:00
Laurențiu Nicola
dd9974c59d
Fix cargo xtask lint references
2021-03-14 15:24:34 +02:00
bors[bot]
7accf6bc37
Merge #7799
...
7799: Related tests r=matklad a=vsrs
This adds an ability to look for tests for the item under the cursor: function, constant, data type, etc
The LSP part is bound to change. But the feature itself already works and I'm looking for a feedback :)
Co-authored-by: vsrs <vit@conrlab.com>
2021-03-13 13:50:35 +00:00
Lukas Wirth
ebf4448f78
Fix remaining references to cargo xtask codegen
2021-03-12 15:10:33 +01:00
vsrs
49cdb2452a
Fix LSP extensions documentation
2021-03-11 17:59:27 +03:00
Aleksey Kladov
5b2b310827
Clarify that all caps are experimental
2021-03-09 12:02:20 +03:00
Laurențiu Nicola
fc9eed4836
Use upstream cov-mark
2021-03-08 22:19:44 +02:00
Aleksey Kladov
9faf8dd69a
Hygiene is an internal implementation detail of the compiler
2021-03-08 22:14:52 +03:00
Aleksey Kladov
1eb61203b7
Make code generation just work
...
Contributors don't need to learn about `cargo xtask codegen` if `cargo
test` just does the right thing.
2021-03-08 21:45:37 +03:00
Aleksey Kladov
e15621482c
Clarify comparison rule
2021-03-03 11:23:05 +03:00
Aleksey Kladov
979c26e1ae
Axe pre-commit
2021-03-01 21:30:21 +03:00
Vincent Esche
c4e2f32d73
Fixed remaining references to AnalysisChange (now: Change)
...
(The type was renamed/moved in 8716c4cec3
2021-02-28 12:57:41 +01:00
vsrs
5e88436517
Update lsp-extensions.md
2021-02-27 21:07:58 +03:00
