Commit Graph

469 Commits

Author SHA1 Message Date
llogiq
b66bccc45a update_lints 2015-09-05 14:22:33 +02:00
llogiq
3848756be0 Made min_max Warn by default 2015-09-05 14:20:35 +02:00
llogiq
b90e4c7bd5 hir naming, removed lookup, match full path 2015-09-05 13:15:18 +02:00
llogiq
cd91110ec0 new lint: min_max 2015-09-05 12:46:34 +02:00
llogiq
0c50d763fc Merge pull request #299 from Manishearth/unicode_str
Unicode lints, second attempt: Lint whole strings, help with replacement

This fixes #85
2015-09-04 14:27:26 +02:00
llogiq
28212e4981 fixed dogfood by using snippet instead of the (escaped) literal string 2015-09-04 14:24:49 +02:00
Manish Goregaokar
fb148a50b2 Add false positive checks to unicode test 2015-09-04 16:27:53 +05:30
llogiq
e11fd49b1c Unicode lints, second attempt: Lint whole strings, help with replacement 2015-09-04 16:18:46 +05:30
Manish Goregaokar
af4d7f9b60 Merge pull request #298 from birkenfeld/as_mut
methods: allow &mut self for as_ methods
2015-09-04 16:16:58 +05:30
Manish Goregaokar
2e412269ac Merge pull request #295 from Manishearth/hir3
Update rust to 0efb9dab8c7c07fa28e9df0eccc5c07ea3c17fbb
2015-09-04 16:14:21 +05:30
Georg Brandl
d659d039b6 methods: allow &mut self for as_ methods 2015-09-04 07:56:52 +02:00
Manish Goregaokar
eca185438b Update rust to 0efb9dab8c7c07fa28e9df0eccc5c07ea3c17fbb (HIR+lints, Thu Sep 3 18:59:56 2015 +0530)
fixes #294
2015-09-03 23:12:19 +05:30
Manish Goregaokar
5b7ec55fc2 Merge pull request #290 from Manishearth/float-cmp
also ignore `ne` functions
2015-09-03 15:49:54 +05:30
llogiq
cb571bf2e2 also ignore functions 2015-09-03 10:57:11 +02:00
Manish Goregaokar
2c3dd4a200 Merge pull request #286 from Manishearth/fix-ice
Fix ICE
2015-09-03 02:17:39 +05:30
Manish Goregaokar
fbdba7f915 Fix ICE 2015-09-03 02:15:02 +05:30
Georg Brandl
d3c53e307d Merge pull request #285 from Manishearth/contains_self
shadow: complete coverage of "contains_self" checker
2015-09-02 18:29:52 +02:00
Georg Brandl
7649d1c2a8 shadow: complete coverage of "contains_self" checker 2015-09-02 18:24:46 +02:00
llogiq
8edc87e3bd Merge pull request #284 from birkenfeld/is_methods
methods: allow multiple self kinds for "is_" methods
2015-09-02 17:21:42 +02:00
Georg Brandl
6b589681c9 methods: allow multiple self kinds for "is_" methods
These can be static method predicates.  (Found one in rust-copperline,
called Term::is_unsupported_term().)
2015-09-02 17:14:27 +02:00
Georg Brandl
2e7496ae7c Merge pull request #283 from birkenfeld/wording
don't say "did you mean to" - use the standard "consider..."
2015-09-02 17:13:08 +02:00
Georg Brandl
846c164709 don't say "did you mean to" - use the standard "consider..."
"Did you mean to ..." sounds a bit condescending to me, since
if I meant to write "if let" I probably wouldn't have written "match" :)
2015-09-02 16:46:14 +02:00
llogiq
a9869e6fe4 Merge pull request #280 from Manishearth/fx-279
Only handle ranges starting with 0 for needless_range_loop (fixes #279)
2015-09-02 12:44:21 +02:00
Manish Goregaokar
73c34e12b3 Only handle ranges starting with 0 for needless_range_loop (fixes #279) 2015-09-02 16:11:54 +05:30
Manish Goregaokar
eb3b9b35da Merge pull request #276 from Manishearth/float_cmp
check item name for eq, fixes #268
2015-09-02 15:47:41 +05:30
llogiq
0c7f05dd76 check item name for eq, fixes #268 2015-09-02 10:30:11 +02:00
llogiq
2086f97bbd Merge pull request #275 from Manishearth/shadow
extended pattern matching
2015-09-02 08:56:12 +02:00
llogiq
0fb7d1d2d9 reporting improvements 2015-09-02 08:19:47 +02:00
llogiq
bc1eb84810 match region patterns 2015-09-02 07:56:13 +02:00
llogiq
683bffba08 Merge branch 'shadow' of https://github.com/Manishearth/rust-clippy into shadow 2015-09-02 07:55:30 +02:00
llogiq
1ab733cfa1 extended pattern matching 2015-09-02 07:55:07 +02:00
llogiq
e2e89bf800 extended pattern matching 2015-09-02 07:50:58 +02:00
llogiq
08fb953e1a extended pattern matching 2015-09-02 01:36:37 +02:00
Manish Goregaokar
91c3c97828 Merge pull request #274 from birkenfeld/copy_fix
methods: try to allow value self when type is Copy (fixes #273)
2015-09-02 01:24:42 +05:30
Georg Brandl
5264196538 methods: try to allow value self when type is Copy (fixes #273) 2015-09-01 21:08:49 +02:00
Manish Goregaokar
718da74c9f Merge pull request #272 from birkenfeld/conventions
new lint: self conventions for certain method names (fixes #267)
2015-09-01 22:25:19 +05:30
Georg Brandl
1007864198 new lint: self conventions for certain method names (fixes #267) 2015-09-01 18:52:48 +02:00
llogiq
77fcca00f0 Merge pull request #271 from birkenfeld/lint_groups
lib: add clippy_pedantic group with all Allow by default lints (fixes #265)
2015-09-01 18:24:33 +02:00
Georg Brandl
88dd38de87 lib: add clippy_pedantic group with all Allow by default lints (fixes #265) 2015-09-01 18:05:28 +02:00
llogiq
2abc5ab97c Merge pull request #270 from jedisct1/nightly
Yet another fix for rust-nightly
2015-09-01 14:54:21 +02:00
Frank Denis
833493cf07 FnKind::FkClosure -> FnKind::Closure 2015-09-01 14:28:23 +02:00
Manish Goregaokar
d3da9f6c81 Merge branch 'pr-260'
Conflicts:
	src/lib.rs
2015-08-31 15:06:53 +05:30
llogiq
994124521e Merge pull request #264 from birkenfeld/fix2
lifetimes lint: walk type bounds as well as types (fixes #253, again)
2015-08-31 11:32:33 +02:00
Georg Brandl
e33bef685e lifetimes lint: walk type bounds as well as types (fixes #253, again) 2015-08-31 11:26:41 +02:00
llogiq
9d49cc5167 Merge pull request #263 from birkenfeld/fix
fix for #261
2015-08-31 08:53:56 +02:00
Georg Brandl
0217fb81ee loops: fix false positives with explicit_iter_loop and references (fixes #261) 2015-08-31 08:29:40 +02:00
Georg Brandl
d499d2a9a7 loops: remove debugging print 2015-08-31 08:20:39 +02:00
llogiq
614ba3ab86 Merge pull request #255 from TimNN/precedence-negative-literal
add precedence_negative_literal lint
2015-08-30 19:32:44 +02:00
Georg Brandl
03abe275b2 new lint: unnecessary patterns (x@_ -> x) 2015-08-30 19:02:30 +02:00
Tim Neumann
ef0c933550 add precedence_negative_literal lint 2015-08-30 17:34:48 +02:00