We use panics for cancellation, so we could trigger panic while
holding the solver. std::sync::Mutex will be poisoned as a result,
which and all further attempts to use solver (from other threads) will
panic as well.
This commit switches to parking_lot::Mutex which just unlocks on panic.
1347: Add status buffer function to emacs integration r=flodiebold a=flodiebold
Also fix a minor race condition in the 'extend selection' initialization.
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
On CI, we remove this project's artifacts from ./target before caching
it. This way, cache never changes, because it only caches deps.
We do this approximatelly, and, together with our own tools crate, we
also remove itertools, which are used by some other deps. Given that
tools change rarely, let's just cache them?
1348: cancel salsa's validation r=matklad a=matklad
This small fix should improve rust-analyzer resopnsivness for
real-time operations like onEnter handling.
Turns out, salsa's validation can take hundreds of milliseconds, and,
in case no changes were made, it won't be triggering any queries.
Because we check for cancellation in queries, that means that
validation is not cancellable!
What this PR does is injecting check_canceled checks into validation,
by using salsa's event API, which wasn't meant to be used like this,
but, hey, it works!
Here's the onEnter handling before and after this change:
https://youtu.be/7-ffPzgvH7o
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
This small fix should improve rust-analyzer resopnsivness for
real-time operations like onEnter handling.
Turns out, salsa's validation can take hundreds of milliseconds, and,
in case no changes were made, it won't be triggering any queries.
Because we check for cancellation in queries, that means that
validation is not cancellable!
What this PR does is injecting check_canceled checks into validation,
by using salsa's event API, which wasn't meant to be used like this,
but, hey, it works!
Here's the onEnter handling before and after this change:
https://youtu.be/7-ffPzgvH7o
1344: Highlight primitive types r=matklad a=lnicola
This is a hack to get better highlighting of primitive types until #1340.
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
