Alex Macleod
9a02386fd8
Allow running cargo dev lint on a package directory
2022-03-29 19:03:36 +01:00
Camille GILLOT
e01897edcb
Remember mutability in DefKind::Static.
...
This allows to compute the `BodyOwnerKind` from `DefKind` only, and
removes a direct dependency of some MIR queries onto HIR.
As a side effect, it also simplifies metadata, since we don't need 4
flavours of `EntryKind::*Static` any more.
2022-03-29 18:50:52 +02:00
Takayuki Nakata
c22b7b8814
Fix ICE for iter_overeager_cloned
2022-03-29 21:51:37 +09:00
J-ZhengLi
448a26d696
improve parent expr check
2022-03-29 15:23:19 +08:00
Oli Scherer
b3535a1549
Remove opaque type obligation and just register opaque types as they are encountered.
...
This also registers obligations for the hidden type immediately.
2022-03-28 16:57:45 +00:00
Oli Scherer
46e832e1ee
Revert "Auto merge of #93893 - oli-obk:sad_revert, r=oli-obk"
...
This reverts commit 6499c5e7fc78450d2d60
2022-03-28 16:27:14 +00:00
Takayuki Nakata
e5fa22e350
Fix version in changelog
2022-03-28 21:48:34 +09:00
Samuel E. Moelius III
cb307bbfcd
Address review comments
2022-03-28 04:48:12 -04:00
Jaic1
ec851b870b
First submit
2022-03-28 12:09:01 +08:00
bors
6206086dd5
Auto merge of #8487 - dswij:8478, r=giraffate
...
[`map_identity`] checks for needless `map_err`
Closes #8478
changelog: [`map_identity`] checks for needless `map_err`
2022-03-28 00:25:45 +00:00
bors
59c0f29916
Auto merge of #8519 - tysg:redundant-modulo, r=giraffate
...
Check if lhs < rhs in modulos in `identity_op`
Fixes #8508
changelog: [`identity_op`] now checks for modulos, e.g. `1 % 3`
2022-03-28 00:11:32 +00:00
Tianyi Song
52b563b283
Emit lint when rhs is negative
2022-03-27 21:49:38 +08:00
bors
a7da8a6019
Auto merge of #95274 - jendrikw:slice-must-use, r=Dylan-DPC
...
add #[must_use] to functions of slice and its iterators.
Continuation of #92853 .
Tracking issue: #89692 .
2022-03-26 20:17:04 +00:00
Caio
af8ed04e09
Rustfmt
2022-03-26 15:48:17 -03:00
Caio
c687f6575f
Do not fire panic in a constant environment
2022-03-26 15:39:21 -03:00
Jendrik
41f1413085
add #[must_use] to functions of slice and its iterators.
2022-03-26 16:19:47 +01:00
Jendrik
96f4e1c630
add #[must_use] to functions of slice and its iterators.
2022-03-26 15:37:48 +01:00
Peter Jaszkowiak
21eae8ceb6
fix indexing_slicing with const
...
- should not fire if indexing with a constant block
- should not fire if indexing within a constant context
(const statement or const block)
2022-03-25 23:05:38 -06:00
bors
2d85270bdf
Auto merge of #95149 - cjgillot:once-diag, r=estebank
...
Remove `Session::one_time_diagnostic`
This is untracked mutable state, which modified the behaviour of queries.
It was used for 2 things: some full-blown errors, but mostly for lint declaration notes ("the lint level is defined here" notes).
It is replaced by the diagnostic deduplication infra which already exists in the diagnostic emitter.
A new diagnostic level `OnceNote` is introduced specifically for lint notes, to deduplicate subdiagnostics.
As a drive-by, diagnostic emission takes a `&mut` to allow dropping the `SubDiagnostic`s.
2022-03-26 00:54:54 +00:00
Peter Jaszkowiak
bca047dcea
specify serde version compatible with codebase
2022-03-25 16:39:15 -06:00
Alex Macleod
610db04222
Provide suggestion context in map_unit_fn
2022-03-25 20:47:54 +00:00
bors
8ebe766695
Auto merge of #8582 - xFrednet:0000-changelog-1-60, r=Manishearth
...
Changelog for Rust 1.60.0 🦀 (Kudos to everyone who contributed!)
As always, I'm impressed by how much stuff happened in just one release. Seriously, kudos to everyone who contributed.
changelog: none
2022-03-25 17:05:05 +00:00
xFrednet
55feb4c4aa
Changelog for Rust 1.60.0 🦀
2022-03-25 17:58:39 +01:00
Grisha Vartanyan
854c3de1ff
Update clippy helper function types
2022-03-25 15:05:27 +01:00
bors
b7b0dad656
Auto merge of #95273 - flip1995:clippyup, r=manishearth
...
Update Clippy
r? `@Manishearth`
2022-03-24 22:52:34 +00:00
flip1995
1fa3d66e62
Merge commit 'd0cf3481a84e3aa68c2f185c460e282af36ebc42' into clippyup
2022-03-24 14:50:04 +01:00
bors
d0cf3481a8
Auto merge of #8580 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
Nice small sync with only typo fixes
changelog: none
2022-03-24 13:29:13 +00:00
flip1995
c995a8b501
Bump nightly version -> 2022-03-24
2022-03-24 14:22:43 +01:00
flip1995
1147b2c481
Merge remote-tracking branch 'upstream/master' into rustup
2022-03-24 14:22:35 +01:00
Samuel Moelius
86872059ed
Typo
2022-03-24 08:57:08 -04:00
bors
e29b3b55a4
Auto merge of #8579 - yoav-lavi:squashed-master, r=flip1995
...
`unnecessary_join` lint
changelog: Adds a lint called ``[`unnecessary_join`]`` that detects cases of `.collect::<Vec<String>>.join("")` or `.collect::<Vec<_>>.join("")` on an iterator, suggesting `.collect::<String>()` instead
Fixes: https://github.com/rust-lang/rust-clippy/issues/8570
This is a reopen of https://github.com/rust-lang/rust-clippy/pull/8573
changelog: add lint [`unnecessary_join`]
2022-03-24 12:57:08 +00:00
Yoav Lavi
b60a7fb7b6
unnecessary_join lint
2022-03-24 13:18:18 +01:00
Oli Scherer
6fc3850847
update clippy stderr file
2022-03-24 11:27:07 +00:00
Samuel E. Moelius III
65a26692fd
Add crate_in_macro_def lint
2022-03-24 05:08:10 -04:00
bors
f07ee8a998
Auto merge of #8232 - Jarcho:match_same_arm_860, r=xFrednet
...
`match_same_arms` fix
fixes #860
fixes #1140
changelog: Don't lint `match_same_arms` when an interposing arm's pattern would overlap
2022-03-21 20:42:51 +00:00
bors
4a07662d94
Auto merge of #8561 - FoseFx:use_unwrap_or, r=xFrednet
...
add `or_then_unwrap`
Closes #8557
changelog: New lint [`or_then_unwrap`]
2022-03-21 20:08:29 +00:00
bors
ff0a3687d8
Auto merge of #8520 - J-ZhengLi:issue8506, r=xFrednet
...
fix suggestion on `[map_flatten]` being cropped causing possible information loss
fixes #8506
Multi-line suggestion given by the lint is missing its bottom part, which could potentially contains useful information about the fix.
---
changelog: [`map_flatten`]: Long suggestions will now be splitup into two help messages
2022-03-21 19:51:56 +00:00
J-ZhengLi
5b6295d663
allowing [map_flatten] to split long suggestions
...
add new function `span_lint_and_sugg_` for edges in `clippy_utils::diagnostics`
2022-03-21 14:11:22 +08:00
Max Baumann
765cce11b1
refactor: remove need for MethodCall matching
2022-03-21 00:04:37 +01:00
Max Baumann
4580c8a9b7
refactor: use is_lang_ctor()
2022-03-20 23:54:04 +01:00
Max Baumann
0f83753934
feat: change error message
2022-03-20 23:43:17 +01:00
bors
47b93ea5ef
Auto merge of #8559 - pickfire:patch-1, r=xFrednet
...
Fix typo in bug report
repoduce -> reproduce
---
changelog: none
2022-03-20 22:32:12 +00:00
Camille GILLOT
94c727eccf
Take &mut Diagnostic in emit_diagnostic.
...
Taking a Diagnostic by move would break the usual pattern
`diag.label(..).emit()`.
2022-03-20 20:36:08 +01:00
Max Baumann
20c352a4f6
test: add method chain test
2022-03-19 18:17:43 +01:00
Max Baumann
895de1f13e
feat: make fixable
2022-03-18 23:18:36 +01:00
Max Baumann
f00e844a1f
feat: use span_lint_and_sugg
2022-03-18 22:44:56 +01:00
Max Baumann
34ad33c57a
refactor: move into methods module
2022-03-18 21:11:54 +01:00
bors
a31dcb77be
Auto merge of #8562 - Jarcho:enum_tuple_variant_as_int, r=Manishearth
...
Add lint `cast_enum_constructor`
fixes : #1116
changelog: Add lint `cast_enum_constructor`
2022-03-18 15:54:45 +00:00
Max Baumann
fd2c860171
feat: add comment
2022-03-18 14:45:48 +01:00
bors
9fd3c2d788
Auto merge of #8543 - dswij:8393, r=giraffate
...
`unnecessary_lazy_eval` show suggestions on multiline lint
Closes #8393
changelog: [`unnecessary_lazy_eval`] now shows suggestions for long-line lints
2022-03-18 00:42:18 +00:00
