Max Baumann
e552267db3
style -> pedantic
2022-03-30 20:13:16 +02:00
Max Baumann
2953cba116
unit_like_struct_brackets -> empty_structs_with_brackets
2022-03-30 20:13:16 +02:00
Max Baumann
37d5a6264c
changes after review
2022-03-30 20:12:58 +02:00
Max Baumann
33383a418d
use span_suggestion_hidden
2022-03-30 20:12:58 +02:00
Max Baumann
7192297c28
additional checks for conditionally compiled code
2022-03-30 20:12:58 +02:00
Max Baumann
1a5ff38f92
fix godfood test
2022-03-30 20:12:58 +02:00
Max Baumann
315521afc6
fix uitests
2022-03-30 20:12:58 +02:00
Max Baumann
9be3945be7
fix existing clippy tests
2022-03-30 20:12:58 +02:00
Max Baumann
528ada958b
add unit_like_struct_brackets
2022-03-30 20:12:58 +02:00
SabrinaJewson
d6f05c6a89
Don't warn int-to-char transmutes in const contexts
2022-03-30 18:47:50 +01:00
Alex Macleod
10a6d872d4
Handle relative paths in module_files lints
2022-03-30 18:44:04 +01:00
bors
c0a5693abc
Auto merge of #8602 - giraffate:fix_ice_for_iter_overeager_cloned, r=llogiq
...
Fix ICE for `iter_overeager_cloned`
Fix https://github.com/rust-lang/rust-clippy/issues/8527
changelog: Fix ICE for [`iter_overeager_cloned`]
2022-03-30 17:12:24 +00:00
bors
fe7254ff6f
Auto merge of #8576 - smoelius:crate_in_macro_def, r=llogiq
...
Add `crate_in_macro_def` lint
This PR adds a lint to check for `crate` as opposed to `$crate` used in a macro definition.
I think this can close #4798 . That issue focused on the case where the macro author "imports something into said macro."
But I think use of `crate` is likely to be a bug whether it appears in a `use` statement or not. There could be some use case I am failing to see, though. (cc: `@nilscript` `@flip1995)`
changelog: `crate_in_macro_def`
2022-03-30 16:57:24 +00:00
Samuel E. Moelius III
aaf04dc043
Fix error message in crate_in_macro_def.stderr
2022-03-30 12:52:31 -04:00
Samuel E. Moelius III
d6eb82c0a8
Move crate_in_macro_def
to suspicious
2022-03-30 12:40:53 -04:00
Samuel Moelius
75dc406e84
Update clippy_lints/src/crate_in_macro_def.rs
...
Co-authored-by: llogiq <bogusandre@gmail.com>
2022-03-30 12:40:44 -04:00
Samuel Moelius
abc221e7f6
Update clippy_lints/src/crate_in_macro_def.rs
...
Co-authored-by: llogiq <bogusandre@gmail.com>
2022-03-30 12:40:25 -04:00
Samuel Moelius
9b304533ab
Update clippy_lints/src/crate_in_macro_def.rs
...
Co-authored-by: llogiq <bogusandre@gmail.com>
2022-03-30 12:40:16 -04:00
bors
df7c253d39
Auto merge of #8597 - giraffate:fix_changelog, r=xFrednet
...
Fix version in changelog
changelog: none
2022-03-30 16:25:42 +00:00
bors
0031f69999
Auto merge of #8592 - c410-f3r:stuff, r=flip1995
...
Do not fire `panic` in a constant environment
Let rustc handle panics in constant environments.
Since https://github.com/rust-lang/rust-clippy/issues/8348 I thought that such modification would require a lot of work but thanks to https://github.com/rust-lang/rust-clippy/pull/8588 I now know that it is not the case.
changelog: [`panic`]: No longer lint in constant context. `rustc` already handles this.
2022-03-30 16:04:14 +00:00
bors
e1ddf29ee3
Auto merge of #8586 - pitaj:fix-8378, r=flip1995
...
specify serde version compatible with codebase
fix #8378
changelog: none
2022-03-30 15:46:48 +00:00
bors
d9819c3b8d
Auto merge of #8584 - Alexendoo:map-unit-fn-context, r=Manishearth
...
Provide suggestion context in map_unit_fn
Fixes #8569
changelog: Fix incorrect suggestion for `option_map_unit_fn` , `result_map_unit_fn`
2022-03-30 15:25:37 +00:00
lcnr
104ba478f2
clippy: nameres for primitive type impls
2022-03-30 11:57:53 +02:00
lcnr
148b593954
get clippy to compile again
2022-03-30 11:23:58 +02:00
Alex Macleod
9a02386fd8
Allow running cargo dev lint
on a package directory
2022-03-29 19:03:36 +01:00
Camille GILLOT
e01897edcb
Remember mutability in DefKind::Static
.
...
This allows to compute the `BodyOwnerKind` from `DefKind` only, and
removes a direct dependency of some MIR queries onto HIR.
As a side effect, it also simplifies metadata, since we don't need 4
flavours of `EntryKind::*Static` any more.
2022-03-29 18:50:52 +02:00
Takayuki Nakata
c22b7b8814
Fix ICE for iter_overeager_cloned
2022-03-29 21:51:37 +09:00
J-ZhengLi
448a26d696
improve parent expr check
2022-03-29 15:23:19 +08:00
Oli Scherer
b3535a1549
Remove opaque type obligation and just register opaque types as they are encountered.
...
This also registers obligations for the hidden type immediately.
2022-03-28 16:57:45 +00:00
Oli Scherer
46e832e1ee
Revert "Auto merge of #93893 - oli-obk:sad_revert, r=oli-obk"
...
This reverts commit 6499c5e7fc
, reversing
changes made to 78450d2d60
.
2022-03-28 16:27:14 +00:00
Takayuki Nakata
e5fa22e350
Fix version in changelog
2022-03-28 21:48:34 +09:00
Samuel E. Moelius III
cb307bbfcd
Address review comments
2022-03-28 04:48:12 -04:00
Jaic1
ec851b870b
First submit
2022-03-28 12:09:01 +08:00
bors
6206086dd5
Auto merge of #8487 - dswij:8478, r=giraffate
...
[`map_identity`] checks for needless `map_err`
Closes #8478
changelog: [`map_identity`] checks for needless `map_err`
2022-03-28 00:25:45 +00:00
bors
59c0f29916
Auto merge of #8519 - tysg:redundant-modulo, r=giraffate
...
Check if lhs < rhs in modulos in `identity_op`
Fixes #8508
changelog: [`identity_op`] now checks for modulos, e.g. `1 % 3`
2022-03-28 00:11:32 +00:00
Tianyi Song
52b563b283
Emit lint when rhs is negative
2022-03-27 21:49:38 +08:00
bors
a7da8a6019
Auto merge of #95274 - jendrikw:slice-must-use, r=Dylan-DPC
...
add #[must_use] to functions of slice and its iterators.
Continuation of #92853 .
Tracking issue: #89692 .
2022-03-26 20:17:04 +00:00
Caio
af8ed04e09
Rustfmt
2022-03-26 15:48:17 -03:00
Caio
c687f6575f
Do not fire panic
in a constant environment
2022-03-26 15:39:21 -03:00
Jendrik
41f1413085
add #[must_use] to functions of slice and its iterators.
2022-03-26 16:19:47 +01:00
Jendrik
96f4e1c630
add #[must_use] to functions of slice and its iterators.
2022-03-26 15:37:48 +01:00
Peter Jaszkowiak
21eae8ceb6
fix indexing_slicing
with const
...
- should not fire if indexing with a constant block
- should not fire if indexing within a constant context
(const statement or const block)
2022-03-25 23:05:38 -06:00
bors
2d85270bdf
Auto merge of #95149 - cjgillot:once-diag, r=estebank
...
Remove `Session::one_time_diagnostic`
This is untracked mutable state, which modified the behaviour of queries.
It was used for 2 things: some full-blown errors, but mostly for lint declaration notes ("the lint level is defined here" notes).
It is replaced by the diagnostic deduplication infra which already exists in the diagnostic emitter.
A new diagnostic level `OnceNote` is introduced specifically for lint notes, to deduplicate subdiagnostics.
As a drive-by, diagnostic emission takes a `&mut` to allow dropping the `SubDiagnostic`s.
2022-03-26 00:54:54 +00:00
Peter Jaszkowiak
bca047dcea
specify serde version compatible with codebase
2022-03-25 16:39:15 -06:00
Alex Macleod
610db04222
Provide suggestion context in map_unit_fn
2022-03-25 20:47:54 +00:00
bors
8ebe766695
Auto merge of #8582 - xFrednet:0000-changelog-1-60, r=Manishearth
...
Changelog for Rust 1.60.0 🦀 (Kudos to everyone who contributed!)
As always, I'm impressed by how much stuff happened in just one release. Seriously, kudos to everyone who contributed.
changelog: none
2022-03-25 17:05:05 +00:00
xFrednet
55feb4c4aa
Changelog for Rust 1.60.0 🦀
2022-03-25 17:58:39 +01:00
Grisha Vartanyan
854c3de1ff
Update clippy helper function types
2022-03-25 15:05:27 +01:00
bors
b7b0dad656
Auto merge of #95273 - flip1995:clippyup, r=manishearth
...
Update Clippy
r? `@Manishearth`
2022-03-24 22:52:34 +00:00
flip1995
1fa3d66e62
Merge commit 'd0cf3481a84e3aa68c2f185c460e282af36ebc42' into clippyup
2022-03-24 14:50:04 +01:00