bors
e53a115fe1
Auto merge of #16067 - roife:fix-introduce-named-generic-impl-inside-types, r=Veykril
...
fix: no code action 'introduce_named_generic' for impl inside types
Fix #15734 .
### Changes Made
- Find params in `ancestors` instead of just `parent`
- Added tests (`replace_impl_with_mut` and `replace_impl_inside`)
2024-01-02 10:09:14 +00:00
Ryan Mehri
b105e9b342
fix: use original range to deal with macros in promote_local_to_const
2024-01-02 10:33:48 +01:00
Ryan Mehri
9f6a2c4564
fix: use original range to deal with macros in bool_to_enum
2024-01-02 10:33:48 +01:00
Ryan Mehri
b5e0edf427
style: clean up bool_to_enum assist
2024-01-02 10:33:46 +01:00
Ryan Mehri
2034556f81
fix: add test for missing case in bool_to_enum
2024-01-02 10:32:43 +01:00
l1nxy
a3be52cbc0
tidy.
2024-01-01 22:31:04 +08:00
l1nxy
b6a14ce5b8
fix doc test.
2024-01-01 22:11:45 +08:00
l1nxy
edb9ad21bd
apply to only has nested if.
2024-01-01 21:53:57 +08:00
Tetsuharu Ohzeki
efc87092b3
Use Cargo's [workspace.lints.*] to config clippy
2023-12-29 23:51:32 +09:00
Yu Zeng
7fee0881db
complete merge_nested_if with bugs.
2023-12-29 18:32:37 +08:00
Young-Flash
6a7d3f1c3e
add test case for nested generic arg with Self
2023-12-27 19:55:36 +08:00
Young-Flash
a38a79e2ba
use SyntaxKind instead of "Self" literal comparison
2023-12-27 19:49:50 +08:00
Young-Flash
67f001e5ec
test: add test case for Self
2023-12-26 21:25:30 +08:00
Young-Flash
8a0a3b2493
fix: extract_struct_from_enum_variant should resolve Self generic arg
2023-12-26 21:23:41 +08:00
Young-Flash
6c9d2ad1d5
test: add test case for remove comma
2023-12-22 21:04:53 +08:00
bors
65ed198819
Auto merge of #16066 - Young-Flash:auto_remove_brace, r=lnicola
...
fix: auto remove unnecessary braces after remove unused imports
before
after
2023-12-20 13:22:00 +00:00
Young-Flash
4cd939ad08
chore: add test case for nested use tree
2023-12-20 19:44:57 +08:00
Lukas Wirth
002e611d09
fix: Deduplicate annotations
2023-12-19 08:49:00 +01:00
Lukas Wirth
f49a2fed3f
internal: Move out WithFixture into dev-dep only crate
2023-12-18 15:24:08 +01:00
Lukas Wirth
35620306a6
internal: Move proc-macro knowledge out of base-db
2023-12-18 12:37:18 +01:00
bors
dd07f1f2fb
Auto merge of #15887 - jinohkang-theori:fix/ide-assists/convert_tuple_struct_to_named_struct/handle_refs_inside_macro_invocations, r=Veykril
...
Fix incorrectly replacing references in macro invocation in "Convert to named struct" assist
Fixes #15630 .
Complements #13647 (same assist but missed this one), #14920 (inverse action assist).
2023-12-13 21:30:18 +00:00
roife
38b5dcb53c
fix: self type replacement with macros
2023-12-14 00:42:33 +08:00
roife
3449222ab1
fix: self type replacement in inline-function
2023-12-13 23:13:55 +08:00
roife
5070534d32
fix: testcases in generate_delegate_trait
2023-12-13 11:42:45 +08:00
roife
59aa791fe6
fix: rewrite code_action generate_delegate_trait
2023-12-13 11:22:42 +08:00
DropDemBits
1506435f65
Update various_resolve_strategies test
...
The weird disjoint `Indel`s are likely an artifact of the tree diffing
algorithm we use.
2023-12-10 20:33:32 -05:00
DropDemBits
c486637ec5
Migrate replace_is_method_with_if_let_method to mutable ast
2023-12-10 18:39:43 -05:00
DropDemBits
316269901f
Migrate generate_function to mutable ast
2023-12-10 18:39:43 -05:00
DropDemBits
1e1761e9ae
Migrate extract_variable to mutable ast
2023-12-10 18:37:51 -05:00
roife
63d2f353d9
fix: fix 'introduce_named_generic' for impl inside types
2023-12-09 17:11:48 +08:00
bors
6bbb2ac304
Auto merge of #15705 - rmehri01:14485_fix_delegate_self_references, r=Veykril
...
fix: resolve Self type references in delegate method assist
This PR makes the delegate method assist resolve any `Self` type references in the parameters or return type. It also works across macros such as the `uint_impl!` macro used for `saturating_mul` in the issue example.
Closes #14485
2023-12-08 11:31:34 +00:00
Ryan Mehri
7e768cbe70
fix: prefer keeping Self if it is in the same impl def
2023-12-08 12:30:14 +01:00
Ryan Mehri
f4349ff26e
fix: preserve where clause in delegate method
2023-12-08 12:29:34 +01:00
Ryan Mehri
934358e95c
fix: resolve Self type references in delegate method assist
2023-12-08 12:29:34 +01:00
Matheus Cardoso
3d9221291f
flip binexpr works for lhs cmp
2023-12-08 11:36:30 +01:00
Matheus Cardoso
e18b89452e
Flip binexpr works for lhs binexpr
2023-12-08 11:36:30 +01:00
bors
49dd3804c0
Auto merge of #16009 - werifu:fix-extract-function, r=Veykril
...
fix: bug in extract_function.rs
There is a little bug in extract_function: It appends `use path::to::ControlFlow;` if the function created contains string "ControlFlow".
A case below (also in the test named `does_not_import_control_flow` which will fail in the original code)
<img width="322" alt="image" src="https://github.com/rust-lang/rust-analyzer/assets/53432474/4b80bb58-0cfd-4d56-b64c-d9649eed336e ">
<img width="391" alt="image" src="https://github.com/rust-lang/rust-analyzer/assets/53432474/3d7262f4-8a4c-44ea-822d-304b8b23fe28 ">
Now I have changed the condition determining whether adding import statement. Only when the new function body contains ControlFlow::Break or ControlFlow::Continue can the import statement be added.
Last related PR: https://github.com/rust-lang/rust-analyzer/pull/10309
2023-12-07 17:28:41 +00:00
Lukas Wirth
634d588fd7
Simplify
2023-12-06 14:36:39 +01:00
Lukas Wirth
d2cd30007c
Implicit format args support
2023-12-05 17:07:00 +01:00
Lukas Wirth
5b8e386bae
Improve macro descension API
2023-12-05 17:06:57 +01:00
Igor Matuszewski
a7224c998d
Don't explicitly warn against semicolon_in_expressions_from_macros
...
This has been warn-by-default for two years now and has already been
added to the future-incompat lints in 1.68.
2023-12-05 11:35:09 +01:00
werifu
05e8b926e6
fix: bug in extract_function: should not import ControlFlow in some cases
2023-12-04 16:23:18 +08:00
Lukas Wirth
81410ab500
Cleanup FileId stuff
2023-12-02 19:32:53 +01:00
Lukas Wirth
c43078f99d
Re-implement InFile wrappers as type aliases over generic InFileWrapper
2023-11-28 10:55:40 +01:00
Lukas Wirth
890eb17b4e
Replace ID based TokenMap with proper relative text-ranges / spans
2023-11-28 10:55:39 +01:00
bors
4ab67291fa
Auto merge of #15857 - Young-Flash:fix, r=Veykril
...
fix: remove parenthesis should ensure space
close https://github.com/rust-lang/rust-analyzer/issues/15844
2023-11-27 16:14:31 +00:00
David Tolnay
b68f5311b5
Replace option.map(cond) == Some(true) with option.is_some_and(cond)
2023-11-24 09:06:44 -08:00
Young-Flash
bd5a63b208
move parentheses judge logic into builder
2023-11-22 14:11:00 +08:00
Young-Flash
1cbda612bc
chore: add use case for PathSegment::qualifying_trait
2023-11-17 21:31:33 +08:00
Laurențiu Nicola
cb8434e594
Bump either
2023-11-15 13:07:36 +02:00
