Commit Graph

84736 Commits

Author SHA1 Message Date
Alexander Regueiro
3e142b92bc Added help message for impl_trait_in_bindings feature gate. 2018-09-30 22:12:34 +01:00
bors
fc403ad987 Auto merge of #53255 - orium:fix-bug-overflow-send, r=arielb1
Add a per-tree error cache to the obligation forest

This implements part of what @nikomatsakis mentioned in  https://github.com/rust-lang/rust/pull/30533#issuecomment-170705871:

> 1. If you find that a new obligation is a duplicate of one already in the tree, the proper processing is:
>      * if that other location is your parent, you should abort with a cycle error (or accept it, if coinductive)
>      * if that other location is not an ancestor, you can safely ignore the new obligation

In particular it implements the "if that other location is your parent accept it, if coinductive" part.  This fixes #40827.

I have to say that I'm not 100% confident that this is rock solid.  This is my first pull request 🎉, and I didn't know anything about the trait resolver before this.  In particular I'm not totally sure that comparing predicates is enough (for instance, do we need to compare `param_env` as well?).  Also, I'm not sure what @nikomatsakis mentions [here](https://github.com/rust-lang/rust/issues/30977#issue-127091096), but it might be something that affects this PR:

> In particular, I am wary of getting things wrong around inference variables! We can always add things to the set in their current state, and if unifications occur then the obligation is just kind of out-of-date, but I want to be sure we don't accidentally fail to notice that something is our ancestor. I decided this was subtle enough to merit its own PR.

Anyway, go ahead and review 🙂.

Ref #30977.

# Performance

We are now copying vectors around, so I decided to do some benchmarking.  A simple benchmark shows that this does not seem to affect performance in a measurable way:

I ran `cargo clean && cargo build` 20 times on actix-web (84b27db) and these are the results:

```text
rustc master:

            Mean        Std.Dev.    Min         Median      Max
real        66.637      2.996       57.220      67.714      69.314
user        307.293     14.741      258.093     312.209     320.702
sys         12.524      0.653       10.499      12.726      13.193

rustc fix-bug-overflow-send:

            Mean        Std.Dev.    Min         Median      Max
real        66.297      4.310       53.532      67.516      70.348
user        306.812     22.371      236.917     314.748     326.229
sys         12.757      0.952       9.671       13.125      13.544
```

I will do a more comprehensive benchmark (compiling rustc stage1) and post the results.

r? @nikomatsakis, @nnethercote

PS: It is better to review this commit-by-commit.
2018-09-30 19:41:07 +00:00
Diogo Sousa
6bfa6aa872 Deduplicate errors in the obligation forest.
Fixes #40827.
2018-09-30 20:01:35 +01:00
Diogo Sousa
d2ff5d696c Typos and style fixes. 2018-09-30 20:01:28 +01:00
Ralf Jung
4cbfc9398d also compile-fail test fn ptr comparison promotion 2018-09-30 20:28:00 +02:00
Ralf Jung
1397836380 do not promote comparing function pointers 2018-09-30 19:48:54 +02:00
Kazuyoshi Kato
ecb5142ede Unify the search boxes
Instead of having the standard library search and DuckDuckGo search.
This change merges two of them, with radio buttons.
2018-09-30 09:00:37 -07:00
Richard Diamond
0b76a97793 Re-export getopts so custom drivers can reference it.
Otherwise, custom drivers will have to use their own copy of `getopts`, which
won't match the types used in `CompilerCalls`.
2018-09-30 10:48:00 -05:00
Jorge Aparicio
dd65d732ed the test requires unwinding so we don't run it on the wasm32-bare target 2018-09-30 17:27:06 +02:00
Jorge Aparicio
0703af2a77 add codegen test 2018-09-30 17:27:06 +02:00
Jorge Aparicio
a5dfbdba7a make the nil-enum test work again 2018-09-30 17:27:06 +02:00
Jorge Aparicio
fba4e291ce adapt to change in Session API 2018-09-30 17:27:06 +02:00
Jorge Aparicio
cef3aa0261 allow dead_code 2018-09-30 17:27:06 +02:00
Jorge Aparicio
0bf40d86d8 add empty enum to the test cases 2018-09-30 17:27:06 +02:00
Jorge Aparicio
22cde0efa5 improve the run-pass test 2018-09-30 17:27:06 +02:00
Jorge Aparicio
00ba5cb00b move our check to reuse a previous computation 2018-09-30 17:27:06 +02:00
Jorge Aparicio
7294fcdc41 improve panic message 2018-09-30 17:27:06 +02:00
Jorge Aparicio
bd3c7812cb use is_uninhabited in more places 2018-09-30 17:27:06 +02:00
Jorge Aparicio
f9bbb5f31d panic when instantiating an uninhabited type via mem::{uninitialized,zeroed} 2018-09-30 17:26:15 +02:00
bors
390540909e Auto merge of #54622 - matthewjasper:more-nll-mode, r=pnkfelix
Enable NLL compare mode for more tests

Most of these tests were disabled due to NLL bugs that have since been fixed. A few needed updating for NLL.

r? @nikomatsakis
2018-09-30 14:38:47 +00:00
Simonas Kazlauskas
0b3e5eb6cc Simplify implementation of align_offset slightly 2018-09-30 16:27:13 +03:00
csmoe
cae164c02c add test for fake self 2018-09-30 20:49:22 +08:00
Ralf Jung
1b22befd36 make run-pass tests with empty main just compile-pass tests 2018-09-30 14:32:10 +02:00
bors
1886d5fe1c Auto merge of #54596 - mjbshaw:drop, r=RalfJung
Make core::mem::needs_drop a const fn

This fixes #51929.
2018-09-30 12:00:45 +00:00
Ralf Jung
d62aa3e085 move ScalarMaybeUndef into the miri engine 2018-09-30 13:09:26 +02:00
Ralf Jung
392ea7ad53 do not normalize non-scalar constants to a ConstValue::ScalarPair 2018-09-30 12:37:00 +02:00
bors
a677e4c347 Auto merge of #53816 - zackmdavis:elided_lifetimes_in_paths_field_day, r=nikomatsakis
don't elide lifetimes in paths in librustc/

In light of the "Apply to rustc" checkbox on #44524 and @nikomatsakis's [recent comment about regularly wanting visual indication of elided lifetimes in types](https://github.com/rust-lang/rust/issues/44524#issuecomment-414663773), I was curious to see what it would look like if we turned the `elided_lifetimes_in_path` lint on in at least one crate in the codebase (I chose librustc). Given that I couldn't figure out how to get `cargo fix` work with the build system, this arguably wasn't a very efficient use of my time, but once I started, the conjunction of moral law and the sunk cost fallacy forced me to continue.

This is mostly applying the `<'_>` suggestions issued by the lint, but there were a few places where I named the lifetimes (_e.g._, `<'a, 'gcx, 'tcx>` on `TyCtxt`) in order to match style with surrounding code.

r? @nikomatsakis
2018-09-30 09:22:31 +00:00
bors
8c1d5e5b71 Auto merge of #54639 - nagisa:lets-alias-for-now, r=eddyb
Do not put noalias annotations by default

This will be re-enabled sooner or later depending on results of further
investigation.

Fixes #54462

Beta backport is: #54640

r? @nikomatsakis
2018-09-30 06:44:13 +00:00
Scott McMurray
d4840da779 Activate the feature in the libcore tests too 2018-09-29 23:29:58 -07:00
Scott McMurray
8d6bee3442 UI test updates 2018-09-29 22:05:07 -07:00
Zack M. Davis
5b22d9b2ca don't elide lifetimes in paths in librustc/
This seemed like a good way to kick the tires on the
elided-lifetimes-in-paths lint (#52069)—seems to work! This was also
pretty tedious—it sure would be nice if `cargo fix` worked on this
codebase (#53896)!
2018-09-29 21:48:29 -07:00
Scott McMurray
0a3bd9b6ab Use impl_header_lifetime_elision in libcore 2018-09-29 21:33:35 -07:00
Michael Bradshaw
43cc32fbb2 Merge branch 'master' into drop 2018-09-29 19:51:09 -07:00
Michael Bradshaw
aec5330082 Fix ui/run-pass/union/union-nodrop.rs test 2018-09-29 19:49:17 -07:00
bors
6310be458f Auto merge of #54601 - cuviper:prep-1.31, r=Mark-Simulacrum
Bump to 1.31.0 and bootstrap from 1.30 beta

Closes #54594.
2018-09-30 01:45:50 +00:00
Niek Sanders
af9eb4fc21 Correct doc for WorkQueue<T>::pop(). 2018-09-30 00:24:37 +02:00
bors
e0a1ab6374 Auto merge of #54591 - ljedrz:cleanup_typeck_rest, r=zackmdavis
A few cleanups and minor improvements to typeck

This PR complements https://github.com/rust-lang/rust/pull/54533, which was limited to `check`.

- change a few `push` loops to `extend`s
- prefer `to_owned` to `to_string` for string literals
- prefer `if let` to `match` where only one branch matters
- a few other minor improvements
- whitespace fixes
2018-09-29 22:20:01 +00:00
Alex Crichton
b3157601b1 Rename sanitizer runtime libraries on OSX
Currently we ship sanitizer libraries as they're built, but these names
unfortunately conflict with the names of the sanitizer libraries
installed on the system. If a crate, for example, links in C code that
wants to use the system sanitizer and the Rust code doesn't use
sanitizers at all, then using `cargo` may accidentally pull in the
Rust-installed sanitizer library due to a conflict in names.

This change is intended to be entirely transparent for Rust users of
sanitizers, it should only hopefully improve our story with other users!

Closes #54134
2018-09-29 14:29:05 -07:00
Philipp Hansch
d654e3c69b
Improve bug! message for impossible case in Relate
Hitting this branch in Clippy and I think it makes sense to print
both values here in case other people hit this branch, too.
2018-09-29 21:59:21 +02:00
bors
bb0896af11 Auto merge of #54240 - csmoe:nonzero_from, r=alexcrichton
Impl From<NonZero<T>> for T

Closes https://github.com/rust-lang/rust/issues/54171

r? @SimonSapin
2018-09-29 19:38:12 +00:00
Donato Sciarra
0390736dce Improve ux when calling associated functions with dot notation
Issue: 22692
2018-09-29 21:36:58 +02:00
Alex Crichton
6f4b378e84 rust: Add a -C default-linker-libraries option
This commit adds a new codegen option for the compiler which disables
rustc's passing of `-nodefaultlibs` by default on relevant platforms.
Sometimes Rust is linked with C code which fails to link with
`-nodefaultlibs` and is unnecessarily onerous to get linking correctly
with `-nodefaultlibs`.

An example of this is that when you compile C code with sanitizers and
then pass `-fsanitize=address` to the linker, it's incompatible with
`-nodefaultlibs` also being passed to the linker.

In these situations it's easiest to turn off Rust's default passing of
`-nodefaultlibs`, which was more ideological to start with than
anything! Preserving the default is somewhat important but having this
be opt-in shouldn't cause any breakage.

Closes #54237
2018-09-29 11:03:59 -07:00
Ralf Jung
54b303ace4 update miri 2018-09-29 19:43:15 +02:00
Keith Yeung
8380b25d13 Add UI test for preserving user types in type ascriptions 2018-09-29 10:34:36 -07:00
Niko Matsakis
4a293a3990 avoid infinite loop in MIR lowering 2018-09-29 10:34:35 -07:00
Keith Yeung
fba9d14779 Lower type ascriptions to HAIR and MIR 2018-09-29 10:34:30 -07:00
Guillaume Gomez
322e46916e Add a sentence before rustc errors 2018-09-29 18:34:49 +02:00
Guillaume Gomez
f7240e1c74 Improve error display for codeblocks in rustdoc 2018-09-29 18:14:34 +02:00
bors
eb50e75729 Auto merge of #54599 - nikomatsakis:issue-54593-impl-Trait, r=eddyb
use closure def-id in returns, but base def-id in locals

The refactorings to  handle `let x: impl Trait`  wound up breaking `impl Trait` in closure return types. I think there are some deeper problems with the code in question, but this a least should make @eddyb's example work.

Fixes #54593

r? @eddyb
2018-09-29 15:07:59 +00:00
Paweł Romanowski
0626afbcd2 First stab at fixing #54505 2018-09-29 15:18:27 +01:00