Commit Graph

5378 Commits

Author SHA1 Message Date
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
1264bb6b7d
Merge pull request #3323 from pengowen123/fix_manual_memcpy
Simplify manual_memcpy suggestion in some cases
2018-10-18 09:44:24 +02:00
Philipp Hansch
adbaa85ee9
Merge pull request #3330 from shssoichiro/3309-goblin-ice
Resolve ICE in needless range loop lint
2018-10-17 21:01:15 +02:00
Joshua Holmer
4b68c965fe Resolve ICE in needless range loop lint
An ICE would occur if the needless range loop was triggered
within a procedural macro, because Clippy would try to produce
a code suggestion which was invalid, and caused the compiler
to crash.

This commit takes the same approach which Clippy currently takes
to work around this type of crash in the needless pass by value lint,
which is to skip the lint if Clippy is inside of a macro.
2018-10-17 10:43:32 -04:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
f40c4fa51d
Merge pull request #3327 from phansch/update_changelog_riir
RIIR update_lints: Update changelog links
2018-10-17 09:47:02 +02:00
Philipp Hansch
9f3ac4e5a3
RIIR update_lints: Update changelog links
This now also updates the link list at the bottom of the changelog.
2018-10-17 08:18:05 +02:00
Philipp Hansch
284c63e84d
Merge pull request #3281 from CYBAI/redundant-match
Add lint for redundant pattern matching for explicit return boolean
2018-10-17 07:31:09 +02:00
Philipp Hansch
b0ab69fcf1
Merge pull request #3326 from mrbuzz/master
Reword help message for len_zero
2018-10-17 07:27:10 +02:00
CYBAI
66ae3b1249 Rename if_let_redundant_pattern_matching to redundant_pattern_matching
Also, making the old one deprecated
2018-10-17 11:20:42 +08:00
CYBAI
3b7c88888b Add lint for redundant pattern matching for explicit return boolean 2018-10-17 11:14:37 +08:00
Giorgio Gambino
aa88e68902 Fix issue #3322: reword help message for len_zero 2018-10-16 23:23:31 +02:00
Owen Sanchez
8c902d1cf2 Simplify manual_memcpy suggestion in some cases 2018-10-16 12:38:23 -07:00
Philipp Hansch
dae7abb16b
Merge pull request #3325 from phansch/riir_update_lints_first_replace_region
RIIR update_lints: Replace lint count in README.md
2018-10-16 21:35:25 +02:00
Philipp Hansch
05ffc2d057
Fix dogfood
`expect_fun_call` causes a false-positive, so I disabled it for now.
2018-10-16 20:58:00 +02:00
Joshua Holmer
33847b579e Update known problems for unnecessary_fold 2018-10-16 09:04:02 -04:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
6ae89c4f11
Merge pull request #3321 from 0ndorio/fix/1123_false_positive_on_boxed_local
Avoid linting `boxed_local` on trait implementations.
2018-10-16 10:45:55 +02:00
Philipp Hansch
956987f43e
RIIR update_lints: Replace lint count in README.md
This allows the usage of `util/dev update_lints` which will write the
new lint_count to the `README.md`.
2018-10-16 08:14:32 +02:00
Philipp Hansch
af441b5b07
Rename active_lints to usable_lints
Because now `usable_lints` will also exclude internal lints.
2018-10-16 08:09:32 +02:00
Philipp Hansch
eb683e6070
Merge pull request #3320 from phansch/riir_update_lints_use_walkdir
RIIR update_lints: use WalkDir instead of read_dir
2018-10-16 07:13:45 +02:00
Philipp Hansch
78cd2c8545
Merge pull request #3319 from majecty/webpage_link_category
Website: Make lint categories linkable
2018-10-16 07:13:03 +02:00
Philipp Hansch
b5dd8f17d1
Add comment on WalkDir vs. fs::read_dir 2018-10-15 21:10:22 +02:00
Philipp Hansch
b61ca63c5e
sort_by -> sort_by_key 2018-10-15 21:02:38 +02:00
Philipp Hansch
fb830c53db
Some more documentation for clippy_dev 2018-10-15 20:47:19 +02:00
Philipp Hansch
7da97a94df
Use WalkDir to also gather from subdirectories
`fs::read_dir` does not recurse into subdirectories.
2018-10-15 20:44:22 +02:00
Bruno Kirschner
2d8b4f3d5c Avoid linting boxed_local on trait implementations. 2018-10-15 20:34:45 +02:00
Park Juhyung
4c88362a9d Website: Make lint categories linkable
Fixes #2973
2018-10-15 22:36:35 +09:00
Josh Mcguigan
66d3672b26 out_of_bounds_indexing improved reporting of out of bounds value 2018-10-15 04:44:39 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
0f4b13bc1b
Merge pull request #3316 from pengowen123/fix_needless_range_loop
Swap order of methods in `needless_range_loop` suggestion for efficiency in some cases
2018-10-15 09:33:21 +02:00
Manish Goregaokar
3ad9290ea4 Restore clippy_dummy's placeholder name
Fixes #3317
2018-10-14 23:41:37 -07:00
Owen Sanchez
456843f1cd Swap order of methods in needless_range_loop suggestion in some cases 2018-10-14 20:14:16 -07:00
Manish Goregaokar
5afdf8b785
Merge pull request #3315 from rust-lang-nursery/oli-obk-patch-1
fix for rustc master
2018-10-14 15:57:23 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
212a4fe4f4
fix for rustc master 2018-10-14 22:55:26 +02:00
Josh Mcguigan
5c39282826 out_of_bounds_indexing refactoring 2018-10-14 07:49:28 -07:00
Martin Carton
1cb90cc48a
Merge pull request #3314 from matthiaskrgr/mem_forget_sample
mem_forget: fix syntax error in code sample
2018-10-14 14:15:31 +02:00
Matthias Krüger
c492818110 mem_forget: fix syntax error in code sample 2018-10-14 10:30:04 +02:00
Josh Mcguigan
0f3345e8b2 OUT_OF_BOUNDS_INDEXING fix #3102 false negative 2018-10-13 13:51:53 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
601cc9d2c5
Merge pull request #3310 from JoshMcguigan/explicit_counter_loop-3308
explicit_counter_loop fix #3308 false positive
2018-10-13 20:11:50 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
6812c0c86d
Merge pull request #3253 from JoshMcguigan/new_ret_no_self-3220
new_ret_no_self
2018-10-13 20:10:51 +02:00
Josh Mcguigan
c6f79c7ba0 explicit_counter_loop fix #3308 false positive 2018-10-13 06:57:52 -07:00
Josh Mcguigan
3f386d33f9 new_ret_no_self test remove tool lints cfg flag 2018-10-13 06:33:46 -07:00
Josh Mcguigan
54506705ce Added new_ret_no_self exception to clippy to pass dogfood tests 2018-10-13 06:25:10 -07:00
Josh Mcguigan
348d18ebd8 Removed new_ret_no_self tests from method.rs 2018-10-13 06:25:10 -07:00
Josh Mcguigan
a5e4805ecf new_ret_no_self correctly lint impl return 2018-10-13 06:20:39 -07:00
Josh Mcguigan
2ef4af7db2 Removed unused variables 2018-10-13 06:20:39 -07:00
Josh Mcguigan
1c4fa419f3 new_ret_no_self fix false positive for impl trait return with associated type self 2018-10-13 06:20:39 -07:00
Josh Mcguigan
13ce96c4bf new_ret_no_self corrected panic and added test stderr 2018-10-13 06:20:39 -07:00
Josh Mcguigan
eb854b233c new_ret_no_self added positive test cases 2018-10-13 06:20:39 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
8b12eee112
Merge pull request #3233 from rust-lang-nursery/unused-unit
new lint: unused_unit
2018-10-13 09:30:19 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
78860a71d8
Merge pull request #3298 from devonhollowood/pedantic-dogfood-naming
Pedantic dogfood: naming and docs
2018-10-13 09:24:55 +02:00
Devon Hollowood
335bc1e820 Fix some more stutter warnings 2018-10-12 17:07:48 -07:00
Andre Bogus
e8687a6677 unused unit lint 2018-10-13 00:42:55 +02:00