Samuel E. Moelius III
a4ebf6f78e
Change unnecessary_to_owned into_iter suggestions to MaybeIncorrect
2022-01-05 05:05:36 -05:00
flip1995
e45842e360
Merge remote-tracking branch 'upstream/master' into rustup
2021-12-30 14:17:53 +01:00
bors
bb7b6beca3
Auto merge of #8133 - surechen:fix_8128, r=xFrednet
...
Fix 8128
Fixes #8128
changelog: Fix error suggestion of `skip(..).next()` for immutable variable.
2021-12-26 14:05:35 +00:00
surechen
4ffd66074a
Fixes #8128
...
changelog: Fix error suggestion of skip(..).next() for immutable variable.
2021-12-26 21:37:57 +08:00
Piotr Mikulski
2a47dbc7a6
Simplify code
2021-12-23 22:12:08 -08:00
Piotr Mikulski
01b7411482
Refactor
2021-12-23 22:00:20 -08:00
Piotr Mikulski
4b3a87f886
clippy
2021-12-23 21:47:31 -08:00
Piotr Mikulski
8b19845ffb
refactor
2021-12-23 21:46:21 -08:00
Piotr Mikulski
ab77c924e9
cargo dev fmt
2021-12-23 21:44:13 -08:00
Piotr Mikulski
26cc55133e
rewrite the PR
2021-12-23 21:41:25 -08:00
Piotr Mikulski
79cf41297a
Imrpove unwrap_or_else_default
2021-12-23 19:16:05 -08:00
bors
879eccead7
Auto merge of #91957 - nnethercote:rm-SymbolStr, r=oli-obk
...
Remove `SymbolStr`
This was originally proposed in https://github.com/rust-lang/rust/pull/74554#discussion_r466203544 . As well as removing the icky `SymbolStr` type, it allows the removal of a lot of `&` and `*` occurrences.
Best reviewed one commit at a time.
r? `@oli-obk`
2021-12-19 09:31:37 +00:00
flip1995
ece0946d7f
Merge commit '23d11428de3e973b34a5090a78d62887f821c90e' into clippyup
2021-12-17 13:40:22 +01:00
flip1995
fad9407c5a
Merge remote-tracking branch 'upstream/master' into rustup
2021-12-17 13:22:25 +01:00
Samuel E. Moelius III
b8913894a1
Expand is_clone_like comment
2021-12-15 05:25:47 -05:00
Nicholas Nethercote
a83c935a18
Remove unnecessary sigils around Ident::as_str() calls.
2021-12-15 17:32:42 +11:00
Nicholas Nethercote
ecd4919ebb
Remove unnecessary sigils around Symbol::as_str() calls.
2021-12-15 17:32:14 +11:00
Nicholas Nethercote
a89a063ba0
Remove SymbolStr.
...
By changing `as_str()` to take `&self` instead of `self`, we can just
return `&str`. We're still lying about lifetimes, but it's a smaller lie
than before, where `SymbolStr` contained a (fake) `&'static str`!
2021-12-15 13:30:26 +11:00
Samuel E. Moelius III
3beb6b1908
Address review comments
2021-12-14 18:36:19 -05:00
Samuel E. Moelius III
cb609a9904
Add comma
2021-12-13 12:27:47 -05:00
Esteban Kuber
d8af82e4bb
Fix clippy uses of QPath::LangItem
2021-12-13 17:09:16 +00:00
Samuel E. Moelius III
3807905e08
Handle to_vec on for loop expression #8069
2021-12-13 07:04:57 -05:00
Samuel E. Moelius III
290f74be4e
Address review comments
...
* Share a list of methods with `implicit_clone`
* Ensure no overlap with `redundant_clone`
2021-12-13 06:31:17 -05:00
Samuel E. Moelius III
468c86e4a3
Add unnecessary_to_owned lint
2021-12-13 06:31:17 -05:00
Cameron Steffen
284b63a687
Rename remove_blocks to peel_blocks
2021-12-06 12:33:02 -06:00
flip1995
8fea1d94f3
Merge commit 'a5d597637dcb78dc73f93561ce474f23d4177c35' into clippyup
2021-12-06 12:33:31 +01:00
nixx quality
e3c60444ce
fix some false negatives for single_char_pattern
2021-12-05 17:33:52 +01:00
bors
9eabec9f07
Auto merge of #8054 - camsteffen:map-flatten-style, r=giraffate
...
Upgrade map_flatten to complexity
changelog: upgrade [`map_flatten`] to complexity
Resolves #7999
2021-12-04 13:30:09 +00:00
Cameron Steffen
de9de4fef1
Upgrade map_flatten to complexity
2021-12-03 13:21:48 -06:00
frobiac
5cc451bc6c
Escape backslash for singe_char_pattern.rs
2021-12-02 23:47:23 +01:00
bors
d5d830a50f
Auto merge of #7463 - ThibsG:find_any_7392, r=xFrednet
...
Fix `any()` not taking reference in `search_is_some` lint
`find` gives reference to the item, but `any` does not, so suggestion is broken in some specific cases.
Fixes : #7392
changelog: [`search_is_some`] Fix suggestion for `any()` not taking item by reference
2021-12-02 17:27:54 +00:00
flip1995
abddd6c491
Merge remote-tracking branch 'upstream/master' into rustup
2021-12-02 09:32:09 +00:00
Camille GILLOT
56533d9e87
Take a LocalDefId in expect_*item.
2021-11-28 21:09:45 +01:00
togami2864
f51bbc7db9
apply iter_cloned_collect to copied()
2021-11-28 23:59:31 +09:00
ThibsG
092fe209a6
Move deref closure builder to clippy_utils::sugg module
2021-11-20 15:48:21 +01:00
ThibsG
5ebede0c14
Fix full projection identifier + move applicability to MaybeIncorrect
2021-11-20 09:40:11 +01:00
ThibsG
1176b8e5e9
Handle closures with type annotations on args
2021-11-20 09:40:11 +01:00
ThibsG
2ff702cbb5
Rephrase the fn checking for a double ref, not only one
2021-11-20 09:40:11 +01:00
ThibsG
abaaf744fd
Add some notes about MethodCall cases
2021-11-20 09:40:11 +01:00
ThibsG
90a72f506c
Handle args taken by ref also for MethodCall
2021-11-20 09:40:11 +01:00
ThibsG
7a55407cc3
Fix suggestions when call functions involved taking by ref
2021-11-20 09:40:11 +01:00
ThibsG
6d1ccbf466
Correct suggestion when dereferencing enough, calling a function
2021-11-20 09:40:11 +01:00
ThibsG
ac45a83ad5
Handle multiple reference levels into binding type and add more tests
2021-11-20 09:40:11 +01:00
ThibsG
788c9ccc93
Applying refactoring for simplified code
2021-11-20 09:40:11 +01:00
ThibsG
91dd9c46de
Handle other projection kinds
2021-11-20 09:40:11 +01:00
ThibsG
97783a8cb9
Return a struct and add applicability
2021-11-20 09:40:11 +01:00
ThibsG
d0dd797709
Build end of suggestion only once at the end of the process
2021-11-20 09:40:11 +01:00
ThibsG
9ab4b673eb
Simplifying next_pos init
2021-11-20 09:40:11 +01:00
ThibsG
e24aba2c1a
Use applicability for snippets
2021-11-20 09:40:11 +01:00
ThibsG
6dca4f261d
Add some doc for search_is_some lint
2021-11-20 09:40:11 +01:00
