bors[bot]
f9f1effd01
Merge #2160
...
2160: Set `deprecated` field on `CompletionItem`s r=matklad a=martskins
This PR aims to address #2042 by setting the deprecated field for completion items.
The setting the tags field for LSP 3.15 part still needs fixing, but that one is blocked due to lsp-types not being up to date with 3.15 yet.
Co-authored-by: Martin Asquino <martin.asquino@gmail.com>
2019-11-03 14:41:30 +00:00
Edwin Cheng
c26fb1abb3
Fix snapshots line-ending in windows
2019-11-03 12:01:25 +08:00
Martin Asquino
ccf8817d18
Use bool
instead of Option<bool>
and print it's value only when true
2019-11-02 19:33:34 -03:00
bors[bot]
5d96ade594
Merge #2164
...
2164: Silence some warnings r=matklad a=lnicola
```
warning: unnecessary parentheses around type
--> crates/ra_tt/src/buffer.rs:114:32
|
114 | pub fn end(self) -> Option<(&'a Subtree)> {
| ^^^^^^^^^^^^^ help: remove these parentheses
|
= note: `#[warn(unused_parens)]` on by default
warning: unnecessary parentheses around type
--> crates/ra_tt/src/buffer.rs:130:30
|
130 | fn entry(self) -> Option<(&'a Entry<'a>)> {
| ^^^^^^^^^^^^^^^ help: remove these parentheses
```
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2019-11-02 22:23:30 +00:00
Laurențiu Nicola
c7b7d7e666
Silence some warnings
2019-11-03 00:19:08 +02:00
bors[bot]
151efb2198
Merge #2162
...
2162: Move diagnostics to hir_expand r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-11-02 20:43:23 +00:00
Aleksey Kladov
13735d91a7
Move diagnostics to hir_expand
2019-11-02 23:42:38 +03:00
Martin Asquino
dc3848a6a3
Set deprecated
field on CompletionItem
s
2019-11-02 17:37:47 -03:00
Aleksey Kladov
b8533413cf
Move Source to hir_expand
2019-11-02 23:11:27 +03:00
bors[bot]
2d142a17ef
Merge #2159
...
2159: Remove forcing \n via rustfmt r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-11-02 19:21:45 +00:00
Aleksey Kladov
7f1903ed46
Remove forcing \n via rustfmt
...
The original idea here was to make sure, on CI, that line endings are
\n. Travis however uses autocrlf, so the check doesn't actually work,
and forcing \n otherwise makes lives of windows folks difficult
closes #2157
2019-11-02 22:19:59 +03:00
bors[bot]
5c2c686a1e
Merge #2156
...
2156: Upgrade Chalk r=flodiebold a=flodiebold
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
2019-11-02 14:32:46 +00:00
Florian Diebold
c5e44b2084
Upgrade Chalk
2019-11-02 15:32:08 +01:00
bors[bot]
eb8f76a86f
Merge #2152
...
2152: Use run-time project path in xtask r=matklad a=lnicola
Fixes #2131 .
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2019-11-01 20:25:17 +00:00
Laurențiu Nicola
e3354c1496
Use run-time project path in xtask
2019-11-01 22:20:44 +02:00
bors[bot]
9db97820f4
Merge #2151
...
2151: Resolve (and complete) trait calls like `Vec::default()` r=flodiebold a=flodiebold
Similar to rustc, we do this using the same code as the method call resolution, just without doing autoderef (and considering more potential candidates).
(Btw, we currently don't complete methods with `self` in path notation, even though they'd be legal to use, so maybe we should -- on the other hand, that will usually not be the most interesting completions...)
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
2019-11-01 19:03:05 +00:00
Florian Diebold
8952380884
Change SourceAnalyzer method resoltion API
2019-11-01 20:01:21 +01:00
Florian Diebold
b29092ade3
Various review fixes
2019-11-01 19:57:08 +01:00
Florian Diebold
dc4066ebed
Add some doc comments
2019-11-01 19:57:08 +01:00
Florian Diebold
77c26c2bf1
Complete items on traits as well
2019-11-01 19:57:08 +01:00
Florian Diebold
79cb0a0dab
Complete trait assoc items
2019-11-01 19:57:08 +01:00
Florian Diebold
5da941897d
Add failing tests for trait assoc method completion
2019-11-01 19:57:08 +01:00
Florian Diebold
b0bf1deb7c
Refactor a bit
2019-11-01 19:57:08 +01:00
Florian Diebold
f4181deb0d
Don't do autoderef for path resolution
2019-11-01 19:57:08 +01:00
Florian Diebold
1173c3dab5
Refactor to unify with method resolution
2019-11-01 19:57:08 +01:00
Florian Diebold
c7cedea270
Record assoc item resolution
2019-11-01 19:57:08 +01:00
Florian Diebold
7b7133ec58
Insert type vars before doing assoc item resolution
2019-11-01 19:57:08 +01:00
Florian Diebold
44279ef1df
Add another unrelated, currently not working test
2019-11-01 19:57:08 +01:00
Florian Diebold
b634ba41e0
Get trait assoc item resolution mostly working
2019-11-01 19:57:08 +01:00
krk
bc14f500a0
Extract common parts of match arms in convert_to_guarded_return assist.
2019-11-01 18:34:42 +01:00
krk
91ab3f8760
Support paths other than "Some".
2019-11-01 18:18:58 +01:00
krk
1841a39f86
Remove variable pat.
2019-11-01 16:58:09 +01:00
bors[bot]
ed5212e1ac
Merge #2150
...
2150: Attach docs to statics r=matklad a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
2019-11-01 14:19:47 +00:00
bors[bot]
363718ba42
Merge #2147
...
2147: Fixes #2143 r=matklad a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
2019-11-01 13:59:59 +00:00
kjeremy
dcc0a9cd7e
Attach docs to statics
2019-10-31 16:21:46 -04:00
krk
4a4d9f7a90
Handle IfLet in convert_to_guarded_return.
2019-10-31 21:10:58 +01:00
kjeremy
c46be83a34
Fixes #2143
2019-10-31 13:29:56 -04:00
bors[bot]
5451bfb9a1
Merge #2145
...
2145: updates r=matklad a=kjeremy
Pulls in new num_cpus which fixes an issue on AMD.
Co-authored-by: kjeremy <kjeremy@gmail.com>
2019-10-31 14:50:07 +00:00
kjeremy
35f907fc21
updates
2019-10-31 10:31:59 -04:00
bors[bot]
9421e5be35
Merge #2144
...
2144: move struct & enum data to hir_def r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-10-31 13:41:12 +00:00
Aleksey Kladov
09f9733ca6
move struct & enum data to hir_def
2019-10-31 16:40:36 +03:00
bors[bot]
d067afb064
Merge #2141
...
2141: add ModuleDefId to hir_def r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-10-31 08:24:03 +00:00
Aleksey Kladov
1602db7d7d
add ModuleDefId to hir_def
2019-10-31 11:23:30 +03:00
bors[bot]
7973c91281
Merge #2140
...
2140: move builtin types to hir_def r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-10-31 07:55:15 +00:00
Aleksey Kladov
b20d37cb49
move builtin types to hir_def
2019-10-31 10:51:54 +03:00
bors[bot]
51092ee72a
Merge #2139
...
2139: move mod_resolution to hir_def r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-10-31 07:34:39 +00:00
Aleksey Kladov
6f4d5f7339
move mod_resolution to hir_def
2019-10-31 10:31:29 +03:00
bors[bot]
37eaa840bb
Merge #2134 #2137
...
2134: More match ast r=matklad a=kjeremy
Use `match_ast!` in more places
2137: Add link to the vscode VIM extension compatibility warning. r=matklad a=krk
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/1831
Co-authored-by: kjeremy <kjeremy@gmail.com>
Co-authored-by: krk <keremkat@gmail.com>
2019-10-30 21:04:58 +00:00
bors[bot]
f70d3e41cf
Merge #2136
...
2136: Fix typo in xtask/src/main.rs. r=kjeremy a=krk
Co-authored-by: krk <keremkat@gmail.com>
2019-10-30 20:54:23 +00:00
krk
9bbb27604d
Add link to the vscode VIM extension compatibility warning.
2019-10-30 21:44:27 +01:00