bors
c1021b806c
Auto merge of #6706 - Y-Nak:excessive-for-each, r=camsteffen
...
New Lint: needless_for_each
resolves : #6543
changelog: Added pedantic lint: `needless_for_each`
2021-03-31 15:59:55 +00:00
Joshua Nelson
1086d9b7b5
Rename CrateSpecific -> InvocationSpecific
2021-03-31 11:55:34 -04:00
Joshua Nelson
d4f3f91c48
Enforce that Toolchain files are static and Crate files are dynamic
...
This also changes custom themes from Toolchain to Crate files.
2021-03-31 11:55:30 -04:00
Eric Loren
56fbbf7b8f
Suggest flatten instead of is_some -> unwrap
2021-03-31 11:35:24 -04:00
Hameer Abbasi
38b31691a7
Fix compiletest to use correct bitwidth stderr files.
2021-03-31 15:30:07 +00:00
Camille GILLOT
f3dde45d2a
Enable debugging the dep-graph without debug-assertions.
...
It may also be useful in these cases,
and some CI configurations test without debug assertions.
2021-03-31 17:12:06 +02:00
Yoshitomo Nakanishi
e61f9782c8
Tweak a suggestion message of needless_for_each
2021-04-01 00:08:59 +09:00
Yoshitomo Nakanishi
bf1e3f7a9f
Skip needless_for_each if an input stmt is local
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
1109dc8838
Fix codes that make dogfood fail
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
f2cc995bcf
Remove method_calls
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
527fbbef48
Refactor excessive_for_each
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
5543c34699
Use ".." as default value of snippet in excessive_for_each
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
3843171299
Improve the document of excessive_for_each
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
25d8b94cec
Add comments to clarify why RetCollector is needed
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
ccd7a60023
Refactor: Remove duplicated codes from excessive_for_each
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
90cbbb2da3
Avoid to suggest using label
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
5bb0f16552
Trigger the lint iff exposure's body is ExprKind::Block.
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
54a04711ed
Change a category of excessive_for_each: Style -> Restriction
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
30952530c5
Fix codes that fails dogfood
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
5029dc805f
New Lint: excessive_for_each
2021-04-01 00:05:42 +09:00
bors
3e42c35b72
Auto merge of #6981 - matthiaskrgr:6803_take_2, r=flip1995
...
disable upper_case_acronyms for pub items - enum edition
Fixes https://github.com/rust-lang/rust-clippy/issues/6803 (again... 😅 )
My previous fix did not work for enums because enum variants were checked separately in the `check_variant` function but it looks like we can't use that because we can't tell if the enum the variants belong to is declared as public or not (it always said `Inherited` for me)
I went and special-cased enums and iterated over all the variants "manually", but only, if the enums is not public.
---
changelog: fix upper_case_acronyms still firing on public enums (#6803 )
2021-03-31 15:02:40 +00:00
bors
2e33bf6347
Auto merge of #6938 - Y-Nak:refactor-types, r=flip1995
...
Refactor types
r? `@flip1995`
This is the last PR to close #6724 🎉
Also, this fixes #6936 .
changelog: `vec_box`: Fix FN in `const` or `static`
changelog: `linkedlist`: Fix FN in `const` or `static`
changelog: `option_option`: Fix FN in `const` or `static`
2021-03-31 14:35:48 +00:00
Jack Huey
7108918db6
Cleanups and comments
2021-03-31 10:16:37 -04:00
Jack Huey
0c98dc66fd
Fix tests and AstConv -> dyn AstConv
2021-03-31 10:16:37 -04:00
Jack Huey
4ff65ec782
Fmt and test revert
2021-03-31 10:16:37 -04:00
Jack Huey
8ad7e5685e
Fix new problem from rebase and a little cleanup
2021-03-31 10:16:37 -04:00
Jack Huey
6d5efa9f04
Add var to BoundRegion. Add query to get bound vars for applicable items.
2021-03-31 10:16:37 -04:00
Jack Huey
666859a6f8
Make late and late_anon regions track the bound var position
2021-03-31 10:15:56 -04:00
Jack Huey
84f82d348c
Revert explicit lifetimes
2021-03-31 10:15:56 -04:00
Jack Huey
b438e30fa6
Track bound vars
2021-03-31 10:15:27 -04:00
Jack Huey
30187c81f6
Track bound vars
2021-03-31 10:15:27 -04:00
Jack Huey
62a49c3bb8
Add tcx lifetime to Binder
2021-03-31 10:13:57 -04:00
Jack Huey
74851f4cf3
count bound vars
2021-03-31 10:11:47 -04:00
Frank Steffahn
7509aa108c
Apply suggestions from code review
...
More links, one more occurrence of “a OsString”
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2021-03-31 16:09:25 +02:00
Jack Huey
97a22a4f9c
Add u32 for bound variables to Binder
2021-03-31 10:05:32 -04:00
Jack Huey
4955d755d3
Some rebinds and dummys
2021-03-31 10:05:32 -04:00
Frank Steffahn
f5e7dbb20a
Add a few missing links, fix a typo
2021-03-31 16:02:59 +02:00
Frank Steffahn
e7821e5475
Fix documentation of conversion from String to OsString
2021-03-31 16:02:52 +02:00
Matthias Krüger
225f7e0617
lintcheck: warn if checking a program results in bad exit status
2021-03-31 14:36:56 +02:00
Matthias Krüger
6ee14697d4
update lintcheck logs
2021-03-31 14:31:26 +02:00
Oli Scherer
74af01b989
Revert tests
2021-03-31 11:33:15 +00:00
Oli Scherer
d139968d19
bail out early when substituting mir constants that don't need substituting
2021-03-31 10:40:45 +00:00
Oli Scherer
4e8edfb5c2
Forward some layouts to prevent recomputation
2021-03-31 10:40:45 +00:00
Oli Scherer
dbacfbc368
Add a new normalization query just for mir constants
2021-03-31 10:40:42 +00:00
JohnTitor
ce6658818d
Add a regression test for issue-68830
2021-03-31 18:48:28 +09:00
Hameer Abbasi
f80b9acf20
Add 32bit.stderr files.
2021-03-31 09:33:45 +00:00
Oli Scherer
c7c39ce6d0
We should never see unevaluated type-level constants after monomorphization unless errors occurred
2021-03-31 09:13:45 +00:00
Oli Scherer
1d56b8a2bc
Make unevaluated DefId rendering deterministic
2021-03-31 09:13:45 +00:00
Aman Arora
e78fac5601
Handle the case of partially captured drop type
2021-03-31 04:40:31 -04:00
bors
a5029ac0ab
Auto merge of #83684 - cjgillot:csp, r=petrochenkov
...
Remove hir::CrateItem.
The crate span is exactly the crate module's inner span. There is no need to store it twice.
2021-03-31 08:34:40 +00:00
