bors
06722c0c15
Auto merge of #7775 - F3real:no_effect, r=xFrednet
...
Detect underscored variables with no side effects
Fixes #7545
changelog: Lint on underscored variables with no side effects in [`no_effect`]
2021-10-20 09:33:45 +00:00
bors
ee8c155527
Auto merge of #7840 - dswij:question-mark-result, r=llogiq
...
Cover `Result` for `question_mark`
closes #7135
changelog: [`question_mark`] now covers `Result`
2021-10-20 07:27:13 +00:00
dswij
083a4546f6
Small refactor on question_mark condition checks
2021-10-20 13:41:44 +08:00
Michael Wright
1ede540b21
Fix false positive in match_overlapping_arm
...
The bug was dues to the constant bytes being compared instead of their
values. This meant that negative values were being treated as larger
than some positive values.
Fixes #7829
2021-10-20 06:13:42 +02:00
Michael Wright
c4d5471a45
Add test for #7829
2021-10-20 06:13:42 +02:00
Michael Wright
4679eb3a0d
Move const int value code to utils
2021-10-20 06:13:42 +02:00
bors
5bdd2cebe2
Auto merge of #7833 - Dmitry-Borodin:patch-1, r=giraffate
...
Add reference to another doc with explanation
Add reference to another doc that explains which repository should be passed in this command since this is not covered in the command help itself.
changelog: none
2021-10-19 23:47:20 +00:00
F3real
6b22bba902
Lint on underscore variable assignment
...
Fix tests after no_effect update
Add a drop testcase
Don't lint _ variables in macro expansion
Address review comments and update tests
Don't shadow unnecessary operation lint if no_effect is allowed
Revert shadowing change and remove no_effect allows
Update clippy_lints/src/no_effect.rs
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Update clippy_lints/src/no_effect.rs
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Address review comments
2021-10-20 00:39:28 +02:00
Nathaniel Hamovitz
0f9f591e30
Rename lint
2021-10-19 14:33:43 -07:00
Nathaniel Hamovitz
60da4c9cb6
remove resolved note
2021-10-19 14:23:55 -07:00
bors
c1e7a07c9c
Auto merge of #7811 - rust-lang:eq-op-testless, r=xFrednet
...
avoid `eq_op` in test code
Add a check to `eq_op` that will avoid linting in functions annotated with `#[test]`
---
*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: avoid `eq_op` in test functions
2021-10-19 19:54:40 +00:00
Yuki Okushi
30cc96efce
Rollup merge of #88860 - nbdd0121:panic, r=m-ou-se
...
Deduplicate panic_fmt
std's begin_panic_fmt and core's panic_fmt are duplicates. Merge them to declutter code and remove a lang item.
2021-10-20 04:35:14 +09:00
Andre Bogus
e88c956e1e
avoid eq_op in test code
2021-10-19 21:02:30 +02:00
Dmitry Borodin
7246731ad8
made description of intellij a link by moving outside of code block.
2021-10-19 20:33:39 +02:00
Gary Guo
ebf4f03f7d
Remove begin_panic_fmt from clippy
2021-10-19 15:15:59 +01:00
dswij
3fc99b6a33
Update test for question_mark to cover Result
2021-10-19 18:50:49 +08:00
dswij
687f3925da
Cover Result for question_mark
2021-10-19 18:50:49 +08:00
Nathaniel Hamovitz
5283d24b38
formatting 🙃
2021-10-18 18:42:01 -07:00
Nathaniel Hamovitz
4c8e816972
Use real type in doc examples
2021-10-18 18:32:00 -07:00
Nathaniel Hamovitz
02b1f266d6
Remove explicit lifetime
2021-10-18 18:20:35 -07:00
Nathaniel Hamovitz
bc32be0fec
Remove comment
2021-10-18 18:03:00 -07:00
Nathaniel Hamovitz
c654cc56da
One more test + final tidying
2021-10-18 17:41:27 -07:00
Nathaniel Hamovitz
6303d2d075
Revert "!: this is the commit that demonstrates the ICE"
...
This reverts commit d85f903c91
2021-10-18 17:18:07 -07:00
Nathaniel Hamovitz
d85f903c91
!: this is the commit that demonstrates the ICE
2021-10-18 17:07:51 -07:00
Nathaniel Hamovitz
48cf9c284a
Don't need rustc_attr anymore
2021-10-18 16:53:17 -07:00
Nathaniel Hamovitz
18c863dd0e
Improve help message
2021-10-18 16:53:05 -07:00
Nathaniel Hamovitz
d8bacf078a
All five has_repr_attr agree + are correct
2021-10-18 15:33:11 -07:00
Nathaniel Hamovitz
3a41f226c5
Exploring emitting other sorts of spans
2021-10-18 07:02:00 -07:00
Nathaniel Hamovitz
ab9fa25e82
Better testcase names
2021-10-18 04:59:03 -07:00
Nathaniel Hamovitz
d25b4eeefb
One more test
2021-10-18 04:22:43 -07:00
Nathaniel Hamovitz
5b78907be7
Still renaming lmao
2021-10-18 03:56:49 -07:00
Nathaniel Hamovitz
a54dbf6445
Improve doc and span messages
2021-10-18 03:52:57 -07:00
Nathaniel Hamovitz
a6aa9864a3
Rename stderr
2021-10-18 03:52:37 -07:00
Nathaniel Hamovitz
7f84e3d791
Rename lint
2021-10-18 03:45:08 -07:00
Nathaniel Hamovitz
149b372873
run rustfmt
2021-10-18 03:16:10 -07:00
Nathaniel Hamovitz
6377fb2fe7
Tidy import + update expected stderr
2021-10-18 03:13:48 -07:00
Nathaniel Hamovitz
cd6862283e
Tidy imports
2021-10-18 03:05:19 -07:00
Nathaniel Hamovitz
9f402b370c
Check for tuple structs
2021-10-18 03:05:19 -07:00
Nathaniel Hamovitz
2a5a4f07cf
Refactor ZS array detection again and this one seems great 👍
2021-10-18 03:05:19 -07:00
Nathaniel Hamovitz
c5d3167a23
update testsuite and expand if_chain
2021-10-18 03:05:19 -07:00
Nathaniel Hamovitz
a3420f7004
Tidy comments + tests; revert 'size-is-zero' detection
2021-10-18 03:05:19 -07:00
Nathaniel Hamovitz
9b3f55ee61
tried to simplify but it doesn't work :/
2021-10-18 03:05:19 -07:00
Nathaniel Hamovitz
5fdf93415b
intermediate step
2021-10-18 03:05:19 -07:00
Nathaniel Hamovitz
003972f428
add multiple get_attrs and includes_repr and they all work!
2021-10-18 03:05:18 -07:00
Nathaniel Hamovitz
b9948c4be6
Ran dev bless!
2021-10-18 03:05:18 -07:00
Nathaniel Hamovitz
4b4db59772
output looks fantastic
2021-10-18 03:05:18 -07:00
Nathaniel Hamovitz
e53a4da4a1
it works i think (incl some dbgs)
2021-10-18 03:05:18 -07:00
Nathaniel Hamovitz
523b013161
Implement getting an array of attributes!
2021-10-18 03:05:18 -07:00
Nathaniel Hamovitz
7ee8e7a9b8
Implement detecting trailing zero-sized array
2021-10-18 03:05:18 -07:00
Nathaniel Hamovitz
92d3b775bd
ayy it compiles! ship it, right? 😎 /s
...
why was `rustc_lint_defs` not already externed in `lib.rs`?
and how was r-a able to find it but cargo wasn't? 🤔
2021-10-18 03:05:18 -07:00
