Commit Graph

26684 Commits

Author SHA1 Message Date
Young-Flash
929544ef28 use check_assist_by_label to pick assist 2023-10-31 22:13:07 +08:00
Young-Flash
a723acf346 simplify the code 2023-10-31 21:03:26 +08:00
bors
a2e2881676 Auto merge of #15815 - Sarrus1:chore/fix-guide-url, r=lnicola
chore: fix urls in guide.md

This PR fixes two URLs in the guide.md file.
2023-10-30 18:49:16 +00:00
Sarrus1
9d290f1d4c
chore: fix urls in guide.md 2023-10-30 19:40:24 +01:00
bors
16f3398ff4 Auto merge of #15812 - cuishuang:master, r=lnicola
Fix some typos
2023-10-30 06:48:55 +00:00
cui fliter
9c99afe3aa Fix some typos
Signed-off-by: cui fliter <imcusg@gmail.com>
2023-10-30 10:31:50 +08:00
jprochazk
3e4de963a2 override language client 2023-10-28 16:34:00 +02:00
bors
f493207744 Auto merge of #15809 - Young-Flash:extract_variable_in_place, r=HKalbasi
feat: make extract_variable assist in place

![extract_variable_without_select](https://github.com/rust-lang/rust-analyzer/assets/71162630/96be2de4-42c9-4b24-b3e1-8b3e3a2da1d9)

close https://github.com/rust-lang/rust-analyzer/issues/15796
2023-10-28 06:20:35 +00:00
Young-Flash
7186a28717 chore: add unapplicable test for extract_variable without select 2023-10-28 10:06:09 +08:00
Young-Flash
00cdbe6c96 feat: make extract_variable assist in place 2023-10-27 21:16:34 +08:00
bors
46c395d570 Auto merge of #15806 - gigaroby:master, r=lnicola
internal: scip: update crate to version 0.3.1.

While the git repo has been updated constantly, crates.io has only now been updated after more than a year of activity.
2023-10-26 16:33:19 +00:00
Roberto Bampi
99ec3aa8a3 scip: update crate to version 0.3.1.
While the git repo has been updated constantly, crates.io has only now
been updated after more than a year of activity.
2023-10-26 16:20:06 +02:00
bors
2f6961aaaf Auto merge of #15780 - Young-Flash:auto_import, r=lnicola
fix: import trait if needed for `unqualify_method_call` assist

before:

![before](https://github.com/rust-lang/rust-analyzer/assets/71162630/66fda67d-afcb-453f-91a9-7e85993c3d2a)

after:

![after](https://github.com/rust-lang/rust-analyzer/assets/71162630/72ffbda4-1615-4413-836e-480eb52e9728)

follow up https://github.com/rust-lang/rust-analyzer/pull/13825
2023-10-23 16:56:22 +00:00
Young-Flash
45ee88f9cb fix: remove unwrap 2023-10-23 23:12:07 +08:00
bors
10872952c0 Auto merge of #15789 - HKalbasi:unused-var, r=HKalbasi
Store binding mode for each instance of a binding independently

fix #15787
2023-10-22 20:26:11 +00:00
hkalbasi
8b82ea4f51 Store binding mode for each instance independently 2023-10-22 23:35:33 +03:30
Young-Flash
4f5f7e2800 feat: import trait with alias 2023-10-22 21:39:00 +08:00
bohan
d20471334f use visibility to check unused imports and delete some stmts 2023-10-22 21:27:46 +08:00
bors
7c11399b6b Auto merge of #15786 - lnicola:detect-insiders, r=lnicola
fix: Fix VS Code detection for Insiders version

Addresses https://github.com/rust-lang/rust-analyzer/discussions/15784.
2023-10-21 16:10:22 +00:00
Laurențiu Nicola
094cecd3bd Fix VS Code detection for Insiders version 2023-10-21 19:08:41 +03:00
bors
954fb1d673 Auto merge of #15727 - DaniPopes:lintgen-unstable-book, r=HKalbasi
feat: generate descriptors for all unstable features

Most unstable features don't have their own chapter in the unstable book, so a rustc helper tool (`src/tools/unstable-book-gen`) generates shims to fill the gaps.
Run this tool to generate the full unstable-book source before parsing it.
2023-10-20 16:42:23 +00:00
bors
bd38871a98 Auto merge of #15736 - rmehri01:15678_module_incorrect_case_diagnostics, r=HKalbasi
fix: add incorrect case diagnostics for module names

Adds diagnostics for checking both inline and file module names are snake case.

Closes #15678
2023-10-20 16:20:40 +00:00
bors
0cae1ca656 Auto merge of #15783 - lnicola:autopublish-space, r=lnicola
internal: Free up some disk space on auto-publish

`@bors` r+
2023-10-19 16:36:42 +00:00
Laurențiu Nicola
94eb142e6d Free up some disk space on auto-publish 2023-10-19 19:03:10 +03:00
Young-Flash
a7f77d89a9 fix: auto import trait if needed 2023-10-19 17:34:17 +08:00
bors
4586a6b26c Auto merge of #15779 - Veykril:open-docs, r=Veykril
Add command for only opening external docs and attempt to fix vscode-remote issue

opening URI in a remote env causes vscode to ask the OS to handle `vscode-remote` URIs as there is no handler registered for such a scheme. This attempts to instruct vscode to handle those.

This is untested, as I can't figure out how to open a debug session on WSL rn.
2023-10-18 12:13:01 +00:00
Lukas Wirth
4296fe52ba Add command for only opening external docs and attempt to fix vscode-remote issue 2023-10-18 14:06:07 +02:00
bors
7f1e6fdfee Auto merge of #15775 - Young-Flash:refactor, r=Veykril
refactor: change generated variable name

change generated variable name in `replace_is_some_with_if_let_some` assist

close https://github.com/rust-lang/rust-analyzer/issues/15765
2023-10-18 06:39:34 +00:00
Young-Flash
1a0fe58d81 refactor: change generated variable name 2023-10-17 17:34:11 +08:00
bors
d6afb4fa23 Auto merge of #15746 - pvalletbo:string-literals-diagnose, r=Veykril
String literals diagnose

Continues the work from #15744 to add diagnosis errors to Str, ByteStr, and CStr literal kinds.

Also replaces `unescape_char` for `unescape_byte` to use the correct method for Byte literals.
2023-10-16 18:23:22 +00:00
bors
2910dbf12d Auto merge of #15770 - lnicola:metrics-url, r=lnicola
internal: Fix metrics repo url
2023-10-16 13:35:33 +00:00
Laurențiu Nicola
490cdfecb5 Fix metrics repo url 2023-10-16 16:34:03 +03:00
bors
03f676ed1f Auto merge of #15769 - lnicola:metrics-ssh, r=lnicola
internal: Create `~/.ssh` before writing deploy key
2023-10-16 12:15:19 +00:00
Laurențiu Nicola
222be48858 Create .ssh before writing deploy key 2023-10-16 15:13:48 +03:00
bors
983094a32c Auto merge of #15764 - Wilfred:emacs_docs, r=lnicola
Expand Emacs documentation

Emacs 29 is now released, and include an example of enabling clippy.
2023-10-16 09:30:56 +00:00
Wilfred Hughes
03bec1112a Expand Emacs documentation
Emacs 29 is now released, and include an example of enabling clippy.
2023-10-15 16:34:23 -07:00
bors
6572ec8d94 Auto merge of #15691 - Veykril:rustc_abi, r=Veykril
Update rustc_abi dependency

cc https://github.com/rust-lang/rust/pull/116269
2023-10-15 17:01:38 +00:00
Lukas Wirth
40acc5250f Update rustc_abi dependency 2023-10-15 18:57:40 +02:00
bors
a8581aa0ff Auto merge of #15762 - Veykril:metrics-deploy, r=Veykril
fix: Fix metrics workflow to use deploy key

I think this should be correct
2023-10-15 16:02:36 +00:00
Lukas Wirth
d33fd15ecf Fix metrics workflow to use deploy key 2023-10-15 17:58:50 +02:00
bors
65532e417d Auto merge of #15755 - Young-Flash:cursor_selection, r=lnicola
fix: make cursor select at _tmp

Here make cursor select at `_tmp` atuomatically after the assist apply. Refer to [vscode snippet placeholder](https://code.visualstudio.com/docs/editor/userdefinedsnippets#_placeholders).

![cursor_selection](https://github.com/rust-lang/rust-analyzer/assets/71162630/a7866efe-2d54-488b-903e-9df039f34a7e)

following https://github.com/rust-lang/rust-analyzer/pull/15752
2023-10-15 07:41:29 +00:00
bors
dbe5392010 Auto merge of #15760 - ChristianSchott:master, r=HKalbasi
make mir::ProjectionStore-impls pub-accessible

When using RA as a crate the `mir::Place` `projection` is accessible, however there is no way to translate the `ProjectionId` to a `&[PlaceElem]`, as the `ProjectionId::lookup` is private.

Personally, I would only need the `ProjectionId::lookup`-fn to be `pub`, but I don't see any reason why the others should be kept private.. am I missing something `@HKalbasi` ?

Relates to: https://github.com/rust-lang/rust-analyzer/pull/15575
2023-10-14 18:07:56 +00:00
Christian Schott
8217ff9c16
make ProjectionStore-impls pub-accessible 2023-10-14 19:20:11 +02:00
bors
16ac6c284c Auto merge of #15756 - harpsword:fix_typo_in_mbe_lib, r=lnicola
fix typo in mbe/lib.rs comment

fix typo in mbe/lib.rs comment
2023-10-14 06:23:12 +00:00
harpsword
3f4368a090 fix: fix typo in mbe/lib.rs comment 2023-10-14 14:13:24 +08:00
Young-Flash
bc34e8f1ad feat: make cursor select at _tmp 2023-10-14 11:05:38 +08:00
bors
862693ff95 Auto merge of #15752 - Young-Flash:replace_is_method_with_if_let_method, r=HKalbasi
feat: add replace_is_ok_with_if_let_ok assist

following https://github.com/rust-lang/rust-analyzer/pull/15743
2023-10-13 07:32:55 +00:00
Young-Flash
5bbca22720 update mod order to adapt alphabetically sorted 2023-10-13 00:09:13 +08:00
Young-Flash
506b1e515b feat: add replace_is_ok_with_if_let_ok assist 2023-10-12 23:26:42 +08:00
bors
84e1d27343 Auto merge of #15743 - Young-Flash:replace_is_some_with_if_let_some, r=HKalbasi
add replace_is_some_with_if_let_some assist

This is a basic impl, if it is ok, `if my_result.is_ok()`-> `if let Ok(_x) = my_result ​`will be add next.

close https://github.com/rust-lang/rust-analyzer/issues/12977
2023-10-12 08:20:08 +00:00