Commit Graph

3817 Commits

Author SHA1 Message Date
Oliver Schneider
e08d8e4876
Merge pull request #2363 from rust-lang-nursery/appveyor
Fix appveyor
2018-01-19 13:25:17 +01:00
Oliver Schneider
71abd81d22 Update error count 2018-01-19 13:18:44 +01:00
Oliver Schneider
d9063b70d3 Don't run cargo clippy on appveyor 2018-01-19 13:14:44 +01:00
Oliver Schneider
248bef67f2 Don't run 32 bit checks on windows 2018-01-19 13:14:44 +01:00
Oliver Schneider
26f83d6218 Readd the .exe extension on windows 2018-01-19 13:14:44 +01:00
Oliver Schneider
b1001e47d6 Disable gnu builds on appveyor, rustc plugins are broken there 2018-01-19 13:14:43 +01:00
Oliver Schneider
920fc17485 Don't run dogfood on windows or in the rustc test suite 2018-01-19 13:14:43 +01:00
Oliver Schneider
70302595a4
Merge branch 'master' of github.com:Manishearth/rust-clippy into fold_any 2018-01-19 12:10:24 +01:00
Oliver Schneider
9a2c50f3d6
Merge pull request #2364 from flip1995/precedence
Add macro check to precedence lint
2018-01-19 12:07:00 +01:00
Oliver Schneider
4bd7ed234e
Merge pull request #2382 from rust-lang-nursery/oli-obk-patch-1
Disable osx builder on travis
2018-01-19 09:43:25 +01:00
Oliver Schneider
8e03769bd2
Disable osx builder on travis 2018-01-19 09:16:33 +01:00
Oliver Schneider
3c6064130b
Merge pull request #2367 from etaoins/inline-fn-without-body-lint
Lint for trait methods without bodies
2018-01-19 09:14:46 +01:00
Oliver Schneider
26c415ab2d
Merge pull request #2381 from HMPerson1/remove_is_unit_expr
Replace `is_unit_expr`
2018-01-19 09:14:04 +01:00
Oliver Schneider
8a53d90241
Merge pull request #2299 from mikerite/option_option_pr
Implemented option_option lint
2018-01-19 08:25:17 +01:00
Michael Wright
79c6c60f51 Added further tests 2018-01-19 08:10:09 +02:00
Michael Wright
fca248957b Merge branch 'master' into option_option_pr 2018-01-19 07:56:46 +02:00
HMPerson1
e09805e8ca
Use unit_expr 2018-01-18 17:33:09 -05:00
HMPerson1
7a6c03f876
Add is_unit_expr to deprecated lints list 2018-01-18 17:29:14 -05:00
Oliver Schneider
5a794d3ee9 Update compiletest 2018-01-18 23:05:29 +01:00
HMPerson1
8081f6fd6e
Replace is_unit_expr 2018-01-18 17:04:26 -05:00
Oliver Schneider
10c96e50c3
Don't run dogfood tests in the rustc test suite 2018-01-18 22:02:58 +01:00
Oliver Schneider
cdd643842f
Merge pull request #2375 from rust-lang-nursery/needless-range
Various needless_pass_by_value false positive fixes
2018-01-18 14:46:36 +01:00
Oliver Schneider
8217e33718
Only suggest implementing Copy if it can actually be done 2018-01-18 14:27:47 +01:00
Ryan Cumming
7467b83377 Suggest removing inline attributes
This adds a `suggest_remove_item` helper that will remove an item and
all trailing whitespace. This should handle both attributes on the same
line as the function and on a separate line; the function takes the
position of the original attribute.
2018-01-18 20:02:42 +11:00
Ryan Cumming
5f3c340bfb Lint for trait methods without bodies
As discussed in rust-lang/rust#47475 the #[inline] attribute is
currently allowed on trait methods without bodies (i.e. without a
default implementation). This is misleading as it could be interpreted
as affecting the implementations of the trait method. Add a lint for any
use of #[inline] on a trait method without a body.

Fixes rust-lang/rust#47475
2018-01-18 20:01:24 +11:00
Manish Goregaokar
552e950080 needless_pass_by_value: Whitelist RangeArgument (fixes #2357) 2018-01-18 14:30:53 +05:30
Manish Goregaokar
2a30c8a194 needless_pass_by_value: Add suggestion for implementing Copy (fixes #2222) 2018-01-18 14:30:47 +05:30
Manish Goregaokar
cf1fbaa36a needless_pass_by_value: Ignore for extern funcs (fixes #1844) 2018-01-18 14:30:32 +05:30
Oliver Schneider
9a5f25aab3
Merge pull request #2370 from Vlad-Shcherbina/patch-1
Document map_clone known problems #498
2018-01-18 09:10:39 +01:00
Michael Wright
bf7efead17 Rename variable
Rename `vec` to `ty` in `match_type_parameter`. This variable is a type
and not a vector. Previously it would only refer to `Vec<_>` so the name used
to make sense.
2018-01-18 07:52:24 +02:00
Michael Wright
d13af87d8a Fixed tests 2018-01-18 07:48:03 +02:00
Michael Wright
ec60baa864 Merge branch 'master' into option_option_pr 2018-01-18 07:21:48 +02:00
Phil Ellison
a324a2bc38 Fix typos 2018-01-17 21:54:09 +00:00
Phil Ellison
b73efad600 Add some reviewer comments 2018-01-17 21:06:16 +00:00
Phil Ellison
9806b31d53 Rename lint, improve documentation 2018-01-17 20:21:29 +00:00
Phil Ellison
29a2dd4cb8 Fix bug. Don't expect lint when acc is on rhs 2018-01-17 20:11:40 +00:00
Phil Ellison
1cac693bc7 Lint on folds implementing .all, .sum and .product 2018-01-17 19:12:44 +00:00
Vlad-Shcherbina
ada0d2c548
Document map_clone known problems #498 2018-01-17 21:40:47 +03:00
Oliver Schneider
41ea14dda8
Merge pull request #2309 from rust-lang-nursery/rustc-monitor
Use rustc_driver::run
2018-01-17 15:38:22 +01:00
Oliver Schneider
4f21b5b112
Update changed ui tests 2018-01-17 14:44:40 +01:00
Manish Goregaokar
3c4f5bfae2
Use rustc_driver::run (fixes #2303)
This internally uses monitor() which catches panics and stuff
2018-01-17 14:04:42 +01:00
Oliver Schneider
a2fdfc05d7
Merge pull request #2298 from goodmanjonathan/else_if_without_else
add new lint else_if_without_else
2018-01-17 09:35:58 +01:00
Michael Wright
e7567f2eac Made requested changes 2018-01-17 07:24:33 +02:00
Michael Wright
21fde9a9d1 Merge branch 'master' into option_option_pr 2018-01-17 06:52:00 +02:00
Phil Ellison
a64d19cc0e Fix error span to play nicely with rustfix 2018-01-16 21:20:55 +00:00
Oliver Schneider
3d2d94b9c9
Merge pull request #2366 from rust-lang-nursery/const-static-fix
Show wider and more accurate suggestion for const_static_lifetime
2018-01-16 16:41:12 +01:00
Manish Goregaokar
37f62a54f8 Show wider and more accurate suggestion for const_static_lifetime
fixes #2365
2018-01-16 20:46:44 +05:30
flip1995
877321ba32 Add macro check to precedence lint 2018-01-16 15:52:16 +01:00
flip1995
647da97622 Lint for numeric literals that have a better representation in another format 2018-01-16 14:01:07 +01:00
Oliver Schneider
61e2b7a4d6
Merge pull request #2355 from alusch/clone_on_ref_ptr_restriction
Fix #2048: Move `clone_on_ref_ptr` to the restriction lints
2018-01-16 10:40:12 +01:00