Commit Graph

977 Commits

Author SHA1 Message Date
llogiq
6aeb955214 fixed if-condition match 2015-08-13 10:48:12 +02:00
llogiq
8b9c2a79ed First (incomplete) const folding 2015-08-13 10:48:11 +02:00
llogiq
12c974e21a changed Constant to a struct with 'needed_resolution' bool 2015-08-13 10:45:30 +02:00
Manish Goregaokar
8dfa02938d Merge branch 'pr-149' 2015-08-13 13:00:29 +05:30
llogiq
45b9553757 added follow flag 2015-08-13 09:25:44 +02:00
Manish Goregaokar
510ea0c5e5 Merge branch 'pr-140'
Conflicts:
	src/lib.rs
2015-08-13 12:52:14 +05:30
Manish Goregaokar
ecd78227ae Merge pull request #147 from birkenfeld/forloop
Lint for for loops over indexes instead of items
2015-08-13 12:34:36 +05:30
Georg Brandl
a67e55f3f0 lint messages: remove trailing period
Since lint messages often are suffixed by ", #[warn(xxx)] on by default"
this trailing period produces an ugly clash with the comma.
2015-08-13 08:15:42 +02:00
Georg Brandl
7aee04878f tests: use fragment of lint text for error checking
(Did not touch strings.rs, which is fixed by @llogiq's PR)
2015-08-13 08:12:07 +02:00
Georg Brandl
38e8d2bc06 methods: move misc.StrToStringPass to MethodsPass 2015-08-13 07:53:08 +02:00
Georg Brandl
5952a29543 lifetimes test: use explicit message prefix 2015-08-13 07:51:24 +02:00
Georg Brandl
2f7693094f lifetimes lint: include support for lifetimes as generic params 2015-08-13 06:43:25 +02:00
Georg Brandl
6603299f3f lifetimes lint: straighten some code, add a few comments 2015-08-13 06:35:40 +02:00
Georg Brandl
b349f9e88d new lint for needless lifetimes (fixes #115) 2015-08-13 06:35:40 +02:00
Georg Brandl
f6090909d3 new lint: using for i in 0..x { .. vec[i] .. } instead of iterator (fixes #3) 2015-08-13 06:34:08 +02:00
Georg Brandl
4400aaed43 if_let_chain: allow mixing in normal ifs as well 2015-08-13 06:32:24 +02:00
Manish Goregaokar
dbd396db91 Merge pull request #146 from birkenfeld/unicode
unicode: add lint against non-ascii chars in literals (Allow by default)
2015-08-13 02:56:46 +05:30
Andre Bogus
1f8c29c6ad fixed error messages in compile-fail test 2015-08-12 21:39:42 +02:00
Andre Bogus
30a6764adb grammar 2015-08-12 21:17:21 +02:00
Georg Brandl
3044d3d633 unicode: add lint against non-ascii chars in literals (Allow by default), #85 2015-08-12 20:36:35 +02:00
Manish Goregaokar
79bf774e9b Update README.md 2015-08-12 21:25:26 +05:30
Manish Goregaokar
c58f803511 Merge branch 'pr-138'
Conflicts:
	src/lib.rs
2015-08-12 21:22:01 +05:30
Manish Goregaokar
0263a6f052 Merge pull request #145 from birkenfeld/string_to_string
methods: lint against String.to_string (fixes #100)
2015-08-12 20:37:29 +05:30
Georg Brandl
4074c1f968 methods: lint against String.to_string (fixes #100) 2015-08-12 17:03:13 +02:00
llogiq
801f01d001 added string_add to clippy lint group 2015-08-12 16:50:55 +02:00
llogiq
e6e036ec20 pulled strings passes together, added more tests 2015-08-12 16:42:42 +02:00
llogiq
f0182ca6c8 fixed formatting 2015-08-12 15:57:50 +02:00
llogiq
2d55381a96 added string_add lint and fixed string_add_assign + test 2015-08-12 15:50:56 +02:00
Manish Goregaokar
6ff1e9a766 Merge pull request #143 from birkenfeld/more_methods
methods: move misc.StrToStringPass to MethodsPass
2015-08-12 17:32:16 +05:30
llogiq
fc6dfafc30 fixed if-condition match 2015-08-12 14:02:13 +02:00
Georg Brandl
225969e8a3 methods: move misc.StrToStringPass to MethodsPass 2015-08-12 13:58:55 +02:00
llogiq
a7527adf08 First (incomplete) const folding 2015-08-12 13:49:28 +02:00
Georg Brandl
e8fed074cf new lint: warn if let-binding has unit value (fixes #74) 2015-08-12 13:21:07 +02:00
Manish Goregaokar
8bcd01ff47 Bump to 0.0.11 2015-08-12 15:20:18 +05:30
Manish Goregaokar
ca3b4330f1 Use snippet, pprust methods expand AST 2015-08-12 15:19:57 +05:30
Manish Goregaokar
0481d04d6f Merge pull request #137 from birkenfeld/collapsible_if_fix
collapsible_if: do not show Debug display of expression
2015-08-12 15:06:24 +05:30
Manish Goregaokar
85499f31a7 Merge pull request #136 from birkenfeld/len_zero_expr
len_zero: display full suggested expr in message
2015-08-12 15:03:21 +05:30
Manish Goregaokar
640c3ff8aa Merge pull request #135 from birkenfeld/consistent_msgs
all: make style of lint messages consistent
2015-08-12 14:47:24 +05:30
Georg Brandl
7b3299e009 collapsible_if: do not show Debug display of expression
Instead, pretty-print the inner block and use the same style as for
the "single match => if let" lint.
2015-08-12 11:00:08 +02:00
Georg Brandl
b831bd1d1d len_zero: display full suggested expr in message 2015-08-12 10:53:14 +02:00
Georg Brandl
bcd95aec1c all: make style of lint messages consistent
* start first sentence lowercased
* use backticks to delimit code snippets
* use "this is wrong. Consider doing X." consistently
2015-08-12 10:47:09 +02:00
Manish Goregaokar
2ec933377c Merge pull request #134 from birkenfeld/if_let_chain_macro
utils: implement if_let_chain macro as suggested by isHavvy
2015-08-12 13:07:37 +05:30
Manish Goregaokar
9be32ea7a4 Merge pull request #133 from birkenfeld/readme_fix
README: update lint output
2015-08-12 13:02:09 +05:30
Georg Brandl
2eacb3c146 README: update lint output 2015-08-12 07:52:45 +02:00
Georg Brandl
6d5f9478b2 utils: implement if_let_chain macro as suggested by isHavvy 2015-08-12 07:48:47 +02:00
Manish Goregaokar
854212ce85 Update CONTRIBUTING.md 2015-08-12 03:32:20 +05:30
Manish Goregaokar
7c14b5b67f Merge pull request #132 from birkenfeld/let_and_return
New lint: let and immediately return
2015-08-12 02:27:48 +05:30
Georg Brandl
f6dc48fe3a new lint for "let x = EXPR; x" at the end of functions (fixes #104) 2015-08-11 22:25:47 +02:00
Georg Brandl
02c0cafa14 move NeedlessReturn pass out to its own module and rename to ReturnPass 2015-08-11 22:06:59 +02:00
Manish Goregaokar
1d948705bf Merge pull request #130 from birkenfeld/use_help
types: remove almost duplicate helper function
2015-08-12 01:35:15 +05:30