Vikas Kumar
|
5e78fbbf57
|
Fixups from review comments
1. Moved common check `in_external_macro` to the top of function from inside each
conditionals.
2. Inlined `is_bool_expr` call
|
2015-10-20 11:26:54 -07:00 |
|
Vikas Kumar
|
2951b70d15
|
Match on bool should be replaced with if..else block
1. Added another conditional in `check_expr` impl to lint if match expr
is a bool.
2. Test cases.
|
2015-10-20 10:18:48 -07:00 |
|
Ravi Shankar
|
185da55263
|
extending while_let to warn for more statements
|
2015-09-29 20:26:34 +05:30 |
|
Manish Goregaokar
|
f4da7d09d2
|
Upgrade Rust to rustc 1.5.0-nightly (cff041170 2015-09-17)
LintPass was split and ExprParen was removed from the HIR
Fixes #338
|
2015-09-19 08:23:04 +05:30 |
|
Georg Brandl
|
e3ee87965e
|
ref matches: false positive with only wildcard pattern match (fixes #335)
|
2015-09-17 07:25:08 +02:00 |
|
Manish Goregaokar
|
eca185438b
|
Update rust to 0efb9dab8c7c07fa28e9df0eccc5c07ea3c17fbb (HIR+lints, Thu Sep 3 18:59:56 2015 +0530)
fixes #294
|
2015-09-03 23:12:19 +05:30 |
|
Georg Brandl
|
846c164709
|
don't say "did you mean to" - use the standard "consider..."
"Did you mean to ..." sounds a bit condescending to me, since
if I meant to write "if let" I probably wouldn't have written "match" :)
|
2015-09-02 16:46:14 +02:00 |
|
Georg Brandl
|
b72ef5a173
|
new lint: loop-match-break, which could be while-let (fixes #118)
|
2015-08-30 12:40:39 +02:00 |
|
Manish Goregaokar
|
9ebcd0bf29
|
More macro checks
|
2015-08-27 04:33:59 +05:30 |
|
Georg Brandl
|
92a3394065
|
all: remove unneeded deref and/or ref operations
|
2015-08-25 14:41:35 +02:00 |
|
Georg Brandl
|
7580da306e
|
matches: special message for this case
match &e { &Pat1 => {}, &Pat2 => {}, ... }
(inspired by dogfood fixes)
|
2015-08-22 14:34:39 +02:00 |
|
Georg Brandl
|
017dac2301
|
new lint: using &Ref patterns instead of matching on *expr (fixes #187)
|
2015-08-22 14:34:39 +02:00 |
|
Georg Brandl
|
5403e82681
|
matches: new module, move single_match lint there
|
2015-08-22 14:34:39 +02:00 |
|