Ibraheem Ahmed
2e8358e1ab
add Option::inspect and Result::{inspect, inspect_err}
2021-11-28 23:31:45 -05:00
Ralf Jung
85558ad5b3
adjust some const_eval_select safety comments
2021-11-28 14:00:58 -05:00
Ralf Jung
15a4ed6937
adjust const_eval_select documentation
2021-11-28 13:54:56 -05:00
Matthias Krüger
af0cf34787
Rollup merge of #90896 - jhpratt:stabilize_const_maybe_uninit, r=oli-obk
...
Stabilize some `MaybeUninit` behavior as const
This stabilizes the `MaybeUninit::as_ptr`, `MaybeUninit::assume_init`, and `MaybeUninit::assume_init_ref` as `const fn`. `MaybeUninit::as_mut_ptr` has been moved to a new flag: `const_maybe_uninit_as_mut_ptr`, which is blocked on #57349 . `MaybeUninit::slice_assume_init_ref` can be `const fn` when the method is stabilized in general.
The relevant intrinsic has been stabilized as `const` as well, though this isn't user-visible. Due to the seemingly unrelated feature name I performed `rg const_assert_type` and found no other instances of it being used.
r? `@oli-obk`
`@rustbot` label: +A-const-fn +S-waiting-on-review +T-libs-api
2021-11-28 10:42:38 +01:00
Jacob Pratt
44b5b838d2
Add test for const MaybeUninit
2021-11-28 01:31:25 -05:00
Jacob Pratt
ad8e6bf5cc
Stabilize some MaybeUninit behavior as const
2021-11-28 01:01:47 -05:00
bors
27d5935df1
Auto merge of #91301 - scottmcm:stabilize-nonzero-ipot, r=nagisa
...
Stabilize nonzero_is_power_of_two
Closes #81106
FCP has finished in the tracking issue
2021-11-28 05:55:09 +00:00
Scott McMurray
23045eb622
Stabilize nonzero_is_power_of_two
...
Fixes 81106
FCP has finished in the tracking issue
2021-11-27 13:13:04 -08:00
bors
686e313a9a
Auto merge of #91288 - matthiaskrgr:rollup-yp5h41r, r=matthiaskrgr
...
Rollup of 6 pull requests
Successful merges:
- #83791 (Weaken guarantee around advancing underlying iterators in zip)
- #90995 (Document non-guarantees for Hash)
- #91057 (Expand `available_parallelism` docs in anticipation of cgroup quota support)
- #91062 (rustdoc: Consolidate static-file replacement mechanism)
- #91208 (Account for incorrect `where T::Assoc = Ty` bound)
- #91266 (Use non-generic inner function for pointer formatting)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2021-11-27 14:29:12 +00:00
bors
5fd3a5c7c1
Auto merge of #89916 - the8472:advance_by-avoid-err-0, r=dtolnay
...
Fix Iterator::advance_by contract inconsistency
The `advance_by(n)` docs state that in the error case `Err(k)` that k is always less than n.
It also states that `advance_by(0)` may return `Err(0)` to indicate an exhausted iterator.
These statements are inconsistent.
Since only one implementation (Skip) actually made use of that I changed it to return Ok(()) in that case too.
While adding some tests I also found a bug in `Take::advance_back_by`.
2021-11-27 11:31:26 +00:00
Matthias Krüger
073b1208f0
Rollup merge of #91266 - jam1garner:fmt-ptr-fix, r=dtolnay
...
Use non-generic inner function for pointer formatting
Previously, despite the implementation being type-unaware, `fmt::Pointer`'s implementation for `*const T` in monomorphized. This affects:
* `fmt::Debug` for `*const T`
* `fmt::Debug` for `*mut T`
* `fmt::Pointer` for `*const T`
* `fmt::Pointer` for `*mut T`
And since the implementation is non-trivial, this results in a large amount of LLVM bitcode being generated. For example, with a large bindgen project with Debug implementations enabled, it will generate a lot of calls to `fmt::Debug for *const T`, which in turn will perform codegen for a copy of this function for every type.
For example, in a real-world bindgen'd header I've been testing with (4,189,245 lines of bindgen Rust with layout tests disabled) the difference between a slightly old nightly (`rustc 1.58.0-nightly (e249ce6b2 2021-10-30)`) and this PR:
<details>
<summary>Nightly (Click to Expand)</summary>
```
Lines Copies Function name
----- ------ -------------
7256000 (100%) 216544 (100%) (TOTAL)
1815449 (25.0%) 24206 (11.2%) <*const T as core::fmt::Pointer>::fmt
300248 (4.1%) 29579 (13.7%) <&T as core::fmt::Debug>::fmt
290328 (4.0%) 24194 (11.2%) <*mut T as core::fmt::Pointer>::fmt
217746 (3.0%) 24194 (11.2%) <*mut T as core::fmt::Debug>::fmt
123329 (1.7%) 1486 (0.7%) core::fmt::builders::DebugList::entries
72790 (1.0%) 1486 (0.7%) core::slice::iter::Iter<T>::post_inc_start
71313 (1.0%) 1486 (0.7%) core::slice::iter::Iter<T>::new
68329 (0.9%) 1486 (0.7%) <core::slice::iter::Iter<T> as core::iter::traits::iterator::Iterator>::next
38636 (0.5%) 1486 (0.7%) <[T] as core::fmt::Debug>::fmt
26874 (0.4%) 1493 (0.7%) core::array::<impl core::fmt::Debug for [T; N]>::fmt
22290 (0.3%) 1486 (0.7%) core::slice::index::<impl core::ops::index::Index<I> for [T]>::index
19407 (0.3%) 1493 (0.7%) core::array::<impl core::ops::index::Index<I> for [T; N]>::index
19318 (0.3%) 1486 (0.7%) core::slice::<impl [T]>::iter
17832 (0.2%) 1486 (0.7%) core::ptr::const_ptr::<impl *const T>::offset
17832 (0.2%) 1486 (0.7%) core::ptr::mut_ptr::<impl *mut T>::offset
16346 (0.2%) 1486 (0.7%) <core::ops::range::RangeFull as core::slice::index::SliceIndex<[T]>>::index
13374 (0.2%) 1486 (0.7%) <I as core::iter::traits::collect::IntoIterator>::into_iter
13374 (0.2%) 1486 (0.7%) core::ptr::const_ptr::<impl *const T>::add
13371 (0.2%) 1486 (0.7%) core::ptr::const_ptr::<impl *const T>::is_null
13371 (0.2%) 1486 (0.7%) core::ptr::mut_ptr::<impl *mut T>::is_null
11888 (0.2%) 1486 (0.7%) core::slice::<impl [T]>::as_ptr
11879 (0.2%) 1486 (0.7%) core::ptr::non_null::NonNull<T>::new_unchecked
7421 (0.1%) 1486 (0.7%) core::ptr::non_null::NonNull<T>::as_ptr
```
</details>
<details>
<summary>This PR (Click to Expand)</summary>
```
Lines Copies Function name
----- ------ -------------
5684504 (100%) 216542 (100%) (TOTAL)
300248 (5.3%) 29579 (13.7%) <&T as core::fmt::Debug>::fmt
290328 (5.1%) 24194 (11.2%) <*mut T as core::fmt::Pointer>::fmt
266265 (4.7%) 24206 (11.2%) <*const T as core::fmt::Pointer>::fmt
217746 (3.8%) 24194 (11.2%) <*mut T as core::fmt::Debug>::fmt
101039 (1.8%) 1486 (0.7%) core::fmt::builders::DebugList::entries
72790 (1.3%) 1486 (0.7%) core::slice::iter::Iter<T>::post_inc_start
71313 (1.3%) 1486 (0.7%) core::slice::iter::Iter<T>::new
68329 (1.2%) 1486 (0.7%) <core::slice::iter::Iter<T> as core::iter::traits::iterator::Iterator>::next
38636 (0.7%) 1486 (0.7%) <[T] as core::fmt::Debug>::fmt
26874 (0.5%) 1493 (0.7%) core::array::<impl core::fmt::Debug for [T; N]>::fmt
22290 (0.4%) 1486 (0.7%) core::slice::index::<impl core::ops::index::Index<I> for [T]>::index
19407 (0.3%) 1493 (0.7%) core::array::<impl core::ops::index::Index<I> for [T; N]>::index
19318 (0.3%) 1486 (0.7%) core::slice::<impl [T]>::iter
17832 (0.3%) 1486 (0.7%) core::ptr::const_ptr::<impl *const T>::offset
17832 (0.3%) 1486 (0.7%) core::ptr::mut_ptr::<impl *mut T>::offset
16346 (0.3%) 1486 (0.7%) <core::ops::range::RangeFull as core::slice::index::SliceIndex<[T]>>::index
13374 (0.2%) 1486 (0.7%) <I as core::iter::traits::collect::IntoIterator>::into_iter
13374 (0.2%) 1486 (0.7%) core::ptr::const_ptr::<impl *const T>::add
13371 (0.2%) 1486 (0.7%) core::ptr::const_ptr::<impl *const T>::is_null
13371 (0.2%) 1486 (0.7%) core::ptr::mut_ptr::<impl *mut T>::is_null
11888 (0.2%) 1486 (0.7%) core::slice::<impl [T]>::as_ptr
11879 (0.2%) 1486 (0.7%) core::ptr::non_null::NonNull<T>::new_unchecked
7421 (0.1%) 1486 (0.7%) core::ptr::non_null::NonNull<T>::as_ptr
```
</details>
Output generated using `cargo llvm-lines` version 0.4.12.
Summary of differences:
| rustc Version | Total LLVM line count | `*const T as fmt::Pointer` LLVM lines | Compilation Time |
|-|-|-|-|
| `nightly` | 7256000 | 1815449 (25.0% of binary) | 537.014 |
| PR | 5684504 (-21.65%) | 266265 (4.7% of binary) (-85.3% from nightly) | 502.990 |
This results in a pretty noticeable as the majority of rustc's time is spent in either codegen or LLVM, in this case, and is significantly improved by disabling derives for `fmt::Debug`, as it prevents generating all this LLVM IR to be handled.
Here's a run time comparison with nightly on the same codebase (commit 454cc5fb built from source vs 37c8f25 from my PR built from source):
<details>
<summary>nightly (Click to Expand)</summary>
```
time: 2.370; rss: 56MB -> 1118MB (+1062MB) parse_crate
time: 0.000; rss: 1118MB -> 1118MB ( +0MB) attributes_injection
time: 0.000; rss: 1118MB -> 1118MB ( +0MB) incr_comp_prepare_session_directory
time: 0.000; rss: 1118MB -> 1118MB ( +0MB) incr_comp_garbage_collect_session_directories
time: 0.000; rss: 1120MB -> 1120MB ( +0MB) plugin_loading
time: 0.000; rss: 1120MB -> 1120MB ( +0MB) plugin_registration
time: 0.000; rss: 1120MB -> 1120MB ( +0MB) crate_injection
time: 13.897; rss: 1120MB -> 3147MB (+2027MB) expand_crate
time: 0.002; rss: 3147MB -> 3147MB ( +0MB) check_unused_macros
time: 13.900; rss: 1120MB -> 3147MB (+2027MB) macro_expand_crate
time: 0.002; rss: 3147MB -> 3147MB ( +0MB) maybe_building_test_harness
time: 0.503; rss: 3147MB -> 3147MB ( +0MB) AST_validation
time: 0.000; rss: 3147MB -> 3147MB ( +0MB) maybe_create_a_macro_crate
time: 0.002; rss: 3147MB -> 3147MB ( +0MB) finalize_imports
time: 0.502; rss: 3147MB -> 3153MB ( +6MB) finalize_macro_resolutions
time: 4.478; rss: 3153MB -> 3574MB ( +420MB) late_resolve_crate
time: 0.000; rss: 3574MB -> 3574MB ( +0MB) resolve_main
time: 0.332; rss: 3574MB -> 3574MB ( +0MB) resolve_check_unused
time: 0.000; rss: 3574MB -> 3574MB ( +0MB) resolve_report_errors
time: 0.279; rss: 3574MB -> 3574MB ( +0MB) resolve_postprocess
time: 5.595; rss: 3147MB -> 3574MB ( +427MB) resolve_crate
time: 0.382; rss: 3574MB -> 3574MB ( +0MB) complete_gated_feature_checking
time: 20.526; rss: 1120MB -> 3574MB (+2454MB) configure_and_expand
time: 0.000; rss: 3574MB -> 3574MB ( +0MB) prepare_outputs
time: 0.000; rss: 3574MB -> 3574MB ( +0MB) blocked_on_dep_graph_loading
time: 65.992; rss: 3574MB -> 6317MB (+2743MB) hir_lowering
time: 1.117; rss: 6317MB -> 6323MB ( +6MB) early_lint_checks
time: 1.447; rss: 6323MB -> 6271MB ( -52MB) drop_ast
time: 0.002; rss: 5838MB -> 5838MB ( +0MB) setup_global_ctxt
time: 0.000; rss: 5843MB -> 5843MB ( +0MB) looking_for_entry_point
time: 0.313; rss: 5843MB -> 5844MB ( +1MB) looking_for_derive_registrar
time: 9.652; rss: 5843MB -> 6065MB ( +222MB) misc_checking_1
time: 9.713; rss: 6065MB -> 6769MB ( +704MB) type_collecting
time: 0.665; rss: 6769MB -> 6769MB ( +0MB) impl_wf_inference
time: 0.064; rss: 6769MB -> 6769MB ( +0MB) unsafety_checking
time: 3.095; rss: 6769MB -> 6792MB ( +23MB) coherence_checking
time: 21.282; rss: 6792MB -> 7546MB ( +754MB) wf_checking
time: 5.404; rss: 7546MB -> 7681MB ( +135MB) item_types_checking
time: 79.665; rss: 7681MB -> 8075MB ( +394MB) item_bodies_checking
time: 120.166; rss: 6065MB -> 8081MB (+2016MB) type_check_crate
time: 2.038; rss: 8081MB -> 8085MB ( +4MB) match_checking
time: 1.300; rss: 8085MB -> 8113MB ( +28MB) liveness_and_intrinsic_checking
time: 3.338; rss: 8081MB -> 8113MB ( +32MB) misc_checking_2
time: 68.612; rss: 8113MB -> 9285MB (+1172MB) MIR_borrow_checking
time: 0.622; rss: 9285MB -> 9301MB ( +17MB) MIR_effect_checking
time: 0.000; rss: 9301MB -> 9301MB ( +0MB) layout_testing
time: 4.331; rss: 9383MB -> 9510MB ( +127MB) death_checking
time: 0.032; rss: 9510MB -> 9510MB ( +0MB) unused_lib_feature_checking
time: 4.444; rss: 9510MB -> 9568MB ( +58MB) crate_lints
time: 59.563; rss: 9568MB -> 9576MB ( +8MB) module_lints
time: 64.006; rss: 9510MB -> 9576MB ( +66MB) lint_checking
time: 4.127; rss: 9576MB -> 9639MB ( +62MB) privacy_checking_modules
time: 77.984; rss: 9301MB -> 9639MB ( +337MB) misc_checking_3
time: 0.311; rss: 10357MB -> 10357MB ( +0MB) monomorphization_collector_root_collections
time: 14.051; rss: 10357MB -> 10573MB ( +217MB) monomorphization_collector_graph_walk
time: 1.759; rss: 10573MB -> 10652MB ( +79MB) partition_and_assert_distinct_symbols
time: 28.518; rss: 9639MB -> 10711MB (+1072MB) generate_crate_metadata
time: 0.000; rss: 10711MB -> 10711MB ( +0MB) find_cgu_reuse
time: 63.408; rss: 10711MB -> 12272MB (+1560MB) codegen_to_LLVM_IR
time: 64.916; rss: 10711MB -> 12267MB (+1556MB) codegen_crate
time: 0.000; rss: 12261MB -> 12261MB ( +0MB) assert_dep_graph
time: 0.000; rss: 12261MB -> 12261MB ( +0MB) check_dirty_clean
time: 0.664; rss: 12230MB -> 12210MB ( -20MB) encode_query_results_for(rustc_query_impl::queries::type_of)
time: 2.111; rss: 12210MB -> 12043MB ( -167MB) encode_query_results_for(rustc_query_impl::queries::generics_of)
time: 0.108; rss: 12043MB -> 12057MB ( +14MB) encode_query_results_for(rustc_query_impl::queries::predicates_of)
time: 0.004; rss: 12057MB -> 12059MB ( +2MB) encode_query_results_for(rustc_query_impl::queries::mir_const_qualif)
time: 0.665; rss: 12059MB -> 12121MB ( +62MB) encode_query_results_for(rustc_query_impl::queries::mir_for_ctfe)
time: 16.149; rss: 12121MB -> 12148MB ( +28MB) encode_query_results_for(rustc_query_impl::queries::optimized_mir)
time: 0.000; rss: 12148MB -> 12148MB ( +0MB) encode_query_results_for(rustc_query_impl::queries::covered_file_name)
time: 0.000; rss: 12148MB -> 12148MB ( +0MB) encode_query_results_for(rustc_query_impl::queries::covered_code_regions)
time: 0.010; rss: 12148MB -> 12150MB ( +2MB) encode_query_results_for(rustc_query_impl::queries::promoted_mir)
time: 0.052; rss: 12150MB -> 12155MB ( +4MB) encode_query_results_for(rustc_query_impl::queries::unsafety_check_result)
time: 0.003; rss: 12155MB -> 12156MB ( +1MB) encode_query_results_for(rustc_query_impl::queries::thir_check_unsafety)
time: 11.428; rss: 12156MB -> 11748MB ( -408MB) encode_query_results_for(rustc_query_impl::queries::typeck)
time: 0.000; rss: 11748MB -> 11748MB ( +0MB) encode_query_results_for(rustc_query_impl::queries::diagnostic_only_typeck)
time: 0.094; rss: 11748MB -> 11756MB ( +8MB) encode_query_results_for(rustc_query_impl::queries::used_trait_imports)
time: 0.272; rss: 11756MB -> 11778MB ( +22MB) encode_query_results_for(rustc_query_impl::queries::mir_borrowck)
time: 0.054; rss: 11778MB -> 11778MB ( +0MB) encode_query_results_for(rustc_query_impl::queries::eval_to_allocation_raw)
time: 0.005; rss: 11778MB -> 11779MB ( +1MB) encode_query_results_for(rustc_query_impl::queries::eval_to_const_value_raw)
time: 0.021; rss: 11779MB -> 11784MB ( +5MB) encode_query_results_for(rustc_query_impl::queries::check_match)
time: 0.041; rss: 11784MB -> 11786MB ( +2MB) encode_query_results_for(rustc_query_impl::queries::symbol_name)
time: 0.743; rss: 11786MB -> 11815MB ( +29MB) encode_query_results_for(rustc_query_impl::queries::codegen_fn_attrs)
time: 0.043; rss: 11815MB -> 11816MB ( +1MB) encode_query_results_for(rustc_query_impl::queries::codegen_fulfill_obligation)
time: 0.674; rss: 11816MB -> 11840MB ( +25MB) encode_query_results_for(rustc_query_impl::queries::specialization_graph_of)
time: 0.000; rss: 11840MB -> 11840MB ( +0MB) encode_query_results_for(rustc_query_impl::queries::adt_drop_tys)
time: 0.000; rss: 11840MB -> 11840MB ( +0MB) encode_query_results_for(rustc_query_impl::queries::adt_significant_drop_tys)
time: 0.005; rss: 11840MB -> 11841MB ( +1MB) encode_query_results_for(rustc_query_impl::queries::unused_generic_params)
time: 33.153; rss: 12232MB -> 11841MB ( -390MB) encode_query_results
time: 88.943; rss: 11955MB -> 11783MB ( -173MB) LLVM_passes(crate)
time: 38.854; rss: 12259MB -> 10095MB (-2164MB) incr_comp_serialize_result_cache
time: 39.030; rss: 12261MB -> 10095MB (-2166MB) incr_comp_persist_result_cache
time: 0.000; rss: 10095MB -> 10095MB ( +0MB) incr_comp_persist_dep_graph
time: 39.064; rss: 12257MB -> 10095MB (-2162MB) serialize_dep_graph
time: 19.047; rss: 10095MB -> 10307MB ( +212MB) free_global_ctxt
time: 0.000; rss: 10307MB -> 10307MB ( +0MB) join_worker_thread
time: 0.519; rss: 10307MB -> 10307MB ( +0MB) copy_all_cgu_workproducts_to_incr_comp_cache_dir
time: 0.522; rss: 10307MB -> 10307MB ( +0MB) finish_ongoing_codegen
time: 0.000; rss: 10307MB -> 10307MB ( +0MB) llvm_dump_timing_file
time: 0.002; rss: 10307MB -> 10307MB ( +0MB) serialize_work_products
time: 0.001; rss: 9542MB -> 9542MB ( +0MB) incr_comp_finalize_session_directory
time: 0.000; rss: 9542MB -> 9542MB ( +0MB) link_binary_check_files_are_writeable
time: 7.835; rss: 9542MB -> 9544MB ( +2MB) link_rlib
time: 0.000; rss: 9544MB -> 9544MB ( +0MB) link_binary_remove_temps
time: 7.872; rss: 9542MB -> 9544MB ( +2MB) link_binary
time: 7.944; rss: 9542MB -> 9201MB ( -341MB) link_crate
time: 8.495; rss: 10307MB -> 9201MB (-1106MB) link
time: 537.014; rss: 33MB -> 3715MB (+3682MB) total
```
</details>
<details>
<summary>This PR (Click to Expand)</summary>
```
time: 2.379; rss: 51MB -> 1116MB (+1064MB) parse_crate
time: 0.003; rss: 1116MB -> 1116MB ( +0MB) attributes_injection
time: 0.002; rss: 1116MB -> 1116MB ( +0MB) incr_comp_prepare_session_directory
time: 0.000; rss: 1116MB -> 1116MB ( +0MB) incr_comp_garbage_collect_session_directories
time: 0.000; rss: 1116MB -> 1116MB ( +0MB) plugin_loading
time: 0.000; rss: 1116MB -> 1116MB ( +0MB) plugin_registration
time: 0.003; rss: 1118MB -> 1118MB ( +0MB) crate_injection
time: 13.376; rss: 1118MB -> 3143MB (+2025MB) expand_crate
time: 0.002; rss: 3143MB -> 3143MB ( +0MB) check_unused_macros
time: 13.379; rss: 1118MB -> 3143MB (+2025MB) macro_expand_crate
time: 0.002; rss: 3143MB -> 3143MB ( +0MB) maybe_building_test_harness
time: 0.479; rss: 3143MB -> 3143MB ( +0MB) AST_validation
time: 0.002; rss: 3143MB -> 3143MB ( +0MB) maybe_create_a_macro_crate
time: 0.005; rss: 3143MB -> 3143MB ( +0MB) finalize_imports
time: 0.520; rss: 3143MB -> 3125MB ( -18MB) finalize_macro_resolutions
time: 4.446; rss: 3125MB -> 3577MB ( +453MB) late_resolve_crate
time: 0.000; rss: 3577MB -> 3577MB ( +0MB) resolve_main
time: 0.336; rss: 3577MB -> 3577MB ( +0MB) resolve_check_unused
time: 0.000; rss: 3577MB -> 3577MB ( +0MB) resolve_report_errors
time: 0.295; rss: 3577MB -> 3578MB ( +0MB) resolve_postprocess
time: 5.602; rss: 3143MB -> 3578MB ( +435MB) resolve_crate
time: 0.388; rss: 3578MB -> 3578MB ( +0MB) complete_gated_feature_checking
time: 20.014; rss: 1116MB -> 3578MB (+2462MB) configure_and_expand
time: 0.000; rss: 3578MB -> 3578MB ( +0MB) prepare_outputs
time: 0.000; rss: 3578MB -> 3578MB ( +0MB) blocked_on_dep_graph_loading
time: 64.219; rss: 3578MB -> 6313MB (+2736MB) hir_lowering
time: 1.102; rss: 6313MB -> 6319MB ( +6MB) early_lint_checks
time: 1.426; rss: 6319MB -> 6268MB ( -52MB) drop_ast
time: 0.005; rss: 5834MB -> 5836MB ( +2MB) setup_global_ctxt
time: 0.000; rss: 5838MB -> 5838MB ( +0MB) looking_for_entry_point
time: 0.292; rss: 5838MB -> 5840MB ( +1MB) looking_for_derive_registrar
time: 9.553; rss: 5838MB -> 6060MB ( +222MB) misc_checking_1
time: 9.949; rss: 6060MB -> 6764MB ( +704MB) type_collecting
time: 0.630; rss: 6764MB -> 6764MB ( +0MB) impl_wf_inference
time: 0.060; rss: 6764MB -> 6764MB ( +0MB) unsafety_checking
time: 3.054; rss: 6764MB -> 6787MB ( +23MB) coherence_checking
time: 20.702; rss: 6787MB -> 7533MB ( +746MB) wf_checking
time: 5.194; rss: 7533MB -> 7668MB ( +135MB) item_types_checking
time: 74.677; rss: 7668MB -> 8062MB ( +394MB) item_bodies_checking
time: 114.497; rss: 6060MB -> 8068MB (+2008MB) type_check_crate
time: 1.891; rss: 8068MB -> 8072MB ( +4MB) match_checking
time: 1.292; rss: 8072MB -> 8100MB ( +28MB) liveness_and_intrinsic_checking
time: 3.183; rss: 8068MB -> 8100MB ( +32MB) misc_checking_2
time: 68.845; rss: 8100MB -> 9279MB (+1179MB) MIR_borrow_checking
time: 0.587; rss: 9279MB -> 9295MB ( +17MB) MIR_effect_checking
time: 0.000; rss: 9295MB -> 9295MB ( +0MB) layout_testing
time: 4.443; rss: 9377MB -> 9504MB ( +127MB) death_checking
time: 0.034; rss: 9504MB -> 9504MB ( +0MB) unused_lib_feature_checking
time: 4.409; rss: 9504MB -> 9562MB ( +58MB) crate_lints
time: 56.490; rss: 9562MB -> 9571MB ( +8MB) module_lints
time: 60.900; rss: 9504MB -> 9571MB ( +66MB) lint_checking
time: 4.147; rss: 9571MB -> 9633MB ( +62MB) privacy_checking_modules
time: 75.094; rss: 9295MB -> 9633MB ( +337MB) misc_checking_3
time: 0.315; rss: 10357MB -> 10357MB ( +0MB) monomorphization_collector_root_collections
time: 14.501; rss: 10357MB -> 10571MB ( +215MB) monomorphization_collector_graph_walk
time: 1.763; rss: 10571MB -> 10661MB ( +89MB) partition_and_assert_distinct_symbols
time: 29.035; rss: 9633MB -> 10706MB (+1073MB) generate_crate_metadata
time: 0.000; rss: 10706MB -> 10706MB ( +0MB) find_cgu_reuse
time: 30.913; rss: 10706MB -> 12150MB (+1444MB) codegen_to_LLVM_IR
time: 31.108; rss: 10706MB -> 12150MB (+1444MB) codegen_crate
time: 0.000; rss: 12150MB -> 12150MB ( +0MB) assert_dep_graph
time: 0.000; rss: 12150MB -> 12150MB ( +0MB) check_dirty_clean
time: 0.416; rss: 12152MB -> 12199MB ( +46MB) encode_query_results_for(rustc_query_impl::queries::type_of)
time: 1.259; rss: 12199MB -> 12211MB ( +12MB) encode_query_results_for(rustc_query_impl::queries::generics_of)
time: 0.095; rss: 12211MB -> 12193MB ( -18MB) encode_query_results_for(rustc_query_impl::queries::predicates_of)
time: 0.005; rss: 12193MB -> 12195MB ( +2MB) encode_query_results_for(rustc_query_impl::queries::mir_const_qualif)
time: 0.828; rss: 12195MB -> 12208MB ( +14MB) encode_query_results_for(rustc_query_impl::queries::mir_for_ctfe)
time: 17.880; rss: 12208MB -> 11987MB ( -222MB) encode_query_results_for(rustc_query_impl::queries::optimized_mir)
time: 0.000; rss: 11987MB -> 11987MB ( +0MB) encode_query_results_for(rustc_query_impl::queries::covered_file_name)
time: 0.000; rss: 11987MB -> 11987MB ( +0MB) encode_query_results_for(rustc_query_impl::queries::covered_code_regions)
time: 0.007; rss: 11987MB -> 11988MB ( +1MB) encode_query_results_for(rustc_query_impl::queries::promoted_mir)
time: 0.049; rss: 11988MB -> 11992MB ( +4MB) encode_query_results_for(rustc_query_impl::queries::unsafety_check_result)
time: 0.002; rss: 11992MB -> 11994MB ( +1MB) encode_query_results_for(rustc_query_impl::queries::thir_check_unsafety)
time: 38.049; rss: 11994MB -> 12093MB ( +99MB) encode_query_results_for(rustc_query_impl::queries::typeck)
time: 0.000; rss: 12093MB -> 12093MB ( +0MB) encode_query_results_for(rustc_query_impl::queries::diagnostic_only_typeck)
time: 0.024; rss: 12093MB -> 12095MB ( +2MB) encode_query_results_for(rustc_query_impl::queries::used_trait_imports)
time: 0.372; rss: 12095MB -> 12053MB ( -42MB) encode_query_results_for(rustc_query_impl::queries::mir_borrowck)
time: 0.015; rss: 12053MB -> 12053MB ( +0MB) encode_query_results_for(rustc_query_impl::queries::eval_to_allocation_raw)
time: 0.005; rss: 12053MB -> 12054MB ( +1MB) encode_query_results_for(rustc_query_impl::queries::eval_to_const_value_raw)
time: 0.003; rss: 12054MB -> 12056MB ( +2MB) encode_query_results_for(rustc_query_impl::queries::check_match)
time: 0.037; rss: 12056MB -> 11899MB ( -157MB) encode_query_results_for(rustc_query_impl::queries::symbol_name)
time: 0.667; rss: 11899MB -> 11708MB ( -191MB) encode_query_results_for(rustc_query_impl::queries::codegen_fn_attrs)
time: 0.045; rss: 11708MB -> 11709MB ( +1MB) encode_query_results_for(rustc_query_impl::queries::codegen_fulfill_obligation)
time: 0.295; rss: 11709MB -> 11734MB ( +25MB) encode_query_results_for(rustc_query_impl::queries::specialization_graph_of)
time: 0.000; rss: 11734MB -> 11734MB ( +0MB) encode_query_results_for(rustc_query_impl::queries::adt_drop_tys)
time: 0.000; rss: 11734MB -> 11734MB ( +0MB) encode_query_results_for(rustc_query_impl::queries::adt_significant_drop_tys)
time: 0.005; rss: 11734MB -> 11734MB ( +1MB) encode_query_results_for(rustc_query_impl::queries::unused_generic_params)
time: 60.063; rss: 12152MB -> 11734MB ( -418MB) encode_query_results
time: 76.745; rss: 12007MB -> 11699MB ( -308MB) LLVM_passes(crate)
time: 61.634; rss: 12150MB -> 10557MB (-1593MB) incr_comp_serialize_result_cache
time: 61.637; rss: 12150MB -> 10557MB (-1593MB) incr_comp_persist_result_cache
time: 0.001; rss: 10557MB -> 10557MB ( +0MB) incr_comp_persist_dep_graph
time: 61.641; rss: 12150MB -> 10557MB (-1593MB) serialize_dep_graph
time: 15.601; rss: 10557MB -> 10242MB ( -315MB) free_global_ctxt
time: 0.000; rss: 10242MB -> 10242MB ( +0MB) join_worker_thread
time: 0.368; rss: 10242MB -> 10242MB ( +0MB) copy_all_cgu_workproducts_to_incr_comp_cache_dir
time: 0.375; rss: 10242MB -> 10242MB ( +0MB) finish_ongoing_codegen
time: 0.000; rss: 10242MB -> 10242MB ( +0MB) llvm_dump_timing_file
time: 0.002; rss: 10242MB -> 10242MB ( +0MB) serialize_work_products
time: 0.001; rss: 9668MB -> 9668MB ( +0MB) incr_comp_finalize_session_directory
time: 0.000; rss: 9668MB -> 9668MB ( +0MB) link_binary_check_files_are_writeable
time: 1.469; rss: 9668MB -> 9671MB ( +3MB) link_rlib
time: 0.000; rss: 9671MB -> 9671MB ( +0MB) link_binary_remove_temps
time: 1.506; rss: 9668MB -> 9671MB ( +3MB) link_binary
time: 1.622; rss: 9668MB -> 9329MB ( -339MB) link_crate
time: 2.037; rss: 10242MB -> 9329MB ( -913MB) link
time: 502.990; rss: 32MB -> 5888MB (+5855MB) total
```
</details>
(6.34% decrease in runtime, results are consistent across multiple runs)
2021-11-27 11:46:45 +01:00
Matthias Krüger
43279b2749
Rollup merge of #90995 - the8472:hash-portability, r=dtolnay
...
Document non-guarantees for Hash
Dependence on endianness and type sizes was reported for enum discriminants in #74215 but it is a more general
issue since for example the default implementation of `Hasher::write_usize` uses native endianness.
Additionally the implementations of library types are occasionally changed as their internal fields
change or hashing gets optimized.
## Question
Should this go on the module level documentation instead since it also concerns `Hasher` to some extent and not just `Hash`?
resolves #74215
2021-11-27 11:46:42 +01:00
Matthias Krüger
14ef447d12
Rollup merge of #83791 - the8472:relax-zip-side-effect-guarantee, r=dtolnay
...
Weaken guarantee around advancing underlying iterators in zip
The current guarantee (introduced in #52279 ) is too strong as it prevents adapters from exploiting knowledge about the iterator length and using counted loops for example because they would stop calling `next()` before it ever returned `None`. Additionally several nested zip iterators already fail to uphold this.
This does not yet remove any of the specialization code that tries (and sometimes fails) to uphold the guarantee for `next()`
because removing it would also affect `next_back()` in more surprising ways.
The intent is to be able to remove for example this branch
36bcf40697/library/core/src/iter/adapters/zip.rs (L234-L243)36bcf40697/library/core/tests/iter/adapters/zip.rs (L177-L188)#82303 by declaring it a non-issue.
2021-11-27 11:46:40 +01:00
bors
bbad745a68
Auto merge of #91269 - matthiaskrgr:rollup-jh8i8eh, r=matthiaskrgr
...
Rollup of 7 pull requests
Successful merges:
- #90611 (Fix another ICE in rustdoc scrape_examples)
- #91197 (rustdoc: Rename `Type::ResolvedPath` to `Type::Path` and don't re-export it)
- #91223 (Fix headings indent)
- #91240 (Saner formatting for UTF8_CHAR_WIDTH table)
- #91248 (Bump compiler-builtins to 0.1.53)
- #91252 (Fix bug where submodules wouldn't be updated when running x.py from a subdirectory)
- #91259 (Remove `--display-doctest-warnings`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2021-11-27 00:42:30 +00:00
bors
ccce98535b
Auto merge of #91246 - nnethercote:faster-layout-array, r=dtolnay
...
Faster `Layout::array`
`Layout::array` is called (indirectly) by `Vec::push()`, which is typically instantiated many times, and so making it smaller can help with compile times because less LLVM IR is generated.
r? `@ghost`
2021-11-26 21:35:53 +00:00
David Tolnay
c6810a569f
Clarify safety comment on using i to index into self.source
2021-11-26 12:57:36 -08:00
jam1garner
37c8f254ed
Use non-generic inner function for pointer formatting
2021-11-26 13:59:57 -05:00
Nicholas Nethercote
f3bda74d36
Optimize Layout::array.
...
The current implementation is much more conservative than it needs to
be, because it's dealing with the size and alignment of a given `T`,
which are more restricted than an arbitrary `Layout`.
For example, imagine a struct with a `u32` and a `u4`. You can safely
create a `Layout { size_: 5, align_: 4 }` by hand, but
`Layout:🆕 :<T>` will give `Layout { size_: 8, align_: 4}`, where the
size already has padding that accounts for the alignment. (And the
existing `debug_assert_eq!` in `Layout::array` already demonstrates that
no additional padding is required.)
2021-11-26 19:30:35 +11:00
Nicholas Nethercote
026edbb4ef
Use unchecked construction in Layout::pad_to_align.
...
Other, similar methods for `Layout` do likewise, and there's already an
`unwrap()` around the result demonstrating the safety.
2021-11-26 19:30:35 +11:00
David Tolnay
2be9a8349f
Eliminate bunch of copies of error codepath from Utf8LossyChunksIter
...
Using a macro to stamp out 7 identical copies of the nontrivial slicing
logic to exit this loop didn't seem like a necessary use of a macro. The
early return case can be handled by `break` without practically any
changes to the logic inside the loop.
All this code is from early 2014 (7.5 years old, pre-1.0) so it's
possible there were compiler limitations that forced the macro way at
the time.
Confirmed that `x.py bench library/alloc --stage 0 --test-args from_utf8_lossy`
is unaffected on my machine.
2021-11-25 19:52:45 -08:00
David Tolnay
553a84c445
Saner formatting for UTF8_CHAR_WIDTH table
2021-11-25 18:18:36 -08:00
Matthias Krüger
6970cf5a23
Rollup merge of #91096 - compiler-errors:elaborate_opaque_trait, r=estebank
...
Print associated types on opaque `impl Trait` types
This PR generalizes #91021 , printing associated types for all opaque `impl Trait` types instead of just special-casing for future.
before:
```
error[E0271]: type mismatch resolving `<impl Iterator as Iterator>::Item == u32`
```
after:
```
error[E0271]: type mismatch resolving `<impl Iterator<Item = usize> as Iterator>::Item == u32`
```
---
Questions:
1. I'm kinda lost in binders hell with this one. Is all of the `rebind`ing necessary?
2. Is there a map collection type that will give me a stable iteration order? Doesn't seem like TraitRef is Ord, so I can't just sort later..
3. I removed the logic that suppresses printing generator projection types. It creates outputs like this [gist](https://gist.github.com/compiler-errors/d6f12fb30079feb1ad1d5f1ab39a3a8d ). Should I put that back?
4. I also added spaces between traits, `impl A+B` -> `impl A + B`. I quite like this change, but is there a good reason to keep it like that?
r? ````@estebank````
2021-11-25 15:05:37 +01:00
Guillaume Gomez
a6a1d7ca29
Rollup merge of #90420 - GuillaumeGomez:rustdoc-internals-feature, r=camelid
...
Create rustdoc_internals feature gate
As suggested by ``@camelid`` [here](https://github.com/rust-lang/rust/pull/90398#issuecomment-955093851 ), since `doc_keyword` and `doc_primitive` aren't meant to be stabilized, we could put them behind a same feature flag.
This is pretty much what it would look like (needs to update the tests too).
The tracking issue is https://github.com/rust-lang/rust/issues/90418 .
What do you think ``@rust-lang/rustdoc`` ?
2021-11-24 22:56:37 +01:00
Guillaume Gomez
658c148b87
Rollup merge of #89542 - jhpratt:stabilize-duration-const-fns, r=oli-obk
...
Partially stabilize `duration_consts_2`
Methods that were only blocked on `const_panic` have been stabilized.
The remaining methods of `duration_consts_2` are all related to floats,
and as such have been placed behind the `duration_consts_float` feature
gate.
2021-11-24 22:56:35 +01:00
Guillaume Gomez
1e6ced3532
Create rustdoc_internals feature gate
2021-11-24 21:57:18 +01:00
woppopo
89b2e0c9d5
Make intrinsics::write_bytes const
2021-11-24 13:05:26 +09:00
the8472
53fc69f87c
Apply suggestions from code review
...
Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>
2021-11-23 23:55:05 +01:00
Michael Goulet
b84a52c95a
Add generator lang-item
2021-11-23 10:34:16 -08:00
Jacob Pratt
7b103e7dd2
Use derive_default_enum in the compiler
2021-11-22 20:17:53 -05:00
Eric Holk
dfa0db5961
Reintroduce into_future in .await desugaring
...
This is a reintroduction of the remaining parts from
https://github.com/rust-lang/rust/pull/65244 that have not been relanded
yet.
Issues GH-67644, GH-67982
2021-11-22 14:57:27 -08:00
Jacob Pratt
41f70f3491
Revert "Temporarily rename int_roundings functions to avoid conflicts"
...
This reverts commit 3ece63b64e192146fcdd1724e25856a93d7626aa.
2021-11-22 15:49:04 -05:00
Jacob Pratt
88b0d7cfc5
Partially stabilize duration_consts_2
...
Methods that were only blocked on `const_panic` have been stabilized.
The remaining methods of `duration_consts_2` are all related to floats,
and as such have been placed behind the `duration_consts_float` feature
gate.
2021-11-22 13:09:08 -05:00
Scott McMurray
348a25044b
Intra-doc links apparently don't like pointers?
2021-11-22 02:40:56 -08:00
Scott McMurray
875e01e616
Add <*{const|mut} T>::{to|from}_bits
...
Named based on the floating-point methods of the same name, as those are also about returning the *representation* of the value.
2021-11-22 02:08:59 -08:00
Eduardo Sánchez Muñoz
23637e20cd
libcore: assume the input of next_code_point and next_code_point_reverse is UTF-8-like
...
The functions are now `unsafe` and they use `Option::unwrap_unchecked` instead of `unwrap_or_0`
`unwrap_or_0` was added in 42357d772b8a3a1ce4395deeac0a5cf1f66e951d. I guess `unwrap_unchecked` was not available back then.
Given this example:
```rust
pub fn first_char(s: &str) -> Option<char> {
s.chars().next()
}
```
Previously, the following assembly was produced:
```asm
_ZN7example10first_char17ha056ddea6bafad1cE:
.cfi_startproc
test rsi, rsi
je .LBB0_1
movzx edx, byte ptr [rdi]
test dl, dl
js .LBB0_3
mov eax, edx
ret
.LBB0_1:
mov eax, 1114112
ret
.LBB0_3:
lea r8, [rdi + rsi]
xor eax, eax
mov r9, r8
cmp rsi, 1
je .LBB0_5
movzx eax, byte ptr [rdi + 1]
add rdi, 2
and eax, 63
mov r9, rdi
.LBB0_5:
mov ecx, edx
and ecx, 31
cmp dl, -33
jbe .LBB0_6
cmp r9, r8
je .LBB0_9
movzx esi, byte ptr [r9]
add r9, 1
and esi, 63
shl eax, 6
or eax, esi
cmp dl, -16
jb .LBB0_12
.LBB0_13:
cmp r9, r8
je .LBB0_14
movzx edx, byte ptr [r9]
and edx, 63
jmp .LBB0_16
.LBB0_6:
shl ecx, 6
or eax, ecx
ret
.LBB0_9:
xor esi, esi
mov r9, r8
shl eax, 6
or eax, esi
cmp dl, -16
jae .LBB0_13
.LBB0_12:
shl ecx, 12
or eax, ecx
ret
.LBB0_14:
xor edx, edx
.LBB0_16:
and ecx, 7
shl ecx, 18
shl eax, 6
or eax, ecx
or eax, edx
ret
```
After this change, the assembly is reduced to:
```asm
_ZN7example10first_char17h4318683472f884ccE:
.cfi_startproc
test rsi, rsi
je .LBB0_1
movzx ecx, byte ptr [rdi]
test cl, cl
js .LBB0_3
mov eax, ecx
ret
.LBB0_1:
mov eax, 1114112
ret
.LBB0_3:
mov eax, ecx
and eax, 31
movzx esi, byte ptr [rdi + 1]
and esi, 63
cmp cl, -33
jbe .LBB0_4
movzx edx, byte ptr [rdi + 2]
shl esi, 6
and edx, 63
or edx, esi
cmp cl, -16
jb .LBB0_7
movzx ecx, byte ptr [rdi + 3]
and eax, 7
shl eax, 18
shl edx, 6
and ecx, 63
or ecx, edx
or eax, ecx
ret
.LBB0_4:
shl eax, 6
or eax, esi
ret
.LBB0_7:
shl eax, 12
or eax, edx
ret
```
2021-11-21 17:05:55 +01:00
Jonas Platte
64cca297cb
Fix method name reference in stream documentation
2021-11-21 11:57:38 +01:00
Matthias Krüger
789d168e13
Rollup merge of #91008 - Urgau:float-minimum-maximum, r=scottmcm
...
Adds IEEE 754-2019 minimun and maximum functions for f32/f64
IEEE 754-2019 removed the `minNum` (`min` in Rust) and `maxNum` (`max` in Rust) operations in favor of the newly created `minimum` and `maximum` operations due to their [non-associativity](https://grouper.ieee.org/groups/msc/ANSI_IEEE-Std-754-2019/background/minNum_maxNum_Removal_Demotion_v3.pdf ) that cannot be fix in a backwards compatible manner. This PR adds `fN::{minimun,maximum}` functions following the new rules.
### IEEE 754-2019 Rules
> **minimum(x, y)** is x if x < y, y if y < x, and a quiet NaN if either operand is a NaN, according to 6.2.
For this operation, −0 compares less than +0. Otherwise (i.e., when x = y and signs are the same)
it is either x or y.
> **maximum(x, y)** is x if x > y, y if y > x, and a quiet NaN if either operand is a NaN, according to 6.2.
For this operation, +0 compares greater than −0. Otherwise (i.e., when x = y and signs are the
same) it is either x or y.
"IEEE Standard for Floating-Point Arithmetic," in IEEE Std 754-2019 (Revision of IEEE 754-2008) , vol., no., pp.1-84, 22 July 2019, doi: 10.1109/IEEESTD.2019.8766229.
### Implementation
This implementation is inspired by the one in [`glibc` ](90f0ac10a7/math/s_fminimum_template.c1d8aa13bc3https://godbolt.org/z/7sMrxW49a ) when trying to lower them to machine intructions, GCC doesn't yet have built-ins for them, only cranelift support them nativelly (as it doesn't support the nativelly the old sementics).
Helps with https://github.com/rust-lang/rust/issues/83984
2021-11-21 09:55:13 +01:00
Linda_pp
ac083c6b45
Reborrow mut slice instead of converting it with as_ref
...
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
2021-11-21 11:01:31 +09:00
Ibraheem Ahmed
25271a5a98
fix doc links for downcast_unchecked
2021-11-20 18:22:05 -05:00
Urgau
e2ec3b1dd7
Apply documentation suggestions from @est31
...
Co-authored-by: est31 <est31@users.noreply.github.com>
2021-11-20 23:05:30 +01:00
Dylan MacKenzie
7ba4accfbf
Stabilize ControlFlow::{is_break, is_continue}
2021-11-20 11:52:09 -08:00
Linda_pp
66e0523d09
Update version in stable attribute
...
Co-authored-by: Joshua Nelson <github@jyn.dev>
2021-11-20 23:35:28 +09:00
rhysd
72b411fd89
Implement TryFrom<&'_ mut [T]> for [T; N]
2021-11-20 23:05:08 +09:00
Loïc BRANSTETT
2bad893900
Add similar note as LLVM does for minNum and maxNum functions
2021-11-20 10:14:03 +01:00
Loïc BRANSTETT
a8ee0e9c2c
Implement IEEE 754-2019 minimun and maximum functions for f32/f64
2021-11-20 10:14:03 +01:00
Matthias Krüger
62b259cd88
Rollup merge of #91044 - r00ster91:x1b, r=joshtriplett
...
Turn all 0x1b_u8 into '\x1b' or b'\x1b'
Supersedes #91040
2021-11-20 01:09:44 +01:00
Matthias Krüger
97bd45b373
Rollup merge of #88361 - WaffleLapkin:patch-2, r=jyn514
...
Makes docs for references a little less confusing
- Make clear that the `Pointer` trait is related to formatting
- Make clear that the `Pointer` trait is implemented for references (previously it was confusing to first see that it's implemented and then see it in "expect")
- Make clear that `&T` (shared reference) implements `Send` (if `T: Send + Sync`)
2021-11-20 01:09:37 +01:00
r00ster91
a2d78573d3
Turn all 0x1b_u8 into '\x1b' or b'\x1b'
2021-11-19 18:14:18 +01:00
Maybe Waffle
cdb0c29a9c
Remove unnecessary doc links
2021-11-19 19:13:53 +03:00
The8472
3f9b26dc64
Fix Iterator::advance_by contract inconsistency
...
The `advance_by(n)` docs state that in the error case `Err(k)` that k is always less than n.
It also states that `advance_by(0)` may return `Err(0)` to indicate an exhausted iterator.
These statements are inconsistent.
Since only one implementation (Skip) actually made use of that I changed it to return Ok(()) in that case too.
While adding some tests I also found a bug in `Take::advance_back_by`.
2021-11-19 13:00:23 +01:00
