Oliver Schneider
ff2487b30e
permit more equalities
2016-12-02 19:23:30 +01:00
Oliver Schneider
cf1fa94be1
down to for-loops not comparing as equal
2016-12-02 19:19:52 +01:00
Oliver Schneider
16aab71688
enum glob use
and copies
left
2016-12-02 17:38:31 +01:00
Oliver Schneider
59b0077565
WIP compiles and doesn't crash (much) but tests are failing
2016-12-01 22:31:56 +01:00
Oliver Schneider
31e482403c
rustup to rustc 1.15.0-nightly ( d5814b03e
2016-11-23)
2016-11-25 19:24:55 +01:00
mcarton
c7e3cc1e27
Rustup to *rustc 1.15.0-nightly ( 3bf2be9ce
2016-11-22)*
2016-11-23 22:44:00 +01:00
mcarton
c35f82b823
Rustup to *rustc 1.15.0-nightly ( 7b3eeea22
2016-11-21)*
2016-11-23 21:31:55 +01:00
Oliver Schneider
f39c6278e1
fix the inspector
2016-11-18 13:21:07 +01:00
mcarton
945c027768
Handle closure with single expression blocks
2016-11-17 19:44:18 +01:00
mcarton
19c5f5394b
Rustup to rustc 1.15.0-nightly ( 0ed951993
2016-11-14)
2016-11-16 23:05:26 +01:00
Sébastien Santoro
0e6807e86b
Recognize quux as a metasyntactic variable
...
quux is another metasyntactic variable like foo and so
should be detected by the blacklisted names linter.
2016-11-11 05:57:29 +01:00
Oliver Schneider
a56af73fd8
mark cyclomatic complexity attribute as used
...
fixes #1315
2016-11-02 10:29:57 +01:00
Oliver Schneider
053896b678
Merge pull request #1307 from Kha/partialeq_ne
...
Implement 'Re-implementing `PartialEq::ne`' lint
2016-10-31 09:06:14 -04:00
Sebastian Ullrich
9314965af0
inspector: fix printing non-local trait refs
2016-10-30 15:00:59 -04:00
Oliver Schneider
8b2e80b47b
Merge pull request #1299 from Manishearth/clippy-toml
...
Search for `clippy.toml` recursively
2016-10-30 14:35:32 -04:00
Sebastian Ullrich
90f71be4e9
factor out is_automatically_derived
util fn
2016-10-30 14:25:06 -04:00
d-dorazio
d213040381
Add lint for redundant pattern matching in iflet for Result/Option
2016-10-30 15:43:46 +01:00
mcarton
d52af53e04
Search for clippy.toml
recursively
2016-10-25 19:41:24 +02:00
Oliver Schneider
233459ea33
clean up docs for clippy_dump
2016-10-24 16:30:22 +02:00
Oliver Schneider
34deb72c36
properly name the docs
2016-10-24 15:43:37 +02:00
Oliver Schneider
ed50cb133d
dogfood
2016-10-24 15:16:21 +02:00
Oliver Schneider
6a6dfa59da
factor out decl dumping
2016-10-24 14:29:09 +02:00
Oliver Schneider
1248159f0d
add expression and pattern dump
2016-10-24 14:28:58 +02:00
Oliver Schneider
f29ab8c245
Merge branch 'master' of github.com:Manishearth/rust-clippy into deep_code_inspection
2016-10-24 10:39:19 +02:00
Arnavion
2315a817ce
Changed signature of cargo::metadata according to review comment.
2016-10-23 12:24:16 -07:00
Arnavion
ebbd00b1ab
Don't assume the first package in the result of cargo metadata
is the current crate.
...
Instead find the one with the manifest path that matches the --manifest-path argument or the current directory.
Fixes #1247
2016-10-22 18:15:42 -07:00
mcarton
1c3fce41b6
Rustup to *rustc 1.14.0-nightly ( f09420685
2016-10-20)*
2016-10-22 15:57:19 +02:00
Oliver Schneider
a177d85681
rename inspection attribute to clippy_dump
2016-10-18 17:29:01 +02:00
Oliver Schneider
ff3efc759e
initial implementation of the code inspector lint
2016-10-18 16:57:39 +02:00
Patrick Horlebein
4fbd8906e1
doc_markdown: Added "iOS" and "macOS" to the doc-valid-idents list
2016-10-12 15:32:44 +02:00
mcarton
0475eae1fa
Rustup to *rustc 1.14.0-nightly ( 3210fd5c2
2016-10-05)*
2016-10-06 17:46:50 +02:00
mcarton
2b8500664c
Remove warning in the lastest nightly
2016-10-04 17:17:40 +02:00
mcarton
4f91d66905
Rustup to *rustc 1.14.0-nightly ( 144af3e97
2016-10-02)*
2016-10-03 21:25:27 +02:00
Manish Goregaokar
a4198c1108
Merge pull request #1255 from Manishearth/cov
...
Improve test coverage
2016-10-03 22:15:23 +05:30
mcarton
9a3f53dee6
Partially hash let
declaration in SpanlessHash
...
The hash never needs to be good but before it was simply doing nothing
for these.
2016-10-02 02:17:04 +02:00
mcarton
e036a8145a
Support ExprType
(type ascription) comparison
...
*ish
2016-10-01 22:26:57 +02:00
mcarton
3e009b9424
Implement more hir
typed node comparison
2016-10-01 22:19:20 +02:00
Elliott Clark
5fa004313b
Add a lint to warn about un-necessary .into_iter()
...
This should close #1094 .
2016-09-30 17:42:43 -07:00
mcarton
4f3920307a
Rustup to *rustc 1.13.0-nightly ( d0623cf7b
2016-09-26)*
2016-09-28 01:09:11 +02:00
mcarton
c8986b4676
Fix FP with WHILE_LET_ON_ITERATOR
and refutable pats
2016-09-16 15:50:35 +02:00
mcarton
90c390ec2a
Fix typo
...
Who cares? Meh, consistency.
2016-09-16 15:45:19 +02:00
mcarton
ab6669a641
Rustup to *rustc 1.13.0-nightly ( f1f40f850
2016-09-09)*
2016-09-10 19:13:49 +02:00
kennytm
5f09020e90
Added a lint_without_lint_pass lint.
...
Four lints were missing from LintPass, making them unavailable unless the
`clippy` lint group is explicitly enabled:
* `for_loop_over_result`
* `for_loop_over_option`
* `match_overlapping_arm`
* `filter_next`
2016-09-01 15:07:37 +08:00
mcarton
3f43996aa5
Rustup to *1.13.0-nightly ( eac41469d
2016-08-30)*
2016-08-31 18:22:35 +02:00
mcarton
d87f137254
Add a builtin_type_shadow
lint
2016-08-28 19:56:18 +02:00
mcarton
189c5e5cfc
Rustup to rustc 1.13.0-nightly ( a23064af5
2016-08-27)
2016-08-28 17:25:58 +02:00
mcarton
be329ebdf7
Typo
...
TIL what `wether` means.
2016-08-23 19:51:42 +02:00
mcarton
9a2aadf872
Deny missing_docs_in_private_items
in some modules
2016-08-23 19:39:36 +02:00
llogiq
cf2b0c8dd6
New cmp_null lint ( fixes #1184 ) ( #1186 )
...
* new cmp_null lint (fixes #1184 )
* adressed comments (still fails)
* fixed tests, dogfood, ran update_lints
2016-08-22 18:29:29 +02:00
Oliver Schneider
40720a61e8
rustup for the ! type
2016-08-17 17:58:15 +02:00
mcarton
a34beedfe5
Add "DirectX" and "OpenGL" to doc_valid_idents
2016-08-17 15:46:33 +02:00
David Tolnay
95df2d1bf4
Update to rustc 1.12.0-nightly ( 1deb02ea6
2016-08-12)
2016-08-13 14:23:38 -07:00
Oliver Schneider
7e67f447ce
add suggestions to clone_on_copy
...
also:
* don't report clone_on_copy when reporting clone_on_double_ref
* don't suggest `((x))`
2016-08-08 16:43:45 +02:00
Georg Brandl
b91c1a509e
Make lint descriptions short and to the point; always fitting the column "triggers on".
2016-08-07 08:09:26 +02:00
Georg Brandl
3b5ff0f813
Make the lint docstrings more consistent.
2016-08-07 08:06:19 +02:00
Georg Brandl
fa0df69a97
Add a configurable threshold for enum variants before name lints trigger ( fixes #1138 )
2016-08-06 20:59:27 +02:00
Andre Bogus
75b85a55ec
added OAuth and TrueType to doc whitelist
2016-08-03 22:49:54 +02:00
Oliver Schneider
81c5757f44
lint on by ref patterns for references
2016-08-01 16:59:14 +02:00
mcarton
a01d7c93e7
Add IPv4
and IPv6
to the valid doc idents list
2016-07-31 01:07:28 +02:00
llogiq
a371558bdb
Merge pull request #1093 from oli-obk/serde_specific_lint
...
lint on implementing `visit_string` without also implementing `visit_str`
2016-07-18 11:53:28 +02:00
Oliver Schneider
b4ee9115d8
"fallout"
2016-07-18 11:19:45 +02:00
Oliver Schneider
02c46f057f
add an internal lint that catches misordered paths
2016-07-18 11:19:33 +02:00
Oliver Schneider
fc54a91916
add the path to the util::path module
2016-07-15 18:10:28 +02:00
llogiq
b1becf41e4
Merge pull request #1099 from Manishearth/fix
...
Some small fixes
2016-07-14 21:32:45 +02:00
mcarton
ea665c38f1
Fix FP with USELESS_VEC
and non-copy types
2016-07-14 19:31:17 +02:00
Manish Goregaokar
c1421c6e82
Don't warn when boxing large arrays
2016-07-12 18:49:34 +05:30
mcarton
3a201f43ec
Rustup to rustc 1.12.0-nightly ( f93aaf84c
2016-07-09)
2016-07-10 15:42:02 +02:00
mcarton
eb75d4ee62
Fix suggestions for NEW_WITHOUT_DEFAULT
2016-07-10 14:20:38 +02:00
llogiq
ad1cd99054
Merge pull request #1060 from Manishearth/sugg
...
Improve suggestions
2016-07-10 00:06:30 +02:00
David Tolnay
33c767c510
Add "JavaScript" to doc-valid-idents
2016-07-06 21:27:29 -07:00
mcarton
bf513229b1
Address PR's comments
2016-07-06 15:49:49 +02:00
mcarton
c5e91e70d0
Use sugg::Sugg
in transmute links
2016-07-04 02:22:57 +02:00
mcarton
7778f314f2
Merge branch 'master' into sugg
2016-07-04 00:51:19 +02:00
mcarton
ffa840d4f2
Use utils::sugg
in match
related lints
...
Also don't build suggestion when unnecessary.
2016-07-03 23:27:37 +02:00
mcarton
7781f1d7c5
Add a new not_unsafe_ptr_arg_deref
lint
2016-07-03 13:28:34 +05:30
mcarton
cc18556ae5
Use utils::sugg
in swap lints
2016-07-02 17:31:22 +02:00
mcarton
2a45a2ab6b
Use utils::sugg
in FOR_KV_MAP
2016-07-01 20:55:45 +02:00
mcarton
dbf6dc66d8
Add more sugggestion-building functions
2016-07-01 19:30:38 +02:00
mcarton
e613c8b492
Introduce multispan_sugg
2016-07-01 18:43:42 +02:00
mcarton
97f65b0296
Rustup to ea0dc92972
III
2016-07-01 17:49:18 +02:00
mcarton
98f18f0474
Move vec!
unexpanding function to utils::higher
2016-07-01 17:12:49 +02:00
mcarton
4dff4df577
Move more functions to utils::higher
2016-07-01 17:12:49 +02:00
mcarton
92b04129fe
Move unsugar_range
to utils::higher
2016-07-01 17:12:49 +02:00
mcarton
7023988020
Use utils::sugg
in TOPLEVEL_REF_ARG
2016-07-01 17:12:48 +02:00
mcarton
7a1fc9fce5
Use utils::sugg
in MATCH_BOOL
2016-07-01 17:12:48 +02:00
mcarton
9811dea237
Add a module to pretty-print suggestions
2016-07-01 17:12:48 +02:00
Oliver Schneider
799861d7e0
use span_lint_and_then instead of adding to the DiagnosticWrapper
2016-06-27 17:14:04 +02:00
Oliver 'ker' Schneider
8c5e617c9a
don't lint on comparing *const f32
s
2016-06-25 18:59:37 +02:00
Oliver Schneider
36c5026c48
fix cargo clippy when using with --manifest-path
2016-06-21 12:31:30 +02:00
Manish Goregaokar
5b1d849c7e
Revert "fix cargo clippy when using with --manifest-path
"
...
This reverts commit b31bebeea4
.
2016-06-21 15:24:04 +05:30
Oliver Schneider
b31bebeea4
fix cargo clippy when using with --manifest-path
2016-06-21 11:35:34 +02:00
Oliver Schneider
a976401171
round 2
2016-06-16 12:20:05 +02:00
Oliver Schneider
4701f13551
round 1
2016-06-16 12:20:05 +02:00
Martin Carton
f9b3aebfdf
Merge pull request #1000 from Manishearth/doc_whitelist
...
added GPLv{2,3} to doc-valid-idents
2016-06-10 00:44:52 +02:00
mcarton
d85b8062e3
Format all if_let_chain
consistently
2016-06-10 00:09:17 +02:00
mcarton
90453fd893
Run rustfmt
...
Only partially apply suggestions.
2016-06-10 00:08:14 +02:00
Andre Bogus
8756ae5082
added GPLv{2,3} to doc-valid-idents
2016-06-10 00:06:50 +02:00
mcarton
c5affa2efc
Whitelist Nan in DOC_MARKDOWN
2016-06-09 23:33:28 +02:00
Oliver Schneider
a3f7fea36c
simply parse unknown json-strings as strings instead of erroring
2016-06-06 11:03:15 +02:00
mcarton
a7a6c0461d
Add environment variable to deactivate wiki links
2016-06-05 22:03:02 +02:00
Oliver Schneider
7bb8ba4631
process more kinds of metadata
2016-06-02 17:29:25 +02:00
Andre Bogus
2811dd64ec
added missing PatKind::Path + tests
2016-05-31 23:35:42 +02:00
Andre Bogus
6aa37e57a2
s/PatKind::Ident/PatKind::Binding/g
2016-05-31 23:30:49 +02:00
Oliver Schneider
80e81d351d
add version check to the unit tests
2016-05-30 12:47:04 +02:00
mcarton
a892a96eeb
Rustup to *1.10.0-nightly ( 7bddce693
2016-05-27)*
2016-05-28 16:35:38 +02:00
Oliver Schneider
bf227f4729
split clippy into lints, plugin and cargo-clippy
2016-05-27 13:03:58 +02:00