Shotaro Yamada
d06733efeb
Cleanup
2020-02-19 13:36:59 +09:00
Shotaro Yamada
dd0c3c41b9
Fix a crash with non-ascii whitespace in doc-comments
2020-02-19 13:13:29 +09:00
Edwin Cheng
b9d94d73a2
Use proper range for hover on macro arguments
2020-02-19 11:56:27 +08:00
bors[bot]
20252efb32
Merge #3225
...
3225: Cleanup imports r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-18 22:54:11 +00:00
Aleksey Kladov
b4450b1043
Cleanup imports
2020-02-18 23:52:53 +01:00
bors[bot]
f03404f681
Merge #3223
...
3223: Minor simplification r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-18 17:56:49 +00:00
Aleksey Kladov
97ab471b6d
Minor simplification
2020-02-18 18:52:33 +01:00
bors[bot]
04080dc4f6
Merge #3221
...
3221: Fix dev guide broken links r=matklad a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-02-18 14:44:37 +00:00
bors[bot]
cecf25b72f
Merge #3220
...
3220: Fix clippy warnings, update Cargo.toml versions r=matklad a=SomeoneToIgnore
In the `cargo xtask lint` ouptut, there were two interesting Clippy warnings that might be interesting to investigate further:
* warning: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
* warning: large size difference between variants
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
2020-02-18 14:37:34 +00:00
Laurențiu Nicola
48737be857
Fix dev guide broken links
2020-02-18 16:24:04 +02:00
Kirill Bulatov
f6816c253b
Update versions
2020-02-18 16:12:40 +02:00
Kirill Bulatov
eceaf94f19
More manual clippy fixes
2020-02-18 16:12:37 +02:00
Kirill Bulatov
b8ddcb0652
Run cargo +nightly fix --clippy -Z unstable-options
2020-02-18 16:03:08 +02:00
bors[bot]
eab80cd961
Merge #3218
...
3218: Cut some deps r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-18 13:46:54 +00:00
Aleksey Kladov
039f2039a4
Remove unicase dependency
2020-02-18 14:44:52 +01:00
Aleksey Kladov
b643ccfaed
Drop extra deps
2020-02-18 14:44:52 +01:00
Aleksey Kladov
c870318f53
Ignore cargo -Z timings info
2020-02-18 14:44:52 +01:00
bors[bot]
e59445cdde
Merge #3217
...
3217: Remove dat FIXME r=matklad a=Veetaha
Co-authored-by: Veetaha <veetaha2@gmail.com>
2020-02-18 13:23:45 +00:00
Veetaha
583b1e155a
Remove dat FIXME
2020-02-18 15:19:49 +02:00
bors[bot]
c447fe9bc0
Merge #3026
...
3026: ra_syntax: reshape SyntaxError for the sake of removing redundancy r=matklad a=Veetaha
Followup of #2911 , also puts some crosses to the todo list of #223 .
**AHTUNG!** A big part of the diff of this PR are test data files changes.
Simplified `SyntaxError` that was `SyntaxError { kind: { /* big enum */ }, location: Location }` to `SyntaxError(String, TextRange)`. I am not sure whether the tuple struct here is best fit, I am inclined to add names to the fields, because I already provide getters `SyntaxError::message()`, `SyntaxError::range()`.
I also removed `Location` altogether ...
This is currently WIP, because the following is not done:
- [ ] ~~Add tests to `test_data` dir for unescape errors *// I don't know where to put these errors in particular, because they are out of the scope of the lexer and parser. However, I have an idea in mind that we move all validators we have right now to parsing stage, but this is up to discussion...*~~ **[UPD]** I came to a conclusion that tree validation logic, which unescape errors are a part of, should be rethought of, we currently have no tests and no place to put tests for tree validations. So I'd like to extract potential redesign (maybe move of tree validation to ra_parser) and adding tests for this into a separate task.
Co-authored-by: Veetaha <gerzoh1@gmail.com>
Co-authored-by: Veetaha <veetaha2@gmail.com>
2020-02-18 12:57:26 +00:00
Aleksey Kladov
742459c8fe
Merge pull request #3204 from Veetaha/feature/vscode-remove-updates-notification-comment
...
vscode: remove comment about updates notification
2020-02-18 13:44:56 +01:00
Aleksey Kladov
d05480a178
Merge pull request #3216 from matklad/rename-to-rust-analyzer
...
rename binary to rust-analyzer
2020-02-18 13:30:40 +01:00
Aleksey Kladov
865759925b
Rename folder
2020-02-18 12:37:45 +01:00
Aleksey Kladov
c855e36696
Rename config value for server Path
2020-02-18 12:35:44 +01:00
Aleksey Kladov
c0fa5e2246
Rename the binary to rust-analyzer
2020-02-18 12:33:16 +01:00
bors[bot]
2768476e49
Merge #3214
...
3214: Fully document ra_lsp_server r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-18 11:26:10 +00:00
Aleksey Kladov
4d307ff802
Fully document ra_lsp_server
2020-02-18 12:25:26 +01:00
Aleksey Kladov
1f142d79ed
Refactor
2020-02-18 12:17:47 +01:00
Aleksey Kladov
42c766b2bd
Reduce visibility
2020-02-18 12:16:40 +01:00
Aleksey Kladov
b6740060f6
Refactor
2020-02-18 12:15:12 +01:00
Aleksey Kladov
93b969003d
Some docs
2020-02-18 12:11:32 +01:00
Aleksey Kladov
59e1207dac
Better folder structure
2020-02-18 11:56:18 +01:00
bors[bot]
a349e5d4fc
Merge #3211
...
3211: Fix typo r=edwin0cheng a=atsisy
Just fix typo in user/doc/readme.adoc
Co-authored-by: Akihiro Takai <at.sisy@gmail.com>
2020-02-18 04:49:08 +00:00
Akihiro Takai
3bdb47ce66
Fix typo
2020-02-18 10:37:26 +09:00
Aleksey Kladov
784919aec1
Merge pull request #3209 from matklad/eslint
...
Eslint
2020-02-18 01:12:29 +01:00
Veetaha
053ccf4121
ra_syntax: fix reparsing merging errors, also now reparse_token() reports errors
2020-02-18 02:11:16 +02:00
Aleksey Kladov
f2e44cfe85
Allow floating promises
...
This backfires for message-showing functions
2020-02-18 01:05:52 +01:00
Aleksey Kladov
d71ddeaced
Gate stuff on CI
2020-02-18 01:05:52 +01:00
bors[bot]
fcca80fb7d
Merge #3210
...
3210: vscode-languageclient 6.1.1 r=kjeremy a=kjeremy
Fixes semantic token mispellings
Co-authored-by: kjeremy <kjeremy@gmail.com>
2020-02-17 23:58:44 +00:00
kjeremy
3b57d8eb20
vscode-languageclient 6.1.1
2020-02-17 18:57:19 -05:00
bors[bot]
585eef1d8c
Merge #3206
...
3206: Install rust-src when it is not found r=SomeoneToIgnore a=SomeoneToIgnore
Closes https://github.com/rust-analyzer/rust-analyzer/issues/2858
Looks like there's no RUSTUP env variable, so it adds one more thing to solve in https://github.com/rust-analyzer/rust-analyzer/issues/3154
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
2020-02-17 23:01:54 +00:00
Aleksey Kladov
07a77ffb35
Migrate to eslint
2020-02-17 23:42:25 +01:00
Kirill Bulatov
e29dbdb139
Simplify the command execution
2020-02-18 00:38:01 +02:00
Kirill Bulatov
67d30312d0
Simplify the code further
2020-02-18 00:18:26 +02:00
Kirill Bulatov
addb61df36
Idempotent location and installation of rust src
2020-02-18 00:07:15 +02:00
Kirill Bulatov
50cf1e3d67
Reword the docs
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-17 23:48:47 +02:00
Kirill Bulatov
5cea8a37b7
Install rust-src when it is not found
2020-02-17 23:40:34 +02:00
Veetaha
fc5e7b8807
ra_syntax: migrate test data to 0-length text-range of SyntaxError when constructed from TextUnit
2020-02-17 23:14:31 +02:00
Veetaha
cd8e56c580
ra_syntax: remove message() method and use only Display trait in SyntaxError as per matklad
2020-02-17 23:13:38 +02:00
Veetaha
e05eb631d4
ra_syntax: change module-level documentation for syntax_error to "see X" as per matklad
2020-02-17 22:50:58 +02:00