Eduardo Broto
fc8ab099c3
identity_op: allow 1 << 0
2020-05-15 21:17:37 +02:00
ThibsG
ab87f87ba0
Fix CHANGELOG.md and lint names plural
2020-05-15 18:27:11 +02:00
bors
e22ccf5332
Auto merge of #5592 - ebroto:extend_unused_unit, r=flip1995
...
unused_unit: lint also in type parameters and where clauses
changelog: unused_unit now also lints in type parameters and where clauses
Fixes #5585
2020-05-15 14:47:11 +00:00
csmoe
0a86335cd4
implement type_implments_trait query
2020-05-15 15:37:11 +08:00
ThibsG
93386563f6
Rename lint map_unwrap
to map_unwrap_or
and register lints as renamed
2020-05-15 09:17:39 +02:00
Vardan Margaryan
1c59cd5f21
Fix example code of wildcard_enum_match_arm lint
2020-05-14 22:41:05 +03:00
Vardan Margaryan
749619cfe3
Apply suggestions from PR review
2020-05-14 22:40:33 +03:00
Vardan Margaryan
4948307977
Fix cases of match_wildcard_for_single_variants lint when it is spanned on Option
2020-05-14 22:36:46 +03:00
Vardan Margaryan
0ad9f7d651
Fix trivial cases of new match_wildcard_for_single_variants lint
2020-05-14 22:36:46 +03:00
Vardan Margaryan
94e4b5ec31
Add the redundant_wildcard_enum_match lint
2020-05-14 22:36:46 +03:00
David Tolnay
95399f8f94
Downgrade useless_let_if_seq to nursery
2020-05-14 09:57:36 -07:00
ThibsG
adbdf7549c
Merge for_loop_over_option
and for_loop_over_result
lints into for_loop_over_fallible
lint
2020-05-14 16:01:07 +02:00
ThibsG
0e8be599cd
Merge option_expect_used
and result_expect_used
lints into expect_used
lint
2020-05-14 16:01:07 +02:00
ThibsG
bcf61666bd
Merge option_unwrap_used
and result_unwrap_used
lints into unwrap_used
lint
2020-05-14 16:01:07 +02:00
ThibsG
6cbdd1e49d
Merge option_map_unwrap_or
, option_map_unwrap_or_else
and result_map_unwrap_or_else
lints into map_unwrap
lint
2020-05-14 15:56:17 +02:00
ThibsG
945c944709
Merge block_in_if_condition_expr
and block_in_if_condition_stmt
lints into block_in_if_condition
lint
2020-05-14 15:56:17 +02:00
bors
e1842b0cac
Auto merge of #5583 - ebroto:reversed_empty_ranges, r=yaahc,flip1995
...
Reversed empty ranges
This lint checks range expressions with inverted limits which result in empty ranges. This includes also the ranges used to index slices.
The lint reverse_range_loop was covering iteration of reversed ranges in a for loop, which is a subset of what this new lint covers, so it has been removed. I'm not sure if that's the best choice. It would be doable to check in the new lint that we are not in the arguments of a for loop; I went for removing it because the logic was too similar to keep them separated.
changelog: Added reversed_empty_ranges lint that checks for ranges where the limits have been inverted, resulting in empty ranges. Removed reverse_range_loop which was covering a subset of the new lint.
Closes #4192
Closes #96
2020-05-14 12:59:24 +00:00
bors
7147068399
Auto merge of #5590 - ebroto:issue_5579, r=phansch
...
Fix ICE caused in unwrap module
changelog: Fix ICE in unwrap module with unexpected number of parameters for method of Option/Result
Fixes #5579
2020-05-14 05:34:54 +00:00
Eduardo Broto
9217675c7f
Fix comparison_chain false positive
2020-05-14 00:26:09 +02:00
Eduardo Broto
671c1e34cc
Avoid running doctest that is expected to panic
2020-05-13 21:07:13 +02:00
Eduardo Broto
8d1029d3ca
Move test for issue 5579 under tests/ui/crashes
2020-05-13 20:47:44 +02:00
Eduardo Broto
e4cd8e7961
Fix ICE caused in unwrap module
2020-05-13 20:35:52 +02:00
Eduardo Broto
064431d22f
Re-add old tests for empty range loops
2020-05-13 20:33:32 +02:00
Eduardo Broto
0f2b1193f9
Remove reverse_range_loop lint
2020-05-13 20:33:32 +02:00
Eduardo Broto
8ffa0bfaa2
New lint: reversed_empty_ranges
2020-05-13 20:33:32 +02:00
Eduardo Broto
f20b962773
unused_unit: lint also in type parameters and where clauses
2020-05-13 20:33:12 +02:00
Julian Wollersberger
ff9a9ed37c
Replace some usages of the old unescape_
functions in AST, clippy and tests.
2020-05-13 10:05:04 +02:00
bors
b20a9cd474
Auto merge of #5587 - flip1995:rustup, r=phansch
...
Rustup
Done with
```bash
git subtree push -P src/tools/clippy git@github.com:flip1995/rust-clippy rustup
```
from https://github.com/flip1995/rust/tree/clippyup
A rebase was required to get rid of empty merge commits, that somehow were not empty? 🤔
changelog: none
2020-05-13 05:55:10 +00:00
flip1995
eec17d2c21
Update failing test
2020-05-11 21:40:33 +02:00
flip1995
505280b108
Run cargo dev fmt
2020-05-11 21:31:01 +02:00
flip1995
33a3d852f5
Fix fallout
...
Re-remove util/dev file
2020-05-11 21:28:14 +02:00
Camille GILLOT
8ab3224b3b
Fix clippy.
2020-05-11 21:26:39 +02:00
Jack Huey
01662d3a23
Fix nit and cargo.lock
2020-05-11 21:26:38 +02:00
flip1995
d13d8987b0
Merge commit '43a1777b89cf6791f9e20878b4e5e3ae907867a5' into clippyup
2020-05-11 20:23:47 +02:00
Philipp Krones
d4092ace00
Merge pull request #5584 from Mark-Simulacrum/beta-next
...
Add hint for collect type
2020-05-11 19:14:38 +02:00
Mark Rousskov
318b8b6aab
Add hint for collect type
2020-05-10 22:15:35 -04:00
Ralf Jung
30822733f0
rustc_driver: factor out computing the exit code
2020-05-10 23:36:41 +02:00
bors
43a1777b89
Auto merge of #5564 - MrAwesome:master, r=flip1995
...
Allow `use super::*;` glob imports
changelog: Allow super::* glob imports
fixes #5554
fixes #5569
A first pass at #5554 - this allows all `use super::*` to pass, which may or may not be desirable. The original issue was around allowing test modules to import their entire parent modules - I'm happy to modify this to do that instead, may just need some guidance on how to implement that (I played around a bit with #[cfg(test)] but from what I can gather, clippy itself isn't in test mode when running, even if the code in question is being checked for the test target).
2020-05-09 18:43:28 +00:00
Glenn Hope
b69200b846
Move is_test_module check to top of function
2020-05-09 11:10:16 -07:00
Glenn Hope
0ba61c612e
Check is_macro inside check_exceptions, update references to fix test
2020-05-09 11:10:16 -07:00
Glenn Hope
a339766136
Fix test from auto-formatter fix
2020-05-09 11:10:16 -07:00
Glenn Hope
4db6abcd50
Remove check for Fn, reflect this in test cases, make test cases more robust/explicit
2020-05-09 11:09:38 -07:00
Glenn Hope
152cdcb45b
Remove unnecessary field, check for Mod/Fn ItemKind
2020-05-09 11:09:38 -07:00
Glenn Hope
a42a2bdac2
Also have flag disable macro check
2020-05-09 11:09:38 -07:00
Glenn Hope
ad92486d52
Add check for "test" in parent name. Include flag for disabling wildcard import exceptions
2020-05-09 11:09:38 -07:00
Glenn Hope
56f4e1c3a8
Check if the parent module name contains "test"
2020-05-09 11:09:38 -07:00
Glenn Hope
bdc75dbb7b
Run cargo dev fmt
2020-05-09 11:09:38 -07:00
Glenn Hope
0c14ea8ed7
Allow 'use super::*;' imports
2020-05-09 11:09:38 -07:00
bors
43d9cdc7b3
Auto merge of #5580 - matthiaskrgr:regex_dep, r=flip1995
...
deps: remove unused regex dependency from root crate
changelog: none
2020-05-09 12:41:19 +00:00
Ralf Jung
51158cc71f
Rollup merge of #71555 - cjgillot:nameless, r=matthewjasper
...
Remove ast::{Ident, Name} reexports.
The reexport of `Symbol` into `Name` confused me.
2020-05-09 13:36:39 +02:00