Commit Graph

90641 Commits

Author SHA1 Message Date
Steven Fackler
c5b87a29dd Fix sgx 2019-02-24 13:45:41 -08:00
bors
eb1df8c8a7 Auto merge of #58706 - matthewjasper:update-miri, r=RalfJung
update miri

cc #57609

r? @RalfJung
2019-02-24 21:40:10 +00:00
Ralf Jung
6d32e5ae1a prefer into_initialized over read_initialited 2019-02-24 20:34:24 +01:00
memoryruins
43e7434120 Simplify exclude_should_panic flag. 2019-02-24 11:58:08 -05:00
Matthew Jasper
09db1789d4 update miri 2019-02-24 16:45:14 +00:00
Nathan Corbyn
8300f51936 Deny async fn in 2015 edition
Fix style issues and update diagnostic messages

Update src/librustc_passes/diagnostics.rs

Co-Authored-By: doctorn <me@nathancorbyn.com>

Deny nested `async fn` in Rust 2015 edition

Deny nested `async fn` in Rust 2015 edition

Deny nested `async fn` in Rust 2015 edition
2019-02-24 16:33:12 +00:00
ljedrz
d7ced1dd5a hir: remove NodeId from Expr 2019-02-24 17:09:37 +01:00
ljedrz
021a140dcd hir: remove NodeId from Block 2019-02-24 17:09:26 +01:00
Ralf Jung
be8d728f3c show how to set with ptr::write 2019-02-24 16:58:04 +01:00
Steven Fackler
4c13791537 Fix cloudabi 2019-02-24 07:42:59 -08:00
Taiki Endo
9a0b4b6705 Remove some unnecessary 'extern crate' 2019-02-25 00:40:34 +09:00
bors
097c04cf43 Auto merge of #58315 - gnzlbg:returns_twice, r=alexcrichton
Implement unstable ffi_return_twice attribute

This PR implements [RFC2633](https://github.com/rust-lang/rfcs/pull/2633)

r? @eddyb
2019-02-24 14:15:55 +00:00
Matthew Jasper
19a54e8093 Type check pointer comparisons 2019-02-24 13:02:37 +00:00
Taiki Endo
871910a2c6 Use ? in some macros 2019-02-24 21:59:44 +09:00
Ralf Jung
a5e2d0c4e5 remark that the rules are unfinished 2019-02-24 12:25:46 +01:00
gnzlbg
2cf6e914aa Update stdsimd 2019-02-24 11:31:49 +01:00
bors
e17c48e2f2 Auto merge of #58691 - Centril:rollup, r=Centril
Rollup of 6 pull requests

Successful merges:

 - #57364 (Improve parsing diagnostic for negative supertrait bounds)
 - #58183 (Clarify guarantees for `Box` allocation)
 - #58442 (Simplify the unix `Weak` functionality)
 - #58454 (Refactor Windows stdio and remove stdin double buffering )
 - #58511 (Const to op simplification)
 - #58642 (rustdoc: support methods on primitives in intra-doc links)

Failed merges:

r? @ghost
2019-02-24 06:59:13 +00:00
ljedrz
63b4dd91be hir: remove NodeId from MacroDef 2019-02-24 07:50:46 +01:00
ljedrz
c886d47b82 doc: partially HirIdify visit_ast 2019-02-24 07:50:46 +01:00
ljedrz
46e4f4ae61 middle: partially HirIdify stability 2019-02-24 07:50:46 +01:00
ljedrz
b6b2edbfd7 hir: remove NodeId from WhereEqPredicate 2019-02-24 07:50:46 +01:00
ljedrz
cd5b5e7a80 hir: remove NodeId from WhereClause 2019-02-24 07:50:46 +01:00
ljedrz
e4f8a6bcc1 hir: remove NodeId from GenericParam 2019-02-24 07:50:46 +01:00
ljedrz
1c18ac1f65 privacy: HirIdify ObsoleteVisiblePrivateTypesVisitor 2019-02-24 07:50:45 +01:00
ljedrz
58ed683379 passes: HirIdify Id 2019-02-24 07:50:45 +01:00
ljedrz
00b74e5eaf hir: remove NodeId from Lifetime and Ty 2019-02-24 07:50:44 +01:00
ljedrz
904a91c496 hir: impl Display for HirId 2019-02-24 07:50:13 +01:00
Mazdak Farrokhzad
f01ebc56dc
Rollup merge of #58642 - tspiteri:intra-rustdoc-prim-method, r=GuillaumeGomez
rustdoc: support methods on primitives in intra-doc links

Fixes #58598.
2019-02-24 05:56:02 +01:00
Mazdak Farrokhzad
1082a292ea
Rollup merge of #58511 - oli-obk:const_to_op, r=RalfJung
Const to op simplification

r? @RalfJung

alternative to https://github.com/rust-lang/rust/pull/58486
2019-02-24 05:56:01 +01:00
Mazdak Farrokhzad
4dcb7af0e7
Rollup merge of #58454 - pitdicker:windows_stdio, r=alexcrichton
Refactor Windows stdio and remove stdin double buffering

I was looking for something nice and small to work on, tried to tackle a few FIXME's in Windows stdio, and things grew from there.

This part of the standard library contains some tricky code, and has changed over the years to handle more corner cases. It could use some refactoring and extra comments.

Changes/fixes:
- Made `StderrRaw` `pub(crate)`, to remove the `Write` implementations on `sys::Stderr` (used unsynchronised for panic output).
- Remove the unused `Read` implementation on `sys::windows::stdin`
- The `windows::stdio::Output` enum made sense when we cached the handles, but we can use simple functions like `is_console` now that we get the handle on every read/write
- `write` can now calculate the number of written bytes as UTF-8 when we can't write all `u16`s.
- If `write` could only write one half of a surrogate pair, attempt another write for the other because user code can't reslice in any way that would allow us to write it otherwise.
- Removed the double buffering on stdin. Documentation on the unexposed `StdinRaw` says: 'This handle is not synchronized or buffered in any fashion'; which is now true.
- `sys::windows::Stdin` now always only partially fills its buffer, so we can guarantee any arbitrary UTF-16 can be re-encoded without losing any data.
- `sys::windows::STDIN_BUF_SIZE` is slightly larger to compensate. There should be no real change in the number of syscalls the buffered `Stdin` does. This buffer is a little larger, while the extra buffer on Stdin is gone.
- `sys::windows::Stdin` now attempts to handle unpaired surrogates at its buffer boundary.
- `sys::windows::Stdin` no langer allocates for its buffer, but the UTF-16 decoding still does.

### Testing
I did some manual testing of reading and writing to console. The console does support UTF-16 in some sense, but doesn't supporting displaying characters outside the BMP.
- compile stage 1 stdlib with a tiny value for `MAX_BUFFER_SIZE` to make it easier to catch corner cases
- run a simple test program that reads on stdin, and echo's to stdout
- write some lines with plenty of ASCII and emoji in a text editor
- copy and paste in console to stdin
- return with `\r\n\` or CTRL-Z
- copy and paste in text editor
- check it round-trips

-----

Fixes https://github.com/rust-lang/rust/issues/23344. All but one of the suggestions in that issue are now implemented. the missing one is:

> * When reading data, we require the entire set of input to be valid UTF-16. We should instead attempt to read as much of the input as possible as valid UTF-16, only returning an error for the actual invalid elements. For example if we read 10 elements, 5 of which are valid UTF-16, the 6th is bad, and then the remaining are all valid UTF-16, we should probably return the first 5 on a call to `read`, then return an error, then return the remaining on the next call to `read`.

Stdin in Console mode is dealing with text directly input by a user. In my opinion getting an unpaired surrogate is quite unlikely in that case, and a valid reason to error on the entire line of input (which is probably short). Dealing with it is incompatible with an unbuffered stdin, which seems the more interesting guarantee to me.
2019-02-24 05:56:00 +01:00
Mazdak Farrokhzad
b78e9f4fe3
Rollup merge of #58442 - cuviper:unix-weak, r=alexcrichton
Simplify the unix `Weak` functionality

- We can avoid allocation by adding a NUL to the function name.
- We can get `Option<F>` directly, rather than aliasing the inner `AtomicUsize`.
2019-02-24 05:55:58 +01:00
Mazdak Farrokhzad
55b5ab8359
Rollup merge of #58183 - jethrogb:jb/alloc-box-guarantees, r=SimonSapin
Clarify guarantees for `Box` allocation

This basically says `Box` does the obvious things for its allocations.

See also: https://users.rust-lang.org/t/alloc-crate-guarantees/24981

This may require a T-libs FCP? Not sure.

r? @sfackler
2019-02-24 05:55:57 +01:00
Mazdak Farrokhzad
ae646687e0
Rollup merge of #57364 - hdhoang:33418_negative_bounds, r=estebank
Improve parsing diagnostic for negative supertrait bounds

closes #33418

r? @estebank
2019-02-24 05:55:55 +01:00
bors
7cb3ee453b Auto merge of #58304 - gnzlbg:simd_saturated, r=nagisa
Add generic simd saturated add/sub intrinsics

r? @eddyb
2019-02-24 04:16:12 +00:00
kenta7777
423ae56943 reduce a code repetition like (n << amt) >> amt 2019-02-24 12:55:14 +09:00
memoryruins
5d1f100988 Add unstable option to ignore should_panic tests. 2019-02-23 21:07:04 -05:00
Oliver Middleton
e7296fd1c4
Fix error index E0370 doctests on 32 bit platforms 2019-02-24 01:24:31 +00:00
bors
f573049729 Auto merge of #58232 - ljedrz:HirIdification_continued, r=Zoxc
HirId-ify intravisit

A big step towards https://github.com/rust-lang/rust/pull/57578.

This affects mostly `hir::{collector, intravisit}` and `rustc::lint`.
2019-02-24 00:24:16 +00:00
kenta7777
46f1cc69db reduce miri code repetition like (n << amt) >> amt 2019-02-24 08:59:19 +09:00
Marcel Hellwig
6464a0baf9
replace deprecated rustfmt_skip with rustfmt::skip 2019-02-23 22:40:56 +01:00
Andy Russell
1536852b42
merge early and late passes into single struct 2019-02-23 15:10:56 -05:00
Andy Russell
906ec8acce
move collapse and unindent docs passes earlier 2019-02-23 14:53:51 -05:00
bors
aadbc459bd Auto merge of #57051 - Eijebong:parking_lot, r=nikomatsakis
Update parking_lot to 0.7

Unfortunately this'll dupe parking_lot until the data_structures crate
is published and be updated in rls in conjunction with crossbeam-channel
2019-02-23 19:46:10 +00:00
varkor
890ef48eb9 Fix an indexing error when using x.py help 2019-02-23 18:57:25 +00:00
Trevor Spiteri
aa0fa752c4 fix build for Rust 2018 now that #58100 has been merged 2019-02-23 18:02:40 +01:00
Trevor Spiteri
bde4d1945c rustdoc: support methods on primitives in intra-doc links 2019-02-23 18:01:26 +01:00
bors
02a4e27254 Auto merge of #58661 - ehuss:update-cargo, r=alexcrichton
Update cargo

5 commits in b33ce7fc9092962b0657b4c25354984b5e5c47e4..5c6aa46e6f28661270979696e7b4c2f0dff8628f
2019-02-19 18:42:50 +0000 to 2019-02-22 19:32:35 +0000
- convert unused doc comments to regular comments (rust-lang/cargo#6692)
- Add more about system library on whether to keep Cargo.lock (rust-lang/cargo#6685)
- Warn when excluding non-existing packages (rust-lang/cargo#6679)
- Incremental profile cleanup. (rust-lang/cargo#6688)
- Various cosmetic improvements (rust-lang/cargo#6687)
2019-02-23 17:00:07 +00:00
gnzlbg
94aa74004e Use E0724 instead of E0723 as an error code 2019-02-23 16:24:14 +01:00
Ralf Jung
8ce9b8667a fix link 2019-02-23 16:20:00 +01:00
Ralf Jung
ac2284b80b expand type name 2019-02-23 16:18:50 +01:00