mcarton
726c2b6e9b
Don't ICE when a float can't be parsed
2016-09-20 18:25:00 +02:00
mcarton
dd6e3863e5
Fix ICE test in compiletest fail-tests
2016-09-08 01:10:23 +02:00
bors
cf0cdc452b
Auto merge of #36304 - TimNN:fix-36299, r=eddyb
...
re-add accidentally removed line in wfcheck
Fixes #36299 , introduced in #36119 .
r? @eddyb
2016-09-07 09:15:30 -07:00
bors
f707582a43
Auto merge of #36289 - euclio:self-suggestion, r=jseyfried
...
resolve: Suggest `use self` when import resolves
Improves errors messages by replacing "Maybe a missing `extern crate`" messages
with "Did you mean `self::...`" when the `self` import would succeed.
Fixes #34191 .
Thank you for the help @jseyfried!
2016-09-07 05:59:50 -07:00
bors
2819eca69c
Auto merge of #36296 - nagisa:pass-timing, r=eddyb
...
Count and report time taken by MIR passes
There’s some desire for deeper introspectability into what MIR passes cost us.
-Z time-passes after this PR:
```
Compiling test_shim v0.1.0 (file:///home/nagisa/Documents/rust/rust/src/rustc/test_shim)
time: 0.000; rss: 29MB parsing
time: 0.000; rss: 29MB configuration
time: 0.000; rss: 29MB recursion limit
time: 0.000; rss: 29MB crate injection
time: 0.000; rss: 29MB plugin loading
time: 0.000; rss: 29MB plugin registration
time: 0.032; rss: 54MB expansion
time: 0.000; rss: 54MB maybe building test harness
time: 0.000; rss: 54MB assigning node ids
time: 0.000; rss: 54MB checking for inline asm in case the target doesn't support it
time: 0.000; rss: 54MB complete gated feature checking
time: 0.000; rss: 54MB collecting defs
time: 0.004; rss: 54MB external crate/lib resolution
time: 0.000; rss: 54MB early lint checks
time: 0.000; rss: 54MB AST validation
time: 0.001; rss: 54MB name resolution
time: 0.000; rss: 54MB lowering ast -> hir
time: 0.000; rss: 56MB indexing hir
time: 0.000; rss: 56MB attribute checking
time: 0.000; rss: 56MB language item collection
time: 0.000; rss: 56MB lifetime resolution
time: 0.000; rss: 56MB looking for entry point
time: 0.000; rss: 56MB looking for plugin registrar
time: 0.000; rss: 56MB region resolution
time: 0.000; rss: 56MB loop checking
time: 0.000; rss: 56MB static item recursion checking
time: 0.000; rss: 56MB compute_incremental_hashes_map
time: 0.000; rss: 56MB load_dep_graph
time: 0.000; rss: 56MB type collecting
time: 0.000; rss: 56MB variance inference
time: 0.011; rss: 59MB coherence checking
time: 0.000; rss: 59MB wf checking
time: 0.000; rss: 59MB item-types checking
time: 0.000; rss: 59MB item-bodies checking
time: 0.000; rss: 59MB drop-impl checking
time: 0.000; rss: 59MB const checking
time: 0.000; rss: 59MB privacy checking
time: 0.000; rss: 59MB stability index
time: 0.000; rss: 59MB intrinsic checking
time: 0.000; rss: 59MB effect checking
time: 0.000; rss: 59MB match checking
time: 0.000; rss: 59MB liveness checking
time: 0.000; rss: 59MB rvalue checking
time: 0.000; rss: 59MB MIR dump
time: 0.000; rss: 59MB SimplifyCfg
time: 0.000; rss: 59MB QualifyAndPromoteConstants
time: 0.000; rss: 59MB TypeckMir
time: 0.000; rss: 59MB SimplifyBranches
time: 0.000; rss: 59MB SimplifyCfg
time: 0.000; rss: 59MB MIR passes
time: 0.000; rss: 59MB borrow checking
time: 0.000; rss: 59MB reachability checking
time: 0.000; rss: 59MB death checking
time: 0.000; rss: 59MB stability checking
time: 0.000; rss: 59MB unused lib feature checking
time: 0.000; rss: 59MB lint checking
time: 0.000; rss: 59MB resolving dependency formats
time: 0.000; rss: 59MB NoLandingPads
time: 0.000; rss: 59MB SimplifyCfg
time: 0.000; rss: 59MB EraseRegions
time: 0.000; rss: 59MB AddCallGuards
time: 0.000; rss: 59MB ElaborateDrops
time: 0.000; rss: 59MB NoLandingPads
time: 0.000; rss: 59MB SimplifyCfg
time: 0.000; rss: 59MB Deaggregator
time: 0.000; rss: 59MB AddCallGuards
time: 0.000; rss: 59MB PreTrans
time: 0.000; rss: 59MB Prepare MIR codegen passes
time: 0.000; rss: 59MB write metadata
time: 0.000; rss: 61MB translation item collection
time: 0.000; rss: 61MB codegen unit partitioning
time: 0.000; rss: 61MB internalize symbols
time: 0.007; rss: 61MB translation
time: 0.000; rss: 61MB assert dep graph
time: 0.000; rss: 61MB serialize dep graph
time: 0.000; rss: 61MB llvm function passes [2]
time: 0.000; rss: 61MB llvm function passes [3]
time: 0.000; rss: 61MB llvm function passes [1]
time: 0.000; rss: 61MB llvm function passes [0]
time: 0.000; rss: 61MB llvm module passes [2]
time: 0.000; rss: 61MB llvm module passes [1]
time: 0.000; rss: 61MB llvm module passes [0]
time: 0.000; rss: 61MB llvm module passes [3]
time: 0.001; rss: 62MB codegen passes [1]
time: 0.001; rss: 62MB codegen passes [2]
time: 0.001; rss: 62MB codegen passes [0]
time: 0.001; rss: 62MB codegen passes [3]
time: 0.001; rss: 63MB codegen passes [1]
time: 0.005; rss: 63MB LLVM passes
time: 0.000; rss: 63MB serialize work products
time: 0.001; rss: 63MB linking
```
r? @eddyb or @nikomatsakis
cc @nrc, @Mark-Simulacrum
2016-09-07 02:47:35 -07:00
bors
fe278a8a32
Auto merge of #36252 - joshtriplett:union-field-never-used, r=sanxiyn
...
Fix "field is never used" warning to take unions into account
When compiling code containing a union with an unused field, rustc says
"struct field is never used".
Rather than saying "struct or union", or adding logic to determine the
type of the item, just change the message to "field is never used",
dropping the "struct".
Update tests accordingly.
2016-09-06 20:06:34 -07:00
bors
3b272bf310
Auto merge of #36303 - jonathandturner:rollup, r=jonathandturner
...
Rollup of 8 pull requests
- Successful merges: #36121 , #36128 , #36241 , #36243 , #36263 , #36267 , #36273 , #36298
- Failed merges:
2016-09-06 16:45:41 -07:00
bors
923bac4596
Auto merge of #36025 - michaelwoerister:incr-comp-hash-spans, r=nikomatsakis
...
incr. comp.: Take spans into account for ICH
This PR makes the ICH (incr. comp. hash) take spans into account when debuginfo is enabled.
A side-effect of this is that the SVH (which is based on the ICHs of all items in the crate) becomes sensitive to the tiniest change in a code base if debuginfo is enabled. Since we are not trying to model ABI compatibility via the SVH anymore (this is done via the crate disambiguator now), this should be not be a problem.
Fixes #33888 .
Fixes #32753 .
2016-09-06 13:22:35 -07:00
Tim Neumann
d8c58d40ef
re-add accidentally removed line
2016-09-06 18:53:43 +02:00
Jonathan Turner
20cce247e1
Rollup merge of #36298 - GuillaumeGomez:hashmap_doc, r=steveklabnik
...
Add missing urls
r? @steveklabnik
2016-09-06 09:38:04 -07:00
Jonathan Turner
8156761e65
Rollup merge of #36273 - apasel422:unsafe_no_drop_flag, r=steveklabnik
...
Remove mention of `unsafe_no_drop_flag` from Reference and Nomicon
2016-09-06 09:38:03 -07:00
Jonathan Turner
c0e5a777d4
Rollup merge of #36267 - Cobrand:E0559, r=jonathandturner
...
Updated E0559 to new format
Refactored a method that printed one suggested field name,
into a method that returns an `Option` of a suggestion
(Updated test cases accordingly)
r? @jonathandturner
Closes #36197
2016-09-06 09:38:03 -07:00
Jonathan Turner
2d26603219
Rollup merge of #36263 - apasel422:scoped, r=steveklabnik
...
Clean up thread-local storage docs
`std` no longer contains an implementation of scoped TLS.
r? @steveklabnik
2016-09-06 09:38:02 -07:00
Jonathan Turner
b5f5f8b865
Rollup merge of #36243 - GuillaumeGomez:hash_map_links, r=steveklabnik
...
Add missing urls
r? @steveklabnik
2016-09-06 09:38:02 -07:00
Jonathan Turner
4f74f837b6
Rollup merge of #36128 - gavinb:error_msgs_p2, r=jonathandturner
...
Update Error format for E0516, E0517, E0518
- E0518 Update error format #36111
- E0517 Update error format #36109
- E0516 Update error format #36108
- Part of #35233
r? @jonathandturner
2016-09-06 09:38:02 -07:00
Jonathan Turner
613f35051f
Rollup merge of #36121 - Cobrand:master, r=jonathandturner
...
Updated E0527 to new error format
* Closes #36113
2016-09-06 09:38:01 -07:00
Michael Woerister
3057b7b974
ICH: Make CachingCodemapView robustly handle invalid spans.
2016-09-06 12:14:43 -04:00
bors
13c4e32e7a
Auto merge of #36288 - nrc:save-var-value, r=eddyb
...
save-analysis: some refinement to the value string for variables
2016-09-06 07:46:06 -07:00
ggomez
dc0e9c0b12
Add missing urls
2016-09-06 16:31:18 +02:00
Simonas Kazlauskas
0520698be3
Count and report time taken by MIR passes
2016-09-06 17:19:36 +03:00
bors
5114f8a29b
Auto merge of #36276 - jseyfried:fix_unused, r=nrc
...
resolve: Fix unused import false positive with `item_like_imports`
Fixes #36249 .
r? @nrc
2016-09-06 01:44:13 -07:00
bors
1d04201565
Auto merge of #36078 - ollie27:rustdoc_search_assocconst, r=alexcrichton
...
rustdoc: Fix associated consts in search results
Associated consts can appear in none trait impls so need to be treated
like methods when generating the search index.
Fixes #36031
2016-09-05 22:32:36 -07:00
Jeffrey Seyfried
ff3a644951
Add struct AmbiguityError
.
2016-09-06 03:52:36 +00:00
Jeffrey Seyfried
888a968139
Add field used: Cell<bool>
to variant NameBindingKind::Import
.
2016-09-06 03:43:46 +00:00
Jeffrey Seyfried
07f8cb28dc
Add regression test.
2016-09-06 03:43:21 +00:00
Jeffrey Seyfried
32674b3f1a
Avoid false positive unused import warnings.
2016-09-06 03:43:20 +00:00
Andy Russell
288e7caf19
show self
suggestion when items are in the block
2016-09-05 23:08:21 -04:00
Andy Russell
41ee2e9124
resolve: Suggest use self
when import resolves
...
Improves errors messages by replacing "Maybe a missing `extern crate`" messages
with "Did you mean `self::...`" when the `self` import would succeed.
2016-09-05 21:48:02 -04:00
Nick Cameron
92a1848d77
save-analysis: some refinement to the value string for variables
2016-09-06 13:07:59 +12:00
bors
e1d0de82cc
Auto merge of #36274 - Manishearth:rollup, r=Manishearth
...
Rollup of 6 pull requests
- Successful merges: #35845 , #35983 , #36065 , #36102 , #36242 , #36245
- Failed merges:
2016-09-05 17:55:45 -07:00
bors
cbe4de78e2
Auto merge of #35845 - frewsxcv:result-into-iter, r=GuillaumeGomez
...
Indicate where `core::result::IntoIter` is created.
None
2016-09-05 14:41:16 -07:00
bors
38824d1061
Auto merge of #36281 - pnkfelix:fix-issue-36036, r=eddyb
...
Fix issue #36036 .
Fix #36036 .
We were treating an associated type as unsized even when the concrete instantiation was actually sized. Fix is to normalize before checking if it is sized.
2016-09-05 11:28:36 -07:00
Cobrand
e8c5dc4806
Updated E0527 to new error format
...
* Closes #36113
2016-09-05 19:28:52 +02:00
Josh Triplett
046c7f2368
Add test for unused field in union
2016-09-05 10:19:00 -07:00
bors
3f50b6342d
Auto merge of #36200 - mattico:fix-llvm-linkage, r=arielb1
...
Fix incorrect LLVM Linkage enum
Followup of #33994 to actually work.
The `Linkage` enum in librustc_llvm got out of sync with the version in LLVM and it caused two variants of the `#[linkage=""]` attribute to break.
This adds the functions `LLVMRustGetLinkage` and `LLVMRustSetLinkage` which convert between the Rust Linkage enum and the LLVM one, which should stop this from breaking every time LLVM changes it.
Possible remaining concerns:
1. There could be a codegen test to make sure that the attributes are applied correctly (I don't know how to do this).
2. ~~The test does not exercise the `appending` linkage. I can't figure out how to make a global static raw pointer to an array. This might not even be possible? If not we should probably remove appending linkage as its unusable in rust.~~ Appending linkage is not 'emittable' anyway.
3. The test only runs on Linux.
Fixes #33992
r? @alexcrichton
2016-09-05 08:13:32 -07:00
Gavin Baker
cd56d47da3
E0518 Update error format #36111
...
- Fixes #36111
- Part of #35233
2016-09-06 00:21:04 +10:00
Gavin Baker
8bcd6a33be
E0517 Update error format #36109
...
- Fixes #36109
- Part of #35233
2016-09-06 00:20:56 +10:00
Gavin Baker
d53ea97bfc
E0516 Update error format #36108
...
- fixes #36108
- part of #35233
2016-09-05 23:07:50 +10:00
bors
58dc448f8c
Auto merge of #35787 - canndrew:bang_type_refactor_check, r=eddyb
...
Typecheck refactor for `!`
Ping @nikomatsakis @eddyb. This is the PR for the typeck refactor for `!`. Is this what you guys had in mind? Is there anything else that needs doing on it?
2016-09-05 04:29:47 -07:00
Felix S. Klock II
09e6a98380
Fix issue #36036 .
...
We were treating an associated type as unsized even when the concrete
instantiation was actually sized. Fix is to normalize before checking
if it is sized.
2016-09-05 12:57:00 +02:00
Manish Goregaokar
20ec61e043
Rollup merge of #36245 - alexcrichton:add-back-accident, r=arielb1
...
Add back feature accidentally removed
This feature was accidentally removed in
https://github.com/rust-lang/rust/pull/35957 .
2016-09-05 14:53:09 +08:00
Manish Goregaokar
b16fbeb8c1
Rollup merge of #36065 - acrrd:new_format_E0496, r=GuillaumeGomez
...
Update E0496 to new format
Fixes #36000 .
Part of #35233 .
r? @GuillaumeGomez
2016-09-05 14:53:08 +08:00
Manish Goregaokar
75e3bc3bd8
Rollup merge of #35983 - GuillaumeGomez:e0060_bonus, r=jonathandturner
...
E0060 and E0061 improvement
Fixes #35290 .
r? @jonathandturner
2016-09-05 14:53:08 +08:00
Manish Goregaokar
acf98d99f9
Rollup merge of #35845 - frewsxcv:result-into-iter, r=GuillaumeGomez
...
Indicate where `core::result::IntoIter` is created.
None
2016-09-05 14:53:08 +08:00
Andrew Cann
c9a340e546
Remove expr_ty method completely
2016-09-05 12:28:52 +08:00
Andrew Cann
7c8f5457d2
Undo unnecessary bookkeeping from last commit
2016-09-05 12:28:52 +08:00
Andrew Cann
180534f398
Remove use of expr_ty from coercions code
2016-09-05 12:28:52 +08:00
Andrew Cann
bd661481e7
Move write_ty to the bottom of check_pat
2016-09-05 12:28:52 +08:00
Andrew Cann
1749fda9c0
Factor write_ty out of more pattern-checking functions
2016-09-05 12:28:52 +08:00
Andrew Cann
c5ff28cd14
Factor write_ty out of pattern-matching functions
2016-09-05 12:26:41 +08:00