Commit Graph

44082 Commits

Author SHA1 Message Date
bors
eeeda89e55 Auto merge of #26526 - djc:patch-1, r=steveklabnik
In particular, I found that the disclaimer (promised in the second paragraph) doesn't stand out right now. I think the extra headers help with scanning this document, and making it easier to discern which steps are relevant to my particular flow through the options.
2015-06-24 05:53:19 +00:00
bors
5678a1a299 Auto merge of #26520 - oli-obk:three-tuple-transitive-traits, r=bluss
Tuples implement Debug and Hash if their components do.

closes #24826

r? @alexcrichton 

cc @steveklabnik
2015-06-24 04:21:34 +00:00
bors
2d0cbf3e3e Auto merge of #26509 - tshepang:4-and-not-3, r=bluss 2015-06-24 02:51:13 +00:00
Nick Hamann
4982b23c22 Add a regression test for #23305.
Closes #23305.
2015-06-23 21:19:34 -05:00
bors
ba770ae094 Auto merge of #26521 - oli-obk:android-x86-libclibc, r=alexcrichton
All types are same as Android/arm.  So I add condition for Android/x86

closes #25475

r? @alexcrichton
2015-06-24 01:07:36 +00:00
bors
4b4a672a8f Auto merge of #26491 - omasanori:fix-18670, r=brson
I've configured with the parameters suggested by @brson in #18670 and confirmed that it works on Gentoo Linux amd64.

Fixes #18670.
2015-06-23 23:35:47 +00:00
Steve Klabnik
56fd31f9a4 Fix grammar in style guide on traits
Fixes #26366
2015-06-23 15:54:16 -07:00
bors
55deea606b Auto merge of #26219 - Veedrac:patch-1, r=alexcrichton
Fixes #26196.

Alternatively we could explicitly check and complain (eg. panic), but I don't see the value-add.
2015-06-23 22:03:04 +00:00
Brian Anderson
913c51ab17 doc: Add newest Rust papers 2015-06-23 13:59:43 -07:00
Brian Anderson
1f14e195b4 Bump to 1.3 2015-06-23 13:32:48 -07:00
bors
6fed735b22 Auto merge of #26061 - Gankro:inherit-dep, r=brson
Uncertain if this is the desired effect/strategy/testing.

r? @aturon
2015-06-23 20:30:56 +00:00
Guillaume Gomez
4c2587c1c0 Add potential cause of the error 2015-06-23 21:47:28 +02:00
Dirkjan Ochtman
5027c9f0d1 Add some more headers to installation documentations
In particular, I found that the disclaimer (promised in the second paragraph) doesn't stand out right now. I think the extra headers help with scanning this document, and making it easier to discern which steps are relevant to my particular flow through the options.
2015-06-23 21:31:07 +02:00
bors
2ad26e850e Auto merge of #26490 - alexcrichton:fix-msvc-again, r=brson
This commit ensures that the modifications made in #26382 also apply to the
archive commands run in addition to the linker commands.
2015-06-23 18:59:00 +00:00
Dave Huseby
c6944fa9d7 this fixes a bitrig break in the parallel codegen closures test 2015-06-23 11:08:56 -07:00
Guillaume Gomez
e52b94e259 Replace example and message by @Manisheart proposition 2015-06-23 19:48:13 +02:00
Guillaume Gomez
67c11b0146 Add E0071 error explanation 2015-06-23 19:34:38 +02:00
Guillaume Gomez
0770f665d9 Add E0044 error code explanation 2015-06-23 19:34:07 +02:00
bors
27ecbba388 Auto merge of #26508 - tshepang:stray-code-block, r=bluss 2015-06-23 17:27:07 +00:00
bors
d54ab412ef Auto merge of #26503 - GuillaumeGomez:patch-4, r=Manishearth
r? @Manishearth
2015-06-23 15:55:19 +00:00
bors
3223c885b9 Auto merge of #26367 - tshepang:patch-1, r=bluss 2015-06-23 14:24:10 +00:00
bors
997bd334fb Auto merge of #26354 - jroesch:remove-param-bounds-take-n, r=nikomatsakis
This pull request removes `ParamBounds` a old holdover in the type checker that we (@nikomatsakis and I) had wanted to remove. I'm not sure if the current form is the best possible refactor but I figured we can use this as a place to discuss it.

r? @nikomatsakis
2015-06-23 12:52:59 +00:00
Makoto Kato
11ec95b949 Support Android/x86 for liblibc
All types are same as Android/arm.  So I add condition for Android/x86
2015-06-23 14:09:01 +02:00
bors
699315e4f5 Auto merge of #26519 - oli-obk:camel_case_const_val, r=eddyb 2015-06-23 11:20:51 +00:00
bors
4ffeb2e32d Auto merge of #26517 - nrc:fix-parallel-codegen, r=arielb1
Closes #26420

r? @nikomatsakis
2015-06-23 09:49:03 +00:00
Josh Triplett
01fa55988a tuple.rs: Document more traits implemented by tuples if their components do
Tuples implement Debug and Hash if their components do.
2015-06-23 11:18:08 +02:00
Oliver Schneider
88b03f349e change const_val enum and its variants to camel-case 2015-06-23 10:31:32 +02:00
bors
17450192d9 Auto merge of #26513 - shunyata:master, r=alexcrichton
I'm currently reading the rust book and this variable name tripped me up.
Because it was called "input", I thought at first it might contain the line
read by read_line(). This new variable name will be more instructive to rust
beginners.
2015-06-23 08:18:14 +00:00
Jared Roesch
81e5c1ff06 Remove the mostly unecessary ParamBounds struct 2015-06-23 00:10:19 -07:00
Guillaume Gomez
3ff12223dc Comment E0222 instead of removing it 2015-06-23 08:14:49 +02:00
Nick Cameron
19645c4e21 Test for a particular parallel codegen corner case 2015-06-22 23:08:44 -07:00
Nick Cameron
ce0c2572ec Fix parallel codegen regression
Regressed by #26326
2015-06-22 22:34:12 -07:00
bors
e749f724b0 Auto merge of #26514 - tshepang:repetition, r=Gankro 2015-06-23 02:32:44 +00:00
bors
cffaf0e7a8 Auto merge of #26435 - gsingh93:master, r=nikomatsakis
When a method exists in an impl but can not be used due to missing trait bounds for the type parameters, we should inform the user which trait bounds are missing.

For example, this code
```
// Note this is missing a Debug impl
struct Foo;

fn main() {
    let a: Result<(), Foo> = Ok(());
    a.unwrap()
}
```
Now gives the following error:
```
/home/gulshan/tmp/tmp.rs:6:7: 6:15 error: no method named `unwrap` found for type `core::result::Result<(), Foo>` in the current scope
/home/gulshan/tmp/tmp.rs:6     a.unwrap()
                                 ^~~~~~~~
/home/gulshan/tmp/tmp.rs:6:7: 6:15 note: The method `unwrap` exists but the following trait bounds were not satisfied: `Foo : core::fmt::Debug`
error: aborting due to previous error
```

Fixes https://github.com/rust-lang/rust/issues/20941.
2015-06-23 01:00:48 +00:00
Tshepang Lekhonkhobe
4ce7901a5a doc: remove repeated word 2015-06-23 02:48:37 +02:00
Gulshan Singh
a006a82724 Suggest missing trait bounds when a method exists but the bounds aren't satisfied 2015-06-22 20:28:46 -04:00
Jake Hickey
deee268015 Use a more descriptive variable name.
I'm currently reading the rust book and this variable name tripped me up.
Because it was called "input", I thought at first it might contain the line
read by read_line(). This new variable name will be more instructive to rust
beginners.
2015-06-22 18:48:50 -04:00
bors
a8dbd71fc8 Auto merge of #26512 - yongqli:master, r=sfackler 2015-06-22 22:33:51 +00:00
Yongqian Li
f21682ba2d fix minor indentation issues 2015-06-22 15:30:56 -07:00
Guillaume Gomez
ccb459e49a Change description of error (thanks @Manisheart) 2015-06-22 21:53:30 +02:00
Guillaume Gomez
11f0f47220 Remove E0222 from errors list 2015-06-22 21:53:19 +02:00
bors
5c5753e876 Auto merge of #26500 - sanxiyn:dead-field, r=alexcrichton
Fix #26353.
2015-06-22 18:42:31 +00:00
Tshepang Lekhonkhobe
f8158122c5 book: there are 4 special sections 2015-06-22 20:32:56 +02:00
Tshepang Lekhonkhobe
7a0a69f801 book: remove a stray code block 2015-06-22 20:14:27 +02:00
Tshepang Lekhonkhobe
e13077f7f0 book: whitespace 2015-06-22 19:29:34 +02:00
Tshepang Lekhonkhobe
0adda45c04 book: fix sentence 2015-06-22 19:29:29 +02:00
Guillaume Gomez
97e1615735 Add E0045 error explanation 2015-06-22 18:39:25 +02:00
Guillaume Gomez
3f9fc39ab9 Unify variadic errors 2015-06-22 18:34:52 +02:00
bors
4e2a898afc Auto merge of #25784 - geofft:subprocess-signal-masks, r=alexcrichton
UNIX specifies that signal dispositions and masks get inherited to child processes, but in general, programs are not very robust to being started with non-default signal dispositions or to signals being blocked. For example, libstd sets `SIGPIPE` to be ignored, on the grounds that Rust code using libstd will get the `EPIPE` errno and handle it correctly. But shell pipelines are built around the assumption that `SIGPIPE` will have its default behavior of killing the process, so that things like `head` work:

```
geofft@titan:/tmp$ for i in `seq 1 20`; do echo "$i"; done | head -1
1
geofft@titan:/tmp$ cat bash.rs
fn main() {
        std::process::Command::new("bash").status();
}
geofft@titan:/tmp$ ./bash
geofft@titan:/tmp$ for i in `seq 1 20`; do echo "$i"; done | head -1
1
bash: echo: write error: Broken pipe
bash: echo: write error: Broken pipe
bash: echo: write error: Broken pipe
bash: echo: write error: Broken pipe
bash: echo: write error: Broken pipe
[...]
```

Here, `head` is supposed to terminate the input process quietly, but the bash subshell has inherited the ignored disposition of `SIGPIPE` from its Rust grandparent process. So it gets a bunch of `EPIPE`s that it doesn't know what to do with, and treats it as a generic, transient error. You can see similar behavior with `find / | head`, `yes | head`, etc.

This PR resets Rust's `SIGPIPE` handler, as well as any signal mask that may have been set, before spawning a child. Setting a signal mask, and then using a dedicated thread or something like `signalfd` to dequeue signals, is one of two reasonable ways for a library to process signals. See carllerche/mio#16 for more discussion about this approach to signal handling and why it needs a change to `std::process`. The other approach is for the library to set a signal-handling function (`signal()` / `sigaction()`): in that case, dispositions are reset to the default behavior on exec (since the function pointer isn't valid across exec), so we don't have to care about that here.

As part of this PR, I noticed that we had two somewhat-overlapping sets of bindings to signal functionality in `libstd`. One dated to old-IO and probably the old runtime, and was mostly unused. The other is currently used by `stack_overflow.rs`. I consolidated the two bindings into one set, and double-checked them by hand against all supported platforms' headers. This probably means it's safe to enable `stack_overflow.rs` on more targets, but I'm not including such a change in this PR.

r? @alexcrichton
cc @Zoxc for changes to `stack_overflow.rs`
2015-06-22 16:11:38 +00:00
Seo Sanghyeon
6f7b4ce65a Do not consider fields matched by wildcard patterns to be used 2015-06-22 21:36:14 +09:00