bors[bot]
aa112bf714
Merge #4365
...
4365: Use the correct color for structs r=matklad a=matklad
This works around https://github.com/microsoft/vscode/issues/97162
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-07 16:49:42 +00:00
Aleksey Kladov
2904311664
Use the correct color for structs
...
This works around https://github.com/microsoft/vscode/issues/97162
2020-05-07 18:46:58 +02:00
bors[bot]
fd84c31ff7
Merge #4346
...
4346: Fix rename of enum variant visible from module r=matklad a=montekki
Probably fixes #4237
It looks like the ref is found correctly in this case but it's visibility is not correctly determined. I took a stab at fixing that by adding an implementation of `HasVisibility` for `EnumVariant` so it works more or less the same way it does for struct fields.
In other words, the `search_range` here does not contain the ref since it's not considered visible:
efd8e34c39/crates/ra_ide_db/src/search.rs (L209-L214)
Before that I tried to populate `ItemScope` with visible enum variants but that ended up with breaking tests all over the place and also it looked illogical in the end: `ItemScope` is not populated with, say, public struct fields and the same should be true for `enum` variants.
I've added two more or less identical tests: one for the case with a struct field rename and one for enum variant rename; the test for struct should probably be removed and the names should be changed.
Co-authored-by: Fedor Sakharov <fedor.sakharov@gmail.com>
2020-05-07 16:29:01 +00:00
vsrs
23f4859166
Add CodeLLDB Rust visualization
2020-05-07 18:53:14 +03:00
vsrs
435a17ecd8
Add separate settings for each debug engine.
2020-05-07 18:35:48 +03:00
bors[bot]
a9945137dc
Merge #4364
...
4364: Touch up assists public API r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-07 15:32:40 +00:00
Aleksey Kladov
1e790ea314
Simplify
2020-05-07 17:32:01 +02:00
Aleksey Kladov
28fcff125a
Nicer API
2020-05-07 17:29:23 +02:00
Aleksey Kladov
c6b81bc013
Rename AssitLabel -> Assist
2020-05-07 17:18:28 +02:00
Benjamin Coenen
c839d4f7a9
do not show runnables for main function outside of a binary target #4356
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-07 16:52:14 +02:00
bors[bot]
c7e305731c
Merge #4350
...
4350: Refactor assists API to be more convenient for adding new assists r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-07 14:28:47 +00:00
Aleksey Kladov
4867968d22
Refactor assists API to be more convenient for adding new assists
...
It now duplicates completion API in its shape.
2020-05-07 16:27:54 +02:00
vsrs
5426e2927e
Add additional debug options
2020-05-07 17:07:58 +03:00
Fedor Sakharov
210f0cbd27
Remove HasVisibility implementation
2020-05-07 16:31:51 +03:00
bors[bot]
f4cd75ac06
Merge #4359
...
4359: Fix panic in FunctionSignature r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-07 12:32:21 +00:00
Aleksey Kladov
43cedecf68
Fix panic in FunctionSignature
2020-05-07 14:29:01 +02:00
Benjamin Coenen
6203e9c4fa
add if let and while let postfix for Option and Result #4348
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-07 11:23:38 +02:00
Craig Disselkoen
227929f9dd
simplify by using bail! macro
2020-05-06 13:29:22 -07:00
Craig Disselkoen
5d4648884b
cargo fmt
2020-05-06 12:47:13 -07:00
Craig Disselkoen
44b01ccff3
return a PathBuf instead of String
2020-05-06 12:39:11 -07:00
bors[bot]
9cb55966fe
Merge #4333
...
4333: Update Arch Linux and ALE install instructions r=matklad a=polyzen
Package has been added to the Arch repos:
https://www.archlinux.org/packages/community/x86_64/rust-analyzer/
ALE merged rust-analyzer support:
70005134e5
Co-authored-by: Daniel M. Capella <polyzen@archlinux.org>
2020-05-06 17:13:02 +00:00
bors[bot]
6b18d364fc
Merge #4353
...
4353: Better mapping to TextMate scopes for keywords r=matklad a=matklad
https://github.com/microsoft/vscode/issues/94367#issuecomment-608629883
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-06 17:04:00 +00:00
Aleksey Kladov
71369f5c59
Better mapping to TextMate scopes for keywords
...
https://github.com/microsoft/vscode/issues/94367#issuecomment-608629883
2020-05-06 19:03:17 +02:00
bors[bot]
1a0988b899
Merge #4316 #4351
...
4316: do not truncate display for hover r=matklad a=bnjjj
close #4311
4351: Fix Windows server path r=matklad a=lnicola
CC @Coder-256.
Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-05-06 16:54:31 +00:00
Laurențiu Nicola
e0b63855b1
Fix Windows server path
...
CC @Coder-256.
2020-05-06 19:53:14 +03:00
bors[bot]
5b697d5693
Merge #4349
...
4349: package.json: Minor configuration spelling fix r=matklad a=seanbright
Co-authored-by: Sean Bright <seanbright@users.noreply.github.com>
2020-05-06 16:46:55 +00:00
bors[bot]
b832dfc917
Merge #4331
...
4331: Fixture improvements r=TimoFreiberg a=TimoFreiberg
As mentioned in [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/resolve_path.20between.20fixture.20files ) :)
I think always allowing unindented first lines is friendlier than making the user fix it and I don't see any drawbacks.
Co-authored-by: Timo Freiberg <timo.freiberg@gmail.com>
2020-05-06 16:18:17 +00:00
Timo Freiberg
86fa80e5b3
Allow fixture strings with unindented first line
...
This allows fixtures like
"//- /lib.rs
...
//- /foo.rs
...
"
2020-05-06 18:09:28 +02:00
Timo Freiberg
8a5d14453e
Add fixture doc comment
2020-05-06 18:09:28 +02:00
bors[bot]
fbc8bd3fdb
Merge #4043
...
4043: add Ok wrapping assist #3907 r=matklad a=bnjjj
About issue #3907
close #3907
Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-06 16:04:47 +00:00
Benjamin Coenen
51c02ab84f
add Ok wrapping
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-06 17:45:55 +02:00
Sean Bright
9a4553b833
package.json: Minor configuration spelling fix
2020-05-06 11:22:24 -04:00
bors[bot]
e99447ffbf
Merge #4347
...
4347: Fix usefulness check for never type r=flodiebold a=MikailBag
Co-authored-by: Mikail Bagishov <bagishov.mikail@yandex.ru>
2020-05-06 15:11:26 +00:00
Mikail Bagishov
7c94fa7d01
Fix usefulness check for never type
2020-05-06 17:59:27 +03:00
bors[bot]
1252107a3c
Merge #4345
...
4345: Refactor assists a bit r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-06 14:39:49 +00:00
Aleksey Kladov
020ca6695f
Simplify
2020-05-06 16:39:11 +02:00
Fedor Sakharov
bd9f1f7eb7
Fix rename of enum variant visible from module
2020-05-06 17:35:22 +03:00
Aleksey Kladov
4d50709a96
Minor
2020-05-06 16:10:35 +02:00
Aleksey Kladov
0970c3454b
Rename
2020-05-06 16:10:35 +02:00
bors[bot]
efd8e34c39
Merge #4344
...
4344: Use SourceChange for assists r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-06 13:49:34 +00:00
Aleksey Kladov
fdd4df97ba
Use SourceChange for assists
2020-05-06 15:43:47 +02:00
vsrs
c4ca6e29c2
Uniformed way to get Debug Lens target executable.
2020-05-06 16:06:21 +03:00
Aleksey Kladov
1116c9a0e9
Fix TODO
2020-05-06 13:21:49 +02:00
bors[bot]
4de3c3eedc
Merge #4341
...
4341: Move target to AssistLabel r=matklad a=matklad
Target is used for assists sorting, so we need it before we compute
the action.
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-06 10:52:57 +00:00
Aleksey Kladov
233f01c9ba
Move target to AssistLabel
...
Target is used for assists sorting, so we need it before we compute
the action.
2020-05-06 12:51:28 +02:00
bors[bot]
ede8906844
Merge #4340
...
4340: Lift SourceChange to the ra_ide_db r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-06 09:34:24 +00:00
Benjamin Coenen
1ec953f117
do not truncate display for hover
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-06 11:33:43 +02:00
Aleksey Kladov
3850b1c086
Lift SourceChange to the ra_ide_db
2020-05-06 11:32:34 +02:00
bors[bot]
18907e6cc5
Merge #4339
...
4339: Fix capitalization r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-06 09:20:09 +00:00
Aleksey Kladov
beb35c3ecb
Fix capitalization
2020-05-06 11:19:43 +02:00