mcarton
204c12c99e
Lint unused labels
2016-03-08 16:43:40 +01:00
Oliver Schneider
bf20b40664
fix cyclomatic complexity lint triggering because of short circuit operations
2016-03-08 15:10:02 +01:00
llogiq
08b7931b6b
Merge pull request #741 from martiansideofthemoon/blastoise
...
Linting classical overflow checks
2016-03-08 09:50:00 +01:00
KALPESH KRISHNA
9faffd2870
Adding symmetric lints and test cases
2016-03-08 13:39:44 +05:30
mcarton
8bbd8b0b92
Fix ICE in for_loop with globals
2016-03-07 23:32:43 +01:00
KALPESH KRISHNA
d6d409414e
Adding underflow checks and tests
2016-03-08 02:57:45 +05:30
KALPESH KRISHNA
55fbf59f3b
Linting classical overflow checks.
2016-03-08 02:48:42 +05:30
mcarton
3c3a4549a8
Fix tests with inclusive ranges
2016-03-07 16:55:12 +01:00
mcarton
13bb22a68b
Remove all ExprRange
...
Rustup to rustc 1.9.0-nightly (998a6720b 2016-03-07)
2016-03-07 16:31:38 +01:00
mcarton
eb0a493442
Implement struct literal equality
2016-03-07 16:30:02 +01:00
mcarton
2abb775de5
Fix dogfood
2016-03-06 14:10:04 +01:00
Manish Goregaokar
f69e09ab0e
Merge branch 'pr-737'
2016-03-05 23:41:34 +05:30
KALPESH KRISHNA
e421a0f8a3
Warn about calling a closure in the same expression where it's defined.
2016-03-05 22:41:52 +05:30
Oliver Schneider
e7fa117ff8
simplify cyclomatic complexity auxiliarly value computation
...
previously the HIR was unnecessarily traversed twice
2016-03-04 16:27:03 +01:00
mcarton
c7bf068121
s/ctxt/TyCtxt
2016-03-04 14:25:34 +01:00
mcarton
79b0ad7441
vec! now uses box
2016-03-03 20:09:31 +01:00
Manish Goregaokar
100ca33742
Rust upgrade to 2016-03-02 nightly
2016-03-03 01:24:20 +05:30
Manish Goregaokar
bd45cfd273
rustfmt
2016-02-29 21:35:51 +05:30
Oliver Schneider
3b7720f992
lint ! and != in if expressions with else branches
2016-02-29 12:34:48 +01:00
Oliver Schneider
67213c9be4
lint unportable clike enum discriminants
2016-02-29 09:36:13 +01:00
llogiq
105a14f547
Merge pull request #721 from mcarton/while_let_loop
...
Fix wrong suggestion in `WHILE_LET_LOOP`
2016-02-28 22:49:56 +01:00
mcarton
76004306cc
Lint manual swaps
2016-02-28 12:16:13 +01:00
mcarton
5fadfb3ea6
Fix wrong suggestion in WHILE_LET_LOOP
...
Ok, I lied in the title. This basically *removes* the problematic part
but:
1) it was ugly with big bodies;
2) it was not indented properly;
3) it wasn’t very smart (see #675 ).
2016-02-28 12:09:28 +01:00
mcarton
72ef26272d
Lint foo = bar; bar = foo sequences
2016-02-28 00:02:43 +01:00
mcarton
05178c92b9
Cleanup
2016-02-27 18:18:58 +01:00
mcarton
3a5b9a707c
Fix (new?) rustc warnings
2016-02-27 18:18:58 +01:00
mcarton
1c3cce8ba5
Add a lint about suspiciously formatted else if
2016-02-27 18:18:53 +01:00
mcarton
810de56079
Add a lint about suspiciously formatted =@ ops
...
For `@` in {`*`, `!`, `-`}.
2016-02-27 17:57:36 +01:00
mcarton
62cbd87728
Fix false positive in FOR_KV_MAP and &mut refs
2016-02-26 12:51:26 +01:00
llogiq
b3ffc1868f
Merge pull request #689 from mcarton/entries
...
Improve the `MAP_ENTRY` lint
2016-02-26 12:18:34 +01:00
Manish Goregaokar
f13b841282
Merge branch 'pr-704'
...
Conflicts:
src/len_zero.rs
2016-02-25 01:38:08 +05:30
mcarton
783437eef0
Use span_suggestion in loops lints
2016-02-24 20:54:35 +01:00
mcarton
7b1a0a9434
Macro check len_zero
2016-02-24 20:53:15 +01:00
mcarton
c1b2fe31b7
Use span_suggestion in len_zero
2016-02-24 20:52:47 +01:00
mcarton
b753e77cbe
Rustfmt and sort all use items
2016-02-24 17:38:57 +01:00
mcarton
3b783152cc
Fix ICE with match_def_path
2016-02-22 20:00:51 +01:00
mcarton
2a0fb1fb44
Limit USELESS_FORMAT with args to string args
2016-02-22 17:54:46 +01:00
Martin Carton
c47d5a615f
Merge pull request #690 from quininer/fix-nightly
...
fix nightly (2016-02-17)
2016-02-21 15:38:31 +01:00
mcarton
d77ccdc338
Fix USELESS_FORMAT wiki
2016-02-21 13:21:04 +01:00
mcarton
1a64a4890c
Small cleanup
2016-02-20 21:20:56 +01:00
mcarton
ba3be83488
Lint about format!("{}", foo)
2016-02-20 21:15:05 +01:00
mcarton
b6443b9928
Replace all format!("{}", foo) calls
2016-02-20 21:03:45 +01:00
mcarton
ef4401d4ac
Lint about usage of format!("string literal")
2016-02-20 17:46:20 +01:00
mcarton
222086d62b
Remove all use of format!("string literal")
2016-02-20 17:46:20 +01:00
mcarton
5fe6e9f911
Build the import lint in update_lints.py
2016-02-20 17:46:16 +01:00
quininer kel
35a48bf512
fix nightly
...
9b40e1e5b3
2016-02-19 04:16:39 +08:00
Manish Goregaokar
78b31c61bd
Merge pull request #688 from Manishearth/fix-671
...
improve str_add_assign lint description
2016-02-19 01:43:23 +05:30
mcarton
aa1df8e9ff
Improve the MAP_ENTRY lint
...
Don’t span a suggestion when not appropriate but use a note and don’t
force it to be `if !cond`.
2016-02-18 20:19:16 +01:00
llogiq
1fd0676fa3
improve str_add_assign lint description
2016-02-18 20:12:33 +01:00
Oliver Schneider
add483afed
fix enum glob use (again)
2016-02-18 16:08:45 +01:00
