Wilfred Hughes
1e76b11a20
Set the default status bar action to openLogs
...
Previously, clicking 'rust-analyzer' would stop the server
entirely. This was easy to do accidentally, and then the user has to
wait for the server to start up again.
2023-08-04 11:03:41 -07:00
Lukas Wirth
bd6ec06237
Write proc-macro server spawn errors to the status text
2023-07-30 14:38:25 +02:00
bors
bc1b0bfa7f
Auto merge of #15308 - vsrs:runnable_env_per_platform, r=HKalbasi
...
Runnable env per platform
This PR adds an option to specify runnables `env` per platform (win32, linux, etc.):
```
{
"rust-analyzer.runnables.extraEnv": [
{
"platform": "win32",
"env": {
"SCITER_BIN_FOLDER": "C:\\Projects\\3rd\\sciter-js-sdk\\bin\\windows\\x64",
}
},
{
"platform":["linux","darwin"],
"env": {
"SCITER_BIN_FOLDER": "/home/vit/Projects/sciter/sciter-js-sdk/bin/linux/x64",
}
}
]
}
```
2023-07-28 07:03:09 +00:00
David Barsky
ba722165a0
vscode: change minimum VS Code version to 1.75 from 1.78
2023-07-24 11:24:24 -04:00
bors
99718d0c8b
Auto merge of #15303 - oxalica:fix/byte-escape-highlight, r=lowr
...
Fix highlighting of byte escape sequences
Currently non-UTF8 escape sequences in byte strings and any escape sequences in byte literals are ignored.
2023-07-22 20:25:40 +00:00
bors
c99bb3c782
Auto merge of #15281 - tetsuharuohzeki:split-ci-steps, r=lnicola
...
editor/code: Break down CI steps to know what is failing easily
This do the thing I mentioned in https://github.com/rust-lang/rust-analyzer/pull/15265#issuecomment-1634424385
This aims to improve CI status check more readable.
I tried to use [`jobs.<job_id>.if`](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif ) to make the configuration
more shortly once.
But it could not fire the `end-success` or `end-failure` status if some jobs in the workflow were skipped. This causes an integration problem with bors.
By their reasons, this patch still uses `jobs.<job_id>.steps[*].if`.
---
To do this change, we reorganize npm-script.
| previous | after |
|--------------------|----------------------------------------|
| `npm run lint` | `npm run lint && npm run format:check` |
| `npm run fix` | `npm run lint:fix && npm run format` |
The previous `npm run fix` sometimes does not complete fix automatically because ESLint's autofix doees not follow prettier's formatting. So we need to run `npm run lint:fix && npm run format` by this order.
2023-07-22 16:53:21 +00:00
Tetsuharu Ohzeki
5cca093fa8
editor/code: Break down CI steps to know what is failing easily
...
To do this change, we reorganize npm-script.
| previous | after |
|--------------------|----------------------------------------|
| `npm run lint` | `npm run lint && npm run format:check` |
| `npm run fix` | `npm run lint:fix && npm run format` |
The previous `npm run fix` sometimes does not complete fix automatically
because ESLint's autofix doees not follow prettier's formatting.
So we need to run `npm run lint:fix && npm run format` by this order.
2023-07-23 01:51:57 +09:00
igorskyflyer
5d67cbea43
Use notification command links for debugger installation
2023-07-20 15:41:08 +02:00
oxalica
1f35e4d3f1
Introduce invalidEscapeSequence
semantic token type
2023-07-19 15:12:53 +08:00
vsrs
08b3b2a56d
Fix lint
2023-07-18 18:06:20 +07:00
vsrs
3468b093bd
Platform specific runnables env
2023-07-18 17:51:57 +07:00
Tetsuharu Ohzeki
085b755123
editor/code: Update esbuild
...
https://github.com/evanw/esbuild/blob/main/CHANGELOG.md
2023-07-13 22:46:15 +09:00
Tetsuharu Ohzeki
d534180b30
editor/code: Update ESLint
...
https://eslint.org/blog/category/release-notes/
2023-07-13 22:45:11 +09:00
Tetsuharu Ohzeki
837ded9c9a
editor/code: Update ovsx
...
https://github.com/eclipse/openvsx/blob/master/cli/CHANGELOG.md
2023-07-13 22:45:10 +09:00
Tetsuharu Ohzeki
f7823f3106
editor/code: Re-apply code format
2023-07-13 22:44:29 +09:00
Tetsuharu Ohzeki
9d06aa55b4
editor/code: Update prettier to v3
...
https://prettier.io/blog/2023/07/05/3.0.0.html
2023-07-13 22:44:29 +09:00
Tetsuharu Ohzeki
eed1888b81
editor/code: Update typescript-eslint to v6
...
https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/
2023-07-13 22:44:29 +09:00
Tetsuharu Ohzeki
143646d17e
editor/code: Update typescript
2023-07-13 22:44:29 +09:00
dependabot[bot]
f0e2ad5a95
Bump semver from 5.7.1 to 5.7.2 in /editors/code
...
Bumps [semver](https://github.com/npm/node-semver ) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases )
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md )
- [Commits](https://github.com/npm/node-semver/compare/v5.7.1...v5.7.2 )
---
updated-dependencies:
- dependency-name: semver
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-07-11 22:02:42 +00:00
bors
75ac37f317
Auto merge of #15259 - tetsuharuohzeki:sort-the-style-to-import, r=Veykril
...
editor/code: Sort the style to import types
This pull requests enables new lint rule to sorts the style to import types/symbols.
## see details of enabled rules
- https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/consistent-type-imports.md
- https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-import-type-side-effects.md
2023-07-11 12:01:57 +00:00
Tetsuharu Ohzeki
445b4fc27f
editor/code: Sort the style to import types
...
see:
- https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/consistent-type-imports.md
- https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-import-type-side-effects.md
2023-07-11 06:12:00 +09:00
Tetsuharu Ohzeki
e54f6636b6
editor/code: Add FIXME comments for TS' --exactOptionalPropertyTypes
option
2023-07-10 23:39:08 +09:00
Tetsuharu Ohzeki
444bc5b3ba
editor/code: Enable TypeScript's --useUnknownInCatchVariables
option
...
see: https://www.typescriptlang.org/tsconfig#useUnknownInCatchVariables
2023-07-10 23:13:36 +09:00
Tetsuharu Ohzeki
a66b7e3eba
editor/code: Remove unused sendRequestWithRetry
2023-07-10 23:13:36 +09:00
Tetsuharu Ohzeki
fd31006646
editor/code: Assert types in catch in sendRequestWithRetry()
properly
2023-07-10 23:13:36 +09:00
Adenine
1dd54eb44a
change viewMemoryLayoutParams to be textPositionParams
2023-07-08 12:25:54 -04:00
Adenine
4d5c66986e
cleanup + docs + tests
2023-07-07 23:12:09 -04:00
Adenine
c43cfefdd8
fix typescript return path warning
2023-07-07 23:09:41 -04:00
Adenine
de5e3cf745
fix incorrect committed rust and run prettier
2023-07-07 23:09:41 -04:00
Adenine
cfa15d49aa
implement first pass of memory layout viewer
2023-07-07 23:09:41 -04:00
bors
09f666b51b
Auto merge of #15227 - DropDemBits:indent-on-blank-line, r=lnicola
...
fix: Indent after pressing enter on a blank line
Regressed after https://github.com/rust-lang/rust-analyzer/pull/13975 (whoops).
2023-07-07 09:06:56 +00:00
DropDemBits
ebaf8c8135
fix: Indent after pressing enter on a blank line
2023-07-06 23:25:02 -04:00
Tetsuharu Ohzeki
f70845305f
editor/code: Enable noPropertyAccessFromIndexSignature
ts option
2023-07-06 16:17:02 +09:00
Tetsuharu Ohzeki
72a3883a71
editor/code: Enable noUncheckedIndexedAccess
ts option
...
https://www.typescriptlang.org/tsconfig#noUncheckedIndexedAccess
2023-07-06 16:17:02 +09:00
Tetsuharu Ohzeki
bb35d8fa8e
editor/code: Set ts' --moduleResolution=node16 option
...
https://www.typescriptlang.org/tsconfig#moduleResolution
By this change, typescript compiler can read `exports` field in
package.json for dependencies.
https://nodejs.org/api/packages.html#exports-sugar
2023-07-05 00:48:18 +09:00
Alex Kladov
832a64e290
feat: don't add panics to error jump list by default
...
To re-enable this, use
"rust-analyzer.runnables.problemMatcher": [
"$rustc",
"$rust-panic"
],
setting.
closes : #14977
2023-06-30 22:23:13 +01:00
Laurențiu Nicola
477a75d671
Drop cross-env npm dep
2023-06-30 09:20:02 +03:00
Tetsuharu Ohzeki
0500b1d5f8
editor/code: Switch to @vscode/vsce
...
`vsce` was renamed to `@vscode/vsce`.
We should switch to it now.
- https://code.visualstudio.com/updates/v1_74#_extension-authoring
- https://www.npmjs.com/package/@vscode/vsce
2023-06-30 09:55:43 +09:00
bors
d7f4c21950
Auto merge of #15138 - mohsen-alizadeh:13583-rename-runnableEnv-to-runnables-extraEnv, r=Veykril
...
13583 rename runnable env to runnables extra env
closes #13583
2023-06-29 07:18:57 +00:00
Mohsen Alizadeh
3f70117d69
fallback to old key
2023-06-28 21:24:28 -07:00
bors
77ccd64326
Auto merge of #15136 - mohsen-alizadeh:13908-delete-matching-brace-key-binding, r=Veykril
...
delete matching brace key binding
closes #13908
2023-06-28 10:28:01 +00:00
Tetsuharu Ohzeki
8e0efbc2a7
editor/code: Enable noImplicitOverride
ts option
2023-06-28 17:40:27 +09:00
bors
89d7056151
Auto merge of #15154 - tetsuharuohzeki:tsconfig-strictest, r=lnicola
...
editor/code: Use `@tsconfig/strictest` to define type checking rules
Motivation
-----------
This change aims to make it easier to manage tsconfig by [``@tsconfig/strictest`](https://www.npmjs.com/package/@tsconfig/strictest )` and intend to leave to create "ideal" rules about TypeScript's type checking.
Implementation
---------------
This change removes some duplicated rules defined in ``@tsconfig/strictest`` and add disabing some strict rules that fails with the current codebase.
2023-06-28 08:09:55 +00:00
Tetsuharu Ohzeki
0ddf8b63e9
editor/code: Use @tsconfig/strictest
to define type checking rules
...
Motivation
-----------
This change aims to make it easier to manage tsconfig.
This intend to leave to create "ideal" rules about TypeScript's type checking.
Implementation
---------------
This change removes some duplicated rules defined in `@tsconfig/strictest` and add disabing some strict rules
that fails with the current codebase.
2023-06-28 03:05:04 +09:00
Tetsuharu Ohzeki
682f90cc16
Clean up activationEvents
in vscode extension's package.json
...
By documents, VSCode v1.74 or later activates extension automatically
according to other configurations.
See:
- https://code.visualstudio.com/api/references/activation-events#onLanguage
- https://code.visualstudio.com/docs/languages/identifiers
- https://code.visualstudio.com/api/references/activation-events#onCommand
- https://code.visualstudio.com/api/references/contribution-points#contributes.commands
2023-06-28 02:38:06 +09:00
Tetsuharu Ohzeki
1b228f9a6f
Update @types/vscode
to v1.78
...
- https://code.visualstudio.com/updates/v1_67
- https://code.visualstudio.com/updates/v1_68
- https://code.visualstudio.com/updates/v1_69
- https://code.visualstudio.com/updates/v1_70
- https://code.visualstudio.com/updates/v1_71
- https://code.visualstudio.com/updates/v1_72
- https://code.visualstudio.com/updates/v1_73
- https://code.visualstudio.com/updates/v1_74
- https://code.visualstudio.com/updates/v1_75
- https://code.visualstudio.com/updates/v1_76
- https://code.visualstudio.com/updates/v1_77
- https://code.visualstudio.com/updates/v1_78
2023-06-27 23:40:50 +09:00
Tetsuharu Ohzeki
35184bec10
Regenerate package-lock.json
2023-06-27 23:05:28 +09:00
Tetsuharu Ohzeki
9930889918
Update esbuild
...
- https://github.com/evanw/esbuild/blob/main/CHANGELOG-2022.md
- https://github.com/evanw/esbuild/blob/main/CHANGELOG.md
2023-06-27 23:04:23 +09:00
Tetsuharu Ohzeki
9870aa027e
Update ovsx
...
aa90b01b13/cli/CHANGELOG.md
2023-06-27 23:03:06 +09:00
Tetsuharu Ohzeki
6454b5a559
Update d3
...
https://github.com/d3/d3
2023-06-27 23:00:16 +09:00
Tetsuharu Ohzeki
658831c80d
Update @hpcc-js/wasm
...
https://github.com/hpcc-systems/hpcc-js-wasm
2023-06-27 22:57:17 +09:00
Tetsuharu Ohzeki
95e4c66692
Update vscode-languageclient
...
https://github.com/Microsoft/vscode-languageserver-node
2023-06-27 22:55:39 +09:00
Tetsuharu Ohzeki
1bfdcb227f
Update ESLint
...
https://eslint.org/blog/category/release-notes/
2023-06-27 22:54:40 +09:00
Tetsuharu Ohzeki
2f7a16c9d9
Update @vscode/test-electron
...
https://github.com/microsoft/vscode-test/blob/main/CHANGELOG.md
2023-06-27 22:53:48 +09:00
Tetsuharu Ohzeki
8769df938a
Update prettier
...
https://github.com/prettier/prettier/blob/main/CHANGELOG.md
2023-06-27 22:51:16 +09:00
Tetsuharu Ohzeki
9a0a0a0963
Update tslib
...
https://github.com/microsoft/tslib/releases
2023-06-27 22:49:41 +09:00
Tetsuharu Ohzeki
c0863892f7
Update typescript-eslint to v5.60
...
https://github.com/typescript-eslint/typescript-eslint/releases
2023-06-27 22:49:04 +09:00
Tetsuharu Ohzeki
1ec07fda09
Update typescript to v5.1
...
- https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/
- https://devblogs.microsoft.com/typescript/announcing-typescript-5-1/
2023-06-27 22:47:57 +09:00
Mohsen Alizadeh
fd1130b0e7
delete matching brace key binding
2023-06-25 17:27:28 -07:00
Mohsen Alizadeh
6c3e15aaa0
13583 rename runnable env to runnables extra env
2023-06-25 17:26:04 -07:00
Lukas Wirth
0141a6b65c
Remove markdown injection
2023-06-23 11:31:10 +02:00
Lukas Wirth
c672cedeba
Remove markdown injection for block comments
2023-06-21 19:08:00 +02:00
Andreas Backx
942b392150
Exclude Markdown injection grammar from .vscodeignore.
...
Enables Markdown injection introduced in #14866 but wasn't included in release due to it being ignored.
2023-06-11 22:53:58 -07:00
Lukas Wirth
3c862507b9
Add render configs for memory layout hovers
2023-05-30 18:36:06 +02:00
Lukas Wirth
cea84427e0
Allow setting cfgs
2023-05-28 13:43:21 +02:00
David Barsky
7dfef85be6
fix: add a toggle to disable the dependency explorer.
2023-05-26 11:50:07 -04:00
Andreas Backx
09f624721c
[editors/code] add markdown syntax highlighting to doc comments
2023-05-21 17:34:42 +01:00
Lukas Wirth
0028e73927
fix: Force disable augmentsSyntaxTokens capability on VSCode
2023-05-18 08:26:16 +02:00
Lukas Wirth
91d5a689c7
Add config for disabling non standard lsp highlight tokens
2023-05-11 10:01:38 +02:00
Laurențiu Nicola
f8477d0cb4
Hide deps panel outside of Rust projects and set missing category
2023-05-08 21:43:59 +03:00
bors
aaed89ac04
Auto merge of #14763 - lnicola:dep-tree-fixes, r=lnicola
...
Fix manual formatting and remove duplicate command
2023-05-08 18:28:58 +00:00
Laurențiu Nicola
053741c28c
Remove duplicate command
2023-05-08 21:27:52 +03:00
bors
d3ce333ec8
Auto merge of #14742 - Veykril:closure-capture-inlays, r=Veykril
...
feat: Closure capture inlay hints
I opted for a fictional `move(foo, &bar, &mut qux)` syntax here, disabled by default as these are not correct rust syntax and hence could cause confusion.
![image](https://user-images.githubusercontent.com/3757771/236447484-649a4ea6-ad61-496e-bad8-765a5236150e.png )
2023-05-08 09:52:29 +00:00
bors
833d5301d1
Auto merge of #14758 - lumenian:hover-layout-config, r=HKalbasi
...
Add config for disabling hover memory layout data
Requested in https://github.com/rust-lang/rust-analyzer/pull/14748#issuecomment-1537190252
2023-05-07 16:22:57 +00:00
Yury Ivanou
98a4c5049f
Rename hover memory layout config key
2023-05-07 18:37:56 +03:00
Yury Ivanou
4ed0fa8414
Add config for disabling hover memory layout data
2023-05-07 18:21:07 +03:00
Aleksey Kladov
7bc60f512e
feat: define problem matcher for panics in VS Code
...
Now in VS Code "go to next error" (`F8`) will bring you to the source of
a panic.
2023-05-06 16:49:42 +01:00
Erik Steiger
91b4a169cd
Fix formatting
2023-05-05 14:49:42 +02:00
Erik Steiger
06cfeb47b2
Sort rust dependencies in tree view
2023-05-05 14:41:03 +02:00
Lukas Wirth
8081a654da
feat: Closure capture inlay hints
2023-05-05 13:38:22 +02:00
Bruno Ortiz
0aed507f16
fixing TS linting, removing import
2023-05-02 11:06:28 -03:00
Bruno Ortiz
bcb21311ea
Accepting review suggestions
2023-05-02 11:06:25 -03:00
Bruno Ortiz
072f69e4c1
fixing ts linting and rust test
2023-05-02 11:01:53 -03:00
Bruno Ortiz
bd2160f014
final rabasing fixes
2023-05-02 11:01:53 -03:00
Bruno Ortiz
66fe84d936
accepting review suggestions
2023-05-02 11:01:41 -03:00
Bruno Ortiz
fe7874af90
reveal only when tree is visible
2023-05-02 10:59:31 -03:00
Bruno Ortiz
a3081a6774
Adding crate_root_path to crate_graph
2023-05-02 10:59:31 -03:00
Bruno Ortiz
8e687f7afb
improving code to work with multi-workspaces
2023-05-02 10:59:31 -03:00
Bruno Ortiz
1b8288ff96
Fixing naming from graph to list
2023-05-02 10:59:29 -03:00
Bruno Ortiz
061940dad9
running prettier
2023-05-02 10:56:47 -03:00
Bruno Ortiz
fc57339fdf
removing unused code
2023-05-02 10:56:13 -03:00
Lukas Wirth
299382dacd
WIP: Add lsp-ext scaffold
2023-05-02 10:56:13 -03:00
Lukas Wirth
9533644ccf
Remove unnecessary openFile command
2023-05-02 10:56:13 -03:00
Lukas Wirth
af999f152b
Reformat VSCode client code
2023-05-02 10:56:13 -03:00
bruno-ortiz
d1721b11e9
removing unused function
2023-05-02 10:56:13 -03:00
bruno-ortiz
ee54c6558d
fixing linting problemas
2023-05-02 10:56:13 -03:00
bruno-ortiz
f8215dd426
fixing stblib loading
2023-05-02 10:56:13 -03:00
bruno-ortiz
d01fc6405b
Creating rust dependencies tree view
2023-05-02 10:56:13 -03:00
Bruno Ortiz
09e0a00d36
fetching dependencies from the server
2023-05-02 10:56:09 -03:00
Lukas Wirth
1201b156d8
WIP: Add lsp-ext scaffold
2023-05-02 10:52:33 -03:00
Lukas Wirth
16cba19ff3
Remove unnecessary openFile command
2023-05-02 10:48:38 -03:00
Lukas Wirth
76432d39cb
Reformat VSCode client code
2023-05-02 10:48:38 -03:00
bruno-ortiz
364308d1dc
removing unused function
2023-05-02 10:48:38 -03:00
bruno-ortiz
77a4bfd34f
fixing linting problemas
2023-05-02 10:48:38 -03:00
bruno-ortiz
68aa20bb8a
fixing stblib loading
2023-05-02 10:48:38 -03:00
bruno-ortiz
795a1cbe89
Creating rust dependencies tree view
2023-05-02 10:48:33 -03:00
Lukas Wirth
a64626d99e
Highlight closure captures when cursor is on pipe
2023-05-02 08:59:40 +02:00
hkalbasi
6312fbf521
MIR episode 4
2023-05-01 23:23:10 +03:30
Lukas Wirth
cf8f13b531
fix: Fix restart server button trying to start instead of restart the server
2023-04-28 21:34:31 +02:00
Lukas Wirth
c21860bd6a
Remove proc-macro server command from the rust-analyzer binary
2023-04-26 08:19:28 +02:00
Nagy Botond
36281e0745
using VSCode's native parameterHints.enabled setting
2023-04-20 22:13:33 +03:00
Nagy Botond
770734fdbb
Automatic parameter hints trigger can be toggled on/off
2023-04-20 19:41:15 +03:00
Josh Soref
bc7d84c3ce
Spelling
...
* a rule
* access
* after
* amount
* annotations
* assignment
* assist
* associated
* attribute
* borrowed
* built-in type
* clarification
* command
* const
* constructor
* corresponding
* counterparts
* curlies
* dependencies
* deterministic
* diagnostic
* duplicates
* edge
* edited
* efficient
* elsewhere
* execution
* expression
* extensions
* extracted
* fill
* github
* helper
* heuristic
* incomplete
* indent end
* inlay
* invocation
* lifetime
* looking
* maybe
* move
* mutability
* mutable
* necessarily
* necessary
* negative
* nonexistent
* occurred
* offsets
* offsetted
* overridden
* parameters
* params
* params_and_where_preds_in_scope
* paredit
* parent
* parentheses
* prepended if
* punctuation
* receive
* receiver
* referring
* repeated
* representing
* semantically
* separately
* shouldnot
* siblings
* similar
* something's
* statement
* struct
* structure
* surprise
* the
* this
* transparent
* unimplemented
* unnamed
* unnecessary
* unneeded
* unreachable
* unterminated
* utilities
* variant
* variants
* visibility
* work around (v)
* workaround
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-04-19 09:45:55 -04:00
Lukas Wirth
34177d8552
minor: Allow copying the graphviz source from the view crategraph webview
2023-04-13 22:01:57 +02:00
Lukas Wirth
7a6d5c680c
fix: Fix view crate graph being broken due to webworker usage
2023-04-13 17:38:12 +02:00
bors
208a74ca50
Auto merge of #14535 - davidbarsky:davidbarsky/use-parent-folder-for-discovery-cwd, r=Veykril
...
fix: when running the "discoverProjectCommand", use the Rust file's parent directory instead of the workspace folder
This is a quick fix to allow the `discoverProjectCommand` to run successfully when the user has a workspace that does not, e.g., have a `.buckconfig` defined.
(It's also probably _more correct_ to set the `pwd` of the command to the parent of the Rust file _anyways_ rather than relying on the workspace folders, which may be entirely unrelated.)
2023-04-11 07:22:40 +00:00
hkalbasi
59b6f2d9f2
Compute closure captures
2023-04-10 23:04:34 +03:30
David Barsky
b99c129b74
fix: when running the "discoverProjectCommand", use the Rust file's
...
parent directory instead of the workspace folder.
2023-04-10 09:36:38 -04:00
Lukas Wirth
98a673c4a8
fix: Fix project linking popup appearing for modules that can be linked to a crate
2023-04-09 10:17:58 +02:00
Lukas Wirth
7989a94391
fix: Fix relative path creation using the wrong path accessor
2023-04-04 08:20:35 +02:00
Lukas Wirth
4243eeeb2b
fix: Fix vscode project linking popup buttons being swapped
2023-04-04 07:55:09 +02:00
Ryo Yoshida
613e008593
Don't append "!" to non-bang macro name
2023-04-02 20:13:34 +09:00
bors
d3b129f04f
Auto merge of #14444 - zapkub:runable-debug-env-is-not-passing-properly, r=Veykril
...
Missing runnable env on debug target
Fix bug in Rust Analyzer VSCode where runnable debugging did not pass
environment variable from configuration to child process of Cargo on binary build stage
There is a missing env passing along to `cargo` in debug target which give an in-consistent result from debug and run target
For example
```json
{
"rust-analyzer.runnableEnv": {
"OUT_DIR": "/test/path2"
}
}
```
## run
![image](https://user-images.githubusercontent.com/4373581/228749503-fa55f62c-13d3-4d3c-bee6-1cfbe042bdd0.png )
## debug
compiling binary is failed. Missing env
![image](https://user-images.githubusercontent.com/4373581/228749688-3fe42efb-b5ca-41be-862d-f2d97ecab7be.png )
## debug (after fix)
![image](https://user-images.githubusercontent.com/4373581/228750057-1db60051-3465-47db-8b18-4159ec58cfdb.png )
2023-03-30 13:38:36 +00:00
bors
fc8c5139fa
Auto merge of #14410 - Veykril:query-lru-capacities, r=Veykril
...
internal: Add config to specifiy lru capacities for all queries
Might help figuring out what queries should be limited by LRU by default, as currently we only limit `parse`, `parse_macro_expansion` and `macro_expand`.
2023-03-30 12:20:24 +00:00
Lukas Wirth
5616d91b73
internal: Add config to specifiy lru capacities for all queries
2023-03-30 12:52:28 +02:00
Rungsikorn Rungsikavarnich
fb9a1dd87e
Missing runnable env on debug target
...
Fix bug in Rust Analyzer where runnable debugging did not pass
environment variable from configuration to child process of Cargo
on binary build stage
2023-03-30 15:39:49 +09:00
bors
5bba438c9c
Auto merge of #14366 - Veykril:linked-proj, r=Veykril
...
feat: Pop a notification prompting the user to add a Cargo.toml of unlinked file to the linkedProjects
cc https://github.com/rust-lang/rust-analyzer/issues/13226 https://github.com/rust-lang/rust-analyzer/issues/9661
2023-03-28 07:05:43 +00:00
David Barsky
ef422406ef
finish renaming rust-analyzer/reloadProcMacros
to rust-analyzer/rebuildProcMacros
2023-03-26 15:12:25 -04:00
Lukas Wirth
ee02213e65
Handle proc macro fetching via OpQueue
2023-03-26 09:33:41 +02:00
Lukas Wirth
586db0790c
minor: Add user facing command for reloading proc-macros in VSCode
2023-03-25 20:54:24 +01:00
Lukas Wirth
e9fb2ffe45
Add lsp command for rebuilding proc macros
2023-03-25 16:50:31 +01:00
Lukas Wirth
3622fb6456
Fix lints
2023-03-25 14:14:12 +01:00
x2cf
9745a25d57
Fix VS Code status message formatting error
2023-03-21 14:56:07 +08:00
Lukas Wirth
66636939a6
feat: Pop a notification prompting the user to add a Cargo.toml of unlinked file to the linkedProjects
2023-03-16 16:26:19 +01:00
bors
c15335c8b0
Auto merge of #14307 - davidbarsky:davidbarsky/add-cargo-style-project-discovery-for-buck-and-bazel-sickos, r=Veykril
...
Add Cargo-style project discovery for Buck and Bazel Users
This feature requires the user to add a command that generates a `rust-project.json` from a set of files. Project discovery can be invoked in two ways:
1. At extension activation time, which includes the generated `rust-project.json` as part of the linkedProjects argument in `InitializeParams`.
2. Through a new command titled "rust-analyzer: Add current file to workspace", which makes use of a new, rust-analyzer-specific LSP request that adds the workspace without erasing any existing workspaces. Note that there is no mechanism to _remove_ workspaces other than "quit the rust-analyzer server".
Few notes:
- I think that the command-running functionality _could_ merit being placed into its own extension (and expose it via extension contribution points) to provide build-system idiomatic progress reporting and status handling, but I haven't (yet) made an extension that does this nor does Buck expose this sort of functionality.
- This approach would _just work_ for Bazel. I'll try and get the tool that's responsible for Buck integration open-sourced soon.
- On the testing side of things, I've used this in around my employer's Buck-powered monorepo and it's a nice experience. That being said, I can't think of an open-source repository where this can be tested in public, so you might need to trust me on this one.
I'd love to get feedback on:
- Naming of LSP extensions/new commands. I'm not too pleased with how "rust-analyzer: Add current file to workspace" is named, in that it's creating a _new_ workspace. I think that this command being added should be gated on `rust-analyzer.discoverProjectCommand` on being set, so I can add this in sequent commits.
- My Typescript. It's not particularly good.
- Suggestions on handling folders with _both_ Cargo and non-Cargo build systems and if I make activation a bit better.
(I previously tried to add this functionality entirely within rust-analyzer-the-LSP server itself, but matklad was right—an extension side approach is much, much easier.)
2023-03-14 17:48:49 +00:00
David Barsky
6e7bc07cdf
fix: don't override linkedProjects
if no workspace was discovered.
2023-03-14 13:36:21 -04:00
David Barsky
bd545a1c10
Address review comments
2023-03-14 12:49:35 -04:00
bors
4cbb940cc4
Auto merge of #14337 - Veykril:vscode-status, r=lnicola
...
internal: Allow the status bar item to be clicked again
And give that the most useful action for the given state.
2023-03-14 07:23:17 +00:00
David Barsky
78aed305e1
rename "addProject" command
2023-03-13 15:37:58 -04:00
David Barsky
cb93c12c31
fmt
2023-03-13 13:33:39 -04:00
David Barsky
56273b3cf5
Remove rust-analyzer/addProject
in favor of notifying r-a that configuration has changed
2023-03-13 13:30:19 -04:00
David Barsky
8d9bff0c74
Add a workspace config-based approach to reloading discovered projects.
2023-03-13 13:30:19 -04:00
David Barsky
91371494ee
move rust-analyzer.discoverProjectCommand
above $generated-start
to avoid failing tests
2023-03-13 13:30:19 -04:00
David Barsky
68d3eaead4
fix typo in package.json.
2023-03-13 13:30:19 -04:00
David Barsky
1f5c535089
remove errant --
in executeDiscoverProject
2023-03-13 13:30:19 -04:00
David Barsky
46e022098f
fmt
2023-03-13 13:30:19 -04:00
David Barsky
8af3d6367e
This commit add Cargo-style project discovery for Buck and Bazel users.
...
This feature requires the user to add a command that generates a
`rust-project.json` from a set of files. Project discovery can be invoked
in two ways:
1. At extension activation time, which includes the generated
`rust-project.json` as part of the linkedProjects argument in
InitializeParams
2. Through a new command titled "Add current file to workspace", which
makes use of a new, rust-analyzer specific LSP request that adds
the workspace without erasing any existing workspaces.
I think that the command-running functionality _could_ merit being
placed into its own extension (and expose it via extension contribution
points), if only provide build-system idiomatic progress reporting and
status handling, but I haven't (yet) made an extension that does this.
2023-03-13 13:30:18 -04:00
Lukas Wirth
cf95322541
Allow the status bar item to be clicked again
2023-03-13 12:32:53 +01:00
Laurențiu Nicola
c3864eb511
Add and use rust-analyzer.cargo.extraArgs setting
2023-03-12 13:04:24 +02:00
Lukas Wirth
2cb60343ed
Add fancy buttons to the vscode status message
2023-03-10 10:13:30 +01:00