Samuel Tardieu
6267b6ca09
no_effect_underscore_binding: _ prefixed variables can be used
...
Prefixing a variable with a `_` does not mean that it will not be used.
If such a variable is used later, do not warn about the fact that its
initialization does not have a side effect as this is fine.
2024-01-19 23:25:36 +01:00
cocodery
ee2354badf
Add check for unary-operator
...
Fix typo and add test for unary-opeator
2023-12-06 12:17:48 +08:00
cocodery
89774234be
Rewrite logic of has_nontrivial_oprand.
...
Check whether operator is overrided with a `struct` operand.
The struct here refers to `struct`, `enum`, `union`.
Add and fix test for `no_effect` lint.
2023-12-04 15:57:27 +08:00
Guillaume Gomez
a05d3a4137
Automatic generation of error annotations for ui tests
2023-08-22 17:18:11 +02:00
y21
05f78e530a
allow the lint in a bunch of tests
2023-06-06 22:56:57 +02:00
Philipp Krones
62cba5d971
Merge remote-tracking branch 'upstream/master' into rustup
2023-03-24 13:36:09 +01:00
Samuel "Sam" Tardieu
d7d3dbf060
New lint: detect unnecessary struct building
2023-03-23 20:56:45 +01:00
clubby789
213a22efb9
Remove uses of box_syntax in rustc and tools
2023-03-12 13:19:46 +00:00
Philipp Krones
d75b25faab
Merge commit 'ac0e10aa68325235069a842f47499852b2dee79e' into clippyup
2022-10-06 09:44:38 +02:00
Yuri Astrakhan
eb3970285b
fallout: fix tests to allow uninlined_format_args
...
In order to switch `clippy::uninlined_format_args` from pedantic to
style, all existing tests must not raise a warning. I did not want to
change the actual tests, so this is a relatively minor change that:
* add `#![allow(clippy::uninlined_format_args)]` where needed
* normalizes all allow/deny/warn attributes
* all allow attributes are grouped together
* sorted alphabetically
* the `clippy::*` attributes are listed separate from the other ones.
* deny and warn attributes are listed before the allowed ones
changelog: none
2022-10-02 15:13:22 -04:00
Philipp Krones
7d4daaa8fa
Merge commit 'fdb84cbfd25908df5683f8f62388f663d9260e39' into clippyup
2022-07-18 09:39:37 +02:00
Philipp Krones
f074034590
Merge remote-tracking branch 'upstream/master' into rustup
2022-07-15 09:49:15 +02:00
Ralf Jung
eee0bf459d
add array tests, cleanup, tidy, and bless
2022-07-13 18:31:29 -04:00
flip1995
71131351de
Merge commit '984330a6ee3c4d15626685d6dc8b7b759ff630bd' into clippyup
2022-04-08 10:06:10 +01:00
Max Baumann
e552267db3
style -> pedantic
2022-03-30 20:13:16 +02:00
Max Baumann
2953cba116
unit_like_struct_brackets -> empty_structs_with_brackets
2022-03-30 20:13:16 +02:00
Max Baumann
315521afc6
fix uitests
2022-03-30 20:12:58 +02:00
Max Baumann
9be3945be7
fix existing clippy tests
2022-03-30 20:12:58 +02:00
flip1995
8fea1d94f3
Merge commit 'a5d597637dcb78dc73f93561ce474f23d4177c35' into clippyup
2021-12-06 12:33:31 +01:00
F3real
e9bf5ec659
Don't show no_effect warning on unit structs implementing fn* traits
2021-11-17 00:50:07 +01:00
flip1995
7631fc5d82
Merge commit '91496c2ac6abf6454c413bb23e8becf6b6dc20ea' into clippyup
2021-10-21 13:11:36 +02:00
F3real
6b22bba902
Lint on underscore variable assignment
...
Fix tests after no_effect update
Add a drop testcase
Don't lint _ variables in macro expansion
Address review comments and update tests
Don't shadow unnecessary operation lint if no_effect is allowed
Revert shadowing change and remove no_effect allows
Update clippy_lints/src/no_effect.rs
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Update clippy_lints/src/no_effect.rs
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Address review comments
2021-10-20 00:39:28 +02:00
flip1995
6c27482115
Merge commit '3ae8faff4d46ad92f194c2a4b941c3152a701b31' into clippyup
2021-06-03 08:41:37 +02:00
Cameron Steffen
f3e77a454a
Fix allow on some statement lints
2021-05-26 22:07:53 -05:00
Philipp Hansch
38d4ac7cea
Remove all copyright license headers
...
Discussion previously happened in https://github.com/rust-lang/rust/pull/43498
2019-01-08 21:46:39 +01:00
Konrad Borowski
815e434a1f
Move constant write checks to temporary_assignment lint
...
They make more sense here
2018-12-30 00:25:09 +01:00
Konrad Borowski
9fe8a3e52e
Support array indexing expressions in unused write to a constant
2018-12-29 15:34:15 +01:00
Konrad Borowski
847898f18f
Mark writes to constants as side-effect-less
2018-12-29 15:18:51 +01:00
Matthias Krüger
435299be30
rustfmt tests
2018-12-09 23:26:16 +01:00
Philipp Hansch
7adc8dc956
UI test cleanup: Extract unnecessary_operation tests
2018-10-28 18:40:29 +01:00
Oliver Scherer
b8654eaa6c
Stabilize tool lints
2018-10-11 12:16:22 +02:00
Manish Goregaokar
e9c025ea70
Add license header to Rust files
2018-10-06 09:43:08 -07:00
flip1995
1b6f6051a8
Adapt ui-tests to the tool_lints
2018-08-29 11:08:29 -07:00
Oliver Schneider
fd8a1d20cc
Remove all mention and testing of #[plugin(clippy)] and warn if used
2018-05-11 13:20:39 +02:00
Oliver Schneider
8749927973
Rustup
2018-03-16 09:44:20 +01:00
TomasKralCZ
85642ddd23
Implement redundant field names lint #2244
2018-02-10 22:52:31 +01:00
Chris Emerson
dcaaab3801
Add a test with a struct containing a String.
2017-10-07 23:32:09 +01:00
Chris Emerson
fcdce8fc1d
Merge branch 'master' into no_effect_with_drop
2017-10-07 23:24:36 +01:00
Oliver Schneider
50ffaca4c9
Reduce the hackiness of cargo-clippy
2017-10-03 12:07:24 +02:00
Manish Goregaokar
3159a7f2a1
Update ... -> ..= in tests
2017-09-28 10:40:37 -07:00
Chris Emerson
f680eb164d
Update unnecessary_operation and no_effect to not suggest removing
...
structs/enums wrappers when that type implements Drop as noted
in #2061 .
2017-09-18 20:07:33 +01:00
Oliver Schneider
74c776585c
Move all our tests back to ui tests
2017-08-01 17:54:21 +02:00
Oliver Schneider
4465bc3e3f
Make most tests an example so we can run them one by one
2017-05-17 14:19:44 +02:00
Luis de Bethencourt
efbaf09308
clean tests/ui/no_effect.rs
...
Cleaning the empty lines for clarity.
2017-05-11 16:22:32 +01:00
Oliver Schneider
1f2c97a291
remove all //~ from tests
2017-02-08 14:58:07 +01:00
Oliver Schneider
fd1351f6e3
rustup and compile-fail -> ui test move
2017-02-07 21:05:30 +01:00
