Lukas Lueg
66a97055b2
Initial implementation of result_large_err
2022-08-30 17:39:40 +02:00
Jason Newcomb
3ad398d9b0
Merge branch 'master' into rustup
2022-08-28 06:44:13 -04:00
dswij
51e9113c60
Add span_contains_comments util
2022-08-28 00:07:00 +08:00
Michael Wright
a0afbdfbec
Replace contains_ty(..) with Ty::contains(..)
...
This removes some code we don't need and the method syntax is
also more readable IMO.
2022-08-24 08:11:29 +02:00
Nicholas Nethercote
06d7119f40
Remove the symbol from ast::LitKind::Err.
...
Because it's never used meaningfully.
2022-08-23 16:56:24 +10:00
alex-semenyuk
2781ad0e9e
Fix typos
2022-08-20 12:31:29 +03:00
bors
2091142f5d
Auto merge of #9258 - Serial-ATA:unused-peekable, r=Alexendoo
...
Add [`unused_peekable`] lint
changelog: Add [`unused_peekable`] lint
closes : #854
2022-08-19 18:30:13 +00:00
Alex Macleod
4f049f5a69
Refactor FormatArgsExpn
2022-08-19 15:35:26 +00:00
Serial
2666c38acb
Add [unused_peekable] lint
2022-08-19 08:05:59 -04:00
bors
868dba9f65
Auto merge of #9295 - Guilherme-Vasconcelos:manual-empty-string-creation, r=dswij
...
Add `manual_empty_string_creations` lint
Closes #2972
- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `cargo dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo dev fmt`
changelog: [`manual_empty_string_creations`]: Add lint for empty String not being created with `String::new()`
2022-08-19 11:19:06 +00:00
Samuel E. Moelius III
a05cb74d30
Enhance needless_borrow to consider trait implementations
2022-08-16 18:34:51 -04:00
Nicholas Nethercote
6e5f90ae46
Shrink ast::Attribute.
2022-08-16 11:10:13 +10:00
Guilherme-Vasconcelos
80826c3944
Implement clippy::manual_empty_string_creations lint
2022-08-14 12:45:24 -03:00
Mark Rousskov
1a3192a331
Adjust cfgs
2022-08-12 16:28:15 -04:00
bors
9ac237dce5
Auto merge of #100419 - flip1995:clippyup, r=Manishearth
...
Update Clippy
r? `@Manishearth`
2022-08-12 00:12:51 +00:00
Philipp Krones
dc29cfb8d5
Merge commit '2b2190cb5667cdd276a24ef8b9f3692209c54a89' into clippyup
2022-08-11 19:42:16 +02:00
Philipp Krones
280b527821
Bump Clippy version -> 0.1.65
2022-08-11 19:26:38 +02:00
Philipp Krones
879855bbaf
Merge remote-tracking branch 'upstream/master' into rustup
2022-08-11 19:26:04 +02:00
Camille GILLOT
cf3f71d2a2
Do not consider method call receiver as an argument in AST.
2022-08-10 18:34:54 +02:00
dAxpeDDa
fd60581628
Address review take 2
2022-08-09 05:14:03 +02:00
dAxpeDDa
6f5d64842b
Address review
2022-08-09 04:56:04 +02:00
dAxpeDDa
8d4f2ac381
Use check_proc_macro for missing_const_for_fn
2022-08-09 03:41:59 +02:00
bors
4912c0ece4
Auto merge of #9126 - Jarcho:auto_deref_sugg, r=Manishearth
...
`explicit_auto_deref` changes
fixes #9123
fixes #9109
fixes #9143
fixes #9101
This avoid suggesting code which hits a rustc bug. Basically `&{x}` won't use auto-deref if the target type is `Sized`.
changelog: Don't suggest using auto deref for block expressions when the target type is `Sized`
changelog: Include the borrow in the suggestion for `explicit_auto_deref`
changelog: Don't lint `explicit_auto_deref` on `dyn Trait` return
changelog: Don't lint `explicit_auto_deref` when other adjustments are required
changelog: Lint `explicit_auto_deref` in implicit return positions for closures
2022-08-08 15:20:24 +00:00
Jason Newcomb
ecb51fe6a5
Lint explicit_auto_deref in implicit return positions for closures
2022-08-08 10:25:05 -04:00
bors
0ee702514e
Auto merge of #9303 - Jarcho:ice_9297, r=Alexendoo
...
Fix ICE when reading literals with weird proc-macro spans
fixes #9297
changelog: Fix ICE when reading literals with weird proc-macro spans
2022-08-08 11:36:27 +00:00
Jason Newcomb
99abd4a9f6
Fix ICE when reading literals with weird proc-macro spans
2022-08-07 22:22:17 -04:00
Jason Newcomb
745b194292
Small cleanup for check_proc_macro.rs
2022-08-07 21:55:10 -04:00
Jason Newcomb
8dda974a27
Add note to the docs on is_from_proc_macro
2022-08-07 21:55:10 -04:00
Jason Newcomb
670efd5720
Don't lint default_trait_access in proc-macro expansions
2022-08-07 21:55:08 -04:00
Jason Newcomb
4ae582ef88
Don't lint missing_docs_in_private_items on proc-macro output
2022-08-07 21:53:51 -04:00
Jason Newcomb
37e838f759
Use new util function in suspicious_else_formatting
2022-08-07 21:52:27 -04:00
Jason Newcomb
2ae8b300a7
Don't lint unit_arg when expanded from a proc-macro
2022-08-07 21:52:25 -04:00
bors
05e7d5481b
Auto merge of #9053 - AaronC81:fix-9052, r=flip1995
...
Fix suggestions for `async` closures in redundant_closure_call
Fixes #9052
changelog: Fix suggestions given by [`redundant_closure_call`] for async closures
2022-08-02 12:39:37 +00:00
Federico Guerinoni
0696624ba7
Add elapsed_instant lint
...
Closes #8603
Signed-off-by: Federico Guerinoni <guerinoni.federico@gmail.com>
2022-08-01 23:39:00 +02:00
bors
80a56878cf
Auto merge of #99884 - nnethercote:lexer-improvements, r=matklad
...
Lexer improvements
Some cleanups and small speed improvements.
r? `@matklad`
2022-08-01 12:52:49 +00:00
Nicholas Nethercote
09f9acea0a
Shrink Token.
...
From 72 bytes to 12 bytes (on x86-64).
There are two parts to this:
- Changing various source code offsets from 64-bit to 32-bit. This is
not a problem because the rest of rustc also uses 32-bit source code
offsets. This means `Token` is no longer `Copy` but this causes no
problems.
- Removing the `RawStrError` from `LiteralKind`. Raw string literal
invalidity is now indicated by a `None` value within
`RawStr`/`RawByteStr`, and the new `validate_raw_str` function can be
used to re-lex an invalid raw string literal to get the `RawStrError`.
There is one very small change in behaviour. Previously, if a raw string
literal matched both the `InvalidStarter` and `TooManyHashes` cases,
the latter would override the former. This has now changed, because
`raw_double_quoted_string` now uses `?` and so returns immediately upon
detecting the `InvalidStarter` case. I think this is a slight
improvement to report the earlier-detected error, and it explains the
change in the `test_too_many_hashes` test.
The commit also removes a couple of comments that refer to #77629 and
say that the size of these types don't affect performance. These
comments are wrong, though the performance effect is small.
2022-08-01 08:53:04 +10:00
Dylan DPC
72649cf2a6
Rollup merge of #99186 - camsteffen:closure-localdefid, r=cjgillot
...
Use LocalDefId for closures more
2022-07-31 17:36:40 +05:30
Cameron Steffen
62907727af
Use LocalDefId for closures more
2022-07-30 15:59:17 -05:00
Miguel Guarniz
ce5fa10cce
Change enclosing_body_owner to return LocalDefId
...
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
2022-07-29 18:26:10 -04:00
Philipp Krones
67c405cc1d
Merge commit '3c7e7dbc1583a0b06df5bd7623dd354a4debd23d' into clippyup
2022-07-28 19:08:22 +02:00
Philipp Krones
0905ec465d
Merge remote-tracking branch 'upstream/master' into rustup
2022-07-28 18:55:32 +02:00
Jason Newcomb
ab6463e9d9
Fix ICE in miri_to_const
2022-07-24 18:23:33 -04:00
Oli Scherer
bcd2241c9a
Revert "Rollup merge of #98582 - oli-obk:unconstrained_opaque_type, r=estebank"
...
This reverts commit 6f8fb911ad504b77549cf3256a09465621beab9d, reversing
changes made to 7210e46dc69a4b197a313d093fe145722c248b7d.
2022-07-20 07:55:58 +00:00
Jason Newcomb
95c759157c
Check for todo! on every expression in SpanlessEq
2022-07-19 09:57:18 -04:00
Philipp Krones
7d4daaa8fa
Merge commit 'fdb84cbfd25908df5683f8f62388f663d9260e39' into clippyup
2022-07-18 09:39:37 +02:00
Jason Newcomb
84e03b6215
Don't lint explicit_auto_deref on dyn Trait return
2022-07-17 11:14:07 -04:00
Caio
f88a1399bb
Stabilize let_chains
2022-07-16 20:17:58 -03:00
Oli Scherer
417a600c30
Introduce opaque type to hidden type projection
2022-07-15 15:49:22 +00:00
Aaron Christiansen
4c43aa7053
Fix suggestion for async in redundant_closure_call
...
Fix redundant_closure_call for single-expression async closures
Add Sugg::asyncify
Use Sugg for redundant_closure_call implementation
2022-07-15 15:49:04 +01:00
Philipp Krones
f074034590
Merge remote-tracking branch 'upstream/master' into rustup
2022-07-15 09:49:15 +02:00
